dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Jyri Sarha <jsarha@ti.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 11/13] drm/omap: remove legacy get_resolution
Date: Fri, 12 May 2017 15:20:36 +0300	[thread overview]
Message-ID: <55366204.i0ashFAO7X@avalon> (raw)
In-Reply-To: <1494585702-9665-12-git-send-email-tomi.valkeinen@ti.com>

Hi Tomi,

Thank you for the patch.

On Friday 12 May 2017 13:41:40 Tomi Valkeinen wrote:
> get_resolution is not used, remove it.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c      |  2 --
>  drivers/gpu/drm/omapdrm/displays/connector-dvi.c            |  2 --
>  drivers/gpu/drm/omapdrm/displays/connector-hdmi.c           |  2 --
>  drivers/gpu/drm/omapdrm/displays/panel-dpi.c                |  2 --
>  drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c             |  9 ---------
>  drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c |  2 --
>  drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c     |  2 --
>  drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c  |  2 --
>  drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c     |  2 --
>  drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c     |  2 --
>  drivers/gpu/drm/omapdrm/dss/display.c                       | 10 ----------
> drivers/gpu/drm/omapdrm/dss/omapdss.h                       |  5 ----- 12
> files changed, 42 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
> b/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c index
> 8453b1103abd..542a76503fbd 100644
> --- a/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
> +++ b/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
> @@ -171,8 +171,6 @@ static struct omap_dss_driver tvc_driver = {
>  	.get_timings		= tvc_get_timings,
>  	.check_timings		= tvc_check_timings,
> 
> -	.get_resolution		= omapdss_default_get_resolution,
> -
>  	.get_wss		= tvc_get_wss,
>  	.set_wss		= tvc_set_wss,
>  };
> diff --git a/drivers/gpu/drm/omapdrm/displays/connector-dvi.c
> b/drivers/gpu/drm/omapdrm/displays/connector-dvi.c index
> 8720b2dcb316..05fa24a518c8 100644
> --- a/drivers/gpu/drm/omapdrm/displays/connector-dvi.c
> +++ b/drivers/gpu/drm/omapdrm/displays/connector-dvi.c
> @@ -227,8 +227,6 @@ static struct omap_dss_driver dvic_driver = {
>  	.get_timings	= dvic_get_timings,
>  	.check_timings	= dvic_check_timings,
> 
> -	.get_resolution	= omapdss_default_get_resolution,
> -
>  	.read_edid	= dvic_read_edid,
>  	.detect		= dvic_detect,
>  };
> diff --git a/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
> b/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c index
> 555e193c9732..79cb69f1acf5 100644
> --- a/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
> +++ b/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
> @@ -195,8 +195,6 @@ static struct omap_dss_driver hdmic_driver = {
>  	.get_timings		= hdmic_get_timings,
>  	.check_timings		= hdmic_check_timings,
> 
> -	.get_resolution		= omapdss_default_get_resolution,
> -
>  	.read_edid		= hdmic_read_edid,
>  	.detect			= hdmic_detect,
>  	.set_hdmi_mode		= hdmic_set_hdmi_mode,
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c index
> cc5920b476d6..49ceed7f1d11 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> @@ -159,8 +159,6 @@ static struct omap_dss_driver panel_dpi_ops = {
>  	.set_timings	= panel_dpi_set_timings,
>  	.get_timings	= panel_dpi_get_timings,
>  	.check_timings	= panel_dpi_check_timings,
> -
> -	.get_resolution	= omapdss_default_get_resolution,
>  };
> 
>  static int panel_dpi_probe_of(struct platform_device *pdev)
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
> b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c index
> 1fbbe4c4bce6..76787a75a4dc 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
> @@ -379,13 +379,6 @@ static const struct backlight_ops dsicm_bl_ops = {
>  	.update_status  = dsicm_bl_update_status,
>  };
> 
> -static void dsicm_get_resolution(struct omap_dss_device *dssdev,
> -		u16 *xres, u16 *yres)
> -{
> -	*xres = dssdev->panel.vm.hactive;
> -	*yres = dssdev->panel.vm.vactive;
> -}
> -
>  static ssize_t dsicm_num_errors_show(struct device *dev,
>  		struct device_attribute *attr, char *buf)
>  {
> @@ -1116,8 +1109,6 @@ static struct omap_dss_driver dsicm_ops = {
>  	.update		= dsicm_update,
>  	.sync		= dsicm_sync,
> 
> -	.get_resolution	= dsicm_get_resolution,
> -
>  	.enable_te	= dsicm_enable_te,
>  	.get_te		= dsicm_get_te,
> 
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
> b/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c index
> 451e1608a1db..c90474afaebd 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
> @@ -226,8 +226,6 @@ static struct omap_dss_driver lb035q02_ops = {
>  	.set_timings	= lb035q02_set_timings,
>  	.get_timings	= lb035q02_get_timings,
>  	.check_timings	= lb035q02_check_timings,
> -
> -	.get_resolution	= omapdss_default_get_resolution,
>  };
> 
>  static int lb035q02_probe_of(struct spi_device *spi)
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c
> b/drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c index
> 95f6702a7b4f..df8132d3b9c6 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c
> @@ -220,8 +220,6 @@ static struct omap_dss_driver nec_8048_ops = {
>  	.set_timings	= nec_8048_set_timings,
>  	.get_timings	= nec_8048_get_timings,
>  	.check_timings	= nec_8048_check_timings,
> -
> -	.get_resolution	= omapdss_default_get_resolution,
>  };
> 
>  static int nec_8048_probe_of(struct spi_device *spi)
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c
> b/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c index
> b38c3df0532f..98d170aecaba 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c
> @@ -190,8 +190,6 @@ static struct omap_dss_driver sharp_ls_ops = {
>  	.set_timings	= sharp_ls_set_timings,
>  	.get_timings	= sharp_ls_get_timings,
>  	.check_timings	= sharp_ls_check_timings,
> -
> -	.get_resolution	= omapdss_default_get_resolution,
>  };
> 
>  static  int sharp_ls_get_gpio_of(struct device *dev, int index, int val,
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c
> b/drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c index
> be368868f77f..a4214a6a95fa 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c
> @@ -691,8 +691,6 @@ static struct omap_dss_driver acx565akm_ops = {
>  	.set_timings	= acx565akm_set_timings,
>  	.get_timings	= acx565akm_get_timings,
>  	.check_timings	= acx565akm_check_timings,
> -
> -	.get_resolution	= omapdss_default_get_resolution,
>  };
> 
>  static int acx565akm_probe_of(struct spi_device *spi)
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c
> b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c index
> da5ea2c378da..20c6d8fe215a 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c
> @@ -457,8 +457,6 @@ static struct omap_dss_driver tpo_td043_ops = {
> 
>  	.set_mirror	= tpo_td043_set_hmirror,
>  	.get_mirror	= tpo_td043_get_hmirror,
> -
> -	.get_resolution	= omapdss_default_get_resolution,
>  };
> 
>  static int tpo_td043_probe_of(struct spi_device *spi)
> diff --git a/drivers/gpu/drm/omapdrm/dss/display.c
> b/drivers/gpu/drm/omapdrm/dss/display.c index 10c36539d8ee..42279933790e
> 100644
> --- a/drivers/gpu/drm/omapdrm/dss/display.c
> +++ b/drivers/gpu/drm/omapdrm/dss/display.c
> @@ -30,14 +30,6 @@
> 
>  #include "omapdss.h"
> 
> -void omapdss_default_get_resolution(struct omap_dss_device *dssdev,
> -			u16 *xres, u16 *yres)
> -{
> -	*xres = dssdev->panel.vm.hactive;
> -	*yres = dssdev->panel.vm.vactive;
> -}
> -EXPORT_SYMBOL(omapdss_default_get_resolution);
> -
>  void omapdss_default_get_timings(struct omap_dss_device *dssdev,
>  				 struct videomode *vm)
>  {
> @@ -71,8 +63,6 @@ int omapdss_register_display(struct omap_dss_device
> *dssdev) if (dssdev->name == NULL)
>  		dssdev->name = dssdev->alias;
> 
> -	if (drv && drv->get_resolution == NULL)
> -		drv->get_resolution = omapdss_default_get_resolution;
>  	if (drv && drv->get_timings == NULL)
>  		drv->get_timings = omapdss_default_get_timings;
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> b/drivers/gpu/drm/omapdrm/dss/omapdss.h index 4909ea11cb71..74408b0ece26
> 100644
> --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> @@ -688,9 +688,6 @@ struct omap_dss_driver {
>  			void *buf, size_t size,
>  			u16 x, u16 y, u16 w, u16 h);
> 
> -	void (*get_resolution)(struct omap_dss_device *dssdev,
> -			u16 *xres, u16 *yres);
> -
>  	int (*check_timings)(struct omap_dss_device *dssdev,
>  			     struct videomode *vm);
>  	void (*set_timings)(struct omap_dss_device *dssdev,
> @@ -749,8 +746,6 @@ int omapdss_output_unset_device(struct omap_dss_device
> *out); struct omap_dss_device *omapdss_find_output_from_display(struct
> omap_dss_device *dssdev); struct omap_overlay_manager
> *omapdss_find_mgr_from_display(struct omap_dss_device *dssdev);
> 
> -void omapdss_default_get_resolution(struct omap_dss_device *dssdev,
> -		u16 *xres, u16 *yres);
>  void omapdss_default_get_timings(struct omap_dss_device *dssdev,
>  				 struct videomode *vm);

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-05-12 12:20 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-12 10:41 [PATCH 00/13] drm/omap: legacy cleanup Tomi Valkeinen
2017-05-12 10:41 ` [PATCH 01/13] drm/omap: panel-dpi: remove non-DT support Tomi Valkeinen
2017-05-12 12:08   ` Laurent Pinchart
2017-05-12 12:29     ` Tomi Valkeinen
2017-05-12 12:30       ` Laurent Pinchart
2017-05-12 10:41 ` [PATCH 02/13] drm/omap: acx565akm: " Tomi Valkeinen
2017-05-12 12:10   ` Laurent Pinchart
2017-05-12 10:41 ` [PATCH 03/13] drm/omap: connector-analog-tv: " Tomi Valkeinen
2017-05-12 10:41 ` [PATCH 04/13] drm/omap: connector-dvi/hdmi: remove extra include Tomi Valkeinen
2017-05-12 12:14   ` Laurent Pinchart
2017-05-12 10:41 ` [PATCH 05/13] drm/omap: sdi: remove legacy set_datapairs Tomi Valkeinen
2017-05-12 12:14   ` Laurent Pinchart
2017-05-12 10:41 ` [PATCH 06/13] drm/omap: venc: remove set_type & invert_vid_out_polarity Tomi Valkeinen
2017-05-12 12:15   ` Laurent Pinchart
2017-05-12 10:41 ` [PATCH 07/13] drm/omap: remove recommended_bpp Tomi Valkeinen
2017-05-12 12:16   ` Laurent Pinchart
2017-05-12 10:41 ` [PATCH 08/13] drm/omap: dpi: remove legacy data_lines Tomi Valkeinen
2017-05-12 12:17   ` Laurent Pinchart
2017-05-12 10:41 ` [PATCH 09/13] drm/omap: remove rfbi Tomi Valkeinen
2017-05-12 12:18   ` Laurent Pinchart
2017-05-12 10:41 ` [PATCH 10/13] drm/omap: remove unused get_dimensions() Tomi Valkeinen
2017-05-12 12:19   ` Laurent Pinchart
2017-05-12 10:41 ` [PATCH 11/13] drm/omap: remove legacy get_resolution Tomi Valkeinen
2017-05-12 12:20   ` Laurent Pinchart [this message]
2017-05-12 10:41 ` [PATCH 12/13] drm/omap: remove unused fields Tomi Valkeinen
2017-05-12 12:21   ` Laurent Pinchart
2017-05-12 10:41 ` [PATCH 13/13] drm/omap: remove omap_overlay & omap_overlay_manager Tomi Valkeinen
2017-05-12 12:25   ` Laurent Pinchart
2017-05-12 12:33 ` [PATCH 14/13] drm: omapdrm: Remove unused omap_dss_find_output() function Laurent Pinchart
2017-05-12 12:40   ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55366204.i0ashFAO7X@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox