From: "Michel Dänzer" <michel@daenzer.net>
To: akulichalexander@gmail.com
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] libdrm/amdgpu: Fixed drm.h include.
Date: Fri, 17 Jul 2015 18:13:33 +0900 [thread overview]
Message-ID: <55A8C73D.8010408@daenzer.net> (raw)
In-Reply-To: <4876049.pKxBoWjQE9@gid0pc>
On 17.07.2015 05:19, akulichalexander@gmail.com wrote:
> From: Alexandr Akulich <akulichalexander@gmail.com>
>
> The include type changed from system to own.
>
> Signed-off-by: Alexandr Akulich <akulichalexander@gmail.com>
> ---
> include/drm/amdgpu_drm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h
> index b6fce90..25e9b0a 100644
> --- a/include/drm/amdgpu_drm.h
> +++ b/include/drm/amdgpu_drm.h
> @@ -32,7 +32,7 @@
> #ifndef __AMDGPU_DRM_H__
> #define __AMDGPU_DRM_H__
>
> -#include <drm/drm.h>
> +#include "drm.h"
>
> #define DRM_AMDGPU_GEM_CREATE 0x00
> #define DRM_AMDGPU_GEM_MMAP 0x01
>
It should be
#include <drm.h>
<drm/drm.h> is wrong because that's the path of the kernel header, which
not every distro ships.
"drm.h" is wrong because amdgpu_drm.h is used by other projects.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-07-17 9:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 20:19 [PATCH] libdrm/amdgpu: Fixed drm.h include akulichalexander
2015-07-17 9:13 ` Michel Dänzer [this message]
2015-07-17 13:33 ` Alexandr Akulich
2015-07-22 7:19 ` Michel Dänzer
2015-07-22 7:33 ` Alexandr Akulich
2015-07-22 7:35 ` Alexandr Akulich
2015-07-22 8:20 ` Michel Dänzer
2015-07-29 2:35 ` Alexandr Akulich
2015-07-29 20:59 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A8C73D.8010408@daenzer.net \
--to=michel@daenzer.net \
--cc=akulichalexander@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox