Re: [PATCH] libdrm/amdgpu: Fixed drm.h include.

From: "Michel Dänzer" <michel@daenzer.net>
To: Alexandr Akulich <akulichalexander@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] libdrm/amdgpu: Fixed drm.h include.
Date: Wed, 22 Jul 2015 16:19:08 +0900	[thread overview]
Message-ID: <55AF43EC.7050107@daenzer.net> (raw)
In-Reply-To: <CAA1VrPor5LYX_yh=NZj43Wt3KG+MEkPN=abMQw9QpXNcZJreag@mail.gmail.com>

On 17.07.2015 22:33, Alexandr Akulich wrote:
> As I see, this is not a kernel header, but a local (belongs to libdrm) one.
> (Otherwise, I would like you to point me on such file at, say,
> https://github.com/torvalds/linux/tree/master/include/drm)

https://github.com/torvalds/linux/blob/master/include/uapi/drm/amdgpu_drm.h

> At files drm_sarea.h, mga_drm.h, qxl_drm.h, radeon_drm.h and via_drm.h we have
> 
> #include "drm.h"
> 
> At the same time, at i915_drm.h and tegra_drm.h. we have
> 
> #include <drm.h>
> 
> I'm pretty sure that the first case is correct, because drm.h is
> always would be local file (in the same directory), related to
> amdgpu_drm.h, and that is why local include "drm.h" would be always
> valid.

Makes sense to me, the patch is

Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>

> This fixes libdrm build with amdgpu support on bare system for me.

FWIW though, that's because you're dropping the drm/ prefix, not because
you're changing from <> to "".

-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel