dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/hisilicon/hibmc: Using module_pci_driver.
@ 2018-04-21  9:51 YueHaibing
  2018-04-23  3:14 ` xinliang
  0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2018-04-21  9:51 UTC (permalink / raw)
  To: dri-devel; +Cc: z.liuxinliang, daniel.vetter, intel-gfx, zourongrong, puck.chen

Remove boilerplate code by using macro module_pci_driver.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
index d4f6f1f..68d80c1 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
@@ -414,18 +414,7 @@ static struct pci_driver hibmc_pci_driver = {
 	.driver.pm =    &hibmc_pm_ops,
 };
 
-static int __init hibmc_init(void)
-{
-	return pci_register_driver(&hibmc_pci_driver);
-}
-
-static void __exit hibmc_exit(void)
-{
-	return pci_unregister_driver(&hibmc_pci_driver);
-}
-
-module_init(hibmc_init);
-module_exit(hibmc_exit);
+module_pci_driver(hibmc_pci_driver);
 
 MODULE_DEVICE_TABLE(pci, hibmc_pci_table);
 MODULE_AUTHOR("RongrongZou <zourongrong@huawei.com>");
-- 
2.7.0


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/hisilicon/hibmc: Using module_pci_driver.
  2018-04-21  9:51 [PATCH] drm/hisilicon/hibmc: Using module_pci_driver YueHaibing
@ 2018-04-23  3:14 ` xinliang
  0 siblings, 0 replies; 2+ messages in thread
From: xinliang @ 2018-04-23  3:14 UTC (permalink / raw)
  To: YueHaibing, dri-devel; +Cc: zourongrong, daniel.vetter, intel-gfx, puck.chen



On 2018/4/21 17:51, YueHaibing wrote:
> Remove boilerplate code by using macro module_pci_driver.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks Haibing,

Reviewed-by: Xinliang Liu <z.liuxinliang@hisilicon.com>

Xinliang

> ---
>   drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 13 +------------
>   1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> index d4f6f1f..68d80c1 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> @@ -414,18 +414,7 @@ static struct pci_driver hibmc_pci_driver = {
>   	.driver.pm =    &hibmc_pm_ops,
>   };
>   
> -static int __init hibmc_init(void)
> -{
> -	return pci_register_driver(&hibmc_pci_driver);
> -}
> -
> -static void __exit hibmc_exit(void)
> -{
> -	return pci_unregister_driver(&hibmc_pci_driver);
> -}
> -
> -module_init(hibmc_init);
> -module_exit(hibmc_exit);
> +module_pci_driver(hibmc_pci_driver);
>   
>   MODULE_DEVICE_TABLE(pci, hibmc_pci_table);
>   MODULE_AUTHOR("RongrongZou <zourongrong@huawei.com>");


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-23  3:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-21  9:51 [PATCH] drm/hisilicon/hibmc: Using module_pci_driver YueHaibing
2018-04-23  3:14 ` xinliang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox