dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* Re: drm/amdgpu: remove the redundant null check
       [not found]   ` <5D70A196.3020106@huawei.com>
@ 2019-09-05  8:38     ` Markus Elfring
  2019-09-05  8:46       ` zhong jiang
  0 siblings, 1 reply; 3+ messages in thread
From: Markus Elfring @ 2019-09-05  8:38 UTC (permalink / raw)
  To: zhong jiang, amd-gfx, dri-devel; +Cc: LKML, kernel-janitors

>> Were any source code analysis tools involved for finding
>> these update candidates?
> With the help of Coccinelle. You can find out some example in scripts/coccinelle/.

Thanks for such background information.
Was the script “ifnullfree.cocci” applied here?

Will it be helpful to add attribution for such tools
to any more descriptions in your patches?

Regards,
Markus

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: drm/amdgpu: remove the redundant null check
  2019-09-05  8:38     ` drm/amdgpu: remove the redundant null check Markus Elfring
@ 2019-09-05  8:46       ` zhong jiang
  2019-09-13 21:04         ` Alex Deucher
  0 siblings, 1 reply; 3+ messages in thread
From: zhong jiang @ 2019-09-05  8:46 UTC (permalink / raw)
  To: Markus Elfring; +Cc: amd-gfx, dri-devel, LKML, kernel-janitors

On 2019/9/5 16:38, Markus Elfring wrote:
>>> Were any source code analysis tools involved for finding
>>> these update candidates?
>> With the help of Coccinelle. You can find out some example in scripts/coccinelle/.
> Thanks for such background information.
> Was the script “ifnullfree.cocci” applied here?
Yep
> Will it be helpful to add attribution for such tools
> to any more descriptions in your patches?
Sometimes, I will add the description in my patches. Not always.

Thanks,
zhong jiang
> Regards,
> Markus
>
> .
>

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: drm/amdgpu: remove the redundant null check
  2019-09-05  8:46       ` zhong jiang
@ 2019-09-13 21:04         ` Alex Deucher
  0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2019-09-13 21:04 UTC (permalink / raw)
  To: zhong jiang
  Cc: Markus Elfring, kernel-janitors, Maling list - DRI developers,
	amd-gfx list, LKML

On Fri, Sep 6, 2019 at 3:01 AM zhong jiang <zhongjiang@huawei.com> wrote:
>
> On 2019/9/5 16:38, Markus Elfring wrote:
> >>> Were any source code analysis tools involved for finding
> >>> these update candidates?
> >> With the help of Coccinelle. You can find out some example in scripts/coccinelle/.
> > Thanks for such background information.
> > Was the script “ifnullfree.cocci” applied here?
> Yep
> > Will it be helpful to add attribution for such tools
> > to any more descriptions in your patches?
> Sometimes, I will add the description in my patches. Not always.

Applied with some minor tweaks to the commit message.

Thanks!

Alex

>
> Thanks,
> zhong jiang
> > Regards,
> > Markus
> >
> > .
> >
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-13 21:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1567491305-18320-1-git-send-email-zhongjiang@huawei.com>
     [not found] ` <62b33279-9ca9-5970-5336-a8511ce54197@web.de>
     [not found]   ` <5D70A196.3020106@huawei.com>
2019-09-05  8:38     ` drm/amdgpu: remove the redundant null check Markus Elfring
2019-09-05  8:46       ` zhong jiang
2019-09-13 21:04         ` Alex Deucher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox