From: Stephen Boyd <sboyd@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>,
Maxime Ripard <maxime@cerno.tech>
Cc: "Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Emma Anholt" <emma@anholt.net>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Maíra Canal" <mcanal@igalia.com>,
"Javier Martinez Canillas" <javierm@redhat.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Noralf Trønnes" <noralf@tronnes.org>,
"Matti Vaittinen" <matti.vaittinen@fi.rohmeurope.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v4 2/8] kunit: drm/tests: move generic helpers
Date: Mon, 20 Mar 2023 12:23:36 -0700 [thread overview]
Message-ID: <5ace543cae7a54db399750a1b330c3ae.sboyd@kernel.org> (raw)
In-Reply-To: <e8f50fe8-bad3-e59e-4d80-e2f7db9c9933@gmail.com>
Quoting Matti Vaittinen (2023-03-18 23:36:20)
> >
> > I think you would have an easier time if you just copied and renamed
> > them into the kunit folder as an preparation series.
>
> Yes. That would simplify the syncing between the trees. It slightly bugs
> me to add dublicate code in kernel-but the clean-up series for DRM users
> could be prepared at the same time. It would be even possible to just
> change the drm-helper to be a wrapper for the generic one - and leave
> the callers intact - although it leaves some seemingly unnecessary
> "onion code" there.
>
> > That way, you wouldn't have to coordinate DRM, CCF and IIO, you'd just
> > create new helpers that can be reused/converted to by everyone eventually
>
> Yes. Thanks - I think I may go with this approach for the v5 :)
Which kunit directory? I imagine if there are conflicts they will be
trivial so it probably doesn't matter. Have you Cced kunit folks and the
list on the kunit patches? They may have some opinion.
next prev parent reply other threads:[~2023-03-20 19:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 14:40 [PATCH v4 0/8] Support ROHM BU27034 ALS sensor Matti Vaittinen
2023-03-17 14:41 ` [PATCH v4 1/8] drm/tests: helpers: rename generic helpers Matti Vaittinen
2023-03-17 14:42 ` [PATCH v4 2/8] kunit: drm/tests: move " Matti Vaittinen
2023-03-17 15:09 ` Maxime Ripard
2023-03-19 6:36 ` Matti Vaittinen
2023-03-20 19:23 ` Stephen Boyd [this message]
2023-03-21 5:45 ` Matti Vaittinen
2023-03-21 18:59 ` Stephen Boyd
2023-03-22 6:16 ` Vaittinen, Matti
2023-03-22 9:44 ` Andy Shevchenko
2023-03-19 16:57 ` [PATCH v4 0/8] Support ROHM BU27034 ALS sensor Jonathan Cameron
2023-03-20 10:10 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ace543cae7a54db399750a1b330c3ae.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=maxime@cerno.tech \
--cc=mazziesaccount@gmail.com \
--cc=mcanal@igalia.com \
--cc=noralf@tronnes.org \
--cc=rafael@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox