Re: [PATCH v3 16/22] drm/sti: Use drm_gem_fb_create()

From: Vincent ABRIOU <vincent.abriou@st.com>
To: "Noralf Trønnes" <noralf@tronnes.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Cc: "narmstrong@baylibre.com" <narmstrong@baylibre.com>,
	"daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>,
	"liviu.dudau@arm.com" <liviu.dudau@arm.com>,
	"laurent.pinchart@ideasonboard.com"
	<laurent.pinchart@ideasonboard.com>,
	"marex@denx.de" <marex@denx.de>,
	"boris.brezillon@free-electrons.com"
	<boris.brezillon@free-electrons.com>,
	"abrodkin@synopsys.com" <abrodkin@synopsys.com>,
	"z.liuxinliang@hisilicon.com" <z.liuxinliang@hisilicon.com>,
	"kong.kongxinwei@hisilicon.com" <kong.kongxinwei@hisilicon.com>,
	"tomi.valkeinen@ti.com" <tomi.valkeinen@ti.com>,
	"puck.chen@hisilicon.com" <puck.chen@hisilicon.com>,
	"jsarha@ti.com" <jsarha@ti.com>,
	"alison.wang@freescale.com" <alison.wang@freescale.com>,
	Philippe CORNU <philippe.cornu@st.com>,
	Yannick FERTRE <yannick.fertre@st.com>,
	"zourongrong@gmail.com" <zourongrong@gmail.com>,
	"maxime.ripard@free-electrons.com" <maxime.ripard@free->
Subject: Re: [PATCH v3 16/22] drm/sti: Use drm_gem_fb_create()
Date: Mon, 21 Aug 2017 07:53:16 +0000	[thread overview]
Message-ID: <5d150e1e-3eea-dcd0-8b72-ce758376468a@st.com> (raw)
In-Reply-To: <1502631125-13557-17-git-send-email-noralf@tronnes.org>

Hi Noralf,

On 08/13/2017 03:31 PM, Noralf Trønnes wrote:
> drm_fb_cma_create() is just a wrapper around drm_gem_fb_create() now,
> so use the function directly.
> 
> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> Cc: Vincent Abriou <vincent.abriou@st.com>
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>

Acked-by: Vincent Abriou <vincent.abriou@st.com>

> ---
>   drivers/gpu/drm/sti/sti_drv.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c
> index 1700c54..9e93431 100644
> --- a/drivers/gpu/drm/sti/sti_drv.c
> +++ b/drivers/gpu/drm/sti/sti_drv.c
> @@ -16,6 +16,7 @@
>   #include <drm/drm_atomic_helper.h>
>   #include <drm/drm_crtc_helper.h>
>   #include <drm/drm_gem_cma_helper.h>
> +#include <drm/drm_gem_framebuffer_helper.h>
>   #include <drm/drm_fb_cma_helper.h>
>   #include <drm/drm_of.h>
>   
> @@ -145,7 +146,7 @@ static void sti_output_poll_changed(struct drm_device *ddev)
>   }
>   
>   static const struct drm_mode_config_funcs sti_mode_config_funcs = {
> -	.fb_create = drm_fb_cma_create,
> +	.fb_create = drm_gem_fb_create,
>   	.output_poll_changed = sti_output_poll_changed,
>   	.atomic_check = sti_atomic_check,
>   	.atomic_commit = drm_atomic_helper_commit,
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel