Re: [PATCH v3 17/22] drm/stm: Use drm_gem_fb_create()

["Noralf Trønnes" <noralf@tronnes.org>]

Den 01.09.2017 13.28, skrev Philippe CORNU:
> Hi Noralf,
> Many thanks for your patchset (and sorry for this late reply due to
> summer holidays :-),
>
> On 08/13/2017 03:32 PM, Noralf Trønnes wrote:
>> drm_fb_cma_create() is just a wrapper around drm_gem_fb_create() now,
>> so use the function directly.
>>
>> Cc: Yannick Fertre <yannick.fertre@st.com>
>> Cc: Philippe Cornu <philippe.cornu@st.com>
>> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
>> Cc: Vincent Abriou <vincent.abriou@st.com>
>> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
> Acked-by: Philippe Cornu <philippe.cornu@st.com>
> Tested-by: Philippe Cornu <philippe.cornu@st.com>

Thanks for your testing Philippe, it's appreciated.
It's reassuring to see that someone else gets this to work as well :-)
Applied to drm-misc.

Noralf.

> Philippe :-)
>
>> ---
>>    drivers/gpu/drm/stm/drv.c | 3 ++-
>>    1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/stm/drv.c b/drivers/gpu/drm/stm/drv.c
>> index b333b37..c857663 100644
>> --- a/drivers/gpu/drm/stm/drv.c
>> +++ b/drivers/gpu/drm/stm/drv.c
>> @@ -17,6 +17,7 @@
>>    #include <drm/drm_crtc_helper.h>
>>    #include <drm/drm_fb_cma_helper.h>
>>    #include <drm/drm_gem_cma_helper.h>
>> +#include <drm/drm_gem_framebuffer_helper.h>
>>    
>>    #include "ltdc.h"
>>    
>> @@ -31,7 +32,7 @@ static void drv_output_poll_changed(struct drm_device *ddev)
>>    }
>>    
>>    static const struct drm_mode_config_funcs drv_mode_config_funcs = {
>> -	.fb_create = drm_fb_cma_create,
>> +	.fb_create = drm_gem_fb_create,
>>    	.output_poll_changed = drv_output_poll_changed,
>>    	.atomic_check = drm_atomic_helper_check,
>>    	.atomic_commit = drm_atomic_helper_commit,
>>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel