* [PATCH] phy: phy-mtk-dp: Fix an error code in probe()
@ 2023-07-11 6:13 Dan Carpenter
2023-07-11 6:26 ` Chen-Yu Tsai
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dan Carpenter @ 2023-07-11 6:13 UTC (permalink / raw)
To: Markus Schneider-Pargmann
Cc: Kishon Vijay Abraham I, Chun-Kuang Hu, Bo-Chen Chen, linux-phy,
kernel-janitors, dri-devel, Matthias Brugger, Vinod Koul,
Guillaume Ranquet, linux-mediatek, Chunfeng Yun,
AngeloGioacchino Del Regno
Negative -EINVAL was intended instead of positive EINVAL.
Fixes: 6a23afad443a ("phy: phy-mtk-dp: Add driver for DP phy")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/phy/mediatek/phy-mtk-dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/mediatek/phy-mtk-dp.c b/drivers/phy/mediatek/phy-mtk-dp.c
index 232fd3f1ff1b..d7024a144335 100644
--- a/drivers/phy/mediatek/phy-mtk-dp.c
+++ b/drivers/phy/mediatek/phy-mtk-dp.c
@@ -169,7 +169,7 @@ static int mtk_dp_phy_probe(struct platform_device *pdev)
regs = *(struct regmap **)dev->platform_data;
if (!regs)
- return dev_err_probe(dev, EINVAL,
+ return dev_err_probe(dev, -EINVAL,
"No data passed, requires struct regmap**\n");
dp_phy = devm_kzalloc(dev, sizeof(*dp_phy), GFP_KERNEL);
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] phy: phy-mtk-dp: Fix an error code in probe()
2023-07-11 6:13 [PATCH] phy: phy-mtk-dp: Fix an error code in probe() Dan Carpenter
@ 2023-07-11 6:26 ` Chen-Yu Tsai
2023-07-11 7:36 ` Vinod Koul
2023-07-11 9:22 ` AngeloGioacchino Del Regno
2 siblings, 0 replies; 4+ messages in thread
From: Chen-Yu Tsai @ 2023-07-11 6:26 UTC (permalink / raw)
To: Dan Carpenter
Cc: Kishon Vijay Abraham I, Chun-Kuang Hu, Guillaume Ranquet,
kernel-janitors, dri-devel, Markus Schneider-Pargmann, linux-phy,
Vinod Koul, Chunfeng Yun, Matthias Brugger, Bo-Chen Chen,
linux-mediatek, AngeloGioacchino Del Regno
On Tue, Jul 11, 2023 at 2:13 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> Negative -EINVAL was intended instead of positive EINVAL.
>
> Fixes: 6a23afad443a ("phy: phy-mtk-dp: Add driver for DP phy")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] phy: phy-mtk-dp: Fix an error code in probe()
2023-07-11 6:13 [PATCH] phy: phy-mtk-dp: Fix an error code in probe() Dan Carpenter
2023-07-11 6:26 ` Chen-Yu Tsai
@ 2023-07-11 7:36 ` Vinod Koul
2023-07-11 9:22 ` AngeloGioacchino Del Regno
2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2023-07-11 7:36 UTC (permalink / raw)
To: Markus Schneider-Pargmann, Dan Carpenter
Cc: Kishon Vijay Abraham I, Chun-Kuang Hu, Bo-Chen Chen, linux-phy,
kernel-janitors, dri-devel, Matthias Brugger, Guillaume Ranquet,
linux-mediatek, Chunfeng Yun, AngeloGioacchino Del Regno
On Tue, 11 Jul 2023 09:13:25 +0300, Dan Carpenter wrote:
> Negative -EINVAL was intended instead of positive EINVAL.
>
>
Applied, thanks!
[1/1] phy: phy-mtk-dp: Fix an error code in probe()
commit: 03966c3950d36d6b671158be3794eb7211434faa
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] phy: phy-mtk-dp: Fix an error code in probe()
2023-07-11 6:13 [PATCH] phy: phy-mtk-dp: Fix an error code in probe() Dan Carpenter
2023-07-11 6:26 ` Chen-Yu Tsai
2023-07-11 7:36 ` Vinod Koul
@ 2023-07-11 9:22 ` AngeloGioacchino Del Regno
2 siblings, 0 replies; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-07-11 9:22 UTC (permalink / raw)
To: Dan Carpenter, Markus Schneider-Pargmann
Cc: Kishon Vijay Abraham I, Chun-Kuang Hu, Bo-Chen Chen, linux-phy,
kernel-janitors, dri-devel, Matthias Brugger, Vinod Koul,
Guillaume Ranquet, linux-mediatek, Chunfeng Yun
Il 11/07/23 08:13, Dan Carpenter ha scritto:
> Negative -EINVAL was intended instead of positive EINVAL.
>
> Fixes: 6a23afad443a ("phy: phy-mtk-dp: Add driver for DP phy")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-11 9:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-11 6:13 [PATCH] phy: phy-mtk-dp: Fix an error code in probe() Dan Carpenter
2023-07-11 6:26 ` Chen-Yu Tsai
2023-07-11 7:36 ` Vinod Koul
2023-07-11 9:22 ` AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox