From: Hoegeun Kwon <hoegeun.kwon@samsung.com>
To: Eric Anholt <eric@anholt.net>,
airlied@linux.ie, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org,
Hoegeun Kwon <hoegeun.kwon@samsung.com>
Subject: Re: [PATCH] drm/vc4: Fix with pm_runtime synchronization on DSI
Date: Wed, 22 May 2019 19:24:47 +0900 [thread overview]
Message-ID: <77366d2d-9239-2fb3-9938-0d270c52867c@samsung.com> (raw)
In-Reply-To: <87ftqrno2v.fsf@anholt.net>
[-- Attachment #1.1: Type: text/plain, Size: 1232 bytes --]
On 4/10/19 1:24 AM, Eric Anholt wrote:
> Hoegeun Kwon <hoegeun.kwon@samsung.com> writes:
>
>> On 4/2/19 2:48 AM, Eric Anholt wrote:
>>> Hoegeun Kwon <hoegeun.kwon@samsung.com> writes:
>>>
>>>> There is a problem when often dpms goes from off to on. pm idle is not
>>>> in sync and the problem occurs. Modify pm_runtime_put from
>>>> asynchronous to synchronous.
>>> Why would we need the power domain to go to off before we try to come
>>> back? Any idea? Also, please specify what "the problem" is.
>> Hi Eric,
>>
>>
>> First thank you for your review.
>>
>> There is a problem failed to runtime PM enable on DSI when often dpms
> What do you mean by "failed to runtime PM enable"? The
> pm_runtime_enable() returned an error? Have you investigated the source
> that error, if so?
I'm sorry for the late reply.
The pm_runtime_enable() is not returned because return value is void.
The problem is that if the error log is not output
and the DPMS off on is repeated, the screen will stop.
As a result of debugging the problem, I think that synchronization
is a problem caused by dsi pm_suspend and resume.
So when we entered the pm runtime idle state, if used with sync,
the problem does not occur.
Best regards,
Hoegeun
[-- Attachment #1.2.1: Type: text/html, Size: 2842 bytes --]
[-- Attachment #1.2.2: Type: image/gif, Size: 13402 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-05-22 10:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190329012926epcas1p3fbfa796a221c2fd105a84c31c80016d5@epcas1p3.samsung.com>
2019-03-29 1:29 ` [PATCH] drm/vc4: Fix with pm_runtime synchronization on DSI Hoegeun Kwon
2019-04-01 17:48 ` Eric Anholt
2019-04-08 1:05 ` Hoegeun Kwon
2019-04-09 16:24 ` Eric Anholt
2019-05-22 10:24 ` Hoegeun Kwon [this message]
2019-05-22 11:32 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77366d2d-9239-2fb3-9938-0d270c52867c@samsung.com \
--to=hoegeun.kwon@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox