From: Eric Anholt <eric@anholt.net>
To: airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org
Cc: hoegeun.kwon@samsung.com
Subject: Re: [PATCH] drm/vc4: Fix with pm_runtime synchronization on DSI
Date: Mon, 01 Apr 2019 10:48:11 -0700 [thread overview]
Message-ID: <87bm1p1usk.fsf@anholt.net> (raw)
In-Reply-To: <20190329012913.29538-1-hoegeun.kwon@samsung.com>
[-- Attachment #1.1: Type: text/plain, Size: 1064 bytes --]
Hoegeun Kwon <hoegeun.kwon@samsung.com> writes:
> There is a problem when often dpms goes from off to on. pm idle is not
> in sync and the problem occurs. Modify pm_runtime_put from
> asynchronous to synchronous.
Why would we need the power domain to go to off before we try to come
back? Any idea? Also, please specify what "the problem" is.
>
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
> ---
> drivers/gpu/drm/vc4/vc4_dsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
> index 11702e1d9011..b0264c7b8bed 100644
> --- a/drivers/gpu/drm/vc4/vc4_dsi.c
> +++ b/drivers/gpu/drm/vc4/vc4_dsi.c
> @@ -822,7 +822,7 @@ static void vc4_dsi_encoder_disable(struct drm_encoder *encoder)
> clk_disable_unprepare(dsi->escape_clock);
> clk_disable_unprepare(dsi->pixel_clock);
>
> - pm_runtime_put(dev);
> + pm_runtime_put_sync(dev);
> }
>
> /* Extends the mode's blank intervals to handle BCM2835's integer-only
> --
> 2.17.1
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-04-01 17:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190329012926epcas1p3fbfa796a221c2fd105a84c31c80016d5@epcas1p3.samsung.com>
2019-03-29 1:29 ` [PATCH] drm/vc4: Fix with pm_runtime synchronization on DSI Hoegeun Kwon
2019-04-01 17:48 ` Eric Anholt [this message]
2019-04-08 1:05 ` Hoegeun Kwon
2019-04-09 16:24 ` Eric Anholt
2019-05-22 10:24 ` Hoegeun Kwon
2019-05-22 11:32 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm1p1usk.fsf@anholt.net \
--to=eric@anholt.net \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hoegeun.kwon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox