From: Thomas Zimmermann <tzimmermann@suse.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: airlied@linux.ie, puck.chen@hisilicon.com,
dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org,
z.liuxinliang@hisilicon.com, hdegoede@redhat.com,
kong.kongxinwei@hisilicon.com, ray.huang@amd.com,
zourongrong@gmail.com, sam@ravnborg.org,
christian.koenig@amd.com
Subject: Re: [PATCH v4 12/19] drm/bochs: Convert bochs driver to VRAM MM
Date: Mon, 6 May 2019 15:15:34 +0200 [thread overview]
Message-ID: <78ce7242-81c0-e617-c181-5686aba3847b@suse.de> (raw)
In-Reply-To: <20190506124031.jwo5exbz6xk5fjan@sirius.home.kraxel.org>
[-- Attachment #1.1.1: Type: text/plain, Size: 1095 bytes --]
Hi
Am 06.05.19 um 14:40 schrieb Gerd Hoffmann:
> Hi,
>
>> static const struct file_operations bochs_fops = {
>> .owner = THIS_MODULE,
>> - .open = drm_open,
>> - .release = drm_release,
>> - .unlocked_ioctl = drm_ioctl,
>> - .compat_ioctl = drm_compat_ioctl,
>> - .poll = drm_poll,
>> - .read = drm_read,
>> .llseek = no_llseek,
>> - .mmap = bochs_mmap,
>> + DRM_VRAM_MM_FILE_OPERATIONS
>> };
>
> What about llseek? I think it should either be deleted (if not needed)
> or added to DRM_VRAM_MM_FILE_OPERATIONS (if needed).
Some drivers set no_llseek, some leave the .llseek field to NULL. So I
don't set the field from DRM_VRAM_MM_FILE_OPERATIONS.
But now that you asked, I found that DRM actually requires no_llseek.
I'll add it to the default operations in the next iteration of the patch
set.
Best regards
Thomas
> cheers,
> Gerd
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-05-06 13:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 8:26 [PATCH v4 00/19] Share TTM code among DRM framebuffer drivers Thomas Zimmermann
2019-05-06 8:26 ` [PATCH v4 01/19] drm: Add |struct drm_gem_vram_object| and helpers Thomas Zimmermann
2019-05-06 12:31 ` Gerd Hoffmann
2019-05-06 12:58 ` Thomas Zimmermann
2019-05-06 13:17 ` Gerd Hoffmann
2019-05-06 13:53 ` Thomas Zimmermann
2019-05-06 8:26 ` [PATCH v4 02/19] drm: Add |struct drm_gem_vram_object| callbacks for |struct ttm_bo_driver| Thomas Zimmermann
2019-05-06 8:26 ` [PATCH v4 03/19] drm: Add |struct drm_gem_vram_object| callbacks for |struct drm_driver| Thomas Zimmermann
2019-05-06 8:26 ` [PATCH v4 04/19] drm: Add drm_gem_vram_fill_create_dumb() to create dumb buffers Thomas Zimmermann
2019-05-06 8:26 ` [PATCH v4 05/19] drm: Add VRAM MM, a simple memory manager for dedicated VRAM Thomas Zimmermann
2019-05-06 8:26 ` [PATCH v4 06/19] drm: Add default instance for VRAM MM callback functions Thomas Zimmermann
2019-05-06 8:26 ` [PATCH v4 07/19] drm: Integrate VRAM MM into struct drm_device Thomas Zimmermann
2019-05-06 8:26 ` [PATCH v4 08/19] drm/ast: Convert AST driver to |struct drm_gem_vram_object| Thomas Zimmermann
2019-05-06 8:26 ` [PATCH v4 09/19] drm/ast: Convert AST driver to VRAM MM Thomas Zimmermann
2019-05-06 8:26 ` [PATCH v4 10/19] drm/ast: Replace mapping code with drm_gem_vram_{kmap/kunmap}() Thomas Zimmermann
2019-05-06 8:26 ` [PATCH v4 11/19] drm/bochs: Convert bochs driver to |struct drm_gem_vram_object| Thomas Zimmermann
2019-05-06 8:26 ` [PATCH v4 12/19] drm/bochs: Convert bochs driver to VRAM MM Thomas Zimmermann
2019-05-06 12:40 ` Gerd Hoffmann
2019-05-06 13:15 ` Thomas Zimmermann [this message]
2019-05-06 8:26 ` [PATCH v4 13/19] drm/mgag200: Convert mgag200 driver to |struct drm_gem_vram_object| Thomas Zimmermann
2019-05-06 8:26 ` [PATCH v4 14/19] drm/mgag200: Convert mgag200 driver to VRAM MM Thomas Zimmermann
2019-05-06 8:26 ` [PATCH v4 15/19] drm/mgag200: Replace mapping code with drm_gem_vram_{kmap/kunmap}() Thomas Zimmermann
2019-05-06 8:26 ` [PATCH v4 16/19] drm/vboxvideo: Convert vboxvideo driver to |struct drm_gem_vram_object| Thomas Zimmermann
2019-05-06 8:26 ` [PATCH v4 17/19] drm/vboxvideo: Convert vboxvideo driver to VRAM MM Thomas Zimmermann
2019-05-06 8:26 ` [PATCH v4 18/19] drm/hisilicon: Convert hibmc-drm driver to |struct drm_gem_vram_object| Thomas Zimmermann
2019-05-06 8:26 ` [PATCH v4 19/19] drm/hisilicon: Convert hibmc-drm driver to VRAM MM Thomas Zimmermann
2019-05-06 12:22 ` [PATCH v4 00/19] Share TTM code among DRM framebuffer drivers Gerd Hoffmann
2019-05-06 13:09 ` Thomas Zimmermann
2019-05-06 14:20 ` Gerd Hoffmann
2019-05-06 15:23 ` Daniel Vetter
2019-05-06 12:43 ` Gerd Hoffmann
2019-05-06 13:05 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78ce7242-81c0-e617-c181-5686aba3847b@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@linux.ie \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=kraxel@redhat.com \
--cc=puck.chen@hisilicon.com \
--cc=ray.huang@amd.com \
--cc=sam@ravnborg.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=z.liuxinliang@hisilicon.com \
--cc=zourongrong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox