dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Jyri Sarha <jsarha@ti.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 01/24] drm/omap: fix omap_fbdev_free() when omap_fbdev_create() wasn't called
Date: Tue, 27 Feb 2018 13:28:52 +0200	[thread overview]
Message-ID: <7970757.6UgUtQ5Y9V@avalon> (raw)
In-Reply-To: <1518428694-18018-2-git-send-email-tomi.valkeinen@ti.com>

Hi Tomi,

Thank you for the patch.

On Monday, 12 February 2018 11:44:31 EET Tomi Valkeinen wrote:
> If we have no crtcs/connectors, fbdev init goes fine, but
> omap_fbdev_create() is never called. This means that omap_fbdev->bo is
> NULL and omap_fbdev_free() crashes.
> 
> Add a check to omap_fbdev_free() to handle the NULL case.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

I wonder whether we shouldn't fail probe if we have no CRTC or connector, but 
regardless of that, this change looks good to me.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/omapdrm/omap_fbdev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c
> b/drivers/gpu/drm/omapdrm/omap_fbdev.c index 1ace63e2ff22..632ebcf2165f
> 100644
> --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
> +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> @@ -303,7 +303,8 @@ void omap_fbdev_free(struct drm_device *dev)
>  	fbdev = to_omap_fbdev(priv->fbdev);
> 
>  	/* unpin the GEM object pinned in omap_fbdev_create() */
> -	omap_gem_unpin(fbdev->bo);
> +	if (fbdev->bo)
> +		omap_gem_unpin(fbdev->bo);
> 
>  	/* this will free the backing object */
>  	if (fbdev->fb)

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-02-27 11:28 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12  9:44 [PATCH 00/24] drm/omap: misc patches Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 01/24] drm/omap: fix omap_fbdev_free() when omap_fbdev_create() wasn't called Tomi Valkeinen
2018-02-27 11:28   ` Laurent Pinchart [this message]
2018-02-27 11:53     ` Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 02/24] drm/omap: cleanup fbdev init/free Tomi Valkeinen
2018-02-27 11:38   ` Laurent Pinchart
2018-02-28  8:49     ` Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 03/24] drm/omap: add HPD support to connector-dvi Tomi Valkeinen
2018-02-27 12:58   ` Laurent Pinchart
2018-02-28  9:00     ` Tomi Valkeinen
     [not found] ` <1518428694-18018-1-git-send-email-tomi.valkeinen-l0cyMroinI0@public.gmane.org>
2018-02-12  9:44   ` [PATCH 04/24] dt-bindings: display: add HPD gpio to DVI connector Tomi Valkeinen
2018-02-19  0:11     ` Rob Herring
2018-02-27 13:01     ` Laurent Pinchart
2018-02-12  9:44 ` [PATCH 05/24] drm/omap: Use devm_kzalloc() to allocate omap_drm_private Tomi Valkeinen
2018-02-27 13:03   ` Laurent Pinchart
2018-02-12  9:44 ` [PATCH 06/24] drm/omap: Allocate drm_device earlier and unref it as last step Tomi Valkeinen
2018-02-27 13:07   ` Laurent Pinchart
2018-02-12  9:44 ` [PATCH 07/24] drm/omap: Manage the usable omap_dss_device list within omap_drm_private Tomi Valkeinen
2018-02-27 13:19   ` Laurent Pinchart
2018-02-12  9:44 ` [PATCH 08/24] drm/omap: Separate the dssdevs array setup from the connect function Tomi Valkeinen
2018-02-27 13:23   ` Laurent Pinchart
2018-02-12  9:44 ` [PATCH 09/24] drm/omap: Do dss_device (display) ordering in omap_drv.c Tomi Valkeinen
2018-02-27 13:26   ` Laurent Pinchart
2018-02-12  9:44 ` [PATCH 10/24] drm/omap: dss: Remove display ordering from dss/display.c Tomi Valkeinen
2018-02-27 13:30   ` Laurent Pinchart
2018-02-12  9:44 ` [PATCH 11/24] drm/omap: Add kernel parameter to specify the desired display order Tomi Valkeinen
2018-02-27 13:35   ` Laurent Pinchart
2018-02-28  9:16     ` Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 12/24] drm/omap: Init fbdev emulation only when we have displays Tomi Valkeinen
2018-02-27 13:36   ` Laurent Pinchart
2018-02-12  9:44 ` [PATCH 13/24] drm/omap: remove leftover enums Tomi Valkeinen
2018-02-27 13:36   ` Laurent Pinchart
2018-02-12  9:44 ` [PATCH 14/24] drm/omap: dispc: disp_wb_setup to check return code Tomi Valkeinen
2018-02-27 13:38   ` Laurent Pinchart
2018-02-12  9:44 ` [PATCH 15/24] drm/omap: Add pclk setting case when channel is DSS_WB Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 16/24] drm/omap: set WB channel-in in wb_setup() Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 17/24] drm/omap: fix WBDELAYCOUNT for HDMI Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 18/24] drm/omap: fix WBDELAYCOUNT with interlace Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 19/24] drm/omap: fix WB height " Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 20/24] drm/omap: fix scaling limits for WB Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 21/24] drm/omap: add writeback funcs to dispc_ops Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 22/24] drm/omap: fix maximum sizes Tomi Valkeinen
2018-02-27 13:42   ` Laurent Pinchart
2018-02-28  9:10     ` Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 23/24] drm/omap: Allow HDMI audio setup even if we do not have video configured Tomi Valkeinen
2018-02-12  9:44 ` [PATCH 24/24] drm/omap: cleanup color space conversion Tomi Valkeinen
2018-02-27 14:08   ` Laurent Pinchart
2018-02-28 10:09     ` Tomi Valkeinen
2018-02-28 10:13       ` Laurent Pinchart
2018-02-28 10:22         ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7970757.6UgUtQ5Y9V@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).