* [PATCH] drm/amdkfd: Fix if preprocessor statement above kfd_fill_iolink_info_for_cpu [not found] <20190121223516.24340-1-natechancellor@gmail.com> @ 2019-01-21 23:52 ` Nathan Chancellor 2019-01-31 20:10 ` Kuehling, Felix 0 siblings, 1 reply; 3+ messages in thread From: Nathan Chancellor @ 2019-01-21 23:52 UTC (permalink / raw) To: Oded Gabbay, Alex Deucher, Christian König, David (ChunMing) Zhou Cc: Felix Kuehling, Mark Nutter, dri-devel, amd-gfx, linux-kernel, Nathan Chancellor Clang warns: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:866:5: warning: 'CONFIG_X86_64' is not defined, evaluates to 0 [-Wundef] #if CONFIG_X86_64 ^ 1 warning generated. Fixes: d1c234e2cd10 ("drm/amdkfd: Allow building KFD on ARM64 (v2)") Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- Resending as I forgot to add the lists... drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c index 5d85ff341385..2e7c44955f43 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c @@ -863,7 +863,7 @@ static int kfd_fill_mem_info_for_cpu(int numa_node_id, int *avail_size, return 0; } -#if CONFIG_X86_64 +#ifdef CONFIG_X86_64 static int kfd_fill_iolink_info_for_cpu(int numa_node_id, int *avail_size, uint32_t *num_entries, struct crat_subtype_iolink *sub_type_hdr) -- 2.20.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdkfd: Fix if preprocessor statement above kfd_fill_iolink_info_for_cpu 2019-01-21 23:52 ` [PATCH] drm/amdkfd: Fix if preprocessor statement above kfd_fill_iolink_info_for_cpu Nathan Chancellor @ 2019-01-31 20:10 ` Kuehling, Felix [not found] ` <7a6ce2e6-620e-ca73-d21d-207c8f9248ce-5C7GfCeVMHo@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Kuehling, Felix @ 2019-01-31 20:10 UTC (permalink / raw) To: Nathan Chancellor, Oded Gabbay, Deucher, Alexander, Koenig, Christian, Zhou, David(ChunMing) Cc: Mark Nutter, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Thank you, Nathan. I applied your patch to amd-staging-drm-next. Sorry for the late response. I'm catching up with my email backlog after a vacation. Regards, Felix On 2019-01-21 6:52 p.m., Nathan Chancellor wrote: > Clang warns: > > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:866:5: warning: > 'CONFIG_X86_64' is not defined, evaluates to 0 [-Wundef] > #if CONFIG_X86_64 > ^ > 1 warning generated. > > Fixes: d1c234e2cd10 ("drm/amdkfd: Allow building KFD on ARM64 (v2)") > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > --- > > Resending as I forgot to add the lists... > > drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c > index 5d85ff341385..2e7c44955f43 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c > @@ -863,7 +863,7 @@ static int kfd_fill_mem_info_for_cpu(int numa_node_id, int *avail_size, > return 0; > } > > -#if CONFIG_X86_64 > +#ifdef CONFIG_X86_64 > static int kfd_fill_iolink_info_for_cpu(int numa_node_id, int *avail_size, > uint32_t *num_entries, > struct crat_subtype_iolink *sub_type_hdr) ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <7a6ce2e6-620e-ca73-d21d-207c8f9248ce-5C7GfCeVMHo@public.gmane.org>]
* Re: [PATCH] drm/amdkfd: Fix if preprocessor statement above kfd_fill_iolink_info_for_cpu [not found] ` <7a6ce2e6-620e-ca73-d21d-207c8f9248ce-5C7GfCeVMHo@public.gmane.org> @ 2019-02-04 3:26 ` Dave Airlie 0 siblings, 0 replies; 3+ messages in thread From: Dave Airlie @ 2019-02-04 3:26 UTC (permalink / raw) To: Kuehling, Felix Cc: Oded Gabbay, Mark Nutter, Zhou, David(ChunMing), linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Deucher, Alexander, Nathan Chancellor, Koenig, Christian Alex, can you get this into next and resend the pull? I don't like adding warnings. Dave. On Fri, 1 Feb 2019 at 06:10, Kuehling, Felix <Felix.Kuehling@amd.com> wrote: > > Thank you, Nathan. I applied your patch to amd-staging-drm-next. > > Sorry for the late response. I'm catching up with my email backlog after > a vacation. > > Regards, > Felix > > On 2019-01-21 6:52 p.m., Nathan Chancellor wrote: > > Clang warns: > > > > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:866:5: warning: > > 'CONFIG_X86_64' is not defined, evaluates to 0 [-Wundef] > > #if CONFIG_X86_64 > > ^ > > 1 warning generated. > > > > Fixes: d1c234e2cd10 ("drm/amdkfd: Allow building KFD on ARM64 (v2)") > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > > --- > > > > Resending as I forgot to add the lists... > > > > drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c > > index 5d85ff341385..2e7c44955f43 100644 > > --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c > > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c > > @@ -863,7 +863,7 @@ static int kfd_fill_mem_info_for_cpu(int numa_node_id, int *avail_size, > > return 0; > > } > > > > -#if CONFIG_X86_64 > > +#ifdef CONFIG_X86_64 > > static int kfd_fill_iolink_info_for_cpu(int numa_node_id, int *avail_size, > > uint32_t *num_entries, > > struct crat_subtype_iolink *sub_type_hdr) > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-04 3:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190121223516.24340-1-natechancellor@gmail.com>
2019-01-21 23:52 ` [PATCH] drm/amdkfd: Fix if preprocessor statement above kfd_fill_iolink_info_for_cpu Nathan Chancellor
2019-01-31 20:10 ` Kuehling, Felix
[not found] ` <7a6ce2e6-620e-ca73-d21d-207c8f9248ce-5C7GfCeVMHo@public.gmane.org>
2019-02-04 3:26 ` Dave Airlie
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox