From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Jyri Sarha <jsarha@ti.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] Revert "drm: omapdrm: Let the DRM core skip plane commit on inactive CRTCs"
Date: Mon, 30 Jan 2017 10:48:43 +0200 [thread overview]
Message-ID: <8687fdb8-c8a8-86b2-4a7e-74aa0bbce22e@ti.com> (raw)
In-Reply-To: <1633511.8VzXcN818D@avalon>
[-- Attachment #1.1.1: Type: text/plain, Size: 1415 bytes --]
On 28/01/17 18:11, Laurent Pinchart wrote:
> Hi Jyri,
>
> Thank you for the patch.
>
> On Friday 27 Jan 2017 12:04:54 Jyri Sarha wrote:
>> This reverts commit dadf4659d0608e034b6633f30300c2eff2dafb4c.
>>
>> If planes are not disabled when the they are not on any crtc anymore
>> they will remain active and may show as "ghosts" when the crtc they
>> were last on is active again.
>
> Sorry for the breakage.
>
> The drm_atomic_helper_commit_planes() helper documentation states
>
> * Unless otherwise needed, drivers are advised to set the ACTIVE_ONLY flag in
> * @flags in order not to receive plane update notifications related to a
> * disabled CRTC. This avoids the need to manually ignore plane updates in
> * driver code when the driver and/or hardware can't or just don't need to
> * deal with updates on disabled CRTCs, for example when supporting runtime
> * PM.
>
> I wonder what this implies when CRTCs are being disabled. I see very few cases
> where the hardware wouldn't need the plane atomic disable operation being
> called when a plane is being disabled due to its CRTC being disabled. Maybe
> this should thus be addressed in the core. Daniel, any comment on this ?
Similar change was done to mali in "drm: mali-dp: Don't set
DRM_PLANE_COMMIT_ACTIVE_ONLY", so at least omapdrm is not alone here. I
also wonder if this behavior is correct.
Tomi
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-01-30 8:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 10:04 [PATCH 0/2] drm/omapdrm: Couple of plane related fixes Jyri Sarha
2017-01-27 10:04 ` [PATCH 1/2] Revert "drm: omapdrm: Let the DRM core skip plane commit on inactive CRTCs" Jyri Sarha
2017-01-28 16:11 ` Laurent Pinchart
2017-01-30 8:48 ` Tomi Valkeinen [this message]
2017-01-27 10:04 ` [PATCH 2/2] drm/omapdrm: Move commit_modeset_enables() before commit_planes() Jyri Sarha
2017-01-28 16:17 ` Laurent Pinchart
2017-01-30 8:50 ` Tomi Valkeinen
2017-01-30 11:11 ` Jyri Sarha
2017-01-30 11:15 ` Laurent Pinchart
2017-01-30 12:50 ` Jyri Sarha
2017-02-06 11:50 ` [PATCH 0/2] drm/omapdrm: Couple of plane related fixes Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8687fdb8-c8a8-86b2-4a7e-74aa0bbce22e@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox