Re: [Intel-gfx] [PATCH] drm/i915: Invalidate the TLBs on each GT

Re: [Intel-gfx] [PATCH] drm/i915: Invalidate the TLBs on each GT

[Nirmoy Das]

+dri-devel

On 10/2/2023 4:07 PM, Jonathan Cavitt wrote:
> From: Chris Wilson <chris.p.wilson@intel.com>
>
> With multi-GT devices, the object may have been bound on each GT and so
> we need to invalidate the TLBs across all GT before releasing the pages
> back to the system.
>
> Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs on each GT")
> Signed-off-by: Chris Wilson <chris.p.wilson@intel.com>
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> CC: Matt Roper <matthew.d.roper@intel.com>
> CC: Andi Shyti <andi.shyti@linux.intel.com>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>

Can't find it in dri-devel but if you didn't then Cc to 
dri-devel@lists.freedesktop.org for change that touches gt/gem files.


Regards,

Nirmoy

> ---
>   drivers/gpu/drm/i915/gem/i915_gem_pages.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
> index 6b6d22c194110..0ba955611dfb5 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
> @@ -198,7 +198,7 @@ static void flush_tlb_invalidate(struct drm_i915_gem_object *obj)
>   
>   	for_each_gt(gt, i915, id) {
>   		if (!obj->mm.tlb[id])
> -			return;
> +			continue;
>   
>   		intel_gt_invalidate_tlb_full(gt, obj->mm.tlb[id]);
>   		obj->mm.tlb[id] = 0;