From: Eric Anholt <eric@anholt.net>
To: Thierry Reding <thierry.reding@gmail.com>,
dri-devel@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 1/2] drm/atomic: Add helpers for state-subclassing drivers
Date: Fri, 27 Mar 2015 11:03:29 -0700 [thread overview]
Message-ID: <87d23ugvwu.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <1427456044-7643-1-git-send-email-thierry.reding@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 816 bytes --]
Thierry Reding <thierry.reding@gmail.com> writes:
> From: Thierry Reding <treding@nvidia.com>
>
> Drivers that subclass CRTC, plane or connector state need to carefully
> duplicate the code that the atomic helpers have. This is bound to cause
> breakage eventually because it requires auditing all drivers and update
> them when code is added to the helpers.
>
> In order to avoid that, implement new helpers that perform the required
> steps when copying and destroying state. These new helpers are exported
> so that state-subclassing drivers can use them. The default helpers are
> implemented using them as well, providing a single location that needs
> to be changed when adding to base atomic states.
I was looking for these helpers when writing VC4 KMS. Thanks!
Reviewed-by: Eric Anholt <eric@anholt.net>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-03-27 18:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 11:34 [PATCH 1/2] drm/atomic: Add helpers for state-subclassing drivers Thierry Reding
2015-03-27 11:34 ` [PATCH 2/2] drm/tegra: dc: Use base atomic state helpers Thierry Reding
2015-03-27 18:03 ` Eric Anholt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d23ugvwu.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox