public inbox for dri-devel@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: "Lee, Shawn C" <shawn.c.lee@intel.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: Cooper Chiou <cooper.chiou@intel.com>,
	Lee@freedesktop.org,
	Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Subject: Re: [PATCH 3/3] drm: add LG eDP panel to quirk database
Date: Mon, 10 Sep 2018 14:43:10 +0300	[thread overview]
Message-ID: <87in3d37e9.fsf@intel.com> (raw)
In-Reply-To: <1536568214-6949-4-git-send-email-shawn.c.lee@intel.com>

On Mon, 10 Sep 2018, "Lee, Shawn C" <shawn.c.lee@intel.com> wrote:
> The N value was computed by kernel driver that based on synchronous clock
> mode. But only specific N value (0x8000) would be acceptable for
> LG LP140WF6-SPM1 eDP panel which is running at asynchronous clock mode.
> With the other N value, Tcon will enter BITS mode and display black screen.
> Add this panel into quirk database and give particular N value when
> calculate M/N divider.
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Cooper Chiou <cooper.chiou@intel.com>
> Cc: Matt Atwood <matthew.s.atwood@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Cc: Clint Taylor <clinton.a.taylor@intel.com>
> Signed-off-by: Lee, Shawn C <shawn.c.lee@intel.com>

No access to the panel or its details, so instead of review,

Acked-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/drm_dp_helper.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index d0c1250975ab..0ef7c43a9025 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -1270,6 +1270,8 @@ struct dpcd_quirk {
>  static const struct dpcd_quirk dpcd_quirk_list[] = {
>  	/* Analogix 7737 needs reduced M and N at HBR2 link rates */
>  	{ OUI(0x00, 0x22, 0xb9), DEVICE_ID_ANY, true, BIT(DP_DPCD_QUIRK_CONSTANT_N) },
> +	/* LG LP140WF6-SPM1 eDP panel */
> +	{ OUI(0x00, 0x22, 0xb9), DEVICE_ID('s', 'i', 'v', 'a', 'r', 'T'), false, BIT(DP_DPCD_QUIRK_CONSTANT_N) },
>  };
>  
>  #undef OUI

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-09-10 11:43 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-10  8:30 [PATCH 0/3] add LG panel to dpcd quirk database Lee, Shawn C
2018-09-10  8:30 ` [PATCH 1/3] drm: Add support for device_id based detection Lee, Shawn C
2018-09-10 11:34   ` Jani Nikula
2018-09-10  8:30 ` [PATCH 2/3] drm: Change limited M/N quirk to constant N quirk Lee, Shawn C
2018-09-10 11:42   ` Jani Nikula
2018-09-10  8:30 ` [PATCH 3/3] drm: add LG eDP panel to quirk database Lee, Shawn C
2018-09-10 11:43   ` Jani Nikula [this message]
2018-09-12  0:34     ` Dhinakaran Pandiyan
2018-09-10 15:26 ` [PATCH v2 0/3] add LG panel to dpcd " Lee, Shawn C
2018-09-10 15:26   ` [PATCH v2 1/3] drm: Add support for device_id based detection Lee, Shawn C
2018-09-12  0:12     ` Dhinakaran Pandiyan
2018-09-12  5:37       ` Lee, Shawn C
2018-09-10 15:26   ` [PATCH v2 2/3] drm: Change limited M/N quirk to constant N quirk Lee, Shawn C
2018-09-10 15:26   ` [PATCH v2 3/3] drm: add LG eDP panel to quirk database Lee, Shawn C
2018-09-10 21:48   ` [PATCH v2 0/3] add LG panel to dpcd " Alex Deucher
2018-09-11  2:52     ` Lee, Shawn C
2018-09-11  8:56 ` [PATCH v3 " Lee, Shawn C
2018-09-11  8:56   ` [PATCH v3 1/3] drm: Add support for device_id based detection Lee, Shawn C
2018-09-11  8:56   ` [PATCH v3 2/3] drm: Change limited M/N quirk to constant N quirk Lee, Shawn C
2018-09-11  8:56   ` [PATCH v3 3/3] drm: add LG eDP panel to quirk database Lee, Shawn C
2018-09-11 16:56   ` [PATCH v3 0/3] add LG panel to dpcd " Jani Nikula
2018-09-12  5:25     ` Lee, Shawn C
2018-09-11 23:19   ` Clint Taylor
2018-09-12  9:06     ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87in3d37e9.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=Lee@freedesktop.org \
    --cc=cooper.chiou@intel.com \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=shawn.c.lee@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox