* [PATCH] drm: DRM_WERROR should depend on DRM
@ 2024-03-26 17:31 Geert Uytterhoeven
2024-03-26 20:13 ` Jani Nikula
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2024-03-26 17:31 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter, Hamza Mahfooz, Jani Nikula,
Javier Martinez Canillas
Cc: dri-devel, linux-kernel, Geert Uytterhoeven
There is no point in asking the user about enforcing the DRM compiler
warning policy when configuring a kernel without DRM support.
Fixes: f89632a9e5fa6c47 ("drm: Add CONFIG_DRM_WERROR")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/gpu/drm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index f2bcf5504aa77679..2e1b23ccf30423a9 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -423,7 +423,7 @@ config DRM_PRIVACY_SCREEN
config DRM_WERROR
bool "Compile the drm subsystem with warnings as errors"
- depends on EXPERT
+ depends on DRM && EXPERT
default n
help
A kernel build should not cause any compiler warnings, and this
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm: DRM_WERROR should depend on DRM
2024-03-26 17:31 [PATCH] drm: DRM_WERROR should depend on DRM Geert Uytterhoeven
@ 2024-03-26 20:13 ` Jani Nikula
2024-03-28 11:11 ` Jani Nikula
0 siblings, 1 reply; 3+ messages in thread
From: Jani Nikula @ 2024-03-26 20:13 UTC (permalink / raw)
To: Geert Uytterhoeven, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter, Hamza Mahfooz,
Javier Martinez Canillas
Cc: dri-devel, linux-kernel, Geert Uytterhoeven
On Tue, 26 Mar 2024, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> There is no point in asking the user about enforcing the DRM compiler
> warning policy when configuring a kernel without DRM support.
>
> Fixes: f89632a9e5fa6c47 ("drm: Add CONFIG_DRM_WERROR")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
D'oh! My bad.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index f2bcf5504aa77679..2e1b23ccf30423a9 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -423,7 +423,7 @@ config DRM_PRIVACY_SCREEN
>
> config DRM_WERROR
> bool "Compile the drm subsystem with warnings as errors"
> - depends on EXPERT
> + depends on DRM && EXPERT
> default n
> help
> A kernel build should not cause any compiler warnings, and this
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm: DRM_WERROR should depend on DRM
2024-03-26 20:13 ` Jani Nikula
@ 2024-03-28 11:11 ` Jani Nikula
0 siblings, 0 replies; 3+ messages in thread
From: Jani Nikula @ 2024-03-28 11:11 UTC (permalink / raw)
To: Geert Uytterhoeven, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter, Hamza Mahfooz,
Javier Martinez Canillas
Cc: dri-devel, linux-kernel, Geert Uytterhoeven
On Tue, 26 Mar 2024, Jani Nikula <jani.nikula@intel.com> wrote:
> On Tue, 26 Mar 2024, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
>> There is no point in asking the user about enforcing the DRM compiler
>> warning policy when configuring a kernel without DRM support.
>>
>> Fixes: f89632a9e5fa6c47 ("drm: Add CONFIG_DRM_WERROR")
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> D'oh! My bad.
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
And pushed to drm-misc-next. Thanks for the patch!
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
>> index f2bcf5504aa77679..2e1b23ccf30423a9 100644
>> --- a/drivers/gpu/drm/Kconfig
>> +++ b/drivers/gpu/drm/Kconfig
>> @@ -423,7 +423,7 @@ config DRM_PRIVACY_SCREEN
>>
>> config DRM_WERROR
>> bool "Compile the drm subsystem with warnings as errors"
>> - depends on EXPERT
>> + depends on DRM && EXPERT
>> default n
>> help
>> A kernel build should not cause any compiler warnings, and this
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-28 11:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-26 17:31 [PATCH] drm: DRM_WERROR should depend on DRM Geert Uytterhoeven
2024-03-26 20:13 ` Jani Nikula
2024-03-28 11:11 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox