From: Jani Nikula <jani.nikula@intel.com>
To: dri-devel@lists.freedesktop.org
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>, Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Andrzej Hajda <andrzej.hajda@intel.com>
Subject: Re: [PATCH 1/2] drm/bridge: use drm_bridge_get_edid() instead of using ->get_edid directly
Date: Tue, 26 Sep 2023 12:56:17 +0300 [thread overview]
Message-ID: <87jzsdl0la.fsf@intel.com> (raw)
In-Reply-To: <20230914131450.2473061-1-jani.nikula@intel.com>
Ping?
On Thu, 14 Sep 2023, Jani Nikula <jani.nikula@intel.com> wrote:
> Make drm_bridge_get_edid() the one place to call the hook.
>
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Robert Foss <rfoss@kernel.org>
> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> Cc: Jonas Karlman <jonas@kwiboo.se>
> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/drm_bridge_connector.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_bridge_connector.c
> index 1da93d5a1f61..31baf1f5ff81 100644
> --- a/drivers/gpu/drm/drm_bridge_connector.c
> +++ b/drivers/gpu/drm/drm_bridge_connector.c
> @@ -238,7 +238,7 @@ static int drm_bridge_connector_get_modes_edid(struct drm_connector *connector,
> if (status != connector_status_connected)
> goto no_edid;
>
> - edid = bridge->funcs->get_edid(bridge, connector);
> + edid = drm_bridge_get_edid(bridge, connector);
> if (!drm_edid_is_valid(edid)) {
> kfree(edid);
> goto no_edid;
--
Jani Nikula, Intel
next prev parent reply other threads:[~2023-09-26 9:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 13:14 [PATCH 1/2] drm/bridge: use drm_bridge_get_edid() instead of using ->get_edid directly Jani Nikula
2023-09-14 13:14 ` [PATCH 2/2] drm/bridge: lt9611uxc: " Jani Nikula
2023-09-27 11:30 ` Laurent Pinchart
2023-09-27 14:09 ` Jani Nikula
2023-09-27 22:35 ` Laurent Pinchart
2023-09-29 11:27 ` Jani Nikula
2023-09-26 9:56 ` Jani Nikula [this message]
2023-09-26 10:19 ` [PATCH 1/2] drm/bridge: " Laurent Pinchart
2023-09-27 10:33 ` Jani Nikula
2023-09-27 11:31 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzsdl0la.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox