From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>, Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
dri-devel@lists.freedesktop.org,
Andrzej Hajda <andrzej.hajda@intel.com>
Subject: Re: [PATCH 2/2] drm/bridge: lt9611uxc: use drm_bridge_get_edid() instead of using ->get_edid directly
Date: Thu, 28 Sep 2023 01:35:10 +0300 [thread overview]
Message-ID: <20230927223510.GY5854@pendragon.ideasonboard.com> (raw)
In-Reply-To: <87lecrk8rw.fsf@intel.com>
On Wed, Sep 27, 2023 at 05:09:23PM +0300, Jani Nikula wrote:
> On Wed, 27 Sep 2023, Laurent Pinchart wrote:
> > On Thu, Sep 14, 2023 at 04:14:50PM +0300, Jani Nikula wrote:
> >> Make drm_bridge_get_edid() the one place to call the hook.
> >>
> >> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> >> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> >> Cc: Robert Foss <rfoss@kernel.org>
> >> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> >> Cc: Jonas Karlman <jonas@kwiboo.se>
> >> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >>
> >> ---
> >>
> >> UNTESTED
> >
> > I can't test this either, but it looks fine.
>
> Thanks. Are you okay with merging the two with review only?
The changes are trivial, if we can't get anyone to test them, then I'm
OK merging them.
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> >> ---
> >> drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> >> index 22c84d29c2bc..7835738a532e 100644
> >> --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> >> +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> >> @@ -296,7 +296,7 @@ static int lt9611uxc_connector_get_modes(struct drm_connector *connector)
> >> unsigned int count;
> >> struct edid *edid;
> >>
> >> - edid = lt9611uxc->bridge.funcs->get_edid(<9611uxc->bridge, connector);
> >> + edid = drm_bridge_get_edid(<9611uxc->bridge, connector);
> >> drm_connector_update_edid_property(connector, edid);
> >> count = drm_add_edid_modes(connector, edid);
> >> kfree(edid);
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2023-09-27 22:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 13:14 [PATCH 1/2] drm/bridge: use drm_bridge_get_edid() instead of using ->get_edid directly Jani Nikula
2023-09-14 13:14 ` [PATCH 2/2] drm/bridge: lt9611uxc: " Jani Nikula
2023-09-27 11:30 ` Laurent Pinchart
2023-09-27 14:09 ` Jani Nikula
2023-09-27 22:35 ` Laurent Pinchart [this message]
2023-09-29 11:27 ` Jani Nikula
2023-09-26 9:56 ` [PATCH 1/2] drm/bridge: " Jani Nikula
2023-09-26 10:19 ` Laurent Pinchart
2023-09-27 10:33 ` Jani Nikula
2023-09-27 11:31 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230927223510.GY5854@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox