* [PATCH] drm/i915/display/tc: Only WARN once for bogus tc port flag
@ 2020-12-09 21:16 Sean Paul
2020-12-09 23:56 ` Rodrigo Vivi
0 siblings, 1 reply; 3+ messages in thread
From: Sean Paul @ 2020-12-09 21:16 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Sean Paul, Rodrigo Vivi
From: Sean Paul <seanpaul@chromium.org>
No need to spam syslog/console when we can ignore/fix the flag.
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
drivers/gpu/drm/i915/display/intel_tc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/display/intel_tc.c
index 4346bc1a747a..27dc2dad6809 100644
--- a/drivers/gpu/drm/i915/display/intel_tc.c
+++ b/drivers/gpu/drm/i915/display/intel_tc.c
@@ -262,7 +262,7 @@ static u32 tc_port_live_status_mask(struct intel_digital_port *dig_port)
mask |= BIT(TC_PORT_LEGACY);
/* The sink can be connected only in a single mode. */
- if (!drm_WARN_ON(&i915->drm, hweight32(mask) > 1))
+ if (!drm_WARN_ON_ONCE(&i915->drm, hweight32(mask) > 1))
tc_port_fixup_legacy_flag(dig_port, mask);
return mask;
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915/display/tc: Only WARN once for bogus tc port flag
2020-12-09 21:16 [PATCH] drm/i915/display/tc: Only WARN once for bogus tc port flag Sean Paul
@ 2020-12-09 23:56 ` Rodrigo Vivi
2020-12-11 13:18 ` [Intel-gfx] " Jani Nikula
0 siblings, 1 reply; 3+ messages in thread
From: Rodrigo Vivi @ 2020-12-09 23:56 UTC (permalink / raw)
To: Sean Paul; +Cc: intel-gfx, Sean Paul, dri-devel
On Wed, Dec 09, 2020 at 04:16:36PM -0500, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
>
> No need to spam syslog/console when we can ignore/fix the flag.
besides that we are calling from multiple places anyway..
>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_tc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/display/intel_tc.c
> index 4346bc1a747a..27dc2dad6809 100644
> --- a/drivers/gpu/drm/i915/display/intel_tc.c
> +++ b/drivers/gpu/drm/i915/display/intel_tc.c
> @@ -262,7 +262,7 @@ static u32 tc_port_live_status_mask(struct intel_digital_port *dig_port)
> mask |= BIT(TC_PORT_LEGACY);
>
> /* The sink can be connected only in a single mode. */
> - if (!drm_WARN_ON(&i915->drm, hweight32(mask) > 1))
> + if (!drm_WARN_ON_ONCE(&i915->drm, hweight32(mask) > 1))
> tc_port_fixup_legacy_flag(dig_port, mask);
>
> return mask;
> --
> Sean Paul, Software Engineer, Google / Chromium OS
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display/tc: Only WARN once for bogus tc port flag
2020-12-09 23:56 ` Rodrigo Vivi
@ 2020-12-11 13:18 ` Jani Nikula
0 siblings, 0 replies; 3+ messages in thread
From: Jani Nikula @ 2020-12-11 13:18 UTC (permalink / raw)
To: Rodrigo Vivi, Sean Paul; +Cc: intel-gfx, Sean Paul, dri-devel
On Wed, 09 Dec 2020, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Wed, Dec 09, 2020 at 04:16:36PM -0500, Sean Paul wrote:
>> From: Sean Paul <seanpaul@chromium.org>
>>
>> No need to spam syslog/console when we can ignore/fix the flag.
>
> besides that we are calling from multiple places anyway..
>
>>
>> Signed-off-by: Sean Paul <seanpaul@chromium.org>
>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Thanks, pushed to din.
BR,
Jani.
>
>
>
>> ---
>> drivers/gpu/drm/i915/display/intel_tc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/display/intel_tc.c
>> index 4346bc1a747a..27dc2dad6809 100644
>> --- a/drivers/gpu/drm/i915/display/intel_tc.c
>> +++ b/drivers/gpu/drm/i915/display/intel_tc.c
>> @@ -262,7 +262,7 @@ static u32 tc_port_live_status_mask(struct intel_digital_port *dig_port)
>> mask |= BIT(TC_PORT_LEGACY);
>>
>> /* The sink can be connected only in a single mode. */
>> - if (!drm_WARN_ON(&i915->drm, hweight32(mask) > 1))
>> + if (!drm_WARN_ON_ONCE(&i915->drm, hweight32(mask) > 1))
>> tc_port_fixup_legacy_flag(dig_port, mask);
>>
>> return mask;
>> --
>> Sean Paul, Software Engineer, Google / Chromium OS
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-11 13:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-09 21:16 [PATCH] drm/i915/display/tc: Only WARN once for bogus tc port flag Sean Paul
2020-12-09 23:56 ` Rodrigo Vivi
2020-12-11 13:18 ` [Intel-gfx] " Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox