* [PATCH 1/4] drm/i915: Replace the unconditional clflush with drm_clflush_virt_range()
2021-10-14 9:09 [PATCH 0/4] drm/i915: Make the driver not oops on load on old machines Ville Syrjala
@ 2021-10-14 9:09 ` Ville Syrjala
2021-10-14 9:09 ` [PATCH 2/4] drm/i915: Convert unconditional clflush to drm_clflush_virt_range() Ville Syrjala
` (3 subsequent siblings)
4 siblings, 0 replies; 14+ messages in thread
From: Ville Syrjala @ 2021-10-14 9:09 UTC (permalink / raw)
To: intel-gfx; +Cc: dri-devel, stable, Chris Wilson, Mika Kuoppala
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Not all machines have clflush, so don't go assuming they do.
Not really sure why the clflush is even here since hwsp
is supposed to get snooped I thought.
Although in my case we're talking about a i830 machine where
render/blitter snooping is definitely busted. But it might
work for the hswp perhaps. Haven't really reverse engineered
that one fully.
Cc: stable@vger.kernel.org
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Fixes: b436a5f8b6c8 ("drm/i915/gt: Track all timelines created using the HWSP")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/gt/intel_ring_submission.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c
index 593524195707..586dca1731ce 100644
--- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c
+++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c
@@ -292,7 +292,7 @@ static void xcs_sanitize(struct intel_engine_cs *engine)
sanitize_hwsp(engine);
/* And scrub the dirty cachelines for the HWSP */
- clflush_cache_range(engine->status_page.addr, PAGE_SIZE);
+ drm_clflush_virt_range(engine->status_page.addr, PAGE_SIZE);
intel_engine_reset_pinned_contexts(engine);
}
--
2.32.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 2/4] drm/i915: Convert unconditional clflush to drm_clflush_virt_range()
2021-10-14 9:09 [PATCH 0/4] drm/i915: Make the driver not oops on load on old machines Ville Syrjala
2021-10-14 9:09 ` [PATCH 1/4] drm/i915: Replace the unconditional clflush with drm_clflush_virt_range() Ville Syrjala
@ 2021-10-14 9:09 ` Ville Syrjala
2021-10-14 9:09 ` [PATCH 3/4] drm/i915: Catch yet another unconditioal clflush Ville Syrjala
` (2 subsequent siblings)
4 siblings, 0 replies; 14+ messages in thread
From: Ville Syrjala @ 2021-10-14 9:09 UTC (permalink / raw)
To: intel-gfx; +Cc: dri-devel, stable, Maarten Lankhorst, Thomas Hellström
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
This one is apparently a "clflush for good measure", so bit more
justification (if you can call it that) than some of the others.
Convert to drm_clflush_virt_range() again so that machines without
clflush will survive the ordeal.
Cc: stable@vger.kernel.org
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Thomas Hellström <thomas.hellstrom@intel.com> #v1
Fixes: 12ca695d2c1e ("drm/i915: Do not share hwsp across contexts any more, v8.")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/gt/intel_timeline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_timeline.c b/drivers/gpu/drm/i915/gt/intel_timeline.c
index 1257f4f11e66..23d7328892ed 100644
--- a/drivers/gpu/drm/i915/gt/intel_timeline.c
+++ b/drivers/gpu/drm/i915/gt/intel_timeline.c
@@ -225,7 +225,7 @@ void intel_timeline_reset_seqno(const struct intel_timeline *tl)
memset(hwsp_seqno + 1, 0, TIMELINE_SEQNO_BYTES - sizeof(*hwsp_seqno));
WRITE_ONCE(*hwsp_seqno, tl->seqno);
- clflush(hwsp_seqno);
+ drm_clflush_virt_range(hwsp_seqno, TIMELINE_SEQNO_BYTES);
}
void intel_timeline_enter(struct intel_timeline *tl)
--
2.32.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 3/4] drm/i915: Catch yet another unconditioal clflush
2021-10-14 9:09 [PATCH 0/4] drm/i915: Make the driver not oops on load on old machines Ville Syrjala
2021-10-14 9:09 ` [PATCH 1/4] drm/i915: Replace the unconditional clflush with drm_clflush_virt_range() Ville Syrjala
2021-10-14 9:09 ` [PATCH 2/4] drm/i915: Convert unconditional clflush to drm_clflush_virt_range() Ville Syrjala
@ 2021-10-14 9:09 ` Ville Syrjala
2021-10-14 9:09 ` [PATCH 4/4] drm/i915: Fix oops on platforms w/o hpd support Ville Syrjala
2021-10-17 23:54 ` [PATCH 0/4] drm/i915: Make the driver not oops on load on old machines Dave Airlie
4 siblings, 0 replies; 14+ messages in thread
From: Ville Syrjala @ 2021-10-14 9:09 UTC (permalink / raw)
To: intel-gfx; +Cc: dri-devel, stable, Maarten Lankhorst, Thomas Hellström
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Replace the unconditional clflush() with drm_clflush_virt_range()
which does the wbinvd() fallback when clflush is not available.
This time no justification is given for the clflush in the
offending commit.
Cc: stable@vger.kernel.org
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Fixes: 2c8ab3339e39 ("drm/i915: Pin timeline map after first timeline pin, v4.")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/gt/intel_timeline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_timeline.c b/drivers/gpu/drm/i915/gt/intel_timeline.c
index 23d7328892ed..438bbc7b8147 100644
--- a/drivers/gpu/drm/i915/gt/intel_timeline.c
+++ b/drivers/gpu/drm/i915/gt/intel_timeline.c
@@ -64,7 +64,7 @@ intel_timeline_pin_map(struct intel_timeline *timeline)
timeline->hwsp_map = vaddr;
timeline->hwsp_seqno = memset(vaddr + ofs, 0, TIMELINE_SEQNO_BYTES);
- clflush(vaddr + ofs);
+ drm_clflush_virt_range(vaddr + ofs, TIMELINE_SEQNO_BYTES);
return 0;
}
--
2.32.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 4/4] drm/i915: Fix oops on platforms w/o hpd support
2021-10-14 9:09 [PATCH 0/4] drm/i915: Make the driver not oops on load on old machines Ville Syrjala
` (2 preceding siblings ...)
2021-10-14 9:09 ` [PATCH 3/4] drm/i915: Catch yet another unconditioal clflush Ville Syrjala
@ 2021-10-14 9:09 ` Ville Syrjala
2021-10-14 9:18 ` Jani Nikula
2021-10-17 23:54 ` [PATCH 0/4] drm/i915: Make the driver not oops on load on old machines Dave Airlie
4 siblings, 1 reply; 14+ messages in thread
From: Ville Syrjala @ 2021-10-14 9:09 UTC (permalink / raw)
To: intel-gfx; +Cc: dri-devel, Dave Airlie, Jani Nikula
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
We don't have hpd support on i8xx/i915 which means hotplug_funcs==NULL.
Let's not oops when loading the driver on one those machines.
Cc: Dave Airlie <airlied@redhat.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Fixes: cd030c7c11a4 ("drm/i915: constify hotplug function vtable.")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_hotplug.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hotplug.c b/drivers/gpu/drm/i915/display/intel_hotplug.c
index 3c1cec953b42..0e949a258a22 100644
--- a/drivers/gpu/drm/i915/display/intel_hotplug.c
+++ b/drivers/gpu/drm/i915/display/intel_hotplug.c
@@ -215,7 +215,8 @@ intel_hpd_irq_storm_switch_to_polling(struct drm_i915_private *dev_priv)
static void intel_hpd_irq_setup(struct drm_i915_private *i915)
{
- if (i915->display_irqs_enabled && i915->hotplug_funcs->hpd_irq_setup)
+ if (i915->display_irqs_enabled &&
+ i915->hotplug_funcs && i915->hotplug_funcs->hpd_irq_setup)
i915->hotplug_funcs->hpd_irq_setup(i915);
}
--
2.32.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 4/4] drm/i915: Fix oops on platforms w/o hpd support
2021-10-14 9:09 ` [PATCH 4/4] drm/i915: Fix oops on platforms w/o hpd support Ville Syrjala
@ 2021-10-14 9:18 ` Jani Nikula
2021-10-14 9:20 ` Jani Nikula
2021-10-14 9:29 ` Ville Syrjälä
0 siblings, 2 replies; 14+ messages in thread
From: Jani Nikula @ 2021-10-14 9:18 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx; +Cc: dri-devel, Dave Airlie
On Thu, 14 Oct 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We don't have hpd support on i8xx/i915 which means hotplug_funcs==NULL.
> Let's not oops when loading the driver on one those machines.
D'oh!
Lemme guess, CI just casually dropped the machines from the results
because they didn't boot?
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Fixes: cd030c7c11a4 ("drm/i915: constify hotplug function vtable.")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_hotplug.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hotplug.c b/drivers/gpu/drm/i915/display/intel_hotplug.c
> index 3c1cec953b42..0e949a258a22 100644
> --- a/drivers/gpu/drm/i915/display/intel_hotplug.c
> +++ b/drivers/gpu/drm/i915/display/intel_hotplug.c
> @@ -215,7 +215,8 @@ intel_hpd_irq_storm_switch_to_polling(struct drm_i915_private *dev_priv)
>
> static void intel_hpd_irq_setup(struct drm_i915_private *i915)
> {
> - if (i915->display_irqs_enabled && i915->hotplug_funcs->hpd_irq_setup)
> + if (i915->display_irqs_enabled &&
> + i915->hotplug_funcs && i915->hotplug_funcs->hpd_irq_setup)
> i915->hotplug_funcs->hpd_irq_setup(i915);
> }
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 4/4] drm/i915: Fix oops on platforms w/o hpd support
2021-10-14 9:18 ` Jani Nikula
@ 2021-10-14 9:20 ` Jani Nikula
2021-10-14 9:27 ` Ville Syrjälä
2021-10-14 9:29 ` Ville Syrjälä
1 sibling, 1 reply; 14+ messages in thread
From: Jani Nikula @ 2021-10-14 9:20 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx; +Cc: dri-devel, Dave Airlie
On Thu, 14 Oct 2021, Jani Nikula <jani.nikula@intel.com> wrote:
> On Thu, 14 Oct 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
>> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>
>> We don't have hpd support on i8xx/i915 which means hotplug_funcs==NULL.
>> Let's not oops when loading the driver on one those machines.
>
> D'oh!
>
> Lemme guess, CI just casually dropped the machines from the results
> because they didn't boot?
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
>>
>> Cc: Dave Airlie <airlied@redhat.com>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Fixes: cd030c7c11a4 ("drm/i915: constify hotplug function vtable.")
>> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_hotplug.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_hotplug.c b/drivers/gpu/drm/i915/display/intel_hotplug.c
>> index 3c1cec953b42..0e949a258a22 100644
>> --- a/drivers/gpu/drm/i915/display/intel_hotplug.c
>> +++ b/drivers/gpu/drm/i915/display/intel_hotplug.c
>> @@ -215,7 +215,8 @@ intel_hpd_irq_storm_switch_to_polling(struct drm_i915_private *dev_priv)
>>
>> static void intel_hpd_irq_setup(struct drm_i915_private *i915)
>> {
>> - if (i915->display_irqs_enabled && i915->hotplug_funcs->hpd_irq_setup)
>> + if (i915->display_irqs_enabled &&
>> + i915->hotplug_funcs && i915->hotplug_funcs->hpd_irq_setup)
Btw i915->hotplug_funcs->hpd_irq_setup is always set if
i915->hotplug_funcs is set, so that bit is a bit redundant.
Anyway, r-b stands either way you decide to go.
>> i915->hotplug_funcs->hpd_irq_setup(i915);
>> }
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 4/4] drm/i915: Fix oops on platforms w/o hpd support
2021-10-14 9:20 ` Jani Nikula
@ 2021-10-14 9:27 ` Ville Syrjälä
0 siblings, 0 replies; 14+ messages in thread
From: Ville Syrjälä @ 2021-10-14 9:27 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, dri-devel, Dave Airlie
On Thu, Oct 14, 2021 at 12:20:24PM +0300, Jani Nikula wrote:
> On Thu, 14 Oct 2021, Jani Nikula <jani.nikula@intel.com> wrote:
> > On Thu, 14 Oct 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> >> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >>
> >> We don't have hpd support on i8xx/i915 which means hotplug_funcs==NULL.
> >> Let's not oops when loading the driver on one those machines.
> >
> > D'oh!
> >
> > Lemme guess, CI just casually dropped the machines from the results
> > because they didn't boot?
> >
> > Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> >
> >>
> >> Cc: Dave Airlie <airlied@redhat.com>
> >> Cc: Jani Nikula <jani.nikula@intel.com>
> >> Fixes: cd030c7c11a4 ("drm/i915: constify hotplug function vtable.")
> >> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >> ---
> >> drivers/gpu/drm/i915/display/intel_hotplug.c | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/i915/display/intel_hotplug.c b/drivers/gpu/drm/i915/display/intel_hotplug.c
> >> index 3c1cec953b42..0e949a258a22 100644
> >> --- a/drivers/gpu/drm/i915/display/intel_hotplug.c
> >> +++ b/drivers/gpu/drm/i915/display/intel_hotplug.c
> >> @@ -215,7 +215,8 @@ intel_hpd_irq_storm_switch_to_polling(struct drm_i915_private *dev_priv)
> >>
> >> static void intel_hpd_irq_setup(struct drm_i915_private *i915)
> >> {
> >> - if (i915->display_irqs_enabled && i915->hotplug_funcs->hpd_irq_setup)
> >> + if (i915->display_irqs_enabled &&
> >> + i915->hotplug_funcs && i915->hotplug_funcs->hpd_irq_setup)
>
> Btw i915->hotplug_funcs->hpd_irq_setup is always set if
> i915->hotplug_funcs is set, so that bit is a bit redundant.
Right. I'll drop the drop the belt, leaving just the suspenders.
>
> Anyway, r-b stands either way you decide to go.
>
>
> >> i915->hotplug_funcs->hpd_irq_setup(i915);
> >> }
>
> --
> Jani Nikula, Intel Open Source Graphics Center
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 4/4] drm/i915: Fix oops on platforms w/o hpd support
2021-10-14 9:18 ` Jani Nikula
2021-10-14 9:20 ` Jani Nikula
@ 2021-10-14 9:29 ` Ville Syrjälä
2021-10-14 9:31 ` Sarvela, Tomi P
1 sibling, 1 reply; 14+ messages in thread
From: Ville Syrjälä @ 2021-10-14 9:29 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, dri-devel, Dave Airlie, Tomi Sarvela
On Thu, Oct 14, 2021 at 12:18:23PM +0300, Jani Nikula wrote:
> On Thu, 14 Oct 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > We don't have hpd support on i8xx/i915 which means hotplug_funcs==NULL.
> > Let's not oops when loading the driver on one those machines.
>
> D'oh!
>
> Lemme guess, CI just casually dropped the machines from the results
> because they didn't boot?
Dunno where the gdg has gone actually. Tomi?
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> >
> > Cc: Dave Airlie <airlied@redhat.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Fixes: cd030c7c11a4 ("drm/i915: constify hotplug function vtable.")
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_hotplug.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_hotplug.c b/drivers/gpu/drm/i915/display/intel_hotplug.c
> > index 3c1cec953b42..0e949a258a22 100644
> > --- a/drivers/gpu/drm/i915/display/intel_hotplug.c
> > +++ b/drivers/gpu/drm/i915/display/intel_hotplug.c
> > @@ -215,7 +215,8 @@ intel_hpd_irq_storm_switch_to_polling(struct drm_i915_private *dev_priv)
> >
> > static void intel_hpd_irq_setup(struct drm_i915_private *i915)
> > {
> > - if (i915->display_irqs_enabled && i915->hotplug_funcs->hpd_irq_setup)
> > + if (i915->display_irqs_enabled &&
> > + i915->hotplug_funcs && i915->hotplug_funcs->hpd_irq_setup)
> > i915->hotplug_funcs->hpd_irq_setup(i915);
> > }
>
> --
> Jani Nikula, Intel Open Source Graphics Center
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 14+ messages in thread* RE: [PATCH 4/4] drm/i915: Fix oops on platforms w/o hpd support
2021-10-14 9:29 ` Ville Syrjälä
@ 2021-10-14 9:31 ` Sarvela, Tomi P
2021-10-14 9:36 ` Ville Syrjälä
0 siblings, 1 reply; 14+ messages in thread
From: Sarvela, Tomi P @ 2021-10-14 9:31 UTC (permalink / raw)
To: Ville Syrjälä, Nikula, Jani
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Dave Airlie
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> On Thu, Oct 14, 2021 at 12:18:23PM +0300, Jani Nikula wrote:
> > On Thu, 14 Oct 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > We don't have hpd support on i8xx/i915 which means
> hotplug_funcs==NULL.
> > > Let's not oops when loading the driver on one those machines.
> >
> > D'oh!
> >
> > Lemme guess, CI just casually dropped the machines from the results
> > because they didn't boot?
>
> Dunno where the gdg has gone actually. Tomi?
Both GDGs are dead to old age (PSU / power delivery).
Tomi
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 4/4] drm/i915: Fix oops on platforms w/o hpd support
2021-10-14 9:31 ` Sarvela, Tomi P
@ 2021-10-14 9:36 ` Ville Syrjälä
2021-10-14 9:42 ` Sarvela, Tomi P
0 siblings, 1 reply; 14+ messages in thread
From: Ville Syrjälä @ 2021-10-14 9:36 UTC (permalink / raw)
To: Sarvela, Tomi P
Cc: Nikula, Jani, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, Dave Airlie
On Thu, Oct 14, 2021 at 09:31:40AM +0000, Sarvela, Tomi P wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > On Thu, Oct 14, 2021 at 12:18:23PM +0300, Jani Nikula wrote:
> > > On Thu, 14 Oct 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > >
> > > > We don't have hpd support on i8xx/i915 which means
> > hotplug_funcs==NULL.
> > > > Let's not oops when loading the driver on one those machines.
> > >
> > > D'oh!
> > >
> > > Lemme guess, CI just casually dropped the machines from the results
> > > because they didn't boot?
> >
> > Dunno where the gdg has gone actually. Tomi?
>
> Both GDGs are dead to old age (PSU / power delivery).
We don't have spare PSUs to throw at them? Or are the boards also
semi-dead due to rotted caps etc.?
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH 4/4] drm/i915: Fix oops on platforms w/o hpd support
2021-10-14 9:36 ` Ville Syrjälä
@ 2021-10-14 9:42 ` Sarvela, Tomi P
0 siblings, 0 replies; 14+ messages in thread
From: Sarvela, Tomi P @ 2021-10-14 9:42 UTC (permalink / raw)
To: Ville Syrjälä
Cc: Nikula, Jani, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, Dave Airlie
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> On Thu, Oct 14, 2021 at 09:31:40AM +0000, Sarvela, Tomi P wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > On Thu, Oct 14, 2021 at 12:18:23PM +0300, Jani Nikula wrote:
> > > > On Thu, 14 Oct 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > >
> > > > > We don't have hpd support on i8xx/i915 which means
> > > hotplug_funcs==NULL.
> > > > > Let's not oops when loading the driver on one those machines.
> > > >
> > > > D'oh!
> > > >
> > > > Lemme guess, CI just casually dropped the machines from the results
> > > > because they didn't boot?
> > >
> > > Dunno where the gdg has gone actually. Tomi?
> >
> > Both GDGs are dead to old age (PSU / power delivery).
>
> We don't have spare PSUs to throw at them? Or are the boards also
> semi-dead due to rotted caps etc.?
It could be MB caps, PSU caps, or PSU anything else. Nothing comes on
when power is turned on, no fans, no leds, nothing. Same issue on both
hosts. No surprises there, they're identical models. It could be CPU,
but IIRC I already tried changing that.
The PSU part is vendor-specific. Standard PSU maybe could be retrofitted,
but that'd need some dedicated time.
Tomi
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/4] drm/i915: Make the driver not oops on load on old machines
2021-10-14 9:09 [PATCH 0/4] drm/i915: Make the driver not oops on load on old machines Ville Syrjala
` (3 preceding siblings ...)
2021-10-14 9:09 ` [PATCH 4/4] drm/i915: Fix oops on platforms w/o hpd support Ville Syrjala
@ 2021-10-17 23:54 ` Dave Airlie
2021-10-19 9:08 ` Ville Syrjälä
4 siblings, 1 reply; 14+ messages in thread
From: Dave Airlie @ 2021-10-17 23:54 UTC (permalink / raw)
To: Ville Syrjala
Cc: Intel Graphics Development, dri-devel, Dave Airlie, Jani Nikula,
Maarten Lankhorst, Thomas Hellström, Chris Wilson,
Mika Kuoppala
On Thu, 14 Oct 2021 at 19:09, Ville Syrjala
<ville.syrjala@linux.intel.com> wrote:
>
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Fix a pile of regression on older machines which just oops the driver
> on load.
>
For all 4:
Reviewed-by: Dave Airlie <airlied@redhat.com>
though it would be nice if the clflushes has more justifications on
initial patch submission/review, maybe something for gt team to keep
an eye for patches coming out from internal.
Dave.
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 0/4] drm/i915: Make the driver not oops on load on old machines
2021-10-17 23:54 ` [PATCH 0/4] drm/i915: Make the driver not oops on load on old machines Dave Airlie
@ 2021-10-19 9:08 ` Ville Syrjälä
0 siblings, 0 replies; 14+ messages in thread
From: Ville Syrjälä @ 2021-10-19 9:08 UTC (permalink / raw)
To: Dave Airlie
Cc: Intel Graphics Development, dri-devel, Dave Airlie, Jani Nikula,
Maarten Lankhorst, Thomas Hellström, Chris Wilson,
Mika Kuoppala
On Mon, Oct 18, 2021 at 09:54:59AM +1000, Dave Airlie wrote:
> On Thu, 14 Oct 2021 at 19:09, Ville Syrjala
> <ville.syrjala@linux.intel.com> wrote:
> >
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Fix a pile of regression on older machines which just oops the driver
> > on load.
> >
>
> For all 4:
>
> Reviewed-by: Dave Airlie <airlied@redhat.com>
>
> though it would be nice if the clflushes has more justifications on
> initial patch submission/review, maybe something for gt team to keep
> an eye for patches coming out from internal.
Thanks. clflush fixes pushed to drm-intel-gt-next. The hpd fix
I pushed to drm-intel-next already earlier.
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 14+ messages in thread