Re: [PATCH] drm: Fix documentation generation for DP_DPCD_QUIRK_NO_PSR

Re: [PATCH] drm: Fix documentation generation for DP_DPCD_QUIRK_NO_PSR

[Dhinakaran Pandiyan]

On Wed, 2018-12-05 at 10:48 -0800, José Roberto de Souza wrote:
> The DP_DPCD_QUIRK_NO_PSR comment is missing colon causing this
> warning when generating kernel documentation.
> 
> ./include/drm/drm_dp_helper.h:1374: warning: Incorrect use of kernel-
> doc format:          * @DP_DPCD_QUIRK_NO_PSR
> 
Cc: dri-devel@lists.freedesktop.org
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Fixes: 7c5c641a930e (drm/i915: Disable PSR in Apple panels)
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  include/drm/drm_dp_helper.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/drm/drm_dp_helper.h
> b/include/drm/drm_dp_helper.h
> index 18cfde45b8ed..c223c87ef119 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -1370,7 +1370,7 @@ enum drm_dp_quirk {
>  	 */
>  	DP_DPCD_QUIRK_CONSTANT_N,
>  	/**
> -	 * @DP_DPCD_QUIRK_NO_PSR
> +	 * @DP_DPCD_QUIRK_NO_PSR:
>  	 *
>  	 * The device does not support PSR even if reports that it
> supports or
>  	 * driver still need to implement proper handling for such
> device.

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm: Fix documentation generation for DP_DPCD_QUIRK_NO_PSR

[Souza, Jose]

[-- Attachment #1.1: Type: text/plain, Size: 1378 bytes --]

On Wed, 2018-12-05 at 12:30 -0800, Dhinakaran Pandiyan wrote:
> On Wed, 2018-12-05 at 10:48 -0800, José Roberto de Souza wrote:
> > The DP_DPCD_QUIRK_NO_PSR comment is missing colon causing this
> > warning when generating kernel documentation.
> > 
> > ./include/drm/drm_dp_helper.h:1374: warning: Incorrect use of
> > kernel-
> > doc format:          * @DP_DPCD_QUIRK_NO_PSR
> > 
> Cc: dri-devel@lists.freedesktop.org
> Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>

Thanks for the review, merged.

> > Fixes: 7c5c641a930e (drm/i915: Disable PSR in Apple panels)
> > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> >  include/drm/drm_dp_helper.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/drm/drm_dp_helper.h
> > b/include/drm/drm_dp_helper.h
> > index 18cfde45b8ed..c223c87ef119 100644
> > --- a/include/drm/drm_dp_helper.h
> > +++ b/include/drm/drm_dp_helper.h
> > @@ -1370,7 +1370,7 @@ enum drm_dp_quirk {
> >  	 */
> >  	DP_DPCD_QUIRK_CONSTANT_N,
> >  	/**
> > -	 * @DP_DPCD_QUIRK_NO_PSR
> > +	 * @DP_DPCD_QUIRK_NO_PSR:
> >  	 *
> >  	 * The device does not support PSR even if reports that it
> > supports or
> >  	 * driver still need to implement proper handling for such
> > device.

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm: Fix documentation generation for DP_DPCD_QUIRK_NO_PSR

[Jani Nikula]

On Thu, 06 Dec 2018, "Souza, Jose" <jose.souza@intel.com> wrote:
> On Wed, 2018-12-05 at 12:30 -0800, Dhinakaran Pandiyan wrote:
>> On Wed, 2018-12-05 at 10:48 -0800, José Roberto de Souza wrote:
>> > The DP_DPCD_QUIRK_NO_PSR comment is missing colon causing this
>> > warning when generating kernel documentation.
>> > 
>> > ./include/drm/drm_dp_helper.h:1374: warning: Incorrect use of
>> > kernel-
>> > doc format:          * @DP_DPCD_QUIRK_NO_PSR
>> > 
>> Cc: dri-devel@lists.freedesktop.org
>> Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>
> Thanks for the review, merged.

This patch is not i915 specific, and should have been merged via
drm-misc intead of drm-intel.

dim will have told you this when you applied the patch to dinq:

---
The following files are outside of i915 maintenance scope:

include/drm/drm_dp_helper.h

Confirm you have appropriate Acked-by and Reviewed-by for above files.
---

As a reminder, you need specific acks to merge non-i915 changes through
drm-intel, and that's reserved for special cases.

Please pay more attention to the maintenance boundaries going forward.

Thanks,
Jani.

>
>> > Fixes: 7c5c641a930e (drm/i915: Disable PSR in Apple panels)
>> > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
>> > ---
>> >  include/drm/drm_dp_helper.h | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> > 
>> > diff --git a/include/drm/drm_dp_helper.h
>> > b/include/drm/drm_dp_helper.h
>> > index 18cfde45b8ed..c223c87ef119 100644
>> > --- a/include/drm/drm_dp_helper.h
>> > +++ b/include/drm/drm_dp_helper.h
>> > @@ -1370,7 +1370,7 @@ enum drm_dp_quirk {
>> >  	 */
>> >  	DP_DPCD_QUIRK_CONSTANT_N,
>> >  	/**
>> > -	 * @DP_DPCD_QUIRK_NO_PSR
>> > +	 * @DP_DPCD_QUIRK_NO_PSR:
>> >  	 *
>> >  	 * The device does not support PSR even if reports that it
>> > supports or
>> >  	 * driver still need to implement proper handling for such
>> > device.
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx