* [PATCH] drm/dp: DPCD register defines for link status within ESI field
@ 2017-09-14 1:03 Dhinakaran Pandiyan
2017-09-14 6:00 ` Jani Nikula
0 siblings, 1 reply; 5+ messages in thread
From: Dhinakaran Pandiyan @ 2017-09-14 1:03 UTC (permalink / raw)
To: dri-devel; +Cc: Jani Nikula, intel-gfx, Dhinakaran Pandiyan
Link status is available in the ESI field on devices with DPCD r1.2 or
higher. DP spec also says "An MST upstream device shall use this field
instead of the Link/Sink Device Status field registers, starting from DPCD
Address 00200h."
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
include/drm/drm_dp_helper.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 2c412a15cfa1..0bf15525cdd0 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -738,6 +738,11 @@
#define DP_RECEIVER_ALPM_STATUS 0x200b /* eDP 1.4 */
# define DP_ALPM_LOCK_TIMEOUT_ERROR (1 << 0)
+#define LANE0_1_STATUS_ESI 0x200c /* Same as status in 0x202 */
+#define LANE2_3_STATUS_ESI 0x200d /* Same as status in 0x203 */
+#define LANE_ALIGN_STATUS_UPDATED_ESI 0x200e /* Same as status in 0x204 */
+#define SINK_STATUS_ESI 0x200f /* Same as status in 0x205 */
+
#define DP_DPRX_FEATURE_ENUMERATION_LIST 0x2210 /* DP 1.3 */
# define DP_GTC_CAP (1 << 0) /* DP 1.3 */
# define DP_SST_SPLIT_SDP_CAP (1 << 1) /* DP 1.4 */
--
2.11.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/dp: DPCD register defines for link status within ESI field
2017-09-14 1:03 [PATCH] drm/dp: DPCD register defines for link status within ESI field Dhinakaran Pandiyan
@ 2017-09-14 6:00 ` Jani Nikula
2017-09-14 6:18 ` [PATCH] drm/dp: DPCD register defines for link Pandiyan, Dhinakaran
2017-09-14 6:21 ` [PATCH v2] drm/dp: DPCD register defines for link status within ESI field Dhinakaran Pandiyan
0 siblings, 2 replies; 5+ messages in thread
From: Jani Nikula @ 2017-09-14 6:00 UTC (permalink / raw)
To: dri-devel; +Cc: intel-gfx, Dhinakaran Pandiyan
On Wed, 13 Sep 2017, Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> wrote:
> Link status is available in the ESI field on devices with DPCD r1.2 or
> higher. DP spec also says "An MST upstream device shall use this field
> instead of the Link/Sink Device Status field registers, starting from DPCD
> Address 00200h."
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
> include/drm/drm_dp_helper.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 2c412a15cfa1..0bf15525cdd0 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -738,6 +738,11 @@
> #define DP_RECEIVER_ALPM_STATUS 0x200b /* eDP 1.4 */
> # define DP_ALPM_LOCK_TIMEOUT_ERROR (1 << 0)
>
> +#define LANE0_1_STATUS_ESI 0x200c /* Same as status in 0x202 */
> +#define LANE2_3_STATUS_ESI 0x200d /* Same as status in 0x203 */
> +#define LANE_ALIGN_STATUS_UPDATED_ESI 0x200e /* Same as status in 0x204 */
> +#define SINK_STATUS_ESI 0x200f /* Same as status in 0x205 */
With the macro names prefixed with DP_,
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> +
> #define DP_DPRX_FEATURE_ENUMERATION_LIST 0x2210 /* DP 1.3 */
> # define DP_GTC_CAP (1 << 0) /* DP 1.3 */
> # define DP_SST_SPLIT_SDP_CAP (1 << 1) /* DP 1.4 */
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/dp: DPCD register defines for link
2017-09-14 6:00 ` Jani Nikula
@ 2017-09-14 6:18 ` Pandiyan, Dhinakaran
2017-09-14 6:21 ` [PATCH v2] drm/dp: DPCD register defines for link status within ESI field Dhinakaran Pandiyan
1 sibling, 0 replies; 5+ messages in thread
From: Pandiyan, Dhinakaran @ 2017-09-14 6:18 UTC (permalink / raw)
To: Nikula, Jani
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
On Thu, 2017-09-14 at 09:00 +0300, Jani Nikula wrote:
> On Wed, 13 Sep 2017, Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> wrote:
> > Link status is available in the ESI field on devices with DPCD r1.2 or
> > higher. DP spec also says "An MST upstream device shall use this field
> > instead of the Link/Sink Device Status field registers, starting from DPCD
> > Address 00200h."
> >
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > ---
> > include/drm/drm_dp_helper.h | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> > index 2c412a15cfa1..0bf15525cdd0 100644
> > --- a/include/drm/drm_dp_helper.h
> > +++ b/include/drm/drm_dp_helper.h
> > @@ -738,6 +738,11 @@
> > #define DP_RECEIVER_ALPM_STATUS 0x200b /* eDP 1.4 */
> > # define DP_ALPM_LOCK_TIMEOUT_ERROR (1 << 0)
> >
> > +#define LANE0_1_STATUS_ESI 0x200c /* Same as status in 0x202 */
> > +#define LANE2_3_STATUS_ESI 0x200d /* Same as status in 0x203 */
> > +#define LANE_ALIGN_STATUS_UPDATED_ESI 0x200e /* Same as status in 0x204 */
> > +#define SINK_STATUS_ESI 0x200f /* Same as status in 0x205 */
>
> With the macro names prefixed with DP_,
>
I must be blind to have not seen that. Thanks!
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
>
> > +
> > #define DP_DPRX_FEATURE_ENUMERATION_LIST 0x2210 /* DP 1.3 */
> > # define DP_GTC_CAP (1 << 0) /* DP 1.3 */
> > # define DP_SST_SPLIT_SDP_CAP (1 << 1) /* DP 1.4 */
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] drm/dp: DPCD register defines for link status within ESI field
2017-09-14 6:00 ` Jani Nikula
2017-09-14 6:18 ` [PATCH] drm/dp: DPCD register defines for link Pandiyan, Dhinakaran
@ 2017-09-14 6:21 ` Dhinakaran Pandiyan
2017-09-18 7:54 ` Jani Nikula
1 sibling, 1 reply; 5+ messages in thread
From: Dhinakaran Pandiyan @ 2017-09-14 6:21 UTC (permalink / raw)
To: dri-devel; +Cc: Jani Nikula, intel-gfx, Dhinakaran Pandiyan
Link status is available in the ESI field on devices with DPCD r1.2 or
higher. DP spec also says "An MST upstream device shall use this field
instead of the Link/Sink Device Status field registers, starting from DPCD
Address 00200h."
v2: Prefixed DP_ (Jani)
Rewrote commment to stay within 80 cols.
Cc: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
include/drm/drm_dp_helper.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 2c412a15cfa1..11c39f15f1b3 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -738,6 +738,11 @@
#define DP_RECEIVER_ALPM_STATUS 0x200b /* eDP 1.4 */
# define DP_ALPM_LOCK_TIMEOUT_ERROR (1 << 0)
+#define DP_LANE0_1_STATUS_ESI 0x200c /* status same as 0x202 */
+#define DP_LANE2_3_STATUS_ESI 0x200d /* status same as 0x203 */
+#define DP_LANE_ALIGN_STATUS_UPDATED_ESI 0x200e /* status same as 0x204 */
+#define DP_SINK_STATUS_ESI 0x200f /* status same as 0x205 */
+
#define DP_DPRX_FEATURE_ENUMERATION_LIST 0x2210 /* DP 1.3 */
# define DP_GTC_CAP (1 << 0) /* DP 1.3 */
# define DP_SST_SPLIT_SDP_CAP (1 << 1) /* DP 1.4 */
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] drm/dp: DPCD register defines for link status within ESI field
2017-09-14 6:21 ` [PATCH v2] drm/dp: DPCD register defines for link status within ESI field Dhinakaran Pandiyan
@ 2017-09-18 7:54 ` Jani Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2017-09-18 7:54 UTC (permalink / raw)
To: dri-devel; +Cc: intel-gfx, Dhinakaran Pandiyan
On Wed, 13 Sep 2017, Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> wrote:
> Link status is available in the ESI field on devices with DPCD r1.2 or
> higher. DP spec also says "An MST upstream device shall use this field
> instead of the Link/Sink Device Status field registers, starting from DPCD
> Address 00200h."
>
> v2: Prefixed DP_ (Jani)
> Rewrote commment to stay within 80 cols.
> Cc: Jani Nikula <jani.nikula@intel.com>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Thanks, pushed to drm-misc-next.
BR,
Jani.
> ---
> include/drm/drm_dp_helper.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 2c412a15cfa1..11c39f15f1b3 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -738,6 +738,11 @@
> #define DP_RECEIVER_ALPM_STATUS 0x200b /* eDP 1.4 */
> # define DP_ALPM_LOCK_TIMEOUT_ERROR (1 << 0)
>
> +#define DP_LANE0_1_STATUS_ESI 0x200c /* status same as 0x202 */
> +#define DP_LANE2_3_STATUS_ESI 0x200d /* status same as 0x203 */
> +#define DP_LANE_ALIGN_STATUS_UPDATED_ESI 0x200e /* status same as 0x204 */
> +#define DP_SINK_STATUS_ESI 0x200f /* status same as 0x205 */
> +
> #define DP_DPRX_FEATURE_ENUMERATION_LIST 0x2210 /* DP 1.3 */
> # define DP_GTC_CAP (1 << 0) /* DP 1.3 */
> # define DP_SST_SPLIT_SDP_CAP (1 << 1) /* DP 1.4 */
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-09-18 7:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-14 1:03 [PATCH] drm/dp: DPCD register defines for link status within ESI field Dhinakaran Pandiyan
2017-09-14 6:00 ` Jani Nikula
2017-09-14 6:18 ` [PATCH] drm/dp: DPCD register defines for link Pandiyan, Dhinakaran
2017-09-14 6:21 ` [PATCH v2] drm/dp: DPCD register defines for link status within ESI field Dhinakaran Pandiyan
2017-09-18 7:54 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox