* [PATCH] drm/i915: Zap some empty lines
@ 2023-09-20 8:57 Tvrtko Ursulin
2023-09-20 9:08 ` [Intel-gfx] " Jani Nikula
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Tvrtko Ursulin @ 2023-09-20 8:57 UTC (permalink / raw)
To: Intel-gfx, dri-devel
Cc: Anusha Srivatsa, Dnyaneshwar Bhadane, Radhakrishna Sripada,
Tvrtko Ursulin
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Recent refactoring left an unsightly block of empty lines. Remove them.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
---
drivers/gpu/drm/i915/i915_drv.h | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 87ffc477c3b1..511eba3bbdba 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -646,13 +646,6 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
#define IS_TIGERLAKE_UY(i915) \
IS_SUBPLATFORM(i915, INTEL_TIGERLAKE, INTEL_SUBPLATFORM_UY)
-
-
-
-
-
-
-
#define IS_XEHPSDV_GRAPHICS_STEP(__i915, since, until) \
(IS_XEHPSDV(__i915) && IS_GRAPHICS_STEP(__i915, since, until))
--
2.39.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915: Zap some empty lines
2023-09-20 8:57 [PATCH] drm/i915: Zap some empty lines Tvrtko Ursulin
@ 2023-09-20 9:08 ` Jani Nikula
2023-09-20 10:31 ` Sripada, Radhakrishna
2023-09-25 14:14 ` [Intel-gfx] " Andi Shyti
2 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2023-09-20 9:08 UTC (permalink / raw)
To: Tvrtko Ursulin, Intel-gfx, dri-devel
On Wed, 20 Sep 2023, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Recent refactoring left an unsightly block of empty lines. Remove them.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
One of the harder patches I've reviewed this week.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 87ffc477c3b1..511eba3bbdba 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -646,13 +646,6 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
> #define IS_TIGERLAKE_UY(i915) \
> IS_SUBPLATFORM(i915, INTEL_TIGERLAKE, INTEL_SUBPLATFORM_UY)
>
> -
> -
> -
> -
> -
> -
> -
> #define IS_XEHPSDV_GRAPHICS_STEP(__i915, since, until) \
> (IS_XEHPSDV(__i915) && IS_GRAPHICS_STEP(__i915, since, until))
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] drm/i915: Zap some empty lines
2023-09-20 8:57 [PATCH] drm/i915: Zap some empty lines Tvrtko Ursulin
2023-09-20 9:08 ` [Intel-gfx] " Jani Nikula
@ 2023-09-20 10:31 ` Sripada, Radhakrishna
2023-09-25 14:14 ` [Intel-gfx] " Andi Shyti
2 siblings, 0 replies; 6+ messages in thread
From: Sripada, Radhakrishna @ 2023-09-20 10:31 UTC (permalink / raw)
To: Tvrtko Ursulin, Intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org
Cc: Srivatsa, Anusha, Bhadane, Dnyaneshwar, Ursulin, Tvrtko
> -----Original Message-----
> From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Tvrtko
> Ursulin
> Sent: Wednesday, September 20, 2023 2:27 PM
> To: Intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> Cc: Srivatsa, Anusha <anusha.srivatsa@intel.com>; Bhadane, Dnyaneshwar
> <dnyaneshwar.bhadane@intel.com>; Sripada, Radhakrishna
> <radhakrishna.sripada@intel.com>; Ursulin, Tvrtko <tvrtko.ursulin@intel.com>
> Subject: [PATCH] drm/i915: Zap some empty lines
>
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Recent refactoring left an unsightly block of empty lines. Remove them.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
LGTM,
Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 87ffc477c3b1..511eba3bbdba 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -646,13 +646,6 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
> #define IS_TIGERLAKE_UY(i915) \
> IS_SUBPLATFORM(i915, INTEL_TIGERLAKE, INTEL_SUBPLATFORM_UY)
>
> -
> -
> -
> -
> -
> -
> -
> #define IS_XEHPSDV_GRAPHICS_STEP(__i915, since, until) \
> (IS_XEHPSDV(__i915) && IS_GRAPHICS_STEP(__i915, since, until))
>
> --
> 2.39.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Zap some empty lines
2023-09-20 8:57 [PATCH] drm/i915: Zap some empty lines Tvrtko Ursulin
2023-09-20 9:08 ` [Intel-gfx] " Jani Nikula
2023-09-20 10:31 ` Sripada, Radhakrishna
@ 2023-09-25 14:14 ` Andi Shyti
2023-09-25 14:28 ` Tvrtko Ursulin
2 siblings, 1 reply; 6+ messages in thread
From: Andi Shyti @ 2023-09-25 14:14 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: Intel-gfx, dri-devel
Hi Tvrtko,
On Wed, Sep 20, 2023 at 09:57:15AM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Recent refactoring left an unsightly block of empty lines. Remove them.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
as this isn't merged yet:
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Andi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Zap some empty lines
2023-09-25 14:14 ` [Intel-gfx] " Andi Shyti
@ 2023-09-25 14:28 ` Tvrtko Ursulin
2023-09-25 14:58 ` Andi Shyti
0 siblings, 1 reply; 6+ messages in thread
From: Tvrtko Ursulin @ 2023-09-25 14:28 UTC (permalink / raw)
To: Andi Shyti; +Cc: Intel-gfx, dri-devel
On 25/09/2023 15:14, Andi Shyti wrote:
> Hi Tvrtko,
>
> On Wed, Sep 20, 2023 at 09:57:15AM +0100, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Recent refactoring left an unsightly block of empty lines. Remove them.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Cc: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
>> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
>
> as this isn't merged yet:
>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Thanks, I am catching up with things and this wasn't so important. If
you have a spare moment feel free to push it?
Regards,
Tvrtko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Zap some empty lines
2023-09-25 14:28 ` Tvrtko Ursulin
@ 2023-09-25 14:58 ` Andi Shyti
0 siblings, 0 replies; 6+ messages in thread
From: Andi Shyti @ 2023-09-25 14:58 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: Intel-gfx, dri-devel, Andi Shyti
Hi Tvrtko,
On Mon, Sep 25, 2023 at 03:28:27PM +0100, Tvrtko Ursulin wrote:
>
> On 25/09/2023 15:14, Andi Shyti wrote:
> > Hi Tvrtko,
> >
> > On Wed, Sep 20, 2023 at 09:57:15AM +0100, Tvrtko Ursulin wrote:
> > > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > >
> > > Recent refactoring left an unsightly block of empty lines. Remove them.
> > >
> > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > > Cc: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
> > > Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > > Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> >
> > as this isn't merged yet:
> >
> > Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
>
> Thanks, I am catching up with things and this wasn't so important. If you
> have a spare moment feel free to push it?
All right, pushed to drm-intel-next :)
Thanks,
Andi
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-09-25 14:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-20 8:57 [PATCH] drm/i915: Zap some empty lines Tvrtko Ursulin
2023-09-20 9:08 ` [Intel-gfx] " Jani Nikula
2023-09-20 10:31 ` Sripada, Radhakrishna
2023-09-25 14:14 ` [Intel-gfx] " Andi Shyti
2023-09-25 14:28 ` Tvrtko Ursulin
2023-09-25 14:58 ` Andi Shyti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox