From: Eric Anholt <eric@anholt.net>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>, airlied@linux.ie
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: pl111: constify amba_id
Date: Mon, 18 Sep 2017 10:28:25 -0700 [thread overview]
Message-ID: <87shfjsypy.fsf@anholt.net> (raw)
In-Reply-To: <86980e42a00d789655e390cd4ae9b1caeadf5ead.1503504813.git.arvind.yadav.cs@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 971 bytes --]
Arvind Yadav <arvind.yadav.cs@gmail.com> writes:
> amba_id are not supposed to change at runtime. All functions
> working with const amba_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/gpu/drm/pl111/pl111_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c
> index ac8771b..522875c 100644
> --- a/drivers/gpu/drm/pl111/pl111_drv.c
> +++ b/drivers/gpu/drm/pl111/pl111_drv.c
> @@ -243,7 +243,7 @@ static int pl111_amba_remove(struct amba_device *amba_dev)
> return 0;
> }
>
> -static struct amba_id pl111_id_table[] = {
> +static const struct amba_id pl111_id_table[] = {
> {
> .id = 0x00041111,
> .mask = 0x000fffff,
> --
> 2.7.4
Sorry about dropping your patch here -- Linus was working on a bigger
series for pl110 support that also happened to fix this.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2017-09-18 17:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <e3ea7773c305ca105b8564821028f91fb529087a.1503504813.git.arvind.yadav.cs@gmail.com>
2017-08-23 16:16 ` [PATCH] drm: pl111: constify amba_id Arvind Yadav
2017-09-18 17:28 ` Eric Anholt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shfjsypy.fsf@anholt.net \
--to=eric@anholt.net \
--cc=airlied@linux.ie \
--cc=arvind.yadav.cs@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox