* [PATCH] drm: pl111: constify amba_id
[not found] <e3ea7773c305ca105b8564821028f91fb529087a.1503504813.git.arvind.yadav.cs@gmail.com>
@ 2017-08-23 16:16 ` Arvind Yadav
2017-09-18 17:28 ` Eric Anholt
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-08-23 16:16 UTC (permalink / raw)
To: eric, airlied; +Cc: linux-kernel, dri-devel
amba_id are not supposed to change at runtime. All functions
working with const amba_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/gpu/drm/pl111/pl111_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c
index ac8771b..522875c 100644
--- a/drivers/gpu/drm/pl111/pl111_drv.c
+++ b/drivers/gpu/drm/pl111/pl111_drv.c
@@ -243,7 +243,7 @@ static int pl111_amba_remove(struct amba_device *amba_dev)
return 0;
}
-static struct amba_id pl111_id_table[] = {
+static const struct amba_id pl111_id_table[] = {
{
.id = 0x00041111,
.mask = 0x000fffff,
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: pl111: constify amba_id
2017-08-23 16:16 ` [PATCH] drm: pl111: constify amba_id Arvind Yadav
@ 2017-09-18 17:28 ` Eric Anholt
0 siblings, 0 replies; 2+ messages in thread
From: Eric Anholt @ 2017-09-18 17:28 UTC (permalink / raw)
To: Arvind Yadav, airlied; +Cc: linux-kernel, dri-devel
[-- Attachment #1: Type: text/plain, Size: 971 bytes --]
Arvind Yadav <arvind.yadav.cs@gmail.com> writes:
> amba_id are not supposed to change at runtime. All functions
> working with const amba_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/gpu/drm/pl111/pl111_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c
> index ac8771b..522875c 100644
> --- a/drivers/gpu/drm/pl111/pl111_drv.c
> +++ b/drivers/gpu/drm/pl111/pl111_drv.c
> @@ -243,7 +243,7 @@ static int pl111_amba_remove(struct amba_device *amba_dev)
> return 0;
> }
>
> -static struct amba_id pl111_id_table[] = {
> +static const struct amba_id pl111_id_table[] = {
> {
> .id = 0x00041111,
> .mask = 0x000fffff,
> --
> 2.7.4
Sorry about dropping your patch here -- Linus was working on a bigger
series for pl110 support that also happened to fix this.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-18 17:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <e3ea7773c305ca105b8564821028f91fb529087a.1503504813.git.arvind.yadav.cs@gmail.com>
2017-08-23 16:16 ` [PATCH] drm: pl111: constify amba_id Arvind Yadav
2017-09-18 17:28 ` Eric Anholt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox