From: Eric Anholt <eric@anholt.net>
Cc: dri-devel@lists.freedesktop.org,
Boris Brezillon <boris.brezillon@bootlin.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/2] drm/vc4: Set ->legacy_cursor_update to false when doing non-async updates
Date: Tue, 13 Nov 2018 13:18:35 -0800 [thread overview]
Message-ID: <87tvkkllqs.fsf@anholt.net> (raw)
In-Reply-To: <20181113094914.22353-2-boris.brezillon@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]
Boris Brezillon <boris.brezillon@bootlin.com> writes:
> drm_atomic_helper_setup_commit() auto-completes commit->flip_done when
> state->legacy_cursor_update is true, but we now for sure that we want
> a sync update when we call drm_atomic_helper_setup_commit() from
> vc4_atomic_commit().
>
> Explicitly set state->legacy_cursor_update to false to prevent this
> auto-completion.
Seems like a reasonable solution.
Reviewed-by: Eric Anholt <eric@anholt.net>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-11-13 21:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 9:49 [PATCH 1/2] drm/vc4: Fix NULL pointer dereference in the async update path Boris Brezillon
2018-11-13 9:49 ` [PATCH 2/2] drm/vc4: Set ->legacy_cursor_update to false when doing non-async updates Boris Brezillon
2018-11-13 21:18 ` Eric Anholt [this message]
2018-11-13 21:24 ` [PATCH 1/2] drm/vc4: Fix NULL pointer dereference in the async update path Eric Anholt
2018-11-13 22:18 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvkkllqs.fsf@anholt.net \
--to=eric@anholt.net \
--cc=boris.brezillon@bootlin.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox