From: Eric Anholt <eric@anholt.net>
To: Rob Herring <robh@kernel.org>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm: vc4: enable XBGR8888 and ABGR8888 pixel formats
Date: Thu, 07 Jul 2016 18:47:16 -0700 [thread overview]
Message-ID: <87twg07vff.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <87eg85x588.fsf@eliezer.anholt.net>
[-- Attachment #1.1: Type: text/plain, Size: 601 bytes --]
Eric Anholt <eric@anholt.net> writes:
> Rob Herring <robh@kernel.org> writes:
>
>> DRM_FORMAT_XBGR8888 and DRM_FORMAT_ABGR8888 are 2 of the native formats
>> used in Android, so enable them for VC4. There seems to be no logic behind
>> HVS_PIXEL_ORDER_xxxx naming, but HVS_PIXEL_ORDER_ARGB seems to work
>> correctly.
>
> Spent a little bit digging into how the pixel orderings work and didn't
> come up with an answer. I'll try to look into this one again later.
Never came up with a good answer, but it's rendering correctly in
modetest, so I've reviewed and applied it to drm-vc4-next.
Thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-07-08 1:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 21:19 [PATCH 1/2] drm: vc4: set permissions for ioctls Rob Herring
2016-06-09 21:19 ` [PATCH 2/2] drm: vc4: enable XBGR8888 and ABGR8888 pixel formats Rob Herring
2016-06-10 0:22 ` Eric Anholt
2016-07-08 1:47 ` Eric Anholt [this message]
2016-06-09 23:15 ` [PATCH 1/2] drm: vc4: set permissions for ioctls Emil Velikov
2016-06-09 23:42 ` Eric Anholt
2016-06-09 23:50 ` Emil Velikov
2016-06-10 20:08 ` Eric Anholt
2016-06-14 12:31 ` Emil Velikov
2016-06-14 15:53 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twg07vff.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox