From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Vinod Koul <vkoul@kernel.org>, Rob Clark <robdclark@gmail.com>
Cc: Kalyan Thota <quic_kalyant@quicinc.com>,
freedreno@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
linux-arm-msm@vger.kernel.org,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
dri-devel@lists.freedesktop.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Stephen Boyd <swboyd@chromium.org>, Sean Paul <sean@poorly.run>,
Guenter Roeck <linux@roeck-us.net>,
Mark Yacoub <markyacoub@google.com>
Subject: Re: [PATCH 2/3] drm/msm/dpu: Update the comment style
Date: Thu, 10 Feb 2022 18:26:05 -0800 [thread overview]
Message-ID: <8eb63d37-fd3e-e9cc-5249-bc6ed8958cd8@quicinc.com> (raw)
In-Reply-To: <20220210114106.290669-2-vkoul@kernel.org>
On 2/10/2022 3:41 AM, Vinod Koul wrote:
> The multi line comment style is wrongly used as kernel-doc comment. This
> gives a warning:
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:17:
> warning: This comment starts with '/**', but isn't a kernel-doc comment.
> Refer Documentation/doc-guide/kernel-doc.rst
>
> Update the style to fix this.
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> index a77a5eaa78ad..9341c88a336f 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> @@ -13,7 +13,7 @@
> #include "dpu_hw_mdss.h"
> #include "dpu_trace.h"
>
> -/**
> +/*
> * Register offsets in MDSS register file for the interrupt registers
> * w.r.t. to the MDP base
> */
next prev parent reply other threads:[~2022-02-11 2:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 11:41 [PATCH 1/3] drm/msm/dpu: Remove set but unused variables Vinod Koul
2022-02-10 11:41 ` [PATCH 2/3] drm/msm/dpu: Update the comment style Vinod Koul
2022-02-11 1:58 ` Dmitry Baryshkov
2022-02-11 2:26 ` Abhinav Kumar [this message]
2022-02-10 11:41 ` [PATCH 3/3] drm/msm/dpu: Update function parameter documentation Vinod Koul
2022-02-11 1:58 ` Dmitry Baryshkov
2022-02-11 2:26 ` Abhinav Kumar
2022-02-11 1:58 ` [PATCH 1/3] drm/msm/dpu: Remove set but unused variables Dmitry Baryshkov
2022-02-11 2:24 ` [Freedreno] " Abhinav Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8eb63d37-fd3e-e9cc-5249-bc6ed8958cd8@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=markyacoub@google.com \
--cc=quic_kalyant@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox