dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Deborah Brouwer" <deborah.brouwer@collabora.com>
Cc: "Daniel Almeida" <daniel.almeida@collabora.com>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Benno Lossin" <lossin@kernel.org>, "Gary Guo" <gary@garyguo.net>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun@kernel.org>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Tamir Duberstein" <tamird@kernel.org>,
	"Alexandre Courbot" <acourbot@nvidia.com>,
	"Onur Özkan" <work@onurozkan.dev>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	rust-for-linux@vger.kernel.org, samitolvanen@google.com,
	lyude@redhat.com, boris.brezillon@collabora.com,
	steven.price@arm.com, alvin.sun@linux.dev,
	laura.nao@collabora.com, beata.michalska@arm.com
Subject: Re: [PATCH v9 1/7] drm/tyr: add resources to RegistrationData
Date: Tue, 28 Jul 2026 11:48:26 +0200	[thread overview]
Message-ID: <DKA3YRMZTRJS.3DOGR3ASR178J@kernel.org> (raw)
In-Reply-To: <20260722-fw-boot-b4-v9-1-8669d2a02590@collabora.com>

On Thu Jul 23, 2026 at 1:54 AM CEST, Deborah Brouwer wrote:
> @@ -53,13 +51,17 @@
>  
>  #[pin_data(PinnedDrop)]
>  pub(crate) struct TyrPlatformDriverData<'bound> {
> -    _device: ARef<TyrDrmDevice>,
>      _reg: drm::Registration<'bound, TyrDrmDriver>,
>  }
>  
> +/// Data owned by the DRM [`Registration`].
> +///
> +/// This data can have references tied to the parent platform device binding scope
> +/// and is accessible only while the DRM device is registered with userspace.
>  #[pin_data]
> -pub(crate) struct TyrDrmDeviceData {
> -    pub(crate) pdev: ARef<platform::Device>,
> +pub(crate) struct TyrDrmRegistrationData<'bound> {

Please use a different lifetime name for this, 'bound should only be used for
the bus device private data itself, as its lifetime defines this scope. Maybe
use 'drm instead?

The same is true for a couple of other places in this series, such as
Mmu<'bound>, VmAsData<'bound>, etc.

Please feel free to fix up on apply or in a follow-up patch.

  reply	other threads:[~2026-07-28  9:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22 23:54 [PATCH v9 0/7] drm/tyr: firmware loading and MCU boot support Deborah Brouwer
2026-07-22 23:54 ` [PATCH v9 1/7] drm/tyr: add resources to RegistrationData Deborah Brouwer
2026-07-28  9:48   ` Danilo Krummrich [this message]
2026-07-22 23:54 ` [PATCH v9 2/7] drm/tyr: add a generic slot manager Deborah Brouwer
2026-07-22 23:54 ` [PATCH v9 3/7] drm/tyr: add Memory Management Unit (MMU) support Deborah Brouwer
2026-07-22 23:54 ` [PATCH v9 4/7] drm/tyr: add GPU virtual memory (VM) support Deborah Brouwer
2026-07-23  0:17   ` sashiko-bot
2026-07-24 14:50     ` Daniel Almeida
2026-07-22 23:54 ` [PATCH v9 5/7] drm/tyr: add a kernel buffer object Deborah Brouwer
2026-07-22 23:54 ` [PATCH v9 6/7] drm/tyr: add parser for firmware binary Deborah Brouwer
2026-07-22 23:54 ` [PATCH v9 7/7] drm/tyr: add Microcontroller Unit (MCU) booting Deborah Brouwer
2026-07-24 15:03   ` Daniel Almeida
2026-07-24 15:01 ` [PATCH v9 0/7] drm/tyr: firmware loading and MCU boot support Daniel Almeida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DKA3YRMZTRJS.3DOGR3ASR178J@kernel.org \
    --to=dakr@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=alvin.sun@linux.dev \
    --cc=beata.michalska@arm.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=boris.brezillon@collabora.com \
    --cc=daniel.almeida@collabora.com \
    --cc=deborah.brouwer@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gary@garyguo.net \
    --cc=laura.nao@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=lyude@redhat.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=samitolvanen@google.com \
    --cc=simona@ffwll.ch \
    --cc=steven.price@arm.com \
    --cc=tamird@kernel.org \
    --cc=tmgross@umich.edu \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox