From: Russell King <rmk+kernel@arm.linux.org.uk>
To: linux-arm-kernel@lists.infradead.org,
Philipp Zabel <philipp.zabel@gmail.com>,
Rob Clark <robdclark@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Inki Dae <inki.dae@samsung.com>
Cc: devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org
Subject: [PATCH RFC v2 7/8] component: move check for unbound master into try_to_bring_up_masters()
Date: Tue, 24 Jun 2014 20:29:28 +0100 [thread overview]
Message-ID: <E1WzWPI-0007zt-He@rmk-PC.arm.linux.org.uk> (raw)
In-Reply-To: <20140624192830.GC20555@n2100.arm.linux.org.uk>
Clean up the code a little; we don't need to check that the master is
unbound for every invocation of try_to_bring_up_master(), so let's move
it to where it's really needed - try_to_bring_up_masters(), where we may
encounter already bound masters.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
drivers/base/component.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/base/component.c b/drivers/base/component.c
index c0a5b1abc931..0863cfeea769 100644
--- a/drivers/base/component.c
+++ b/drivers/base/component.c
@@ -150,13 +150,6 @@ static int try_to_bring_up_master(struct master *master,
{
int ret;
- if (master->bound)
- return 0;
-
- /*
- * Search the list of components, looking for components that
- * belong to this master, and attach them to the master.
- */
if (find_components(master)) {
/* Failed to find all components */
ret = 0;
@@ -196,9 +189,11 @@ static int try_to_bring_up_masters(struct component *component)
int ret = 0;
list_for_each_entry(m, &masters, node) {
- ret = try_to_bring_up_master(m, component);
- if (ret != 0)
- break;
+ if (!m->bound) {
+ ret = try_to_bring_up_master(m, component);
+ if (ret != 0)
+ break;
+ }
}
return ret;
--
1.8.3.1
next prev parent reply other threads:[~2014-06-24 19:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 19:28 [PATCH RFC v2 0/8] component helper improvements Russell King - ARM Linux
2014-06-24 19:28 ` [PATCH RFC v2 1/8] component: fix missed cleanup in case of devres failure Russell King
2014-06-24 19:29 ` [PATCH RFC v2 2/8] component: ignore multiple additions of the same component Russell King
2014-06-24 19:29 ` [PATCH RFC v2 3/8] component: add support for component match array Russell King
2014-06-26 12:34 ` Philipp Zabel
2014-06-26 14:46 ` Russell King - ARM Linux
2014-07-01 14:22 ` Russell King - ARM Linux
2014-07-02 15:26 ` Inki Dae
2014-07-02 16:15 ` Russell King - ARM Linux
2014-08-30 21:33 ` Russell King - ARM Linux
2014-09-01 2:47 ` Inki Dae
2014-06-24 19:29 ` [PATCH RFC v2 4/8] drm: msm: update to use component match support Russell King
2014-06-24 19:29 ` [PATCH RFC v2 5/8] imx-drm: " Russell King
2014-06-24 19:29 ` [PATCH RFC v2 6/8] component: remove old add_components method Russell King
2014-06-24 19:29 ` Russell King [this message]
2014-06-24 19:29 ` [PATCH RFC v2 8/8] component: track components via array rather than list Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1WzWPI-0007zt-He@rmk-PC.arm.linux.org.uk \
--to=rmk+kernel@arm.linux.org.uk \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=philipp.zabel@gmail.com \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox