Re: [PATCH RFC v2 3/8] component: add support for component match array

[Russell King - ARM Linux <linux@arm.linux.org.uk>]

On Thu, Jun 26, 2014 at 02:34:17PM +0200, Philipp Zabel wrote:
> Hi Russell,
> 
> On Tue, Jun 24, 2014 at 9:29 PM, Russell King
> <rmk+kernel@arm.linux.org.uk> wrote:
> [...]
> > +/*
> > + * Add a component to be matched.
> > + *
> > + * The match array is first created or extended if necessary.
> > + */
> > +void component_match_add(struct device *dev, struct component_match **matchptr,
> > +       int (*compare)(struct device *, void *), void *compare_data)
> > +{
> > +       struct component_match *match = *matchptr;
> > +
> > +       if (IS_ERR(match))
> > +               return;
> > +
> > +       if (!match || match->num == match->alloc) {
> > +               size_t new_size = match ? match->alloc + 16 : 15;
> > +
> > +               match = component_match_realloc(dev, match, new_size);
> > +
> > +               *matchptr = match;
> > +
> > +               if (IS_ERR(match))
> > +                       return;
> > +       }
> > +
> > +       match->compare[match->num].fn = compare;
> > +       match->compare[match->num].data = compare_data;
> > +       match->num++;
> > +}
> 
> component_match_add should be exported.

Fixed, thanks.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.