[PATCH 00/86] drm: Header file maintenance

[PATCH 00/86] drm: Header file maintenance

[Sam Ravnborg via B4 Submission Endpoint]

This patchset reduces the headers pulled in by other headers a little.
The end result is more specific dependencies and slightly faster build
times.
This ended up as a lot of patches - which makes it easier to do review
and handle future conflicts.

drm_print
- drm_print.h included a number of files that are not required by the
  header file. Push the nesessary includes to their users and clean up
  drm_print.h to the minimal set of include files.

drm_atomic_helper
- drm_atomic_helper.h included a number of files that are not required by the
  header file. Push the nesessary includes to their users and clean up
  drm_atomic_helper.h to the minimal set of include files.

For both the above changes this was a manual process involving bulding
and adding missing includes.
I have carefully maintained the sorting of the include files (but may
have failed in a few places).
I did not find any way to automate the process, so it was a tad boring.

No attempt was done to find redundant includes - I hope we can find some
tooling to help us one day.

On top of the above drm_utils was removed in a small series of two
patches. One function was moved to drm_util (as per suggestion from
Daniel in an old mail). Another prototype was moved to a more
appropriate place.

The diffstat add more lines than we delete, but the positive thing here
is that the individual files now pull in less files when building.

Sam

---
Sam Ravnborg (86):
      drm/komeda: Direct include headers from drm_print
      drm/bridge: ite-it6505: Direct include headers from drm_print
      drm/bridge: panel: Direct include headers from drm_print
      drm/msm: Direct include headers from drm_print
      drm/nouveau: Direct include headers from drm_print
      drm/omapdrm: Direct include headers from drm_print
      drm/radeon: Direct include headers from drm_print
      drm/ttm: Direct include headers from drm_print
      drm/scheduler: Direct include headers from drm_print
      drm/armada: Direct include headers from drm_print
      drm/sti: Direct include headers from drm_print
      drm/vc4: Direct include headers from drm_print
      drm/drm_print: Direct include headers from drm_print
      drm/vmwgfx: Direct include headers from drm_print
      drm/i915: Direct include headers from drm_print
      drm/drm_print: Minimize include footprint
      drm/xlnx: Direct include headers from drm_atomic_helper
      drm/amd: Direct include headers from drm_atomic_helper
      drm/komeda: Direct include headers from drm_atomic_helper
      drm/arm/hdlcd: Direct include headers from drm_atomic_helper
      drm/arm/malidp: Direct include headers from drm_atomic_helper
      drm/armada: Direct include headers from drm_atomic_helper
      drm/aspeed: Direct include headers from drm_atomic_helper
      drm/ast: Direct include headers from drm_atomic_helper
      drm/atmel-hlcdc: Direct include headers from drm_atomic_helper
      drm/bridge: adv7511: Direct include headers from drm_atomic_helper
      drm/bridge: analogix: Direct include headers from drm_atomic_helper
      drm/bridge: chipone: Direct include headers from drm_atomic_helper
      drm/bridge: chrontel: Direct include headers from drm_atomic_helper
      drm/bridge: display-connector: Direct include headers from drm_atomic_helper
      drm/bridge: fsl-ldb: Direct include headers from drm_atomic_helper
      drm/bridge: ite: Direct include headers from drm_atomic_helper
      drm/bridge: lontium: Direct include headers from drm_atomic_helper
      drm/bridge: lvds-codec: Direct include headers from drm_atomic_helper
      drm/bridge: megachips: Direct include headers from drm_atomic_helper
      drm/bridge: nxp: Direct include headers from drm_atomic_helper
      drm/bridge: panel: Direct include headers from drm_atomic_helper
      drm/bridge: sii902x: Direct include headers from drm_atomic_helper
      drm/bridge: simple-bridge: Direct include headers from drm_atomic_helper
      drm/bridge: synopsys: Direct include headers from drm_atomic_helper
      drm/bridge: tc358767: Direct include headers from drm_atomic_helper
      drm/bridge: ti: Direct include headers from drm_atomic_helper
      drm/display: Direct include headers from drm_atomic_helper
      drm: Direct include headers from drm_atomic_helper
      drm/exynos: Direct include headers from drm_atomic_helper
      drm/fsl-dcu: Direct include headers from drm_atomic_helper
      drm/gud: Direct include headers from drm_atomic_helper
      drm/hisilicon: Direct include headers from drm_atomic_helper
      drm/hyperv: Direct include headers from drm_atomic_helper
      drm/i2c: Direct include headers from drm_atomic_helper
      drm/i915: Direct include headers from drm_atomic_helper
      drm/imx: Direct include headers from drm_atomic_helper
      drm/ingenic: Direct include headers from drm_atomic_helper
      drm/kmb: Direct include headers from drm_atomic_helper
      drm/logicvc: Direct include headers from drm_atomic_helper
      drm/mcde: Direct include headers from drm_atomic_helper
      drm/mediatek: Direct include headers from drm_atomic_helper
      drm/meson: Direct include headers from drm_atomic_helper
      drm/mgag200: Direct include headers from drm_atomic_helper
      drm/msm: Direct include headers from drm_atomic_helper
      drm/mxsfb: Direct include headers from drm_atomic_helper
      drm/nouveau: Direct include headers from drm_atomic_helper
      drm/omapdrm: Direct include headers from drm_atomic_helper
      drm/qxl: Direct include headers from drm_atomic_helper
      drm/rcar-du: Direct include headers from drm_atomic_helper
      drm/rockchip: Direct include headers from drm_atomic_helper
      drm/solomon: Direct include headers from drm_atomic_helper
      drm/sprd: Direct include headers from drm_atomic_helper
      drm/sti: Direct include headers from drm_atomic_helper
      drm/stm: Direct include headers from drm_atomic_helper
      drm/sun4i: Direct include headers from drm_atomic_helper
      drm/tegra: Direct include headers from drm_atomic_helper
      drm/tests: Direct include headers from drm_atomic_helper
      drm/tidss: Direct include headers from drm_atomic_helper
      drm/tilcdc: Direct include headers from drm_atomic_helper
      drm/tiny: Direct include headers from drm_atomic_helper
      drm/udl: Direct include headers from drm_atomic_helper
      drm/vboxvideo: Direct include headers from drm_atomic_helper
      drm/vc4: Direct include headers from drm_atomic_helper
      drm/virtio: Direct include headers from drm_atomic_helper
      drm/vkms: Direct include headers from drm_atomic_helper
      drm/vmwgfx: Direct include headers from drm_atomic_helper
      drm/xen: Direct include headers from drm_atomic_helper
      drm/drm_atomic_helper: Minimize include footprint
      drm: move drm_timeout_abs_to_jiffies to drm_util
      drm: Move drm_get_panel_orientation_quirk prototype to drm_panel

 drivers/accel/ivpu/ivpu_gem.c                      |  2 +-
 drivers/gpu/drm/Makefile                           |  1 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c           |  3 ++
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c  |  2 ++
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c |  2 ++
 .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c    |  2 ++
 .../drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c    |  2 ++
 .../gpu/drm/arm/display/komeda/d71/d71_component.c |  2 ++
 drivers/gpu/drm/arm/display/komeda/komeda_crtc.c   |  2 ++
 drivers/gpu/drm/arm/display/komeda/komeda_drv.c    |  1 +
 .../drm/arm/display/komeda/komeda_framebuffer.c    |  1 +
 drivers/gpu/drm/arm/display/komeda/komeda_kms.c    |  1 +
 .../gpu/drm/arm/display/komeda/komeda_pipeline.c   |  1 +
 drivers/gpu/drm/arm/display/komeda/komeda_plane.c  |  2 ++
 .../drm/arm/display/komeda/komeda_private_obj.c    |  3 ++
 .../drm/arm/display/komeda/komeda_wb_connector.c   |  2 ++
 drivers/gpu/drm/arm/hdlcd_crtc.c                   |  2 ++
 drivers/gpu/drm/arm/malidp_crtc.c                  |  2 ++
 drivers/gpu/drm/arm/malidp_drv.c                   |  1 +
 drivers/gpu/drm/arm/malidp_mw.c                    |  2 ++
 drivers/gpu/drm/arm/malidp_planes.c                |  2 ++
 drivers/gpu/drm/armada/armada_crtc.c               |  2 ++
 drivers/gpu/drm/armada/armada_debugfs.c            |  1 +
 drivers/gpu/drm/armada/armada_overlay.c            |  2 ++
 drivers/gpu/drm/armada/armada_plane.c              |  2 ++
 drivers/gpu/drm/aspeed/aspeed_gfx_out.c            |  2 ++
 drivers/gpu/drm/ast/ast_drv.c                      |  1 +
 drivers/gpu/drm/ast/ast_mode.c                     |  1 +
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c     |  1 +
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c    |  2 ++
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c       |  2 ++
 drivers/gpu/drm/bridge/analogix/analogix-anx6345.c |  2 ++
 drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c |  2 ++
 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c |  2 ++
 drivers/gpu/drm/bridge/analogix/anx7625.c          |  1 +
 drivers/gpu/drm/bridge/chipone-icn6211.c           |  1 +
 drivers/gpu/drm/bridge/chrontel-ch7033.c           |  2 ++
 drivers/gpu/drm/bridge/display-connector.c         |  1 +
 drivers/gpu/drm/bridge/fsl-ldb.c                   |  1 +
 drivers/gpu/drm/bridge/ite-it6505.c                |  3 ++
 drivers/gpu/drm/bridge/ite-it66121.c               |  1 +
 drivers/gpu/drm/bridge/lontium-lt8912b.c           |  2 ++
 drivers/gpu/drm/bridge/lontium-lt9211.c            |  1 +
 drivers/gpu/drm/bridge/lontium-lt9611.c            |  2 ++
 drivers/gpu/drm/bridge/lontium-lt9611uxc.c         |  2 ++
 drivers/gpu/drm/bridge/lvds-codec.c                |  1 +
 .../drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c   |  2 ++
 drivers/gpu/drm/bridge/nxp-ptn3460.c               |  2 ++
 drivers/gpu/drm/bridge/panel.c                     |  3 ++
 drivers/gpu/drm/bridge/sii902x.c                   |  2 ++
 drivers/gpu/drm/bridge/simple-bridge.c             |  2 ++
 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c          |  2 ++
 drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c      |  1 +
 drivers/gpu/drm/bridge/tc358767.c                  |  2 ++
 drivers/gpu/drm/bridge/ti-dlpc3433.c               |  1 +
 drivers/gpu/drm/bridge/ti-sn65dsi83.c              |  1 +
 drivers/gpu/drm/bridge/ti-sn65dsi86.c              |  1 +
 drivers/gpu/drm/bridge/ti-tfp410.c                 |  2 ++
 drivers/gpu/drm/display/drm_dp_mst_topology.c      |  1 +
 drivers/gpu/drm/drm_atomic_helper.c                |  1 +
 drivers/gpu/drm/drm_connector.c                    |  1 -
 drivers/gpu/drm/drm_crtc_helper.c                  |  1 +
 drivers/gpu/drm/drm_fb_dma_helper.c                |  1 +
 drivers/gpu/drm/drm_gem_framebuffer_helper.c       |  1 +
 drivers/gpu/drm/drm_mipi_dbi.c                     |  2 ++
 drivers/gpu/drm/drm_panel_orientation_quirks.c     |  2 +-
 drivers/gpu/drm/drm_print.c                        |  1 +
 drivers/gpu/drm/drm_simple_kms_helper.c            |  2 ++
 drivers/gpu/drm/drm_syncobj.c                      | 34 ------------------
 drivers/gpu/drm/drm_util.c                         | 40 ++++++++++++++++++++++
 drivers/gpu/drm/exynos/exynos_dp.c                 |  1 +
 drivers/gpu/drm/exynos/exynos_drm_crtc.c           |  2 ++
 drivers/gpu/drm/exynos/exynos_drm_dpi.c            |  2 ++
 drivers/gpu/drm/exynos/exynos_drm_drv.c            |  4 +++
 drivers/gpu/drm/exynos/exynos_drm_dsi.c            |  1 +
 drivers/gpu/drm/exynos/exynos_drm_fb.c             |  2 ++
 drivers/gpu/drm/exynos/exynos_drm_plane.c          |  2 ++
 drivers/gpu/drm/exynos/exynos_drm_vidi.c           |  2 ++
 drivers/gpu/drm/exynos/exynos_hdmi.c               |  2 ++
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c         |  2 ++
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c        |  2 ++
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c          |  2 ++
 drivers/gpu/drm/gud/gud_drv.c                      |  1 +
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c     |  2 ++
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h    |  3 ++
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c   |  2 ++
 drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c       |  1 +
 drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c    |  2 ++
 drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c    |  1 +
 drivers/gpu/drm/hyperv/hyperv_drm_drv.c            |  1 +
 drivers/gpu/drm/hyperv/hyperv_drm_modeset.c        |  2 ++
 drivers/gpu/drm/i2c/tda998x_drv.c                  |  2 ++
 drivers/gpu/drm/i915/display/icl_dsi.c             |  2 ++
 drivers/gpu/drm/i915/display/intel_atomic.c        |  1 +
 drivers/gpu/drm/i915/display/intel_atomic_plane.c  |  2 ++
 drivers/gpu/drm/i915/display/intel_connector.c     |  1 +
 drivers/gpu/drm/i915/display/intel_crt.c           |  2 ++
 drivers/gpu/drm/i915/display/intel_crtc.c          |  1 +
 drivers/gpu/drm/i915/display/intel_display.c       |  3 ++
 drivers/gpu/drm/i915/display/intel_dmc.c           |  1 +
 drivers/gpu/drm/i915/display/intel_dp.c            |  2 ++
 drivers/gpu/drm/i915/display/intel_dp_mst.c        |  2 ++
 drivers/gpu/drm/i915/display/intel_dvo.c           |  2 ++
 drivers/gpu/drm/i915/display/intel_hdmi.c          |  2 ++
 drivers/gpu/drm/i915/display/intel_lvds.c          |  2 ++
 drivers/gpu/drm/i915/display/intel_sdvo.c          |  2 ++
 drivers/gpu/drm/i915/display/intel_tv.c            |  2 ++
 drivers/gpu/drm/i915/display/vlv_dsi.c             |  2 ++
 drivers/gpu/drm/i915/i915_debugfs.c                |  1 +
 drivers/gpu/drm/i915/i915_debugfs_params.c         |  1 +
 drivers/gpu/drm/i915/i915_params.c                 |  1 +
 drivers/gpu/drm/imx/dcss/dcss-crtc.c               |  2 ++
 drivers/gpu/drm/imx/dcss/dcss-kms.c                |  1 +
 drivers/gpu/drm/imx/dcss/dcss-plane.c              |  2 ++
 drivers/gpu/drm/imx/ipuv3/dw_hdmi-imx.c            |  1 +
 drivers/gpu/drm/imx/ipuv3/imx-drm-core.c           |  2 ++
 drivers/gpu/drm/imx/ipuv3/imx-ldb.c                |  2 ++
 drivers/gpu/drm/imx/ipuv3/imx-tve.c                |  2 ++
 drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c             |  3 ++
 drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c            |  2 ++
 drivers/gpu/drm/imx/ipuv3/parallel-display.c       |  2 ++
 drivers/gpu/drm/ingenic/ingenic-drm-drv.c          |  3 ++
 drivers/gpu/drm/ingenic/ingenic-ipu.c              |  2 ++
 drivers/gpu/drm/kmb/kmb_crtc.c                     |  1 +
 drivers/gpu/drm/kmb/kmb_drv.h                      |  1 +
 drivers/gpu/drm/kmb/kmb_plane.c                    |  2 ++
 drivers/gpu/drm/lima/lima_gem.c                    |  2 +-
 drivers/gpu/drm/logicvc/logicvc_crtc.c             |  2 ++
 drivers/gpu/drm/logicvc/logicvc_crtc.h             |  2 ++
 drivers/gpu/drm/logicvc/logicvc_interface.c        |  1 +
 drivers/gpu/drm/logicvc/logicvc_layer.c            |  2 ++
 drivers/gpu/drm/mcde/mcde_drv.c                    |  1 +
 drivers/gpu/drm/mediatek/mtk_dp.c                  |  1 +
 drivers/gpu/drm/mediatek/mtk_dpi.c                 |  1 +
 drivers/gpu/drm/mediatek/mtk_drm_crtc.c            |  2 ++
 drivers/gpu/drm/mediatek/mtk_drm_drv.c             |  2 ++
 drivers/gpu/drm/mediatek/mtk_drm_plane.c           |  3 ++
 drivers/gpu/drm/mediatek/mtk_dsi.c                 |  1 +
 drivers/gpu/drm/mediatek/mtk_hdmi.c                |  1 +
 drivers/gpu/drm/meson/meson_crtc.c                 |  3 ++
 drivers/gpu/drm/meson/meson_drv.c                  |  1 +
 drivers/gpu/drm/meson/meson_encoder_cvbs.c         |  1 +
 drivers/gpu/drm/meson/meson_encoder_hdmi.c         |  1 +
 drivers/gpu/drm/meson/meson_overlay.c              |  2 ++
 drivers/gpu/drm/meson/meson_plane.c                |  2 ++
 drivers/gpu/drm/mgag200/mgag200_g200.c             |  2 ++
 drivers/gpu/drm/mgag200/mgag200_g200eh.c           |  2 ++
 drivers/gpu/drm/mgag200/mgag200_g200eh3.c          |  2 ++
 drivers/gpu/drm/mgag200/mgag200_g200er.c           |  2 ++
 drivers/gpu/drm/mgag200/mgag200_g200ev.c           |  2 ++
 drivers/gpu/drm/mgag200/mgag200_g200ew3.c          |  2 ++
 drivers/gpu/drm/mgag200/mgag200_g200se.c           |  2 ++
 drivers/gpu/drm/mgag200/mgag200_g200wb.c           |  2 ++
 drivers/gpu/drm/mgag200/mgag200_mode.c             |  2 ++
 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c           |  2 ++
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c        |  1 +
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c        |  2 ++
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c            |  1 +
 drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c          |  2 ++
 drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c      |  2 ++
 drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c          |  2 ++
 drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c   |  1 +
 drivers/gpu/drm/msm/disp/mdp4/mdp4_dtv_encoder.c   |  2 ++
 drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c           |  1 +
 drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c  |  2 ++
 .../gpu/drm/msm/disp/mdp4/mdp4_lvds_connector.c    |  3 ++
 drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c         |  2 ++
 drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c          |  2 ++
 drivers/gpu/drm/msm/disp/mdp5/mdp5_encoder.c       |  1 +
 drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c           |  1 +
 drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.h           |  2 ++
 drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c         |  2 ++
 drivers/gpu/drm/msm/dp/dp_drm.c                    |  1 +
 drivers/gpu/drm/msm/msm_drv.c                      |  2 ++
 drivers/gpu/drm/msm/msm_fb.c                       |  1 +
 drivers/gpu/drm/mxsfb/lcdif_drv.c                  |  2 ++
 drivers/gpu/drm/mxsfb/lcdif_kms.c                  |  2 ++
 drivers/gpu/drm/mxsfb/mxsfb_drv.c                  |  2 ++
 drivers/gpu/drm/mxsfb/mxsfb_kms.c                  |  2 ++
 drivers/gpu/drm/nouveau/dispnv50/crc.c             |  2 ++
 drivers/gpu/drm/nouveau/dispnv50/disp.c            |  1 +
 drivers/gpu/drm/nouveau/dispnv50/head.c            |  2 ++
 drivers/gpu/drm/nouveau/dispnv50/wndw.c            |  2 ++
 drivers/gpu/drm/nouveau/nouveau_connector.c        |  2 ++
 drivers/gpu/drm/nouveau/nouveau_display.c          |  1 +
 drivers/gpu/drm/omapdrm/omap_crtc.c                |  2 ++
 drivers/gpu/drm/omapdrm/omap_drv.c                 |  3 ++
 drivers/gpu/drm/omapdrm/omap_fb.c                  |  1 +
 drivers/gpu/drm/omapdrm/omap_plane.c               |  2 ++
 drivers/gpu/drm/panfrost/panfrost_drv.c            |  2 +-
 drivers/gpu/drm/qxl/qxl_display.c                  |  2 ++
 drivers/gpu/drm/radeon/r100.c                      |  1 +
 drivers/gpu/drm/radeon/r300.c                      |  1 +
 drivers/gpu/drm/radeon/r420.c                      |  1 +
 drivers/gpu/drm/radeon/r600.c                      |  1 +
 drivers/gpu/drm/radeon/radeon_fence.c              |  1 +
 drivers/gpu/drm/radeon/radeon_gem.c                |  1 +
 drivers/gpu/drm/radeon/radeon_ib.c                 |  2 ++
 drivers/gpu/drm/radeon/radeon_pm.c                 |  1 +
 drivers/gpu/drm/radeon/radeon_ring.c               |  2 ++
 drivers/gpu/drm/radeon/radeon_ttm.c                |  1 +
 drivers/gpu/drm/radeon/rs400.c                     |  1 +
 drivers/gpu/drm/radeon/rv515.c                     |  1 +
 drivers/gpu/drm/rcar-du/rcar_du_crtc.c             |  2 ++
 drivers/gpu/drm/rcar-du/rcar_du_drv.c              |  1 +
 drivers/gpu/drm/rcar-du/rcar_du_kms.c              |  1 +
 drivers/gpu/drm/rcar-du/rcar_du_plane.c            |  2 ++
 drivers/gpu/drm/rcar-du/rcar_du_vsp.c              |  2 ++
 drivers/gpu/drm/rcar-du/rcar_du_writeback.c        |  2 ++
 drivers/gpu/drm/rcar-du/rcar_lvds.c                |  1 +
 drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c            |  1 +
 drivers/gpu/drm/rcar-du/rzg2l_mipi_dsi.c           |  1 +
 drivers/gpu/drm/rockchip/analogix_dp-rockchip.c    |  2 ++
 drivers/gpu/drm/rockchip/cdn-dp-core.c             |  2 ++
 drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c    |  1 +
 drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c        |  1 +
 drivers/gpu/drm/rockchip/inno_hdmi.c               |  2 ++
 drivers/gpu/drm/rockchip/rk3066_hdmi.c             |  2 ++
 drivers/gpu/drm/rockchip/rockchip_drm_drv.c        |  1 +
 drivers/gpu/drm/rockchip/rockchip_drm_drv.h        |  1 +
 drivers/gpu/drm/rockchip/rockchip_drm_fb.c         |  1 +
 drivers/gpu/drm/rockchip/rockchip_drm_vop.c        |  2 ++
 drivers/gpu/drm/rockchip/rockchip_drm_vop2.c       |  2 ++
 drivers/gpu/drm/rockchip/rockchip_lvds.c           |  2 ++
 drivers/gpu/drm/rockchip/rockchip_rgb.c            |  1 +
 drivers/gpu/drm/scheduler/sched_main.c             |  1 +
 drivers/gpu/drm/solomon/ssd130x.c                  |  2 ++
 drivers/gpu/drm/sprd/sprd_dpu.c                    |  2 ++
 drivers/gpu/drm/sprd/sprd_drm.c                    |  1 +
 drivers/gpu/drm/sprd/sprd_dsi.c                    |  1 +
 drivers/gpu/drm/sti/sti_crtc.c                     |  2 ++
 drivers/gpu/drm/sti/sti_cursor.c                   |  2 ++
 drivers/gpu/drm/sti/sti_drv.c                      |  1 +
 drivers/gpu/drm/sti/sti_dvo.c                      |  2 ++
 drivers/gpu/drm/sti/sti_gdp.c                      |  2 ++
 drivers/gpu/drm/sti/sti_hda.c                      |  2 ++
 drivers/gpu/drm/sti/sti_hdmi.c                     |  2 ++
 drivers/gpu/drm/sti/sti_hqvdp.c                    |  2 ++
 drivers/gpu/drm/sti/sti_tvout.c                    |  1 +
 drivers/gpu/drm/sti/sti_vid.c                      |  1 +
 drivers/gpu/drm/stm/ltdc.c                         |  2 ++
 drivers/gpu/drm/sun4i/sun4i_crtc.c                 |  2 ++
 drivers/gpu/drm/sun4i/sun4i_drv.c                  |  1 +
 drivers/gpu/drm/sun4i/sun4i_framebuffer.c          |  1 +
 drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c             |  2 ++
 drivers/gpu/drm/sun4i/sun4i_layer.c                |  2 ++
 drivers/gpu/drm/sun4i/sun4i_lvds.c                 |  2 ++
 drivers/gpu/drm/sun4i/sun4i_rgb.c                  |  2 ++
 drivers/gpu/drm/sun4i/sun4i_tv.c                   |  2 ++
 drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c             |  2 ++
 drivers/gpu/drm/sun4i/sun8i_ui_layer.c             |  2 ++
 drivers/gpu/drm/sun4i/sun8i_vi_layer.c             |  2 ++
 drivers/gpu/drm/tegra/dc.c                         |  2 ++
 drivers/gpu/drm/tegra/drm.c                        |  2 ++
 drivers/gpu/drm/tegra/dsi.c                        |  2 ++
 drivers/gpu/drm/tegra/hdmi.c                       |  2 ++
 drivers/gpu/drm/tegra/hub.c                        |  2 ++
 drivers/gpu/drm/tegra/plane.c                      |  1 +
 drivers/gpu/drm/tegra/rgb.c                        |  1 +
 drivers/gpu/drm/tegra/sor.c                        |  2 ++
 drivers/gpu/drm/tegra/uapi.c                       |  2 +-
 drivers/gpu/drm/tests/drm_plane_helper_test.c      |  1 +
 drivers/gpu/drm/tidss/tidss_crtc.c                 |  2 ++
 drivers/gpu/drm/tidss/tidss_drv.c                  |  1 +
 drivers/gpu/drm/tidss/tidss_kms.c                  |  1 +
 drivers/gpu/drm/tidss/tidss_plane.c                |  2 ++
 drivers/gpu/drm/tilcdc/tilcdc_crtc.c               |  1 +
 drivers/gpu/drm/tilcdc/tilcdc_drv.c                |  1 +
 drivers/gpu/drm/tilcdc/tilcdc_plane.c              |  2 ++
 drivers/gpu/drm/tiny/arcpgu.c                      |  2 ++
 drivers/gpu/drm/tiny/bochs.c                       |  3 ++
 drivers/gpu/drm/tiny/gm12u320.c                    |  1 +
 drivers/gpu/drm/tiny/repaper.c                     |  2 ++
 drivers/gpu/drm/ttm/ttm_device.c                   |  1 +
 drivers/gpu/drm/ttm/ttm_resource.c                 |  1 +
 drivers/gpu/drm/ttm/ttm_tt.c                       |  1 +
 drivers/gpu/drm/udl/udl_drv.c                      |  1 +
 drivers/gpu/drm/udl/udl_modeset.c                  |  1 +
 drivers/gpu/drm/vboxvideo/vbox_mode.c              |  2 ++
 drivers/gpu/drm/vc4/vc4_crtc.c                     |  2 ++
 drivers/gpu/drm/vc4/vc4_dpi.c                      |  1 +
 drivers/gpu/drm/vc4/vc4_drv.h                      |  1 +
 drivers/gpu/drm/vc4/vc4_dsi.c                      |  1 +
 drivers/gpu/drm/vc4/vc4_hdmi.c                     |  2 ++
 drivers/gpu/drm/vc4/vc4_kms.c                      |  2 ++
 drivers/gpu/drm/vc4/vc4_plane.c                    |  2 ++
 drivers/gpu/drm/vc4/vc4_txp.c                      |  2 ++
 drivers/gpu/drm/vc4/vc4_vec.c                      |  2 ++
 drivers/gpu/drm/virtio/virtgpu_display.c           |  3 ++
 drivers/gpu/drm/virtio/virtgpu_plane.c             |  2 ++
 drivers/gpu/drm/vkms/vkms_crtc.c                   |  2 ++
 drivers/gpu/drm/vkms/vkms_drv.c                    |  1 +
 drivers/gpu/drm/vkms/vkms_output.c                 |  2 ++
 drivers/gpu/drm/vkms/vkms_plane.c                  |  1 +
 drivers/gpu/drm/vkms/vkms_writeback.c              |  2 ++
 drivers/gpu/drm/vmwgfx/vmwgfx_gem.c                |  2 ++
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c                |  2 ++
 drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c                |  1 +
 drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c               |  1 +
 drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c               |  1 +
 drivers/gpu/drm/xen/xen_drm_front_conn.c           |  2 ++
 drivers/gpu/drm/xlnx/zynqmp_dp.c                   |  1 +
 drivers/gpu/drm/xlnx/zynqmp_kms.c                  |  2 ++
 drivers/video/fbdev/efifb.c                        |  2 +-
 include/drm/drm_atomic_helper.h                    | 21 ++++++++----
 include/drm/drm_panel.h                            |  1 +
 include/drm/drm_print.h                            | 11 +++---
 include/drm/drm_util.h                             |  1 +
 include/drm/drm_utils.h                            | 19 ----------
 309 files changed, 558 insertions(+), 73 deletions(-)
---
base-commit: 2e337a8d14bd4b04913d52ccf076be29d846acd7
change-id: 20230113-drm-include-v1-17dc8bdd5ada

Best regards,
-- 
Sam Ravnborg <sam@ravnborg.org>

[PATCH 01/86] drm/komeda: Direct include headers from drm_print

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_print.h, because drm_print.h will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/arm/display/komeda/d71/d71_component.c | 2 ++
 drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c   | 1 +
 2 files changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
index 42510fdea27e..875731a8ae90 100644
--- a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
+++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
@@ -4,6 +4,8 @@
  * Author: James.Qian.Wang <james.qian.wang@arm.com>
  *
  */
+#include <linux/seq_file.h>
+
 #include "d71_dev.h"
 #include "komeda_kms.h"
 #include "malidp_io.h"
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c
index 4b7d94961527..00f5864a0495 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c
@@ -5,6 +5,7 @@
  *
  */
 #include <linux/of.h>
+#include <linux/seq_file.h>
 
 #include <drm/drm_print.h>
 

-- 
2.34.1

Re: [PATCH 01/86] drm/komeda: Direct include headers from drm_print

[Thomas Zimmermann]

[-- Attachment #1.1: Type: text/plain, Size: 2038 bytes --]

Hi Sam

Am 21.01.23 um 21:07 schrieb Sam Ravnborg via B4 Submission Endpoint:
> From: Sam Ravnborg <sam@ravnborg.org>
> 
> Direct include the headers that otherwise comes indirect from

The grammar in this sentence is slightly off at 'direct include' and 
'headers that [...] comes'.  I'd write 'Directly include header files 
that currently come from drm_print.h.'  Fixes the adverb/adjective issue 
and is fairly neutral whether 'headers' refers to singular or plural.

Unfortunately that issue is in the first 83 patches. :(

Best regards
Thomas

> drm_print.h, because drm_print.h will be reduced to
> include only the minimal set of headers.
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> ---
>   drivers/gpu/drm/arm/display/komeda/d71/d71_component.c | 2 ++
>   drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c   | 1 +
>   2 files changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> index 42510fdea27e..875731a8ae90 100644
> --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> @@ -4,6 +4,8 @@
>    * Author: James.Qian.Wang <james.qian.wang@arm.com>
>    *
>    */
> +#include <linux/seq_file.h>
> +
>   #include "d71_dev.h"
>   #include "komeda_kms.h"
>   #include "malidp_io.h"
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c
> index 4b7d94961527..00f5864a0495 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c
> @@ -5,6 +5,7 @@
>    *
>    */
>   #include <linux/of.h>
> +#include <linux/seq_file.h>
>   
>   #include <drm/drm_print.h>
>   
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

[PATCH 02/86] drm/bridge: ite-it6505: Direct include headers from drm_print

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_print.h, because drm_print.h will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/bridge/ite-it6505.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
index bc451b2a77c2..ef42cd840958 100644
--- a/drivers/gpu/drm/bridge/ite-it6505.c
+++ b/drivers/gpu/drm/bridge/ite-it6505.c
@@ -3,6 +3,7 @@
  * Copyright (c) 2020, The Linux Foundation. All rights reserved.
  */
 #include <linux/bits.h>
+#include <linux/debugfs.h>
 #include <linux/delay.h>
 #include <linux/device.h>
 #include <linux/err.h>
@@ -16,6 +17,7 @@
 #include <linux/pm_runtime.h>
 #include <linux/regmap.h>
 #include <linux/regulator/consumer.h>
+#include <linux/seq_file.h>
 #include <linux/types.h>
 #include <linux/wait.h>
 

-- 
2.34.1

[PATCH 03/86] drm/bridge: panel: Direct include headers from drm_print

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_print.h, because drm_print.h will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/bridge/panel.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index e8aae3cdc73d..97c305978f9b 100644
--- a/drivers/gpu/drm/bridge/panel.c
+++ b/drivers/gpu/drm/bridge/panel.c
@@ -4,6 +4,8 @@
  * Copyright (C) 2017 Broadcom
  */
 
+#include <linux/debugfs.h>
+
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_connector.h>

-- 
2.34.1

[PATCH 04/86] drm/msm: Direct include headers from drm_print

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_print.h, because drm_print.h will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c
index 691c471b08c2..53e0933ccfcb 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c
@@ -2,6 +2,8 @@
 /* Copyright (c) 2015-2018, The Linux Foundation. All rights reserved.
  */
 
+#include <linux/debugfs.h>
+
 #include "dpu_hwio.h"
 #include "dpu_hw_catalog.h"
 #include "dpu_hw_lm.h"

-- 
2.34.1

[PATCH 05/86] drm/nouveau: Direct include headers from drm_print

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_print.h, because drm_print.h will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/nouveau/dispnv50/crc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/nouveau/dispnv50/crc.c b/drivers/gpu/drm/nouveau/dispnv50/crc.c
index 9c942fbd836d..5936b6b3b15d 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/crc.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/crc.c
@@ -1,5 +1,7 @@
 // SPDX-License-Identifier: MIT
+#include <linux/debugfs.h>
 #include <linux/string.h>
+
 #include <drm/drm_crtc.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_vblank.h>

-- 
2.34.1

[PATCH 06/86] drm/omapdrm: Direct include headers from drm_print

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_print.h, because drm_print.h will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/omapdrm/omap_fb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/omapdrm/omap_fb.c b/drivers/gpu/drm/omapdrm/omap_fb.c
index 1d414b33fee3..449d521c78fe 100644
--- a/drivers/gpu/drm/omapdrm/omap_fb.c
+++ b/drivers/gpu/drm/omapdrm/omap_fb.c
@@ -5,6 +5,7 @@
  */
 
 #include <linux/dma-mapping.h>
+#include <linux/seq_file.h>
 
 #include <drm/drm_blend.h>
 #include <drm/drm_modeset_helper.h>

-- 
2.34.1

[PATCH 07/86] drm/radeon: Direct include headers from drm_print

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_print.h, because drm_print.h will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/radeon/r100.c         | 1 +
 drivers/gpu/drm/radeon/r300.c         | 1 +
 drivers/gpu/drm/radeon/r420.c         | 1 +
 drivers/gpu/drm/radeon/r600.c         | 1 +
 drivers/gpu/drm/radeon/radeon_fence.c | 1 +
 drivers/gpu/drm/radeon/radeon_gem.c   | 1 +
 drivers/gpu/drm/radeon/radeon_ib.c    | 2 ++
 drivers/gpu/drm/radeon/radeon_pm.c    | 1 +
 drivers/gpu/drm/radeon/radeon_ring.c  | 2 ++
 drivers/gpu/drm/radeon/radeon_ttm.c   | 1 +
 drivers/gpu/drm/radeon/rs400.c        | 1 +
 drivers/gpu/drm/radeon/rv515.c        | 1 +
 12 files changed, 14 insertions(+)

diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c
index d4f09ecc3d22..32e0709f4e90 100644
--- a/drivers/gpu/drm/radeon/r100.c
+++ b/drivers/gpu/drm/radeon/r100.c
@@ -26,6 +26,7 @@
  *          Jerome Glisse
  */
 
+#include <linux/debugfs.h>
 #include <linux/firmware.h>
 #include <linux/module.h>
 #include <linux/pci.h>
diff --git a/drivers/gpu/drm/radeon/r300.c b/drivers/gpu/drm/radeon/r300.c
index 7b0cfeaddcec..79127b7053c1 100644
--- a/drivers/gpu/drm/radeon/r300.c
+++ b/drivers/gpu/drm/radeon/r300.c
@@ -26,6 +26,7 @@
  *          Jerome Glisse
  */
 
+#include <linux/debugfs.h>
 #include <linux/pci.h>
 #include <linux/seq_file.h>
 #include <linux/slab.h>
diff --git a/drivers/gpu/drm/radeon/r420.c b/drivers/gpu/drm/radeon/r420.c
index 7e6320e8c6a0..1305e4b372af 100644
--- a/drivers/gpu/drm/radeon/r420.c
+++ b/drivers/gpu/drm/radeon/r420.c
@@ -26,6 +26,7 @@
  *          Jerome Glisse
  */
 
+#include <linux/debugfs.h>
 #include <linux/pci.h>
 #include <linux/seq_file.h>
 #include <linux/slab.h>
diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c
index dd78fc499402..2dd2d4751168 100644
--- a/drivers/gpu/drm/radeon/r600.c
+++ b/drivers/gpu/drm/radeon/r600.c
@@ -26,6 +26,7 @@
  *          Jerome Glisse
  */
 
+#include <linux/debugfs.h>
 #include <linux/firmware.h>
 #include <linux/module.h>
 #include <linux/pci.h>
diff --git a/drivers/gpu/drm/radeon/radeon_fence.c b/drivers/gpu/drm/radeon/radeon_fence.c
index 73e3117420bf..6faf040197fa 100644
--- a/drivers/gpu/drm/radeon/radeon_fence.c
+++ b/drivers/gpu/drm/radeon/radeon_fence.c
@@ -30,6 +30,7 @@
  */
 
 #include <linux/atomic.h>
+#include <linux/debugfs.h>
 #include <linux/firmware.h>
 #include <linux/kref.h>
 #include <linux/sched/signal.h>
diff --git a/drivers/gpu/drm/radeon/radeon_gem.c b/drivers/gpu/drm/radeon/radeon_gem.c
index 261fcbae88d7..f6753c4bd655 100644
--- a/drivers/gpu/drm/radeon/radeon_gem.c
+++ b/drivers/gpu/drm/radeon/radeon_gem.c
@@ -26,6 +26,7 @@
  *          Jerome Glisse
  */
 
+#include <linux/debugfs.h>
 #include <linux/iosys-map.h>
 #include <linux/pci.h>
 
diff --git a/drivers/gpu/drm/radeon/radeon_ib.c b/drivers/gpu/drm/radeon/radeon_ib.c
index 62b116727b4f..8f080b375fdc 100644
--- a/drivers/gpu/drm/radeon/radeon_ib.c
+++ b/drivers/gpu/drm/radeon/radeon_ib.c
@@ -27,6 +27,8 @@
  *          Christian König
  */
 
+#include <linux/debugfs.h>
+
 #include <drm/drm_file.h>
 
 #include "radeon.h"
diff --git a/drivers/gpu/drm/radeon/radeon_pm.c b/drivers/gpu/drm/radeon/radeon_pm.c
index cbc554928bcc..d966c554d92c 100644
--- a/drivers/gpu/drm/radeon/radeon_pm.c
+++ b/drivers/gpu/drm/radeon/radeon_pm.c
@@ -21,6 +21,7 @@
  *          Alex Deucher <alexdeucher@gmail.com>
  */
 
+#include <linux/debugfs.h>
 #include <linux/hwmon-sysfs.h>
 #include <linux/hwmon.h>
 #include <linux/pci.h>
diff --git a/drivers/gpu/drm/radeon/radeon_ring.c b/drivers/gpu/drm/radeon/radeon_ring.c
index 7e207276df37..ca0a7b97ff66 100644
--- a/drivers/gpu/drm/radeon/radeon_ring.c
+++ b/drivers/gpu/drm/radeon/radeon_ring.c
@@ -27,6 +27,8 @@
  *          Christian König
  */
 
+#include <linux/debugfs.h>
+
 #include <drm/drm_device.h>
 #include <drm/drm_file.h>
 
diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
index 1e8e287e113c..7e26675c690b 100644
--- a/drivers/gpu/drm/radeon/radeon_ttm.c
+++ b/drivers/gpu/drm/radeon/radeon_ttm.c
@@ -30,6 +30,7 @@
  *    Dave Airlie
  */
 
+#include <linux/debugfs.h>
 #include <linux/dma-mapping.h>
 #include <linux/pagemap.h>
 #include <linux/pci.h>
diff --git a/drivers/gpu/drm/radeon/rs400.c b/drivers/gpu/drm/radeon/rs400.c
index 6383f7a34bd8..85d995f7cbef 100644
--- a/drivers/gpu/drm/radeon/rs400.c
+++ b/drivers/gpu/drm/radeon/rs400.c
@@ -26,6 +26,7 @@
  *          Jerome Glisse
  */
 
+#include <linux/debugfs.h>
 #include <linux/seq_file.h>
 #include <linux/slab.h>
 
diff --git a/drivers/gpu/drm/radeon/rv515.c b/drivers/gpu/drm/radeon/rv515.c
index 63fb06e8e2d7..565f1c2b5b68 100644
--- a/drivers/gpu/drm/radeon/rv515.c
+++ b/drivers/gpu/drm/radeon/rv515.c
@@ -26,6 +26,7 @@
  *          Jerome Glisse
  */
 
+#include <linux/debugfs.h>
 #include <linux/seq_file.h>
 #include <linux/slab.h>
 

-- 
2.34.1

[PATCH 08/86] drm/ttm: Direct include headers from drm_print

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_print.h, because drm_print.h will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/ttm/ttm_device.c   | 1 +
 drivers/gpu/drm/ttm/ttm_resource.c | 1 +
 drivers/gpu/drm/ttm/ttm_tt.c       | 1 +
 3 files changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/ttm_device.c
index c7a1862f322a..d2d838bb3d12 100644
--- a/drivers/gpu/drm/ttm/ttm_device.c
+++ b/drivers/gpu/drm/ttm/ttm_device.c
@@ -27,6 +27,7 @@
 
 #define pr_fmt(fmt) "[TTM DEVICE] " fmt
 
+#include <linux/debugfs.h>
 #include <linux/mm.h>
 
 #include <drm/ttm/ttm_bo.h>
diff --git a/drivers/gpu/drm/ttm/ttm_resource.c b/drivers/gpu/drm/ttm/ttm_resource.c
index b8a826a24fb2..40b452021649 100644
--- a/drivers/gpu/drm/ttm/ttm_resource.c
+++ b/drivers/gpu/drm/ttm/ttm_resource.c
@@ -22,6 +22,7 @@
  * Authors: Christian König
  */
 
+#include <linux/debugfs.h>
 #include <linux/iosys-map.h>
 #include <linux/io-mapping.h>
 #include <linux/scatterlist.h>
diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c
index ab725d9d14a6..df905445afd6 100644
--- a/drivers/gpu/drm/ttm/ttm_tt.c
+++ b/drivers/gpu/drm/ttm/ttm_tt.c
@@ -31,6 +31,7 @@
 
 #define pr_fmt(fmt) "[TTM] " fmt
 
+#include <linux/debugfs.h>
 #include <linux/sched.h>
 #include <linux/shmem_fs.h>
 #include <linux/file.h>

-- 
2.34.1

[PATCH 09/86] drm/scheduler: Direct include headers from drm_print

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_print.h, because drm_print.h will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/scheduler/sched_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
index 0e4378420271..964ea10bf68e 100644
--- a/drivers/gpu/drm/scheduler/sched_main.c
+++ b/drivers/gpu/drm/scheduler/sched_main.c
@@ -51,6 +51,7 @@
 #include <linux/dma-resv.h>
 #include <uapi/linux/sched/types.h>
 
+#include <drm/drm.h>
 #include <drm/drm_print.h>
 #include <drm/drm_gem.h>
 #include <drm/gpu_scheduler.h>

-- 
2.34.1

[PATCH 10/86] drm/armada: Direct include headers from drm_print

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_print.h, because drm_print.h will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/armada/armada_debugfs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/armada/armada_debugfs.c b/drivers/gpu/drm/armada/armada_debugfs.c
index 29f4b52e3c8d..a763349dd89f 100644
--- a/drivers/gpu/drm/armada/armada_debugfs.c
+++ b/drivers/gpu/drm/armada/armada_debugfs.c
@@ -5,6 +5,7 @@
  */
 
 #include <linux/ctype.h>
+#include <linux/debugfs.h>
 #include <linux/module.h>
 #include <linux/seq_file.h>
 #include <linux/uaccess.h>

-- 
2.34.1

[PATCH 11/86] drm/sti: Direct include headers from drm_print

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_print.h, because drm_print.h will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/sti/sti_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c
index ef6a4e63198f..b81fc05aee8d 100644
--- a/drivers/gpu/drm/sti/sti_drv.c
+++ b/drivers/gpu/drm/sti/sti_drv.c
@@ -5,6 +5,7 @@
  */
 
 #include <linux/component.h>
+#include <linux/debugfs.h>
 #include <linux/dma-mapping.h>
 #include <linux/kernel.h>
 #include <linux/module.h>

-- 
2.34.1

[PATCH 12/86] drm/vc4: Direct include headers from drm_print

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_print.h, because drm_print.h will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/vc4/vc4_drv.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h
index 95069bb16821..be2b3309c599 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.h
+++ b/drivers/gpu/drm/vc4/vc4_drv.h
@@ -5,6 +5,7 @@
 #ifndef _VC4_DRV_H_
 #define _VC4_DRV_H_
 
+#include <linux/debugfs.h>
 #include <linux/delay.h>
 #include <linux/of.h>
 #include <linux/refcount.h>

-- 
2.34.1

[PATCH 13/86] drm/drm_print: Direct include headers from drm_print

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_print.h, because drm_print.h will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/drm_print.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c
index 5b93c11895bb..c444fd9ea186 100644
--- a/drivers/gpu/drm/drm_print.c
+++ b/drivers/gpu/drm/drm_print.c
@@ -25,6 +25,7 @@
 
 #include <linux/stdarg.h>
 
+#include <linux/debugfs.h>
 #include <linux/io.h>
 #include <linux/moduleparam.h>
 #include <linux/seq_file.h>

-- 
2.34.1

[PATCH 14/86] drm/vmwgfx: Direct include headers from drm_print

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_print.h, because drm_print.h will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/vmwgfx/vmwgfx_gem.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
index ce609e7d758f..04b2dec75813 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
@@ -24,6 +24,8 @@
  *
  */
 
+#include <linux/debugfs.h>
+
 #include "vmwgfx_drv.h"
 
 #include "drm/drm_prime.h"

-- 
2.34.1

[PATCH 15/86] drm/i915: Direct include headers from drm_print

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_print.h, because drm_print.h will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/i915/display/intel_dmc.c   | 1 +
 drivers/gpu/drm/i915/i915_debugfs.c        | 1 +
 drivers/gpu/drm/i915/i915_debugfs_params.c | 1 +
 drivers/gpu/drm/i915/i915_params.c         | 1 +
 4 files changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
index 4124b3d37110..8e127c22c755 100644
--- a/drivers/gpu/drm/i915/display/intel_dmc.c
+++ b/drivers/gpu/drm/i915/display/intel_dmc.c
@@ -22,6 +22,7 @@
  *
  */
 
+#include <linux/debugfs.h>
 #include <linux/firmware.h>
 
 #include "i915_drv.h"
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 6c7ac73b69a5..415086050aa6 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -26,6 +26,7 @@
  *
  */
 
+#include <linux/debugfs.h>
 #include <linux/sched/mm.h>
 #include <linux/sort.h>
 #include <linux/string_helpers.h>
diff --git a/drivers/gpu/drm/i915/i915_debugfs_params.c b/drivers/gpu/drm/i915/i915_debugfs_params.c
index 783c8676eee2..72eee814f631 100644
--- a/drivers/gpu/drm/i915/i915_debugfs_params.c
+++ b/drivers/gpu/drm/i915/i915_debugfs_params.c
@@ -3,6 +3,7 @@
  * Copyright © 2019 Intel Corporation
  */
 
+#include <linux/debugfs.h>
 #include <linux/kernel.h>
 
 #include "i915_debugfs_params.h"
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index 5b24dd50fb6a..e0aed6fabe2a 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -22,6 +22,7 @@
  * IN THE SOFTWARE.
  */
 
+#include <linux/dynamic_debug.h>
 #include <linux/string_helpers.h>
 
 #include <drm/drm_print.h>

-- 
2.34.1

[PATCH 16/86] drm/drm_print: Minimize include footprint

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Reduce drm_print.h to include or forward the minimal set of
files/symbols - to minimize the impact of the files that includes this
header file.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 include/drm/drm_print.h | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
index c3753da97c4e..30673ee10190 100644
--- a/include/drm/drm_print.h
+++ b/include/drm/drm_print.h
@@ -26,14 +26,13 @@
 #ifndef DRM_PRINT_H_
 #define DRM_PRINT_H_
 
-#include <linux/compiler.h>
-#include <linux/printk.h>
-#include <linux/seq_file.h>
+#include <linux/dev_printk.h>
 #include <linux/device.h>
-#include <linux/debugfs.h>
-#include <linux/dynamic_debug.h>
+#include <linux/printk.h>
 
-#include <drm/drm.h>
+struct debugfs_regset32;
+struct seq_file;
+struct device;
 
 /* Do *not* use outside of drm_print.[ch]! */
 extern unsigned long __drm_debug;

-- 
2.34.1

Re: [PATCH 16/86] drm/drm_print: Minimize include footprint

[kernel test robot]

Hi Sam,

I love your patch! Yet something to improve:

[auto build test ERROR on 2e337a8d14bd4b04913d52ccf076be29d846acd7]

url:    https://github.com/intel-lab-lkp/linux/commits/Sam-Ravnborg-via-B4-Submission-Endpoint/drm-komeda-Direct-include-headers-from-drm_print/20230122-041306
base:   2e337a8d14bd4b04913d52ccf076be29d846acd7
patch link:    https://lore.kernel.org/r/20230113-drm-include-v1-v1-16-c5cf72d8a5a2%40ravnborg.org
patch subject: [PATCH 16/86] drm/drm_print: Minimize include footprint
config: i386-randconfig-a004 (https://download.01.org/0day-ci/archive/20230122/202301220750.HzZm1ZHu-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/530d852970d1a75527031a4f23689f89f0a85804
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Sam-Ravnborg-via-B4-Submission-Endpoint/drm-komeda-Direct-include-headers-from-drm_print/20230122-041306
        git checkout 530d852970d1a75527031a4f23689f89f0a85804
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/drm_mode_object.c:195:3: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                   DRM_DEBUG("OBJ ID: %d (%d)\n", obj->id, kref_read(&obj->refcount));
                   ^
   include/drm/drm_print.h:565:2: note: expanded from macro 'DRM_DEBUG'
           __drm_dbg(DRM_UT_CORE, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:526:2: note: expanded from macro '__drm_dbg'
           _dynamic_func_call_cls(cat, fmt, ___drm_dbg,                    \
           ^
   drivers/gpu/drm/drm_mode_object.c:212:3: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                   DRM_DEBUG("OBJ ID: %d (%d)\n", obj->id, kref_read(&obj->refcount));
                   ^
   include/drm/drm_print.h:565:2: note: expanded from macro 'DRM_DEBUG'
           __drm_dbg(DRM_UT_CORE, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:526:2: note: expanded from macro '__drm_dbg'
           _dynamic_func_call_cls(cat, fmt, ___drm_dbg,                    \
           ^
   2 errors generated.
--
>> drivers/gpu/drm/drm_plane.c:278:3: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                   DRM_DEBUG_KMS("out of memory when allocating plane\n");
                   ^
   include/drm/drm_print.h:573:2: note: expanded from macro 'DRM_DEBUG_KMS'
           __drm_dbg(DRM_UT_KMS, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:526:2: note: expanded from macro '__drm_dbg'
           _dynamic_func_call_cls(cat, fmt, ___drm_dbg,                    \
           ^
   drivers/gpu/drm/drm_plane.c:305:3: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                   DRM_DEBUG_KMS("out of memory when allocating plane\n");
                   ^
   include/drm/drm_print.h:573:2: note: expanded from macro 'DRM_DEBUG_KMS'
           __drm_dbg(DRM_UT_KMS, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:526:2: note: expanded from macro '__drm_dbg'
           _dynamic_func_call_cls(cat, fmt, ___drm_dbg,                    \
           ^
   drivers/gpu/drm/drm_plane.c:789:3: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                   DRM_DEBUG_KMS("Invalid crtc for plane\n");
                   ^
   include/drm/drm_print.h:573:2: note: expanded from macro 'DRM_DEBUG_KMS'
           __drm_dbg(DRM_UT_KMS, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:526:2: note: expanded from macro '__drm_dbg'
           _dynamic_func_call_cls(cat, fmt, ___drm_dbg,                    \
           ^
   drivers/gpu/drm/drm_plane.c:797:3: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                   DRM_DEBUG_KMS("Invalid pixel format %p4cc, modifier 0x%llx\n",
                   ^
   include/drm/drm_print.h:573:2: note: expanded from macro 'DRM_DEBUG_KMS'
           __drm_dbg(DRM_UT_KMS, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:526:2: note: expanded from macro '__drm_dbg'
           _dynamic_func_call_cls(cat, fmt, ___drm_dbg,                    \
           ^
   drivers/gpu/drm/drm_plane.c:807:3: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                   DRM_DEBUG_KMS("Invalid CRTC coordinates %ux%u+%d+%d\n",
                   ^
   include/drm/drm_print.h:573:2: note: expanded from macro 'DRM_DEBUG_KMS'
           __drm_dbg(DRM_UT_KMS, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:526:2: note: expanded from macro '__drm_dbg'
           _dynamic_func_call_cls(cat, fmt, ___drm_dbg,                    \
           ^
   drivers/gpu/drm/drm_plane.c:985:3: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                   DRM_DEBUG_KMS("Unknown plane ID %d\n",
                   ^
   include/drm/drm_print.h:573:2: note: expanded from macro 'DRM_DEBUG_KMS'
           __drm_dbg(DRM_UT_KMS, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:526:2: note: expanded from macro '__drm_dbg'
           _dynamic_func_call_cls(cat, fmt, ___drm_dbg,                    \
           ^
   drivers/gpu/drm/drm_plane.c:993:4: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                           DRM_DEBUG_KMS("Unknown framebuffer ID %d\n",
                           ^
   include/drm/drm_print.h:573:2: note: expanded from macro 'DRM_DEBUG_KMS'
           __drm_dbg(DRM_UT_KMS, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:526:2: note: expanded from macro '__drm_dbg'
           _dynamic_func_call_cls(cat, fmt, ___drm_dbg,                    \
           ^
   drivers/gpu/drm/drm_plane.c:1001:4: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                           DRM_DEBUG_KMS("Unknown crtc ID %d\n",
                           ^
   include/drm/drm_print.h:573:2: note: expanded from macro 'DRM_DEBUG_KMS'
           __drm_dbg(DRM_UT_KMS, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:526:2: note: expanded from macro '__drm_dbg'
           _dynamic_func_call_cls(cat, fmt, ___drm_dbg,                    \
           ^
   drivers/gpu/drm/drm_plane.c:1051:5: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                                   DRM_DEBUG_KMS("failed to wrap cursor buffer in drm framebuffer\n");
                                   ^
   include/drm/drm_print.h:573:2: note: expanded from macro 'DRM_DEBUG_KMS'
           __drm_dbg(DRM_UT_KMS, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:526:2: note: expanded from macro '__drm_dbg'
           _dynamic_func_call_cls(cat, fmt, ___drm_dbg,                    \
           ^
   drivers/gpu/drm/drm_plane.c:1122:3: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                   DRM_DEBUG_KMS("Unknown CRTC ID %d\n", req->crtc_id);
                   ^
   include/drm/drm_print.h:573:2: note: expanded from macro 'DRM_DEBUG_KMS'
           __drm_dbg(DRM_UT_KMS, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:526:2: note: expanded from macro '__drm_dbg'
           _dynamic_func_call_cls(cat, fmt, ___drm_dbg,                    \
           ^
   drivers/gpu/drm/drm_plane.c:1263:5: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                                   DRM_DEBUG("Invalid absolute flip target %u, "
                                   ^
   include/drm/drm_print.h:565:2: note: expanded from macro 'DRM_DEBUG'
           __drm_dbg(DRM_UT_CORE, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:526:2: note: expanded from macro '__drm_dbg'
           _dynamic_func_call_cls(cat, fmt, ___drm_dbg,                    \
           ^
   drivers/gpu/drm/drm_plane.c:1272:5: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                                   DRM_DEBUG("Invalid relative flip target %u, "
--
>> drivers/gpu/drm/drm_syncobj.c:301:3: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                   DRM_DEBUG("You are adding an unorder point to timeline!\n");
                   ^
   include/drm/drm_print.h:565:2: note: expanded from macro 'DRM_DEBUG'
           __drm_dbg(DRM_UT_CORE, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:526:2: note: expanded from macro '__drm_dbg'
           _dynamic_func_call_cls(cat, fmt, ___drm_dbg,                    \
           ^
   1 error generated.
--
>> drivers/gpu/drm/drm_vblank.c:318:3: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                   drm_dbg_vbl(dev, "crtc %u: Calculating number of vblanks."
                   ^
   include/drm/drm_print.h:499:2: note: expanded from macro 'drm_dbg_vbl'
           drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_VBL, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:412:2: note: expanded from macro 'drm_dev_dbg'
           _dynamic_func_call_cls(cat, fmt, __drm_dev_dbg,         \
           ^
   drivers/gpu/drm/drm_vblank.c:342:3: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                   drm_dbg_vbl(dev,
                   ^
   include/drm/drm_print.h:499:2: note: expanded from macro 'drm_dbg_vbl'
           drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_VBL, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:412:2: note: expanded from macro 'drm_dev_dbg'
           _dynamic_func_call_cls(cat, fmt, __drm_dev_dbg,         \
           ^
   drivers/gpu/drm/drm_vblank.c:348:2: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           drm_dbg_vbl(dev, "updating vblank count on crtc %u:"
           ^
   include/drm/drm_print.h:499:2: note: expanded from macro 'drm_dbg_vbl'
           drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_VBL, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:412:2: note: expanded from macro 'drm_dev_dbg'
           _dynamic_func_call_cls(cat, fmt, __drm_dev_dbg,         \
           ^
   drivers/gpu/drm/drm_vblank.c:494:3: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                   drm_dbg_core(dev, "disabling vblank on crtc %u\n", pipe);
                   ^
   include/drm/drm_print.h:489:2: note: expanded from macro 'drm_dbg_core'
           drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_CORE, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:412:2: note: expanded from macro 'drm_dev_dbg'
           _dynamic_func_call_cls(cat, fmt, __drm_dev_dbg,         \
           ^
   drivers/gpu/drm/drm_vblank.c:649:2: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           drm_dbg_core(dev,
           ^
   include/drm/drm_print.h:489:2: note: expanded from macro 'drm_dbg_core'
           drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_CORE, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:412:2: note: expanded from macro 'drm_dev_dbg'
           _dynamic_func_call_cls(cat, fmt, __drm_dev_dbg,         \
           ^
   drivers/gpu/drm/drm_vblank.c:726:3: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                   drm_dbg_core(dev, "crtc %u: Noop due to uninitialized mode.\n",
                   ^
   include/drm/drm_print.h:489:2: note: expanded from macro 'drm_dbg_core'
           drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_CORE, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:412:2: note: expanded from macro 'drm_dev_dbg'
           _dynamic_func_call_cls(cat, fmt, __drm_dev_dbg,         \
           ^
   drivers/gpu/drm/drm_vblank.c:751:4: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                           drm_dbg_core(dev,
                           ^
   include/drm/drm_print.h:489:2: note: expanded from macro 'drm_dbg_core'
           drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_CORE, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:412:2: note: expanded from macro 'drm_dev_dbg'
           _dynamic_func_call_cls(cat, fmt, __drm_dev_dbg,         \
           ^
   drivers/gpu/drm/drm_vblank.c:767:3: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                   drm_dbg_core(dev,
                   ^
   include/drm/drm_print.h:489:2: note: expanded from macro 'drm_dbg_core'
           drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_CORE, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:412:2: note: expanded from macro 'drm_dev_dbg'
           _dynamic_func_call_cls(cat, fmt, __drm_dev_dbg,         \
           ^
   drivers/gpu/drm/drm_vblank.c:793:2: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           drm_dbg_vbl(dev,
           ^
   include/drm/drm_print.h:499:2: note: expanded from macro 'drm_dbg_vbl'
           drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_VBL, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:412:2: note: expanded from macro 'drm_dev_dbg'
           _dynamic_func_call_cls(cat, fmt, __drm_dev_dbg,         \
           ^
   drivers/gpu/drm/drm_vblank.c:1140:3: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                   drm_dbg_core(dev, "enabling vblank on crtc %u, ret: %d\n",
                   ^
   include/drm/drm_print.h:489:2: note: expanded from macro 'drm_dbg_core'
           drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_CORE, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:412:2: note: expanded from macro 'drm_dev_dbg'
           _dynamic_func_call_cls(cat, fmt, __drm_dev_dbg,         \
           ^
   drivers/gpu/drm/drm_vblank.c:1319:2: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           drm_dbg_vbl(dev, "crtc %d, vblank enabled %d, inmodeset %d\n",
           ^
   include/drm/drm_print.h:499:2: note: expanded from macro 'drm_dbg_vbl'
           drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_VBL, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:412:2: note: expanded from macro 'drm_dev_dbg'
           _dynamic_func_call_cls(cat, fmt, __drm_dev_dbg,         \
           ^
   drivers/gpu/drm/drm_vblank.c:1452:2: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           drm_dbg_vbl(dev, "crtc %d, vblank enabled %d, inmodeset %d\n",
--
>> drivers/gpu/drm/drm_vblank_work.c:141:3: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                   drm_dbg_core(dev,
                   ^
   include/drm/drm_print.h:489:2: note: expanded from macro 'drm_dbg_core'
           drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_CORE, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:412:2: note: expanded from macro 'drm_dev_dbg'
           _dynamic_func_call_cls(cat, fmt, __drm_dev_dbg,         \
           ^
   1 error generated.
--
>> drivers/gpu/drm/drm_ioctl.c:443:2: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           drm_dbg_core(dev, "\n");
           ^
   include/drm/drm_print.h:489:2: note: expanded from macro 'drm_dbg_core'
           drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_CORE, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:412:2: note: expanded from macro 'drm_dev_dbg'
           _dynamic_func_call_cls(cat, fmt, __drm_dev_dbg,         \
           ^
   drivers/gpu/drm/drm_ioctl.c:859:2: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           drm_dbg_core(dev, "comm=\"%s\" pid=%d, dev=0x%lx, auth=%d, %s\n",
           ^
   include/drm/drm_print.h:489:2: note: expanded from macro 'drm_dbg_core'
           drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_CORE, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:412:2: note: expanded from macro 'drm_dev_dbg'
           _dynamic_func_call_cls(cat, fmt, __drm_dev_dbg,         \
           ^
   2 errors generated.
--
>> drivers/gpu/drm/drm_bufs.c:174:2: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           DRM_DEBUG("offset = 0x%08llx, size = 0x%08lx, type = %d\n",
           ^
   include/drm/drm_print.h:565:2: note: expanded from macro 'DRM_DEBUG'
           __drm_dbg(DRM_UT_CORE, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:526:2: note: expanded from macro '__drm_dbg'
           _dynamic_func_call_cls(cat, fmt, ___drm_dbg,                    \
           ^
   drivers/gpu/drm/drm_bufs.c:911:2: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           DRM_DEBUG("count=%d, size=%d (%d), order=%d\n",
           ^
   include/drm/drm_print.h:565:2: note: expanded from macro 'DRM_DEBUG'
           __drm_dbg(DRM_UT_CORE, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:526:2: note: expanded from macro '__drm_dbg'
           _dynamic_func_call_cls(cat, fmt, ___drm_dbg,                    \
           ^
   drivers/gpu/drm/drm_bufs.c:1139:2: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           DRM_DEBUG("count:      %d\n", count);
           ^
   include/drm/drm_print.h:565:2: note: expanded from macro 'DRM_DEBUG'
           __drm_dbg(DRM_UT_CORE, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:526:2: note: expanded from macro '__drm_dbg'
           _dynamic_func_call_cls(cat, fmt, ___drm_dbg,                    \
           ^
   drivers/gpu/drm/drm_bufs.c:1343:2: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           DRM_DEBUG("count = %d\n", count);
           ^
   include/drm/drm_print.h:565:2: note: expanded from macro 'DRM_DEBUG'
           __drm_dbg(DRM_UT_CORE, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:526:2: note: expanded from macro '__drm_dbg'
           _dynamic_func_call_cls(cat, fmt, ___drm_dbg,                    \
           ^
   drivers/gpu/drm/drm_bufs.c:1420:2: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           DRM_DEBUG("%d, %d, %d\n",
           ^
   include/drm/drm_print.h:565:2: note: expanded from macro 'DRM_DEBUG'
           __drm_dbg(DRM_UT_CORE, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:526:2: note: expanded from macro '__drm_dbg'
           _dynamic_func_call_cls(cat, fmt, ___drm_dbg,                    \
           ^
   drivers/gpu/drm/drm_bufs.c:1468:2: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           DRM_DEBUG("%d\n", request->count);
           ^
   include/drm/drm_print.h:565:2: note: expanded from macro 'DRM_DEBUG'
           __drm_dbg(DRM_UT_CORE, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:526:2: note: expanded from macro '__drm_dbg'
           _dynamic_func_call_cls(cat, fmt, ___drm_dbg,                    \
           ^
   drivers/gpu/drm/drm_bufs.c:1568:2: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
           DRM_DEBUG("%d buffers, retcode = %d\n", *p, retcode);
           ^
   include/drm/drm_print.h:565:2: note: expanded from macro 'DRM_DEBUG'
           __drm_dbg(DRM_UT_CORE, fmt, ##__VA_ARGS__)
           ^
   include/drm/drm_print.h:526:2: note: expanded from macro '__drm_dbg'
           _dynamic_func_call_cls(cat, fmt, ___drm_dbg,                    \
           ^
   7 errors generated.
..


vim +/_dynamic_func_call_cls +195 drivers/gpu/drm/drm_mode_object.c

949619f32eee37 Daniel Vetter  2016-08-29  183  
949619f32eee37 Daniel Vetter  2016-08-29  184  /**
020a218f95bd3c Thierry Reding 2017-02-28  185   * drm_mode_object_put - release a mode object reference
020a218f95bd3c Thierry Reding 2017-02-28  186   * @obj: DRM mode object
949619f32eee37 Daniel Vetter  2016-08-29  187   *
a2511a557eb868 Daniel Vetter  2016-08-29  188   * This function decrements the object's refcount if it is a refcounted modeset
949619f32eee37 Daniel Vetter  2016-08-29  189   * object. It is a no-op on any other object. This is used to drop references
020a218f95bd3c Thierry Reding 2017-02-28  190   * acquired with drm_mode_object_get().
949619f32eee37 Daniel Vetter  2016-08-29  191   */
020a218f95bd3c Thierry Reding 2017-02-28  192  void drm_mode_object_put(struct drm_mode_object *obj)
949619f32eee37 Daniel Vetter  2016-08-29  193  {
949619f32eee37 Daniel Vetter  2016-08-29  194  	if (obj->free_cb) {
2c935bc57221cc Peter Zijlstra 2016-11-14 @195  		DRM_DEBUG("OBJ ID: %d (%d)\n", obj->id, kref_read(&obj->refcount));
949619f32eee37 Daniel Vetter  2016-08-29  196  		kref_put(&obj->refcount, obj->free_cb);
949619f32eee37 Daniel Vetter  2016-08-29  197  	}
949619f32eee37 Daniel Vetter  2016-08-29  198  }
020a218f95bd3c Thierry Reding 2017-02-28  199  EXPORT_SYMBOL(drm_mode_object_put);
949619f32eee37 Daniel Vetter  2016-08-29  200  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

Re: [PATCH 16/86] drm/drm_print: Minimize include footprint

[Sam Ravnborg]

Hi all.

On Sun, Jan 22, 2023 at 07:19:15AM +0800, kernel test robot wrote:
> Hi Sam,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on 2e337a8d14bd4b04913d52ccf076be29d846acd7]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Sam-Ravnborg-via-B4-Submission-Endpoint/drm-komeda-Direct-include-headers-from-drm_print/20230122-041306
> base:   2e337a8d14bd4b04913d52ccf076be29d846acd7
> patch link:    https://lore.kernel.org/r/20230113-drm-include-v1-v1-16-c5cf72d8a5a2%40ravnborg.org
> patch subject: [PATCH 16/86] drm/drm_print: Minimize include footprint
> config: i386-randconfig-a004 (https://download.01.org/0day-ci/archive/20230122/202301220750.HzZm1ZHu-lkp@intel.com/config)
> compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/intel-lab-lkp/linux/commit/530d852970d1a75527031a4f23689f89f0a85804
>         git remote add linux-review https://github.com/intel-lab-lkp/linux
>         git fetch --no-tags linux-review Sam-Ravnborg-via-B4-Submission-Endpoint/drm-komeda-Direct-include-headers-from-drm_print/20230122-041306
>         git checkout 530d852970d1a75527031a4f23689f89f0a85804
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/gpu/drm/drm_mode_object.c:195:3: error: implicit declaration of function '_dynamic_func_call_cls' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
>                    DRM_DEBUG("OBJ ID: %d (%d)\n", obj->id, kref_read(&obj->refcount));
>                    ^

For anyone following this. I failed to reproduce the error below using
the instructions above. It looks like some obscure combination of CONFIG
options that may be unrelated to this patch.
allmodconfig, allyesconfig for i386 did not trigger the bug.

I will get back to this in a few days (maybe first in the weekend), and
will share my findings.

	Sam

Re: [PATCH 16/86] drm/drm_print: Minimize include footprint

[kernel test robot]

Hi Sam,

I love your patch! Yet something to improve:

[auto build test ERROR on 2e337a8d14bd4b04913d52ccf076be29d846acd7]

url:    https://github.com/intel-lab-lkp/linux/commits/Sam-Ravnborg-via-B4-Submission-Endpoint/drm-komeda-Direct-include-headers-from-drm_print/20230122-041306
base:   2e337a8d14bd4b04913d52ccf076be29d846acd7
patch link:    https://lore.kernel.org/r/20230113-drm-include-v1-v1-16-c5cf72d8a5a2%40ravnborg.org
patch subject: [PATCH 16/86] drm/drm_print: Minimize include footprint
config: nios2-randconfig-r012-20230123 (https://download.01.org/0day-ci/archive/20230124/202301242323.y0SNS3Fn-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/530d852970d1a75527031a4f23689f89f0a85804
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Sam-Ravnborg-via-B4-Submission-Endpoint/drm-komeda-Direct-include-headers-from-drm_print/20230122-041306
        git checkout 530d852970d1a75527031a4f23689f89f0a85804
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=nios2 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=nios2 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   drivers/gpu/drm/arm/display/komeda/komeda_dev.c: In function 'komeda_register_show':
>> drivers/gpu/drm/arm/display/komeda/komeda_dev.c:26:37: error: invalid use of undefined type 'struct seq_file'
      26 |         struct komeda_dev *mdev = sf->private;
         |                                     ^~
>> drivers/gpu/drm/arm/display/komeda/komeda_dev.c:29:9: error: implicit declaration of function 'seq_puts' [-Werror=implicit-function-declaration]
      29 |         seq_puts(sf, "\n====== Komeda register dump =========\n");
         |         ^~~~~~~~
   drivers/gpu/drm/arm/display/komeda/komeda_dev.c: At top level:
>> drivers/gpu/drm/arm/display/komeda/komeda_dev.c:44:1: warning: data definition has no type or storage class
      44 | DEFINE_SHOW_ATTRIBUTE(komeda_register);
         | ^~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/arm/display/komeda/komeda_dev.c:44:1: error: type defaults to 'int' in declaration of 'DEFINE_SHOW_ATTRIBUTE' [-Werror=implicit-int]
>> drivers/gpu/drm/arm/display/komeda/komeda_dev.c:44:1: warning: parameter names (without types) in function declaration
   drivers/gpu/drm/arm/display/komeda/komeda_dev.c:24:12: warning: 'komeda_register_show' defined but not used [-Wunused-function]
      24 | static int komeda_register_show(struct seq_file *sf, void *x)
         |            ^~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +26 drivers/gpu/drm/arm/display/komeda/komeda_dev.c

bd628c1bed7902 james qian wang (Arm Technology China  2019-01-03  23) 
7d3cfb70a604d2 james qian wang (Arm Technology China  2019-01-22  24) static int komeda_register_show(struct seq_file *sf, void *x)
7d3cfb70a604d2 james qian wang (Arm Technology China  2019-01-22  25) {
7d3cfb70a604d2 james qian wang (Arm Technology China  2019-01-22 @26) 	struct komeda_dev *mdev = sf->private;
7d3cfb70a604d2 james qian wang (Arm Technology China  2019-01-22  27) 	int i;
7d3cfb70a604d2 james qian wang (Arm Technology China  2019-01-22  28) 
aefdaa15e54c09 Lowry Li (Arm Technology China         2019-09-17 @29) 	seq_puts(sf, "\n====== Komeda register dump =========\n");
aefdaa15e54c09 Lowry Li (Arm Technology China         2019-09-17  30) 
efb46508851874 james qian wang (Arm Technology China  2019-12-12  31) 	pm_runtime_get_sync(mdev->dev);
efb46508851874 james qian wang (Arm Technology China  2019-12-12  32) 
7d3cfb70a604d2 james qian wang (Arm Technology China  2019-01-22  33) 	if (mdev->funcs->dump_register)
7d3cfb70a604d2 james qian wang (Arm Technology China  2019-01-22  34) 		mdev->funcs->dump_register(mdev, sf);
7d3cfb70a604d2 james qian wang (Arm Technology China  2019-01-22  35) 
7d3cfb70a604d2 james qian wang (Arm Technology China  2019-01-22  36) 	for (i = 0; i < mdev->n_pipelines; i++)
7d3cfb70a604d2 james qian wang (Arm Technology China  2019-01-22  37) 		komeda_pipeline_dump_register(mdev->pipelines[i], sf);
7d3cfb70a604d2 james qian wang (Arm Technology China  2019-01-22  38) 
efb46508851874 james qian wang (Arm Technology China  2019-12-12  39) 	pm_runtime_put(mdev->dev);
efb46508851874 james qian wang (Arm Technology China  2019-12-12  40) 
7d3cfb70a604d2 james qian wang (Arm Technology China  2019-01-22  41) 	return 0;
7d3cfb70a604d2 james qian wang (Arm Technology China  2019-01-22  42) }
7d3cfb70a604d2 james qian wang (Arm Technology China  2019-01-22  43) 
ef52d5853bf1d0 Qinglang Miao                          2020-09-17 @44  DEFINE_SHOW_ATTRIBUTE(komeda_register);
7d3cfb70a604d2 james qian wang (Arm Technology China  2019-01-22  45) 

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

[PATCH 17/86] drm/xlnx: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/xlnx/zynqmp_dp.c  | 1 +
 drivers/gpu/drm/xlnx/zynqmp_kms.c | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
index 0a7b466446fb..9e8d6456ee13 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
@@ -11,6 +11,7 @@
 
 #include <drm/display/drm_dp_helper.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_device.h>
 #include <drm/drm_edid.h>
diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c
index 776ef5480206..697a97d4f576 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_kms.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c
@@ -11,6 +11,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_bridge_connector.h>
@@ -26,6 +27,7 @@
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_managed.h>
 #include <drm/drm_mode_config.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_plane.h>
 #include <drm/drm_plane_helper.h>
 #include <drm/drm_probe_helper.h>

-- 
2.34.1

[PATCH 18/86] drm/amd: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c                    | 3 +++
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c           | 2 ++
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c      | 2 ++
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 ++
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c     | 2 ++
 5 files changed, 11 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c
index 53ff91fc6cf6..f617b8ddee9e 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c
@@ -1,6 +1,9 @@
 // SPDX-License-Identifier: GPL-2.0+
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
+#include <drm/drm_modeset_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_simple_kms_helper.h>
 #include <drm/drm_vblank.h>
 
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 2db449fed300..d95ec18ee71d 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -82,9 +82,11 @@
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_uapi.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_vblank.h>
 #include <drm/drm_audio_component.h>
 #include <drm/drm_gem_atomic_helper.h>
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c
index 22125daf9dcf..c53652f594e1 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c
@@ -25,6 +25,8 @@
  */
 #include <drm/drm_vblank.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "dc.h"
 #include "amdgpu.h"
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
index 41f35d75d0a8..540b0fa923e3 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
@@ -27,6 +27,8 @@
 #include <drm/display/drm_dp_mst_helper.h>
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include "dm_services.h"
 #include "amdgpu.h"
 #include "amdgpu_dm.h"
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
index 3c50b3ff7954..8638f95af243 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
@@ -25,8 +25,10 @@
  */
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_gem_atomic_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_plane_helper.h>
 #include <drm/drm_fourcc.h>
 

-- 
2.34.1

[PATCH 19/86] drm/komeda: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/arm/display/komeda/komeda_crtc.c         | 2 ++
 drivers/gpu/drm/arm/display/komeda/komeda_drv.c          | 1 +
 drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c  | 1 +
 drivers/gpu/drm/arm/display/komeda/komeda_kms.c          | 1 +
 drivers/gpu/drm/arm/display/komeda/komeda_plane.c        | 2 ++
 drivers/gpu/drm/arm/display/komeda/komeda_private_obj.c  | 3 +++
 drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 2 ++
 7 files changed, 12 insertions(+)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c
index cea3fd5772b5..449e121c77ab 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c
@@ -10,6 +10,8 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 #include <drm/drm_vblank.h>
 
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
index 28f76e07dd95..4e98317c6453 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
@@ -11,6 +11,7 @@
 #include <linux/component.h>
 #include <linux/pm_runtime.h>
 #include <drm/drm_fbdev_generic.h>
+#include <drm/drm_modeset_helper.h>
 #include <drm/drm_module.h>
 #include <drm/drm_of.h>
 #include "komeda_dev.h"
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c b/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c
index df5da5a44755..f550cc887c70 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c
@@ -9,6 +9,7 @@
 #include <drm/drm_gem.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_modeset_helper.h>
 
 #include "komeda_framebuffer.h"
 #include "komeda_dev.h"
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
index 62dc64550793..72d5ee77e0d2 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
@@ -13,6 +13,7 @@
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_managed.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
 
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
index c20ff72f0ae5..dd9ba6142514 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
@@ -6,7 +6,9 @@
  */
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 #include "komeda_dev.h"
 #include "komeda_kms.h"
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_private_obj.c b/drivers/gpu/drm/arm/display/komeda/komeda_private_obj.c
index 914400c4af73..f0a38cce1e3a 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_private_obj.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_private_obj.c
@@ -4,6 +4,9 @@
  * Author: James.Qian.Wang <james.qian.wang@arm.com>
  *
  */
+
+#include <drm/drm_atomic_state_helper.h>
+
 #include "komeda_dev.h"
 #include "komeda_kms.h"
 
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
index ebccb74306a7..23d61fd61fa9 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
@@ -4,7 +4,9 @@
  * Author: James.Qian.Wang <james.qian.wang@arm.com>
  *
  */
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_framebuffer.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include "komeda_dev.h"
 #include "komeda_kms.h"
 

-- 
2.34.1

[PATCH 20/86] drm/arm/hdlcd: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/arm/hdlcd_crtc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/arm/hdlcd_crtc.c b/drivers/gpu/drm/arm/hdlcd_crtc.c
index 3cfefadc7c9d..dae425df07fa 100644
--- a/drivers/gpu/drm/arm/hdlcd_crtc.c
+++ b/drivers/gpu/drm/arm/hdlcd_crtc.c
@@ -17,10 +17,12 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_fb_dma_helper.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_dma_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>

-- 
2.34.1

[PATCH 21/86] drm/arm/malidp: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/arm/malidp_crtc.c   | 2 ++
 drivers/gpu/drm/arm/malidp_drv.c    | 1 +
 drivers/gpu/drm/arm/malidp_mw.c     | 2 ++
 drivers/gpu/drm/arm/malidp_planes.c | 2 ++
 4 files changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/arm/malidp_crtc.c b/drivers/gpu/drm/arm/malidp_crtc.c
index dc01c43f6193..8637663cd8e8 100644
--- a/drivers/gpu/drm/arm/malidp_crtc.c
+++ b/drivers/gpu/drm/arm/malidp_crtc.c
@@ -13,8 +13,10 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_framebuffer.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
index 589c1c66a6dc..e2af7f3371d6 100644
--- a/drivers/gpu/drm/arm/malidp_drv.c
+++ b/drivers/gpu/drm/arm/malidp_drv.c
@@ -25,6 +25,7 @@
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_managed.h>
 #include <drm/drm_modeset_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_module.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_mw.c
index 626709bec6f5..cfe029225245 100644
--- a/drivers/gpu/drm/arm/malidp_mw.c
+++ b/drivers/gpu/drm/arm/malidp_mw.c
@@ -8,12 +8,14 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_fb_dma_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_dma_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_writeback.h>
 
diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
index 34547edf1ee3..cd9d32479a9e 100644
--- a/drivers/gpu/drm/arm/malidp_planes.c
+++ b/drivers/gpu/drm/arm/malidp_planes.c
@@ -11,6 +11,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_fb_dma_helper.h>
@@ -18,6 +19,7 @@
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 
 #include "malidp_hw.h"

-- 
2.34.1

[PATCH 22/86] drm/armada: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/armada/armada_crtc.c    | 2 ++
 drivers/gpu/drm/armada/armada_overlay.c | 2 ++
 drivers/gpu/drm/armada/armada_plane.c   | 2 ++
 3 files changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/armada/armada_crtc.c b/drivers/gpu/drm/armada/armada_crtc.c
index 15dd667aa2e7..a2a6a94339de 100644
--- a/drivers/gpu/drm/armada/armada_crtc.c
+++ b/drivers/gpu/drm/armada/armada_crtc.c
@@ -12,6 +12,8 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
 
diff --git a/drivers/gpu/drm/armada/armada_overlay.c b/drivers/gpu/drm/armada/armada_overlay.c
index f21eb8fb76d8..f273570eb92e 100644
--- a/drivers/gpu/drm/armada/armada_overlay.c
+++ b/drivers/gpu/drm/armada/armada_overlay.c
@@ -8,7 +8,9 @@
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_atomic_uapi.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_fourcc.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_plane_helper.h>
 
 #include "armada_crtc.h"
diff --git a/drivers/gpu/drm/armada/armada_plane.c b/drivers/gpu/drm/armada/armada_plane.c
index cc47c032dbc1..1f8810f969ec 100644
--- a/drivers/gpu/drm/armada/armada_plane.c
+++ b/drivers/gpu/drm/armada/armada_plane.c
@@ -6,7 +6,9 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_fourcc.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_plane_helper.h>
 
 #include "armada_crtc.h"

-- 
2.34.1

[PATCH 23/86] drm/aspeed: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/aspeed/aspeed_gfx_out.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx_out.c b/drivers/gpu/drm/aspeed/aspeed_gfx_out.c
index 78775e0c853f..70163348377a 100644
--- a/drivers/gpu/drm/aspeed/aspeed_gfx_out.c
+++ b/drivers/gpu/drm/aspeed/aspeed_gfx_out.c
@@ -2,8 +2,10 @@
 // Copyright 2018 IBM Corporation
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_connector.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
 #include "aspeed_gfx.h"

-- 
2.34.1

[PATCH 24/86] drm/ast: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/ast/ast_drv.c  | 1 +
 drivers/gpu/drm/ast/ast_mode.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c
index d78852c7cf5b..1def394fcc6f 100644
--- a/drivers/gpu/drm/ast/ast_drv.c
+++ b/drivers/gpu/drm/ast/ast_drv.c
@@ -34,6 +34,7 @@
 #include <drm/drm_drv.h>
 #include <drm/drm_fbdev_generic.h>
 #include <drm/drm_gem_shmem_helper.h>
+#include <drm/drm_modeset_helper.h>
 #include <drm/drm_module.h>
 #include <drm/drm_probe_helper.h>
 
diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index dcb8ced4ce75..edc61f972c8b 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu/drm/ast/ast_mode.c
@@ -43,6 +43,7 @@
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_gem_shmem_helper.h>
 #include <drm/drm_managed.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>
 

-- 
2.34.1

[PATCH 25/86] drm/atmel-hlcdc: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c  | 1 +
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
index 58184cd6ab0b..77e5c5cdc252 100644
--- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
+++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
@@ -18,6 +18,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
index daa508504f47..cd557fee6581 100644
--- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
+++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
@@ -11,11 +11,13 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_fb_dma_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_dma_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "atmel_hlcdc_dc.h"
 

-- 
2.34.1

[PATCH 26/86] drm/bridge: adv7511: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index ddceafa7b637..8da6ad8757b8 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -16,7 +16,9 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
 

-- 
2.34.1

[PATCH 27/86] drm/bridge: analogix: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 2 ++
 drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 2 ++
 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 ++
 drivers/gpu/drm/bridge/analogix/anx7625.c          | 1 +
 4 files changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
index 3577c532abb4..86e41cccd60c 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
@@ -20,9 +20,11 @@
 
 #include <drm/display/drm_dp_helper.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_print.h>
diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
index a3a38bbe2786..616a44961a98 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
@@ -20,9 +20,11 @@
 
 #include <drm/display/drm_dp_helper.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
 
diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index df9370e0ff23..d12fc4e6cc09 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -21,10 +21,12 @@
 #include <drm/bridge/analogix_dp.h>
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_device.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 6846199a2ee1..992ba7b25f9d 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -25,6 +25,7 @@
 #include <drm/display/drm_dp_helper.h>
 #include <drm/display/drm_hdcp_helper.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_mipi_dsi.h>

-- 
2.34.1

[PATCH 28/86] drm/bridge: chipone: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/bridge/chipone-icn6211.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c
index 0e37840cd7a8..939d8fe68f0e 100644
--- a/drivers/gpu/drm/bridge/chipone-icn6211.c
+++ b/drivers/gpu/drm/bridge/chipone-icn6211.c
@@ -5,6 +5,7 @@
  */
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_of.h>
 #include <drm/drm_print.h>
 #include <drm/drm_mipi_dsi.h>

-- 
2.34.1

[PATCH 29/86] drm/bridge: chrontel: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/bridge/chrontel-ch7033.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/bridge/chrontel-ch7033.c b/drivers/gpu/drm/bridge/chrontel-ch7033.c
index 339b759e4c81..734793302b57 100644
--- a/drivers/gpu/drm/bridge/chrontel-ch7033.c
+++ b/drivers/gpu/drm/bridge/chrontel-ch7033.c
@@ -11,8 +11,10 @@
 #include <linux/regmap.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>

-- 
2.34.1

[PATCH 30/86] drm/bridge: display-connector: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/bridge/display-connector.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/bridge/display-connector.c b/drivers/gpu/drm/bridge/display-connector.c
index 9a12449ad7b8..f6b5a894b286 100644
--- a/drivers/gpu/drm/bridge/display-connector.c
+++ b/drivers/gpu/drm/bridge/display-connector.c
@@ -15,6 +15,7 @@
 #include <linux/regulator/consumer.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_edid.h>
 

-- 
2.34.1

[PATCH 31/86] drm/bridge: fsl-ldb: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/bridge/fsl-ldb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c
index 9bcba8fc57e7..0950052a4182 100644
--- a/drivers/gpu/drm/bridge/fsl-ldb.c
+++ b/drivers/gpu/drm/bridge/fsl-ldb.c
@@ -14,6 +14,7 @@
 #include <linux/regmap.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>

-- 
2.34.1

[PATCH 32/86] drm/bridge: ite: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/bridge/ite-it6505.c  | 3 ++-
 drivers/gpu/drm/bridge/ite-it66121.c | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
index ef42cd840958..5afa071f075e 100644
--- a/drivers/gpu/drm/bridge/ite-it6505.c
+++ b/drivers/gpu/drm/bridge/ite-it6505.c
@@ -3,8 +3,8 @@
  * Copyright (c) 2020, The Linux Foundation. All rights reserved.
  */
 #include <linux/bits.h>
-#include <linux/debugfs.h>
 #include <linux/delay.h>
+#include <linux/debugfs.h>
 #include <linux/device.h>
 #include <linux/err.h>
 #include <linux/extcon.h>
@@ -26,6 +26,7 @@
 #include <drm/display/drm_dp_helper.h>
 #include <drm/display/drm_hdcp_helper.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_edid.h>
diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
index a2d723d6a4be..434ba849698b 100644
--- a/drivers/gpu/drm/bridge/ite-it66121.c
+++ b/drivers/gpu/drm/bridge/ite-it66121.c
@@ -21,6 +21,7 @@
 #include <linux/regulator/consumer.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_modes.h>

-- 
2.34.1

[PATCH 33/86] drm/bridge: lontium: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/bridge/lontium-lt8912b.c   | 2 ++
 drivers/gpu/drm/bridge/lontium-lt9211.c    | 1 +
 drivers/gpu/drm/bridge/lontium-lt9611.c    | 2 ++
 drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 ++
 4 files changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c b/drivers/gpu/drm/bridge/lontium-lt8912b.c
index 2019a8167d69..3d0713e00fb7 100644
--- a/drivers/gpu/drm/bridge/lontium-lt8912b.c
+++ b/drivers/gpu/drm/bridge/lontium-lt8912b.c
@@ -12,8 +12,10 @@
 
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_mipi_dsi.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 
 #include <video/videomode.h>
diff --git a/drivers/gpu/drm/bridge/lontium-lt9211.c b/drivers/gpu/drm/bridge/lontium-lt9211.c
index 3e19fff6547a..ce365cff496c 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9211.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9211.c
@@ -22,6 +22,7 @@
 #include <linux/regulator/consumer.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_mipi_dsi.h>
 #include <drm/drm_of.h>
diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
index a25d21a7d5c1..68bb348f55a5 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
@@ -17,8 +17,10 @@
 #include <sound/hdmi-codec.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_mipi_dsi.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
index 583daacf3705..b3fbf0e79c1f 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
@@ -20,8 +20,10 @@
 #include <sound/hdmi-codec.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_mipi_dsi.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
 

-- 
2.34.1

[PATCH 34/86] drm/bridge: lvds-codec: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/bridge/lvds-codec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/bridge/lvds-codec.c b/drivers/gpu/drm/bridge/lvds-codec.c
index 39e7004de720..ea014e9011c9 100644
--- a/drivers/gpu/drm/bridge/lvds-codec.c
+++ b/drivers/gpu/drm/bridge/lvds-codec.c
@@ -13,6 +13,7 @@
 #include <linux/regulator/consumer.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>

-- 
2.34.1

[PATCH 35/86] drm/bridge: megachips: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c
index 4fc494d9084b..69995cf3f416 100644
--- a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c
+++ b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c
@@ -25,8 +25,10 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
 

-- 
2.34.1

[PATCH 36/86] drm/bridge: nxp: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/bridge/nxp-ptn3460.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/nxp-ptn3460.c
index cd292a2f894c..31dc97d444dc 100644
--- a/drivers/gpu/drm/bridge/nxp-ptn3460.c
+++ b/drivers/gpu/drm/bridge/nxp-ptn3460.c
@@ -11,9 +11,11 @@
 #include <linux/module.h>
 #include <linux/of.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_print.h>

-- 
2.34.1

[PATCH 37/86] drm/bridge: panel: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/bridge/panel.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index 97c305978f9b..91e6d4bc03b1 100644
--- a/drivers/gpu/drm/bridge/panel.c
+++ b/drivers/gpu/drm/bridge/panel.c
@@ -7,6 +7,7 @@
 #include <linux/debugfs.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_connector.h>
 #include <drm/drm_encoder.h>

-- 
2.34.1

[PATCH 38/86] drm/bridge: sii902x: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/bridge/sii902x.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
index ef66461e7f7c..81182401c4ca 100644
--- a/drivers/gpu/drm/bridge/sii902x.c
+++ b/drivers/gpu/drm/bridge/sii902x.c
@@ -22,9 +22,11 @@
 #include <linux/clk.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
 

-- 
2.34.1

[PATCH 39/86] drm/bridge: simple-bridge: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/bridge/simple-bridge.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c
index 2c5c5211bdab..7471dfef80d6 100644
--- a/drivers/gpu/drm/bridge/simple-bridge.c
+++ b/drivers/gpu/drm/bridge/simple-bridge.c
@@ -13,9 +13,11 @@
 #include <linux/regulator/consumer.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
 

-- 
2.34.1

[PATCH 40/86] drm/bridge: synopsys: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c     | 2 ++
 drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 1 +
 2 files changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index aa51c61a78c7..bda95703be68 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
@@ -30,7 +30,9 @@
 #include <drm/display/drm_scdc_helper.h>
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
index b2efecf7d160..89711cc63d79 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
@@ -21,6 +21,7 @@
 
 #include <drm/bridge/dw_mipi_dsi.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_mipi_dsi.h>

-- 
2.34.1

[PATCH 41/86] drm/bridge: tc358767: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/bridge/tc358767.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
index 6d16ec45ea61..09156cd756ca 100644
--- a/drivers/gpu/drm/bridge/tc358767.c
+++ b/drivers/gpu/drm/bridge/tc358767.c
@@ -31,9 +31,11 @@
 
 #include <drm/display/drm_dp_helper.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_mipi_dsi.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_print.h>

-- 
2.34.1

[PATCH 42/86] drm/bridge: ti: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/bridge/ti-dlpc3433.c  | 1 +
 drivers/gpu/drm/bridge/ti-sn65dsi83.c | 1 +
 drivers/gpu/drm/bridge/ti-sn65dsi86.c | 1 +
 drivers/gpu/drm/bridge/ti-tfp410.c    | 2 ++
 4 files changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/bridge/ti-dlpc3433.c b/drivers/gpu/drm/bridge/ti-dlpc3433.c
index 186a9e2ff24d..05c2cc2c6330 100644
--- a/drivers/gpu/drm/bridge/ti-dlpc3433.c
+++ b/drivers/gpu/drm/bridge/ti-dlpc3433.c
@@ -9,6 +9,7 @@
  */
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_of.h>
 #include <drm/drm_print.h>
 #include <drm/drm_mipi_dsi.h>
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
index 91ecfbe45bf9..4e2e43036fb0 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
@@ -37,6 +37,7 @@
 #include <linux/regulator/consumer.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_mipi_dsi.h>
 #include <drm/drm_of.h>
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
index 1e26fa63845a..b09d0f580d5b 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
@@ -27,6 +27,7 @@
 #include <drm/display/drm_dp_helper.h>
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_bridge_connector.h>
 #include <drm/drm_edid.h>
diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c
index 6db69df0e18b..b2183c61b599 100644
--- a/drivers/gpu/drm/bridge/ti-tfp410.c
+++ b/drivers/gpu/drm/bridge/ti-tfp410.c
@@ -13,9 +13,11 @@
 #include <linux/workqueue.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
 

-- 
2.34.1

[PATCH 43/86] drm/display: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c
index 5861b0a6247b..6a8f1eb5fb80 100644
--- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
@@ -41,6 +41,7 @@
 #include <drm/display/drm_dp_mst_helper.h>
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_print.h>

-- 
2.34.1

[PATCH 44/86] drm: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/drm_atomic_helper.c          | 1 +
 drivers/gpu/drm/drm_crtc_helper.c            | 1 +
 drivers/gpu/drm/drm_fb_dma_helper.c          | 1 +
 drivers/gpu/drm/drm_gem_framebuffer_helper.c | 1 +
 drivers/gpu/drm/drm_mipi_dbi.c               | 2 ++
 drivers/gpu/drm/drm_simple_kms_helper.c      | 2 ++
 6 files changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
index d579fd8f7cb8..063ed8b6cfa5 100644
--- a/drivers/gpu/drm/drm_atomic_helper.c
+++ b/drivers/gpu/drm/drm_atomic_helper.c
@@ -38,6 +38,7 @@
 #include <drm/drm_drv.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 #include <drm/drm_self_refresh_helper.h>
 #include <drm/drm_vblank.h>
diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
index a209659a996c..843b2df36e3a 100644
--- a/drivers/gpu/drm/drm_crtc_helper.c
+++ b/drivers/gpu/drm/drm_crtc_helper.c
@@ -45,6 +45,7 @@
 #include <drm/drm_encoder.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 #include <drm/drm_vblank.h>
 
diff --git a/drivers/gpu/drm/drm_fb_dma_helper.c b/drivers/gpu/drm/drm_fb_dma_helper.c
index 3b535ad1b07c..fd33fc99d30f 100644
--- a/drivers/gpu/drm/drm_fb_dma_helper.c
+++ b/drivers/gpu/drm/drm_fb_dma_helper.c
@@ -10,6 +10,7 @@
  */
 
 #include <drm/drm_damage_helper.h>
+#include <drm/drm_device.h>
 #include <drm/drm_fb_dma_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
index e93533b86037..1cfbd3fb9fbf 100644
--- a/drivers/gpu/drm/drm_gem_framebuffer_helper.c
+++ b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
@@ -9,6 +9,7 @@
 #include <linux/module.h>
 
 #include <drm/drm_damage_helper.h>
+#include <drm/drm_device.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem.h>
diff --git a/drivers/gpu/drm/drm_mipi_dbi.c b/drivers/gpu/drm/drm_mipi_dbi.c
index c871d9f096b8..76abd8c48c86 100644
--- a/drivers/gpu/drm/drm_mipi_dbi.c
+++ b/drivers/gpu/drm/drm_mipi_dbi.c
@@ -13,6 +13,7 @@
 #include <linux/regulator/consumer.h>
 #include <linux/spi/spi.h>
 
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_connector.h>
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_drv.h>
@@ -25,6 +26,7 @@
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_mipi_dbi.h>
 #include <drm/drm_modes.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_rect.h>
 #include <video/mipi_display.h>
diff --git a/drivers/gpu/drm/drm_simple_kms_helper.c b/drivers/gpu/drm/drm_simple_kms_helper.c
index 270523ae36d4..a7164bffeea8 100644
--- a/drivers/gpu/drm/drm_simple_kms_helper.c
+++ b/drivers/gpu/drm/drm_simple_kms_helper.c
@@ -8,10 +8,12 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_managed.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>
 

-- 
2.34.1

[PATCH 45/86] drm/exynos: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/exynos/exynos_dp.c        | 1 +
 drivers/gpu/drm/exynos/exynos_drm_crtc.c  | 2 ++
 drivers/gpu/drm/exynos/exynos_drm_dpi.c   | 2 ++
 drivers/gpu/drm/exynos/exynos_drm_drv.c   | 4 ++++
 drivers/gpu/drm/exynos/exynos_drm_dsi.c   | 1 +
 drivers/gpu/drm/exynos/exynos_drm_fb.c    | 2 ++
 drivers/gpu/drm/exynos/exynos_drm_plane.c | 2 ++
 drivers/gpu/drm/exynos/exynos_drm_vidi.c  | 2 ++
 drivers/gpu/drm/exynos/exynos_hdmi.c      | 2 ++
 9 files changed, 18 insertions(+)

diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c
index 3404ec1367fb..0db863eb78c3 100644
--- a/drivers/gpu/drm/exynos/exynos_dp.c
+++ b/drivers/gpu/drm/exynos/exynos_dp.c
@@ -22,6 +22,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_crtc.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_print.h>
diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c
index 4153f302de7c..435c8c6c606c 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c
@@ -10,7 +10,9 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_encoder.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
 
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c b/drivers/gpu/drm/exynos/exynos_drm_dpi.c
index 378e5381978f..21ce8aca1f84 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dpi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dpi.c
@@ -12,6 +12,8 @@
 #include <linux/regulator/consumer.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
index 16c539657f73..6b6bc9d52de3 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
@@ -15,11 +15,15 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_drv.h>
+#include <drm/drm_encoder.h>
 #include <drm/drm_fb_helper.h>
 #include <drm/drm_file.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_ioctl.h>
+#include <drm/drm_modeset_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
 #include <drm/exynos_drm.h>
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index 320c370cfe24..f76556edb924 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -23,6 +23,7 @@
 #include <video/videomode.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_mipi_dsi.h>
 #include <drm/drm_panel.h>
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c
index 97f2dee2db29..032ff561c894 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fb.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c
@@ -15,6 +15,8 @@
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_modeset_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/exynos_drm.h>
 
diff --git a/drivers/gpu/drm/exynos/exynos_drm_plane.c b/drivers/gpu/drm/exynos/exynos_drm_plane.c
index 7c3aa77186d3..6c251eabad0b 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_plane.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_plane.c
@@ -7,8 +7,10 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_framebuffer.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/exynos_drm.h>
 
 #include "exynos_drm_crtc.h"
diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exynos/exynos_drm_vidi.c
index 4d56c8c799c5..146eed4ee3e0 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c
@@ -12,8 +12,10 @@
 #include <linux/timer.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_framebuffer.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>
 #include <drm/drm_vblank.h>
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
index b7c11bdce2c8..31c11aab8eb5 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
@@ -34,8 +34,10 @@
 #include <media/cec-notifier.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>

-- 
2.34.1

[PATCH 46/86] drm/fsl-dcu: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c  | 2 ++
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c | 2 ++
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c   | 2 ++
 3 files changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c
index 2af60d98f48f..a063618de7ec 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c
@@ -12,7 +12,9 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
 
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c
index 794a87d16f88..f956d283ad09 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c
@@ -9,11 +9,13 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_fb_dma_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_dma_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_plane_helper.h>
 #include <drm/drm_probe_helper.h>
 
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c
index 2c2b92324a2e..b3b207a37180 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c
@@ -9,7 +9,9 @@
 #include <linux/of_graph.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_probe_helper.h>

-- 
2.34.1

[PATCH 47/86] drm/gud: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/gud/gud_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/gud/gud_drv.c b/drivers/gpu/drm/gud/gud_drv.c
index 9d7bf8ee45f1..9e807fd41f17 100644
--- a/drivers/gpu/drm/gud/gud_drv.c
+++ b/drivers/gpu/drm/gud/gud_drv.c
@@ -24,6 +24,7 @@
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_gem_shmem_helper.h>
 #include <drm/drm_managed.h>
+#include <drm/drm_modeset_helper.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>

-- 
2.34.1

[PATCH 48/86] drm/hisilicon: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c   | 2 ++
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h  | 3 +++
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 2 ++
 drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c     | 1 +
 drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c  | 2 ++
 drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c  | 1 +
 6 files changed, 11 insertions(+)

diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
index 89bed78f1466..716465f3a802 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
@@ -15,8 +15,10 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem_vram_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_vblank.h>
 
 #include "hibmc_drm_drv.h"
diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h
index f957552c6c50..6b43fc08d5fa 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h
@@ -18,8 +18,11 @@
 #include <linux/i2c-algo-bit.h>
 #include <linux/i2c.h>
 
+#include <drm/drm_crtc.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_encoder.h>
 #include <drm/drm_framebuffer.h>
+#include <drm/drm_modeset_helper.h>
 
 struct hibmc_connector {
 	struct drm_connector base;
diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
index 8c6d2ea2a472..55553dd61224 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
@@ -14,6 +14,8 @@
 #include <linux/io.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_print.h>
 #include <drm/drm_simple_kms_helper.h>
diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
index d9978b79828c..5b0721c28ed7 100644
--- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
+++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
@@ -22,6 +22,7 @@
 #include <drm/drm_bridge.h>
 #include <drm/drm_device.h>
 #include <drm/drm_mipi_dsi.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
index 871f79a6b17e..3b1922792e2b 100644
--- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
+++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
@@ -22,12 +22,14 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_fb_dma_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_dma_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
 #include <drm/drm_gem_framebuffer_helper.h>
diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
index 9c5d49bf40c9..8e6ac5b993fa 100644
--- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
@@ -22,6 +22,7 @@
 #include <drm/drm_fbdev_generic.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_module.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>

-- 
2.34.1

[PATCH 49/86] drm/hyperv: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/hyperv/hyperv_drm_drv.c     | 1 +
 drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
index 427c20ba3404..f8671d582d46 100644
--- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
@@ -13,6 +13,7 @@
 #include <drm/drm_drv.h>
 #include <drm/drm_fbdev_generic.h>
 #include <drm/drm_gem_shmem_helper.h>
+#include <drm/drm_modeset_helper.h>
 #include <drm/drm_simple_kms_helper.h>
 
 #include "hyperv_drm.h"
diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
index 6c6b57298797..8a09b59458fe 100644
--- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
@@ -5,6 +5,7 @@
 
 #include <linux/hyperv.h>
 
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_edid.h>
@@ -14,6 +15,7 @@
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_gem_shmem_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>
 

-- 
2.34.1

[PATCH 50/86] drm/i2c: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/i2c/tda998x_drv.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index db5c9343a3d2..f8220123c4f7 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -15,8 +15,10 @@
 #include <sound/hdmi-codec.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>

-- 
2.34.1

[PATCH 51/86] drm/i915: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/i915/display/icl_dsi.c            | 2 ++
 drivers/gpu/drm/i915/display/intel_atomic.c       | 1 +
 drivers/gpu/drm/i915/display/intel_atomic_plane.c | 2 ++
 drivers/gpu/drm/i915/display/intel_connector.c    | 1 +
 drivers/gpu/drm/i915/display/intel_crt.c          | 2 ++
 drivers/gpu/drm/i915/display/intel_crtc.c         | 1 +
 drivers/gpu/drm/i915/display/intel_display.c      | 3 +++
 drivers/gpu/drm/i915/display/intel_dp.c           | 2 ++
 drivers/gpu/drm/i915/display/intel_dp_mst.c       | 2 ++
 drivers/gpu/drm/i915/display/intel_dvo.c          | 2 ++
 drivers/gpu/drm/i915/display/intel_hdmi.c         | 2 ++
 drivers/gpu/drm/i915/display/intel_lvds.c         | 2 ++
 drivers/gpu/drm/i915/display/intel_sdvo.c         | 2 ++
 drivers/gpu/drm/i915/display/intel_tv.c           | 2 ++
 drivers/gpu/drm/i915/display/vlv_dsi.c            | 2 ++
 15 files changed, 28 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
index ae14c794c4bc..e5465ec1fe11 100644
--- a/drivers/gpu/drm/i915/display/icl_dsi.c
+++ b/drivers/gpu/drm/i915/display/icl_dsi.c
@@ -27,7 +27,9 @@
 
 #include <drm/display/drm_dsc_helper.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_mipi_dsi.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "i915_reg.h"
 #include "icl_dsi.h"
diff --git a/drivers/gpu/drm/i915/display/intel_atomic.c b/drivers/gpu/drm/i915/display/intel_atomic.c
index a9a3f3715279..7a2a77c2abea 100644
--- a/drivers/gpu/drm/i915/display/intel_atomic.c
+++ b/drivers/gpu/drm/i915/display/intel_atomic.c
@@ -31,6 +31,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_fourcc.h>
 
 #include "i915_drv.h"
diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
index 10e1fc9d0698..acccfd6eb0d9 100644
--- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
+++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
@@ -32,7 +32,9 @@
  */
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_fourcc.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "gt/intel_rps.h"
 
diff --git a/drivers/gpu/drm/i915/display/intel_connector.c b/drivers/gpu/drm/i915/display/intel_connector.c
index 562da3b741e2..754f0999cdee 100644
--- a/drivers/gpu/drm/i915/display/intel_connector.c
+++ b/drivers/gpu/drm/i915/display/intel_connector.c
@@ -27,6 +27,7 @@
 #include <linux/slab.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_edid.h>
 
 #include "i915_drv.h"
diff --git a/drivers/gpu/drm/i915/display/intel_crt.c b/drivers/gpu/drm/i915/display/intel_crt.c
index 7267ffc7f539..1afc57325b9d 100644
--- a/drivers/gpu/drm/i915/display/intel_crt.c
+++ b/drivers/gpu/drm/i915/display/intel_crt.c
@@ -29,8 +29,10 @@
 #include <linux/slab.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
 #include "i915_drv.h"
diff --git a/drivers/gpu/drm/i915/display/intel_crtc.c b/drivers/gpu/drm/i915/display/intel_crtc.c
index 037fc140b585..e652ad01bc44 100644
--- a/drivers/gpu/drm/i915/display/intel_crtc.c
+++ b/drivers/gpu/drm/i915/display/intel_crtc.c
@@ -7,6 +7,7 @@
 #include <linux/slab.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_plane.h>
 #include <drm/drm_vblank_work.h>
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index e75b9b2a0e01..7778c46566d9 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -37,10 +37,13 @@
 #include <drm/display/drm_dp_helper.h>
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_atomic_uapi.h>
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_fourcc.h>
+#include <drm/drm_modeset_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_privacy_screen_consumer.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_rect.h>
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 80d95cec8f9d..aa19c6be03a4 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -35,12 +35,14 @@
 
 #include <asm/byteorder.h>
 
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/display/drm_dp_helper.h>
 #include <drm/display/drm_dsc_helper.h>
 #include <drm/display/drm_hdmi_helper.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
 #include "g4x_dp.h"
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index 8b0e4defa3f1..b030f11578a5 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
@@ -25,7 +25,9 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
 #include "i915_drv.h"
diff --git a/drivers/gpu/drm/i915/display/intel_dvo.c b/drivers/gpu/drm/i915/display/intel_dvo.c
index 4aeae0f3ac91..cdf0c2dd72f3 100644
--- a/drivers/gpu/drm/i915/display/intel_dvo.c
+++ b/drivers/gpu/drm/i915/display/intel_dvo.c
@@ -29,7 +29,9 @@
 #include <linux/slab.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "i915_drv.h"
 #include "i915_reg.h"
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 6a2ee342eab5..5a3ad2fb38ae 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -36,8 +36,10 @@
 #include <drm/display/drm_hdmi_helper.h>
 #include <drm/display/drm_scdc_helper.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/intel_lpe_audio.h>
 
 #include "i915_debugfs.h"
diff --git a/drivers/gpu/drm/i915/display/intel_lvds.c b/drivers/gpu/drm/i915/display/intel_lvds.c
index aecec992cd0d..f049583f05c5 100644
--- a/drivers/gpu/drm/i915/display/intel_lvds.c
+++ b/drivers/gpu/drm/i915/display/intel_lvds.c
@@ -35,8 +35,10 @@
 #include <linux/vga_switcheroo.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "i915_drv.h"
 #include "i915_reg.h"
diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c
index 21805c15d5eb..3c6248eee3a4 100644
--- a/drivers/gpu/drm/i915/display/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
@@ -33,8 +33,10 @@
 
 #include <drm/display/drm_hdmi_helper.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "i915_drv.h"
 #include "i915_reg.h"
diff --git a/drivers/gpu/drm/i915/display/intel_tv.c b/drivers/gpu/drm/i915/display/intel_tv.c
index b986bf075889..a3559ad07734 100644
--- a/drivers/gpu/drm/i915/display/intel_tv.c
+++ b/drivers/gpu/drm/i915/display/intel_tv.c
@@ -31,8 +31,10 @@
  */
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "i915_drv.h"
 #include "i915_reg.h"
diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c b/drivers/gpu/drm/i915/display/vlv_dsi.c
index 662bdb656aa3..9dfe98bf1dfa 100644
--- a/drivers/gpu/drm/i915/display/vlv_dsi.c
+++ b/drivers/gpu/drm/i915/display/vlv_dsi.c
@@ -26,9 +26,11 @@
 #include <linux/slab.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_mipi_dsi.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "i915_drv.h"
 #include "i915_reg.h"

-- 
2.34.1

[PATCH 52/86] drm/imx: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/imx/dcss/dcss-crtc.c         | 2 ++
 drivers/gpu/drm/imx/dcss/dcss-kms.c          | 1 +
 drivers/gpu/drm/imx/dcss/dcss-plane.c        | 2 ++
 drivers/gpu/drm/imx/ipuv3/dw_hdmi-imx.c      | 1 +
 drivers/gpu/drm/imx/ipuv3/imx-drm-core.c     | 2 ++
 drivers/gpu/drm/imx/ipuv3/imx-ldb.c          | 2 ++
 drivers/gpu/drm/imx/ipuv3/imx-tve.c          | 2 ++
 drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c       | 3 +++
 drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c      | 2 ++
 drivers/gpu/drm/imx/ipuv3/parallel-display.c | 2 ++
 10 files changed, 19 insertions(+)

diff --git a/drivers/gpu/drm/imx/dcss/dcss-crtc.c b/drivers/gpu/drm/imx/dcss/dcss-crtc.c
index 31267c00782f..282ea818bafd 100644
--- a/drivers/gpu/drm/imx/dcss/dcss-crtc.c
+++ b/drivers/gpu/drm/imx/dcss/dcss-crtc.c
@@ -5,6 +5,8 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_vblank.h>
 #include <linux/platform_device.h>
 #include <linux/pm_runtime.h>
diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c
index dab5e664920d..ac05c9beec87 100644
--- a/drivers/gpu/drm/imx/dcss/dcss-kms.c
+++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c
@@ -10,6 +10,7 @@
 #include <drm/drm_fbdev_generic.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
diff --git a/drivers/gpu/drm/imx/dcss/dcss-plane.c b/drivers/gpu/drm/imx/dcss/dcss-plane.c
index ab6d32bad756..a2b0ed5edda4 100644
--- a/drivers/gpu/drm/imx/dcss/dcss-plane.c
+++ b/drivers/gpu/drm/imx/dcss/dcss-plane.c
@@ -5,11 +5,13 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_fb_dma_helper.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "dcss-dev.h"
 #include "dcss-kms.h"
diff --git a/drivers/gpu/drm/imx/ipuv3/dw_hdmi-imx.c b/drivers/gpu/drm/imx/ipuv3/dw_hdmi-imx.c
index a2277a0d6d06..127096e7c2c4 100644
--- a/drivers/gpu/drm/imx/ipuv3/dw_hdmi-imx.c
+++ b/drivers/gpu/drm/imx/ipuv3/dw_hdmi-imx.c
@@ -19,6 +19,7 @@
 #include <drm/drm_edid.h>
 #include <drm/drm_encoder.h>
 #include <drm/drm_managed.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_simple_kms_helper.h>
 
diff --git a/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c b/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c
index e060fa6cbcb9..6b7991879ff3 100644
--- a/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c
+++ b/drivers/gpu/drm/imx/ipuv3/imx-drm-core.c
@@ -20,6 +20,8 @@
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_managed.h>
+#include <drm/drm_modeset_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
diff --git a/drivers/gpu/drm/imx/ipuv3/imx-ldb.c b/drivers/gpu/drm/imx/ipuv3/imx-ldb.c
index c45fc8f4744d..bf6d330a36cc 100644
--- a/drivers/gpu/drm/imx/ipuv3/imx-ldb.c
+++ b/drivers/gpu/drm/imx/ipuv3/imx-ldb.c
@@ -22,9 +22,11 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_managed.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_print.h>
diff --git a/drivers/gpu/drm/imx/ipuv3/imx-tve.c b/drivers/gpu/drm/imx/ipuv3/imx-tve.c
index d6832f506322..980537559287 100644
--- a/drivers/gpu/drm/imx/ipuv3/imx-tve.c
+++ b/drivers/gpu/drm/imx/ipuv3/imx-tve.c
@@ -18,8 +18,10 @@
 #include <video/imx-ipu-v3.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_managed.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>
 
diff --git a/drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c b/drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c
index 5f26090b0c98..10c9c5922705 100644
--- a/drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c
+++ b/drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c
@@ -18,8 +18,11 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
+#include <drm/drm_encoder.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_managed.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
 
diff --git a/drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c
index 80142d9a4a55..e1d55f29d006 100644
--- a/drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c
+++ b/drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c
@@ -7,6 +7,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_fb_dma_helper.h>
 #include <drm/drm_fourcc.h>
@@ -14,6 +15,7 @@
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_managed.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include <video/imx-ipu-v3.h>
 
diff --git a/drivers/gpu/drm/imx/ipuv3/parallel-display.c b/drivers/gpu/drm/imx/ipuv3/parallel-display.c
index 0fa0b590830b..38101ba7a76d 100644
--- a/drivers/gpu/drm/imx/ipuv3/parallel-display.c
+++ b/drivers/gpu/drm/imx/ipuv3/parallel-display.c
@@ -15,9 +15,11 @@
 #include <video/of_display_timing.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_managed.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_probe_helper.h>

-- 
2.34.1

Re: [PATCH 52/86] drm/imx: Direct include headers from drm_atomic_helper

[Philipp Zabel]

On Sat, Jan 21, 2023 at 09:08:30PM +0100, Sam Ravnborg via B4 Submission Endpoint wrote:
> From: Sam Ravnborg <sam@ravnborg.org>
> 
> Direct include the headers that otherwise comes indirect from
> drm_atomic_helper, because drm_atomic_helper will be reduced to
> include only the minimal set of headers.
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp

[PATCH 53/86] drm/ingenic: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 3 +++
 drivers/gpu/drm/ingenic/ingenic-ipu.c     | 2 ++
 2 files changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
index 5ec75e9ba499..7eebb8bff515 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
+++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
@@ -22,6 +22,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_bridge_connector.h>
 #include <drm/drm_color_mgmt.h>
@@ -37,6 +38,8 @@
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_managed.h>
+#include <drm/drm_modeset_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_plane.h>
diff --git a/drivers/gpu/drm/ingenic/ingenic-ipu.c b/drivers/gpu/drm/ingenic/ingenic-ipu.c
index 7a43505011a5..a8875cbae32a 100644
--- a/drivers/gpu/drm/ingenic/ingenic-ipu.c
+++ b/drivers/gpu/drm/ingenic/ingenic-ipu.c
@@ -20,6 +20,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_fb_dma_helper.h>
@@ -28,6 +29,7 @@
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_plane.h>
 #include <drm/drm_property.h>
 #include <drm/drm_vblank.h>

-- 
2.34.1

[PATCH 54/86] drm/kmb: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/kmb/kmb_crtc.c  | 1 +
 drivers/gpu/drm/kmb/kmb_drv.h   | 1 +
 drivers/gpu/drm/kmb/kmb_plane.c | 2 ++
 3 files changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/kmb/kmb_crtc.c b/drivers/gpu/drm/kmb/kmb_crtc.c
index 647872f65bff..b1b51b923928 100644
--- a/drivers/gpu/drm/kmb/kmb_crtc.c
+++ b/drivers/gpu/drm/kmb/kmb_crtc.c
@@ -7,6 +7,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_print.h>
 #include <drm/drm_vblank.h>
diff --git a/drivers/gpu/drm/kmb/kmb_drv.h b/drivers/gpu/drm/kmb/kmb_drv.h
index bf085e95b28f..846164236f9c 100644
--- a/drivers/gpu/drm/kmb/kmb_drv.h
+++ b/drivers/gpu/drm/kmb/kmb_drv.h
@@ -7,6 +7,7 @@
 #define __KMB_DRV_H__
 
 #include <drm/drm_device.h>
+#include <drm/drm_crtc.h>
 
 #include "kmb_plane.h"
 #include "kmb_regs.h"
diff --git a/drivers/gpu/drm/kmb/kmb_plane.c b/drivers/gpu/drm/kmb/kmb_plane.c
index 9e0562aa2bcb..362b8b1ea54a 100644
--- a/drivers/gpu/drm/kmb/kmb_plane.c
+++ b/drivers/gpu/drm/kmb/kmb_plane.c
@@ -5,6 +5,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_fb_dma_helper.h>
@@ -12,6 +13,7 @@
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_managed.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "kmb_drv.h"
 #include "kmb_plane.h"

-- 
2.34.1

[PATCH 55/86] drm/logicvc: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/logicvc/logicvc_crtc.c      | 2 ++
 drivers/gpu/drm/logicvc/logicvc_crtc.h      | 2 ++
 drivers/gpu/drm/logicvc/logicvc_interface.c | 1 +
 drivers/gpu/drm/logicvc/logicvc_layer.c     | 2 ++
 4 files changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/logicvc/logicvc_crtc.c b/drivers/gpu/drm/logicvc/logicvc_crtc.c
index 43a675d03808..83b882b28be4 100644
--- a/drivers/gpu/drm/logicvc/logicvc_crtc.c
+++ b/drivers/gpu/drm/logicvc/logicvc_crtc.c
@@ -10,9 +10,11 @@
 #include <linux/workqueue.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_gem_dma_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 #include <drm/drm_vblank.h>
 
diff --git a/drivers/gpu/drm/logicvc/logicvc_crtc.h b/drivers/gpu/drm/logicvc/logicvc_crtc.h
index b122901f2936..1134dd2519ab 100644
--- a/drivers/gpu/drm/logicvc/logicvc_crtc.h
+++ b/drivers/gpu/drm/logicvc/logicvc_crtc.h
@@ -7,6 +7,8 @@
 #ifndef _LOGICVC_CRTC_H_
 #define _LOGICVC_CRTC_H_
 
+#include <drm/drm_crtc.h>
+
 struct drm_pending_vblank_event;
 struct logicvc_drm;
 
diff --git a/drivers/gpu/drm/logicvc/logicvc_interface.c b/drivers/gpu/drm/logicvc/logicvc_interface.c
index 689049d395c0..a4f01bd3aec3 100644
--- a/drivers/gpu/drm/logicvc/logicvc_interface.c
+++ b/drivers/gpu/drm/logicvc/logicvc_interface.c
@@ -7,6 +7,7 @@
 #include <linux/types.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_connector.h>
 #include <drm/drm_drv.h>
diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c b/drivers/gpu/drm/logicvc/logicvc_layer.c
index 464000aea765..8f6b292b8bf7 100644
--- a/drivers/gpu/drm/logicvc/logicvc_layer.c
+++ b/drivers/gpu/drm/logicvc/logicvc_layer.c
@@ -9,10 +9,12 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_fb_dma_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_plane.h>
 #include <drm/drm_print.h>
 

-- 
2.34.1

[PATCH 56/86] drm/mcde: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/mcde/mcde_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c
index 4aedb050d2a5..457b80e1c75c 100644
--- a/drivers/gpu/drm/mcde/mcde_drv.c
+++ b/drivers/gpu/drm/mcde/mcde_drv.c
@@ -74,6 +74,7 @@
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_managed.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_panel.h>

-- 
2.34.1

[PATCH 57/86] drm/mediatek: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/mediatek/mtk_dp.c        | 1 +
 drivers/gpu/drm/mediatek/mtk_dpi.c       | 1 +
 drivers/gpu/drm/mediatek/mtk_drm_crtc.c  | 2 ++
 drivers/gpu/drm/mediatek/mtk_drm_drv.c   | 2 ++
 drivers/gpu/drm/mediatek/mtk_drm_plane.c | 3 +++
 drivers/gpu/drm/mediatek/mtk_dsi.c       | 1 +
 drivers/gpu/drm/mediatek/mtk_hdmi.c      | 1 +
 7 files changed, 11 insertions(+)

diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c
index b4feaabdb6a7..bd4eb2445551 100644
--- a/drivers/gpu/drm/mediatek/mtk_dp.c
+++ b/drivers/gpu/drm/mediatek/mtk_dp.c
@@ -7,6 +7,7 @@
 #include <drm/display/drm_dp.h>
 #include <drm/display/drm_dp_helper.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_edid.h>
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index 4317595a15d1..f21a5747f038 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -19,6 +19,7 @@
 #include <video/videomode.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_bridge_connector.h>
 #include <drm/drm_crtc.h>
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
index 112615817dcb..76c091ef9702 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
@@ -15,6 +15,8 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
 
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index cd5b18ef7951..d6a33eaf5605 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -22,6 +22,8 @@
 #include <drm/drm_gem.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_modeset_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
index d54fbf34b000..3345610a5e18 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
@@ -6,11 +6,14 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_atomic_uapi.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
+
 #include <linux/align.h>
 
 #include "mtk_drm_crtc.h"
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index 3b7d13028fb6..e263687b6ffb 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -17,6 +17,7 @@
 #include <video/videomode.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_bridge_connector.h>
 #include <drm/drm_mipi_dsi.h>
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
index 0a8e0a13f516..b33b1407801d 100644
--- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
+++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
@@ -24,6 +24,7 @@
 #include <sound/hdmi-codec.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_edid.h>

-- 
2.34.1

[PATCH 58/86] drm/meson: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/meson/meson_crtc.c         | 3 +++
 drivers/gpu/drm/meson/meson_drv.c          | 1 +
 drivers/gpu/drm/meson/meson_encoder_cvbs.c | 1 +
 drivers/gpu/drm/meson/meson_encoder_hdmi.c | 1 +
 drivers/gpu/drm/meson/meson_overlay.c      | 2 ++
 drivers/gpu/drm/meson/meson_plane.c        | 2 ++
 6 files changed, 10 insertions(+)

diff --git a/drivers/gpu/drm/meson/meson_crtc.c b/drivers/gpu/drm/meson/meson_crtc.c
index d70616da8ce2..d2f677ee13ef 100644
--- a/drivers/gpu/drm/meson/meson_crtc.c
+++ b/drivers/gpu/drm/meson/meson_crtc.c
@@ -13,7 +13,10 @@
 #include <linux/soc/amlogic/meson-canvas.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
+#include <drm/drm_crtc.h>
 #include <drm/drm_device.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
index 79bfe3938d3c..eff20c9bfc7e 100644
--- a/drivers/gpu/drm/meson/meson_drv.c
+++ b/drivers/gpu/drm/meson/meson_drv.c
@@ -21,6 +21,7 @@
 #include <drm/drm_fbdev_generic.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_modeset_helper.h>
 #include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_module.h>
 #include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/meson/meson_encoder_cvbs.c b/drivers/gpu/drm/meson/meson_encoder_cvbs.c
index 3f73b211fa8e..6d3d9c53efa9 100644
--- a/drivers/gpu/drm/meson/meson_encoder_cvbs.c
+++ b/drivers/gpu/drm/meson/meson_encoder_cvbs.c
@@ -13,6 +13,7 @@
 #include <linux/of_graph.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_bridge_connector.h>
 #include <drm/drm_device.h>
diff --git a/drivers/gpu/drm/meson/meson_encoder_hdmi.c b/drivers/gpu/drm/meson/meson_encoder_hdmi.c
index 53231bfdf7e2..db27a59223b8 100644
--- a/drivers/gpu/drm/meson/meson_encoder_hdmi.c
+++ b/drivers/gpu/drm/meson/meson_encoder_hdmi.c
@@ -17,6 +17,7 @@
 #include <media/cec-notifier.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_bridge_connector.h>
 #include <drm/drm_device.h>
diff --git a/drivers/gpu/drm/meson/meson_overlay.c b/drivers/gpu/drm/meson/meson_overlay.c
index 7f98de38842b..756b65dd63d2 100644
--- a/drivers/gpu/drm/meson/meson_overlay.c
+++ b/drivers/gpu/drm/meson/meson_overlay.c
@@ -9,6 +9,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_device.h>
 #include <drm/drm_fb_dma_helper.h>
@@ -16,6 +17,7 @@
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "meson_overlay.h"
 #include "meson_registers.h"
diff --git a/drivers/gpu/drm/meson/meson_plane.c b/drivers/gpu/drm/meson/meson_plane.c
index 815dfe30492b..f6b81d50738f 100644
--- a/drivers/gpu/drm/meson/meson_plane.c
+++ b/drivers/gpu/drm/meson/meson_plane.c
@@ -13,6 +13,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_device.h>
 #include <drm/drm_fb_dma_helper.h>
@@ -20,6 +21,7 @@
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "meson_plane.h"
 #include "meson_registers.h"

-- 
2.34.1

[PATCH 59/86] drm/mgag200: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/mgag200/mgag200_g200.c    | 2 ++
 drivers/gpu/drm/mgag200/mgag200_g200eh.c  | 2 ++
 drivers/gpu/drm/mgag200/mgag200_g200eh3.c | 2 ++
 drivers/gpu/drm/mgag200/mgag200_g200er.c  | 2 ++
 drivers/gpu/drm/mgag200/mgag200_g200ev.c  | 2 ++
 drivers/gpu/drm/mgag200/mgag200_g200ew3.c | 2 ++
 drivers/gpu/drm/mgag200/mgag200_g200se.c  | 2 ++
 drivers/gpu/drm/mgag200/mgag200_g200wb.c  | 2 ++
 drivers/gpu/drm/mgag200/mgag200_mode.c    | 2 ++
 9 files changed, 18 insertions(+)

diff --git a/drivers/gpu/drm/mgag200/mgag200_g200.c b/drivers/gpu/drm/mgag200/mgag200_g200.c
index bf5d7fe525a3..646e17d7e1d2 100644
--- a/drivers/gpu/drm/mgag200/mgag200_g200.c
+++ b/drivers/gpu/drm/mgag200/mgag200_g200.c
@@ -5,8 +5,10 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_gem_atomic_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
 #include "mgag200_drv.h"
diff --git a/drivers/gpu/drm/mgag200/mgag200_g200eh.c b/drivers/gpu/drm/mgag200/mgag200_g200eh.c
index fad62453a91d..bc75d711d833 100644
--- a/drivers/gpu/drm/mgag200/mgag200_g200eh.c
+++ b/drivers/gpu/drm/mgag200/mgag200_g200eh.c
@@ -5,8 +5,10 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_gem_atomic_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
 #include "mgag200_drv.h"
diff --git a/drivers/gpu/drm/mgag200/mgag200_g200eh3.c b/drivers/gpu/drm/mgag200/mgag200_g200eh3.c
index 0f7d8112cd49..4ef9dc37b4bc 100644
--- a/drivers/gpu/drm/mgag200/mgag200_g200eh3.c
+++ b/drivers/gpu/drm/mgag200/mgag200_g200eh3.c
@@ -4,8 +4,10 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_gem_atomic_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
 #include "mgag200_drv.h"
diff --git a/drivers/gpu/drm/mgag200/mgag200_g200er.c b/drivers/gpu/drm/mgag200/mgag200_g200er.c
index bce267e0f7de..bccf602c7ac8 100644
--- a/drivers/gpu/drm/mgag200/mgag200_g200er.c
+++ b/drivers/gpu/drm/mgag200/mgag200_g200er.c
@@ -5,8 +5,10 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_gem_atomic_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
 #include "mgag200_drv.h"
diff --git a/drivers/gpu/drm/mgag200/mgag200_g200ev.c b/drivers/gpu/drm/mgag200/mgag200_g200ev.c
index ac957f42abe1..fbf98a93d5c7 100644
--- a/drivers/gpu/drm/mgag200/mgag200_g200ev.c
+++ b/drivers/gpu/drm/mgag200/mgag200_g200ev.c
@@ -5,8 +5,10 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_gem_atomic_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
 #include "mgag200_drv.h"
diff --git a/drivers/gpu/drm/mgag200/mgag200_g200ew3.c b/drivers/gpu/drm/mgag200/mgag200_g200ew3.c
index 170934414d7d..16f745716394 100644
--- a/drivers/gpu/drm/mgag200/mgag200_g200ew3.c
+++ b/drivers/gpu/drm/mgag200/mgag200_g200ew3.c
@@ -4,8 +4,10 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_gem_atomic_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
 #include "mgag200_drv.h"
diff --git a/drivers/gpu/drm/mgag200/mgag200_g200se.c b/drivers/gpu/drm/mgag200/mgag200_g200se.c
index bd6e573c9a1a..e279f9d05c1e 100644
--- a/drivers/gpu/drm/mgag200/mgag200_g200se.c
+++ b/drivers/gpu/drm/mgag200/mgag200_g200se.c
@@ -5,8 +5,10 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_gem_atomic_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
 #include "mgag200_drv.h"
diff --git a/drivers/gpu/drm/mgag200/mgag200_g200wb.c b/drivers/gpu/drm/mgag200/mgag200_g200wb.c
index 9baa727ac6f9..bd4c1b630458 100644
--- a/drivers/gpu/drm/mgag200/mgag200_g200wb.c
+++ b/drivers/gpu/drm/mgag200/mgag200_g200wb.c
@@ -5,8 +5,10 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_gem_atomic_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
 #include "mgag200_drv.h"
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
index 0a5aaf78172a..5ed071989910 100644
--- a/drivers/gpu/drm/mgag200/mgag200_mode.c
+++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
@@ -13,12 +13,14 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_format_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
 

-- 
2.34.1

[PATCH 60/86] drm/msm: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c            | 2 ++
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c         | 1 +
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c             | 1 +
 drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c           | 2 ++
 drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c       | 2 ++
 drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c           | 2 ++
 drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c    | 1 +
 drivers/gpu/drm/msm/disp/mdp4/mdp4_dtv_encoder.c    | 2 ++
 drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c            | 1 +
 drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c   | 2 ++
 drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_connector.c | 3 +++
 drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c          | 2 ++
 drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c           | 2 ++
 drivers/gpu/drm/msm/disp/mdp5/mdp5_encoder.c        | 1 +
 drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c            | 1 +
 drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.h            | 2 ++
 drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c          | 2 ++
 drivers/gpu/drm/msm/dp/dp_drm.c                     | 1 +
 drivers/gpu/drm/msm/msm_drv.c                       | 2 ++
 drivers/gpu/drm/msm/msm_fb.c                        | 1 +
 20 files changed, 33 insertions(+)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
index 13ce321283ff..3f56cdd5a50c 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
@@ -13,11 +13,13 @@
 #include <linux/bits.h>
 
 #include <drm/drm_atomic.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_flip_work.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_mode.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_rect.h>
 #include <drm/drm_vblank.h>
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
index 9c6817b5a194..cf6108687144 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
@@ -14,6 +14,7 @@
 
 #include <drm/drm_crtc.h>
 #include <drm/drm_file.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
 #include "msm_drv.h"
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
index b71199511a52..8e910127511c 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
@@ -14,6 +14,7 @@
 #include <linux/of_irq.h>
 #include <linux/pm_opp.h>
 
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_file.h>
 #include <drm/drm_framebuffer.h>
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
index 86719020afe2..3827538dd93b 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
@@ -11,11 +11,13 @@
 #include <linux/dma-buf.h>
 
 #include <drm/drm_atomic.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_atomic_uapi.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "msm_drv.h"
 #include "dpu_kms.h"
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c
index 088ec990a2f2..9eae9687a006 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c
@@ -3,7 +3,9 @@
  * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  */
 
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "dpu_writeback.h"
 
diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c
index 169f9de4a12a..814da839b027 100644
--- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c
+++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c
@@ -4,9 +4,11 @@
  * Author: Rob Clark <robdclark@gmail.com>
  */
 
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_flip_work.h>
 #include <drm/drm_mode.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
 
diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c
index 39b8fe53c29d..4aca7a143bb1 100644
--- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c
+++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c
@@ -7,6 +7,7 @@
  */
 
 #include <drm/drm_crtc.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
 #include "mdp4_kms.h"
diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_dtv_encoder.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_dtv_encoder.c
index 88645dbc3785..0acea1f03378 100644
--- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_dtv_encoder.c
+++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_dtv_encoder.c
@@ -5,6 +5,8 @@
  */
 
 #include <drm/drm_crtc.h>
+#include <drm/drm_encoder.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
 #include "mdp4_kms.h"
diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
index 9a1a0769575d..e28a1eb83b7d 100644
--- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
+++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
@@ -6,6 +6,7 @@
 
 #include <linux/delay.h>
 
+#include <drm/drm_encoder.h>
 #include <drm/drm_vblank.h>
 
 #include "msm_drv.h"
diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c
index 10eb3e5b218e..fc232263c870 100644
--- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c
+++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c
@@ -8,6 +8,8 @@
 #include <linux/delay.h>
 
 #include <drm/drm_crtc.h>
+#include <drm/drm_encoder.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
 #include "mdp4_kms.h"
diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_connector.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_connector.c
index 7444b75c4215..a61d3f251a77 100644
--- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_connector.c
+++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_connector.c
@@ -5,6 +5,9 @@
  * Author: Vinay Simha <vinaysimha@inforcecomputing.com>
  */
 
+#include <drm/drm_atomic_state_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
+
 #include "mdp4_kms.h"
 
 struct mdp4_lvds_connector {
diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c
index b689b618da78..169d3c56e049 100644
--- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c
+++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c
@@ -5,10 +5,12 @@
  */
 
 #include <drm/drm_atomic.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "mdp4_kms.h"
 
diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c
index e86421c69bd1..ebe4f87c7595 100644
--- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c
+++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c
@@ -8,11 +8,13 @@
 #include <linux/sort.h>
 
 #include <drm/drm_atomic.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_mode.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_flip_work.h>
 #include <drm/drm_fourcc.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
 
diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_encoder.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_encoder.c
index 79d67c495780..c371c770fb4f 100644
--- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_encoder.c
+++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_encoder.c
@@ -6,6 +6,7 @@
  */
 
 #include <drm/drm_crtc.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
 #include "mdp5_kms.h"
diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
index 29ae5c9613f3..2e59aad43ebe 100644
--- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
+++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
@@ -9,6 +9,7 @@
 #include <linux/interconnect.h>
 #include <linux/of_irq.h>
 
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_debugfs.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_file.h>
diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.h b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.h
index 29bf11f08601..ef9a112cb7bc 100644
--- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.h
+++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.h
@@ -7,6 +7,8 @@
 #ifndef __MDP5_KMS_H__
 #define __MDP5_KMS_H__
 
+#include <drm/drm_encoder.h>
+
 #include "msm_drv.h"
 #include "msm_kms.h"
 #include "disp/mdp_kms.h"
diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c
index bd2c4ac45601..3f05154c3c0c 100644
--- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c
+++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c
@@ -6,11 +6,13 @@
  */
 
 #include <drm/drm_atomic.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 
 #include "mdp5_kms.h"
diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c
index 6db82f9b03af..c3105c02436b 100644
--- a/drivers/gpu/drm/msm/dp/dp_drm.c
+++ b/drivers/gpu/drm/msm/dp/dp_drm.c
@@ -5,6 +5,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_atomic.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_bridge_connector.h>
 #include <drm/drm_crtc.h>
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 8b0b0ac74a6f..ec132e99e0fc 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -16,6 +16,8 @@
 #include <drm/drm_drv.h>
 #include <drm/drm_file.h>
 #include <drm/drm_ioctl.h>
+#include <drm/drm_modeset_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_prime.h>
 #include <drm/drm_of.h>
 #include <drm/drm_vblank.h>
diff --git a/drivers/gpu/drm/msm/msm_fb.c b/drivers/gpu/drm/msm/msm_fb.c
index e3f61c39df69..b42085c6e7b4 100644
--- a/drivers/gpu/drm/msm/msm_fb.c
+++ b/drivers/gpu/drm/msm/msm_fb.c
@@ -10,6 +10,7 @@
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_modeset_helper.h>
 #include <drm/drm_probe_helper.h>
 
 #include "msm_drv.h"

-- 
2.34.1

[PATCH 61/86] drm/mxsfb: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/mxsfb/lcdif_drv.c | 2 ++
 drivers/gpu/drm/mxsfb/lcdif_kms.c | 2 ++
 drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 ++
 drivers/gpu/drm/mxsfb/mxsfb_kms.c | 2 ++
 4 files changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdif_drv.c
index cc2ceb301b96..decb084ec90d 100644
--- a/drivers/gpu/drm/mxsfb/lcdif_drv.c
+++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c
@@ -20,6 +20,8 @@
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_mode_config.h>
+#include <drm/drm_modeset_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_module.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c b/drivers/gpu/drm/mxsfb/lcdif_kms.c
index 262bc43b1079..47abc62a28b8 100644
--- a/drivers/gpu/drm/mxsfb/lcdif_kms.c
+++ b/drivers/gpu/drm/mxsfb/lcdif_kms.c
@@ -15,6 +15,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_color_mgmt.h>
 #include <drm/drm_crtc.h>
@@ -24,6 +25,7 @@
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_plane.h>
 #include <drm/drm_vblank.h>
 
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index b3ab86ad1b36..420aec63acc4 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -25,6 +25,8 @@
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_mode_config.h>
+#include <drm/drm_modeset_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_module.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c b/drivers/gpu/drm/mxsfb/mxsfb_kms.c
index 3bcc9c0f2019..020847f02b41 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_kms.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_kms.c
@@ -17,6 +17,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_encoder.h>
@@ -25,6 +26,7 @@
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_plane.h>
 #include <drm/drm_vblank.h>
 

-- 
2.34.1

[PATCH 62/86] drm/nouveau: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/nouveau/dispnv50/disp.c     | 1 +
 drivers/gpu/drm/nouveau/dispnv50/head.c     | 2 ++
 drivers/gpu/drm/nouveau/dispnv50/wndw.c     | 2 ++
 drivers/gpu/drm/nouveau/nouveau_connector.c | 2 ++
 drivers/gpu/drm/nouveau/nouveau_display.c   | 1 +
 5 files changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index edcb2529b402..51c420b5af9e 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
@@ -39,6 +39,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_fb_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
 
diff --git a/drivers/gpu/drm/nouveau/dispnv50/head.c b/drivers/gpu/drm/nouveau/dispnv50/head.c
index 5f490fbf1877..0c01b3d65a26 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/head.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/head.c
@@ -32,6 +32,8 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_vblank.h>
 #include "nouveau_connector.h"
 
diff --git a/drivers/gpu/drm/nouveau/dispnv50/wndw.c b/drivers/gpu/drm/nouveau/dispnv50/wndw.c
index 7a2cceaee6e9..4cf6440da911 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/wndw.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/wndw.c
@@ -32,9 +32,11 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_fourcc.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "nouveau_bo.h"
 #include "nouveau_gem.h"
diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c
index 086b66b60d91..d3de721e5614 100644
--- a/drivers/gpu/drm/nouveau/nouveau_connector.c
+++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
@@ -30,8 +30,10 @@
 #include <linux/vga_switcheroo.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_crtc_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_atomic.h>
 
diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
index ec3ffff487fc..c94158389cee 100644
--- a/drivers/gpu/drm/nouveau/nouveau_display.c
+++ b/drivers/gpu/drm/nouveau/nouveau_display.c
@@ -32,6 +32,7 @@
 #include <drm/drm_fb_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_modeset_helper.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
 

-- 
2.34.1

[PATCH 63/86] drm/omapdrm: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/omapdrm/omap_crtc.c  | 2 ++
 drivers/gpu/drm/omapdrm/omap_drv.c   | 3 +++
 drivers/gpu/drm/omapdrm/omap_plane.c | 2 ++
 3 files changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c b/drivers/gpu/drm/omapdrm/omap_crtc.c
index 63ddc5127f7b..9d91b7872432 100644
--- a/drivers/gpu/drm/omapdrm/omap_crtc.c
+++ b/drivers/gpu/drm/omapdrm/omap_crtc.c
@@ -8,8 +8,10 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_mode.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_vblank.h>
 
 #include "omap_drv.h"
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
index 699ed814e021..0cf9bd9c2d15 100644
--- a/drivers/gpu/drm/omapdrm/omap_drv.c
+++ b/drivers/gpu/drm/omapdrm/omap_drv.c
@@ -11,12 +11,15 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_bridge_connector.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_fb_helper.h>
 #include <drm/drm_file.h>
 #include <drm/drm_ioctl.h>
+#include <drm/drm_modeset_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_prime.h>
 #include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c b/drivers/gpu/drm/omapdrm/omap_plane.c
index 24a2ded08b45..a12f6b50efc0 100644
--- a/drivers/gpu/drm/omapdrm/omap_plane.c
+++ b/drivers/gpu/drm/omapdrm/omap_plane.c
@@ -6,10 +6,12 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "omap_dmm_tiler.h"
 #include "omap_drv.h"

-- 
2.34.1

[PATCH 64/86] drm/qxl: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/qxl/qxl_display.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
index 6492a70e3c39..b73e8c93c64f 100644
--- a/drivers/gpu/drm/qxl/qxl_display.c
+++ b/drivers/gpu/drm/qxl/qxl_display.c
@@ -30,9 +30,11 @@
 #include <drm/drm_drv.h>
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_plane_helper.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>

-- 
2.34.1

[PATCH 65/86] drm/rcar-du: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/rcar-du/rcar_du_crtc.c      | 2 ++
 drivers/gpu/drm/rcar-du/rcar_du_drv.c       | 1 +
 drivers/gpu/drm/rcar-du/rcar_du_kms.c       | 1 +
 drivers/gpu/drm/rcar-du/rcar_du_plane.c     | 2 ++
 drivers/gpu/drm/rcar-du/rcar_du_vsp.c       | 2 ++
 drivers/gpu/drm/rcar-du/rcar_du_writeback.c | 2 ++
 drivers/gpu/drm/rcar-du/rcar_lvds.c         | 1 +
 drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c     | 1 +
 drivers/gpu/drm/rcar-du/rzg2l_mipi_dsi.c    | 1 +
 9 files changed, 13 insertions(+)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
index 3619e1ddeb62..039e88579c6c 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
@@ -14,10 +14,12 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_device.h>
 #include <drm/drm_gem_dma_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_vblank.h>
 
 #include "rcar_cmm.h"
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index eeec1e02446f..b167164f3889 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -23,6 +23,7 @@
 #include <drm/drm_fbdev_generic.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_managed.h>
+#include <drm/drm_modeset_helper.h>
 #include <drm/drm_probe_helper.h>
 
 #include "rcar_du_drv.h"
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
index 8c2719efda2a..1dffbbad264c 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
@@ -15,6 +15,7 @@
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_managed.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
 
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
index d759e0192181..01b6e5f72e18 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
@@ -9,6 +9,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_device.h>
@@ -16,6 +17,7 @@
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_dma_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "rcar_du_drv.h"
 #include "rcar_du_group.h"
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
index e465aef41585..36e9d692017e 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
@@ -9,6 +9,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_fb_dma_helper.h>
@@ -17,6 +18,7 @@
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_managed.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_vblank.h>
 
 #include <linux/bitops.h>
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
index 8cd37d7b8ae2..67bb10a99883 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
@@ -6,10 +6,12 @@
  */
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_device.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_writeback.h>
 
diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
index 81a060c2fe3f..7c0530b57ff3 100644
--- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
+++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
@@ -21,6 +21,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
diff --git a/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c b/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c
index a7f2b7f66a17..d08b8d3eea3e 100644
--- a/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c
+++ b/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c
@@ -19,6 +19,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_mipi_dsi.h>
 #include <drm/drm_of.h>
diff --git a/drivers/gpu/drm/rcar-du/rzg2l_mipi_dsi.c b/drivers/gpu/drm/rcar-du/rzg2l_mipi_dsi.c
index aa95b85a2964..7f2056d5ed9c 100644
--- a/drivers/gpu/drm/rcar-du/rzg2l_mipi_dsi.c
+++ b/drivers/gpu/drm/rcar-du/rzg2l_mipi_dsi.c
@@ -19,6 +19,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_mipi_dsi.h>
 #include <drm/drm_of.h>

-- 
2.34.1

[PATCH 66/86] drm/rockchip: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 ++
 drivers/gpu/drm/rockchip/cdn-dp-core.c          | 2 ++
 drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 1 +
 drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c     | 1 +
 drivers/gpu/drm/rockchip/inno_hdmi.c            | 2 ++
 drivers/gpu/drm/rockchip/rk3066_hdmi.c          | 2 ++
 drivers/gpu/drm/rockchip/rockchip_drm_drv.c     | 1 +
 drivers/gpu/drm/rockchip/rockchip_drm_drv.h     | 1 +
 drivers/gpu/drm/rockchip/rockchip_drm_fb.c      | 1 +
 drivers/gpu/drm/rockchip/rockchip_drm_vop.c     | 2 ++
 drivers/gpu/drm/rockchip/rockchip_drm_vop2.c    | 2 ++
 drivers/gpu/drm/rockchip/rockchip_lvds.c        | 2 ++
 drivers/gpu/drm/rockchip/rockchip_rgb.c         | 1 +
 13 files changed, 20 insertions(+)

diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
index ad2d3ae7e621..2e23903888e4 100644
--- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
+++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
@@ -22,6 +22,8 @@
 #include <drm/display/drm_dp_helper.h>
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/bridge/analogix_dp.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index 8526dda91931..8f8f4ceede83 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
@@ -17,7 +17,9 @@
 
 #include <drm/display/drm_dp_helper.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>
diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
index 7901c3babc8c..6a5fb96d5fc4 100644
--- a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
+++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
@@ -20,6 +20,7 @@
 
 #include <drm/bridge/dw_mipi_dsi.h>
 #include <drm/drm_mipi_dsi.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_simple_kms_helper.h>
 
diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
index 2f4b8f64cbad..bb4727d3eb91 100644
--- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
+++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
@@ -13,6 +13,7 @@
 
 #include <drm/bridge/dw_hdmi.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>
diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c
index f51774866f41..8904fa689e5a 100644
--- a/drivers/gpu/drm/rockchip/inno_hdmi.c
+++ b/drivers/gpu/drm/rockchip/inno_hdmi.c
@@ -16,7 +16,9 @@
 #include <linux/of_device.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>
diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c
index 90145ad96984..4645faa82914 100644
--- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c
+++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c
@@ -4,7 +4,9 @@
  *    Zheng Yang <zhengyang@rock-chips.com>
  */
 
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
index 6e0788d14c10..5d20206e3a09 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
@@ -19,6 +19,7 @@
 #include <drm/drm_drv.h>
 #include <drm/drm_fbdev_generic.h>
 #include <drm/drm_gem_dma_helper.h>
+#include <drm/drm_modeset_helper.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.h b/drivers/gpu/drm/rockchip/rockchip_drm_drv.h
index aeb03a57240f..9dd7c551bf72 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.h
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.h
@@ -10,6 +10,7 @@
 #define _ROCKCHIP_DRM_DRV_H
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_encoder.h>
 #include <drm/drm_gem.h>
 
 #include <linux/i2c.h>
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
index cfe8b793d344..b3560ad2ec5e 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
@@ -12,6 +12,7 @@
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
 #include "rockchip_drm_drv.h"
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index fa1f4ee6d195..43a92681ef25 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
@@ -20,6 +20,7 @@
 
 #include <drm/drm.h>
 #include <drm/drm_atomic.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_atomic_uapi.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_crtc.h>
@@ -28,6 +29,7 @@
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_self_refresh_helper.h>
 #include <drm/drm_vblank.h>
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
index ba3b81789509..30e632c4c9b1 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
@@ -22,12 +22,14 @@
 
 #include <drm/drm.h>
 #include <drm/drm_atomic.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_atomic_uapi.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_debugfs.h>
 #include <drm/drm_flip_work.h>
 #include <drm/drm_framebuffer.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
 
diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c
index 68f6ebb33460..868b52e3e575 100644
--- a/drivers/gpu/drm/rockchip/rockchip_lvds.c
+++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c
@@ -19,8 +19,10 @@
 
 #include <drm/display/drm_dp_helper.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_bridge_connector.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/rockchip/rockchip_rgb.c b/drivers/gpu/drm/rockchip/rockchip_rgb.c
index 75eb7cca3d82..dd4159d889d7 100644
--- a/drivers/gpu/drm/rockchip/rockchip_rgb.c
+++ b/drivers/gpu/drm/rockchip/rockchip_rgb.c
@@ -13,6 +13,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_bridge_connector.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_probe_helper.h>

-- 
2.34.1

[PATCH 67/86] drm/solomon: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/solomon/ssd130x.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c
index c3bf3a18302e..be097de66c84 100644
--- a/drivers/gpu/drm/solomon/ssd130x.c
+++ b/drivers/gpu/drm/solomon/ssd130x.c
@@ -20,6 +20,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_edid.h>
@@ -31,6 +32,7 @@
 #include <drm/drm_gem_shmem_helper.h>
 #include <drm/drm_managed.h>
 #include <drm/drm_modes.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_rect.h>
 #include <drm/drm_probe_helper.h>
 

-- 
2.34.1

[PATCH 68/86] drm/sprd: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/sprd/sprd_dpu.c | 2 ++
 drivers/gpu/drm/sprd/sprd_drm.c | 1 +
 drivers/gpu/drm/sprd/sprd_dsi.c | 1 +
 3 files changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/sprd/sprd_dpu.c b/drivers/gpu/drm/sprd/sprd_dpu.c
index b96fc6837b0d..db8b9e75f260 100644
--- a/drivers/gpu/drm/sprd/sprd_dpu.c
+++ b/drivers/gpu/drm/sprd/sprd_dpu.c
@@ -17,11 +17,13 @@
 #include <linux/workqueue.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_fb_dma_helper.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "sprd_drm.h"
 #include "sprd_dpu.h"
diff --git a/drivers/gpu/drm/sprd/sprd_drm.c b/drivers/gpu/drm/sprd/sprd_drm.c
index be60c0d546a3..0563b4ba1fdd 100644
--- a/drivers/gpu/drm/sprd/sprd_drm.c
+++ b/drivers/gpu/drm/sprd/sprd_drm.c
@@ -14,6 +14,7 @@
 #include <drm/drm_drv.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
diff --git a/drivers/gpu/drm/sprd/sprd_dsi.c b/drivers/gpu/drm/sprd/sprd_dsi.c
index ab0e5cce7adb..b00b09405795 100644
--- a/drivers/gpu/drm/sprd/sprd_dsi.c
+++ b/drivers/gpu/drm/sprd/sprd_dsi.c
@@ -13,6 +13,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>
 

-- 
2.34.1

[PATCH 69/86] drm/sti: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/sti/sti_crtc.c   | 2 ++
 drivers/gpu/drm/sti/sti_cursor.c | 2 ++
 drivers/gpu/drm/sti/sti_dvo.c    | 2 ++
 drivers/gpu/drm/sti/sti_gdp.c    | 2 ++
 drivers/gpu/drm/sti/sti_hda.c    | 2 ++
 drivers/gpu/drm/sti/sti_hdmi.c   | 2 ++
 drivers/gpu/drm/sti/sti_hqvdp.c  | 2 ++
 drivers/gpu/drm/sti/sti_tvout.c  | 1 +
 drivers/gpu/drm/sti/sti_vid.c    | 1 +
 9 files changed, 16 insertions(+)

diff --git a/drivers/gpu/drm/sti/sti_crtc.c b/drivers/gpu/drm/sti/sti_crtc.c
index 3c7154f2d5f3..5887c7056a74 100644
--- a/drivers/gpu/drm/sti/sti_crtc.c
+++ b/drivers/gpu/drm/sti/sti_crtc.c
@@ -10,8 +10,10 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_device.h>
 #include <drm/drm_print.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
 
diff --git a/drivers/gpu/drm/sti/sti_cursor.c b/drivers/gpu/drm/sti/sti_cursor.c
index db0a1eb53532..22bc2d0c4769 100644
--- a/drivers/gpu/drm/sti/sti_cursor.c
+++ b/drivers/gpu/drm/sti/sti_cursor.c
@@ -10,10 +10,12 @@
 #include <linux/seq_file.h>
 
 #include <drm/drm_atomic.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_device.h>
 #include <drm/drm_fb_dma_helper.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_dma_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "sti_compositor.h"
 #include "sti_cursor.h"
diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c
index 577c477b5f46..3d5660ac886e 100644
--- a/drivers/gpu/drm/sti/sti_dvo.c
+++ b/drivers/gpu/drm/sti/sti_dvo.c
@@ -12,8 +12,10 @@
 #include <linux/platform_device.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_device.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/drm/sti/sti_gdp.c
index 43c72c2604a0..bbec2b44a096 100644
--- a/drivers/gpu/drm/sti/sti_gdp.c
+++ b/drivers/gpu/drm/sti/sti_gdp.c
@@ -11,11 +11,13 @@
 #include <linux/seq_file.h>
 
 #include <drm/drm_atomic.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_device.h>
 #include <drm/drm_fb_dma_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_dma_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "sti_compositor.h"
 #include "sti_gdp.h"
diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c
index 15097ac67931..1a13007b5807 100644
--- a/drivers/gpu/drm/sti/sti_hda.c
+++ b/drivers/gpu/drm/sti/sti_hda.c
@@ -13,10 +13,12 @@
 #include <linux/seq_file.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_debugfs.h>
 #include <drm/drm_device.h>
 #include <drm/drm_file.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
 
diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
index 8539fe1fedc4..6388cfc54e66 100644
--- a/drivers/gpu/drm/sti/sti_hdmi.c
+++ b/drivers/gpu/drm/sti/sti_hdmi.c
@@ -15,11 +15,13 @@
 #include <linux/reset.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_debugfs.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_file.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
 
diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
index 02b77279f6e4..388da64092d1 100644
--- a/drivers/gpu/drm/sti/sti_hqvdp.c
+++ b/drivers/gpu/drm/sti/sti_hqvdp.c
@@ -15,11 +15,13 @@
 #include <linux/seq_file.h>
 
 #include <drm/drm_atomic.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_device.h>
 #include <drm/drm_fb_dma_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_dma_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "sti_compositor.h"
 #include "sti_drv.h"
diff --git a/drivers/gpu/drm/sti/sti_tvout.c b/drivers/gpu/drm/sti/sti_tvout.c
index 2499715a69b7..3a86c4e57b57 100644
--- a/drivers/gpu/drm/sti/sti_tvout.c
+++ b/drivers/gpu/drm/sti/sti_tvout.c
@@ -19,6 +19,7 @@
 #include <drm/drm_debugfs.h>
 #include <drm/drm_device.h>
 #include <drm/drm_file.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 
 #include "sti_crtc.h"
diff --git a/drivers/gpu/drm/sti/sti_vid.c b/drivers/gpu/drm/sti/sti_vid.c
index 2d818397918d..e10e57c76230 100644
--- a/drivers/gpu/drm/sti/sti_vid.c
+++ b/drivers/gpu/drm/sti/sti_vid.c
@@ -5,6 +5,7 @@
  */
 #include <linux/seq_file.h>
 
+#include <drm/drm_crtc.h>
 #include <drm/drm_debugfs.h>
 #include <drm/drm_file.h>
 #include <drm/drm_print.h>

-- 
2.34.1

[PATCH 70/86] drm/stm: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/stm/ltdc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index 03c6becda795..db24b9ccfdd1 100644
--- a/drivers/gpu/drm/stm/ltdc.c
+++ b/drivers/gpu/drm/stm/ltdc.c
@@ -24,6 +24,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_device.h>
@@ -33,6 +34,7 @@
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>

-- 
2.34.1

[PATCH 71/86] drm/sun4i: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/sun4i/sun4i_crtc.c        | 2 ++
 drivers/gpu/drm/sun4i/sun4i_drv.c         | 1 +
 drivers/gpu/drm/sun4i/sun4i_framebuffer.c | 1 +
 drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c    | 2 ++
 drivers/gpu/drm/sun4i/sun4i_layer.c       | 2 ++
 drivers/gpu/drm/sun4i/sun4i_lvds.c        | 2 ++
 drivers/gpu/drm/sun4i/sun4i_rgb.c         | 2 ++
 drivers/gpu/drm/sun4i/sun4i_tv.c          | 2 ++
 drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c    | 2 ++
 drivers/gpu/drm/sun4i/sun8i_ui_layer.c    | 2 ++
 drivers/gpu/drm/sun4i/sun8i_vi_layer.c    | 2 ++
 11 files changed, 20 insertions(+)

diff --git a/drivers/gpu/drm/sun4i/sun4i_crtc.c b/drivers/gpu/drm/sun4i/sun4i_crtc.c
index c06d7cd45388..ac06d4bad6b2 100644
--- a/drivers/gpu/drm/sun4i/sun4i_crtc.c
+++ b/drivers/gpu/drm/sun4i/sun4i_crtc.c
@@ -17,8 +17,10 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_modes.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
index cc94efbbf2d4..9f25c954b219 100644
--- a/drivers/gpu/drm/sun4i/sun4i_drv.c
+++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
@@ -19,6 +19,7 @@
 #include <drm/drm_drv.h>
 #include <drm/drm_fbdev_generic.h>
 #include <drm/drm_gem_dma_helper.h>
+#include <drm/drm_modeset_helper.h>
 #include <drm/drm_module.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/sun4i/sun4i_framebuffer.c b/drivers/gpu/drm/sun4i/sun4i_framebuffer.c
index 260136d60ceb..958a7e97b711 100644
--- a/drivers/gpu/drm/sun4i/sun4i_framebuffer.c
+++ b/drivers/gpu/drm/sun4i/sun4i_framebuffer.c
@@ -10,6 +10,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "sun4i_drv.h"
 #include "sun4i_framebuffer.h"
diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c
index c0df5e892fa7..4f25fd3f5ee9 100644
--- a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c
+++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c
@@ -17,8 +17,10 @@
 #include <linux/reset.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_encoder.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_print.h>
diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c b/drivers/gpu/drm/sun4i/sun4i_layer.c
index 98f3176366c0..8d6ddefee7dd 100644
--- a/drivers/gpu/drm/sun4i/sun4i_layer.c
+++ b/drivers/gpu/drm/sun4i/sun4i_layer.c
@@ -8,8 +8,10 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_gem_atomic_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "sun4i_backend.h"
 #include "sun4i_frontend.h"
diff --git a/drivers/gpu/drm/sun4i/sun4i_lvds.c b/drivers/gpu/drm/sun4i/sun4i_lvds.c
index 6716e895ae8a..3eadfc9e4840 100644
--- a/drivers/gpu/drm/sun4i/sun4i_lvds.c
+++ b/drivers/gpu/drm/sun4i/sun4i_lvds.c
@@ -7,7 +7,9 @@
 #include <linux/clk.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_print.h>
diff --git a/drivers/gpu/drm/sun4i/sun4i_rgb.c b/drivers/gpu/drm/sun4i/sun4i_rgb.c
index dfb6acc42f02..8737a003e70a 100644
--- a/drivers/gpu/drm/sun4i/sun4i_rgb.c
+++ b/drivers/gpu/drm/sun4i/sun4i_rgb.c
@@ -9,7 +9,9 @@
 #include <linux/clk.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_print.h>
diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c
index 9625a00a48ba..e5981ae4ce64 100644
--- a/drivers/gpu/drm/sun4i/sun4i_tv.c
+++ b/drivers/gpu/drm/sun4i/sun4i_tv.c
@@ -16,6 +16,8 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_print.h>
diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
index 760ff05eabf4..20f7ea2e0319 100644
--- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
+++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
@@ -20,7 +20,9 @@
 #include <linux/slab.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_mipi_dsi.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c
index ca75ca0835a6..4e12a13607fd 100644
--- a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c
+++ b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c
@@ -11,6 +11,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_fb_dma_helper.h>
@@ -18,6 +19,7 @@
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
 #include "sun8i_mixer.h"
diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c
index f9c0a56d3a14..a1334667838d 100644
--- a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c
+++ b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c
@@ -5,12 +5,14 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_fb_dma_helper.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
 #include "sun8i_csc.h"

-- 
2.34.1

[PATCH 72/86] drm/tegra: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/tegra/dc.c    | 2 ++
 drivers/gpu/drm/tegra/drm.c   | 2 ++
 drivers/gpu/drm/tegra/dsi.c   | 2 ++
 drivers/gpu/drm/tegra/hdmi.c  | 2 ++
 drivers/gpu/drm/tegra/hub.c   | 2 ++
 drivers/gpu/drm/tegra/plane.c | 1 +
 drivers/gpu/drm/tegra/rgb.c   | 1 +
 drivers/gpu/drm/tegra/sor.c   | 2 ++
 8 files changed, 14 insertions(+)

diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
index a67453cee883..36e40458e73e 100644
--- a/drivers/gpu/drm/tegra/dc.c
+++ b/drivers/gpu/drm/tegra/dc.c
@@ -22,10 +22,12 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_debugfs.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_vblank.h>
 
 #include "dc.h"
diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
index 7bd2e65c2a16..dec52df5b0f6 100644
--- a/drivers/gpu/drm/tegra/drm.c
+++ b/drivers/gpu/drm/tegra/drm.c
@@ -20,6 +20,8 @@
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_ioctl.h>
+#include <drm/drm_modeset_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_prime.h>
 #include <drm/drm_vblank.h>
 
diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c
index de1333dc0d86..b6205e30eabe 100644
--- a/drivers/gpu/drm/tegra/dsi.c
+++ b/drivers/gpu/drm/tegra/dsi.c
@@ -18,9 +18,11 @@
 #include <video/mipi_display.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_debugfs.h>
 #include <drm/drm_file.h>
 #include <drm/drm_mipi_dsi.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_simple_kms_helper.h>
 
diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c
index 40ec3e6cf204..3b6a45bcddda 100644
--- a/drivers/gpu/drm/tegra/hdmi.c
+++ b/drivers/gpu/drm/tegra/hdmi.c
@@ -20,10 +20,12 @@
 #include <sound/hdmi-codec.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_debugfs.h>
 #include <drm/drm_file.h>
 #include <drm/drm_fourcc.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>
 
diff --git a/drivers/gpu/drm/tegra/hub.c b/drivers/gpu/drm/tegra/hub.c
index b872527a123c..2fded0b6db24 100644
--- a/drivers/gpu/drm/tegra/hub.c
+++ b/drivers/gpu/drm/tegra/hub.c
@@ -17,9 +17,11 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
 #include "drm.h"
diff --git a/drivers/gpu/drm/tegra/plane.c b/drivers/gpu/drm/tegra/plane.c
index 10090116895f..79201ac67194 100644
--- a/drivers/gpu/drm/tegra/plane.c
+++ b/drivers/gpu/drm/tegra/plane.c
@@ -9,6 +9,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
diff --git a/drivers/gpu/drm/tegra/rgb.c b/drivers/gpu/drm/tegra/rgb.c
index ff8fce36d2aa..f737f768d24d 100644
--- a/drivers/gpu/drm/tegra/rgb.c
+++ b/drivers/gpu/drm/tegra/rgb.c
@@ -8,6 +8,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge_connector.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_simple_kms_helper.h>
 
 #include "drm.h"
diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
index 8af632740673..e0b4e71f0fbe 100644
--- a/drivers/gpu/drm/tegra/sor.c
+++ b/drivers/gpu/drm/tegra/sor.c
@@ -19,8 +19,10 @@
 #include <drm/display/drm_dp_helper.h>
 #include <drm/display/drm_scdc_helper.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_debugfs.h>
 #include <drm/drm_file.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_simple_kms_helper.h>
 

-- 
2.34.1

[PATCH 73/86] drm/tests: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/tests/drm_plane_helper_test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/tests/drm_plane_helper_test.c b/drivers/gpu/drm/tests/drm_plane_helper_test.c
index 0f392146b233..745e35db65db 100644
--- a/drivers/gpu/drm/tests/drm_plane_helper_test.c
+++ b/drivers/gpu/drm/tests/drm_plane_helper_test.c
@@ -8,6 +8,7 @@
 #include <kunit/test.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_crtc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_modes.h>
 #include <drm/drm_rect.h>

-- 
2.34.1

[PATCH 74/86] drm/tidss: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/tidss/tidss_crtc.c  | 2 ++
 drivers/gpu/drm/tidss/tidss_drv.c   | 1 +
 drivers/gpu/drm/tidss/tidss_kms.c   | 1 +
 drivers/gpu/drm/tidss/tidss_plane.c | 2 ++
 4 files changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/tidss/tidss_crtc.c b/drivers/gpu/drm/tidss/tidss_crtc.c
index 5e5e466f35d1..ce3319b4b50d 100644
--- a/drivers/gpu/drm/tidss/tidss_crtc.c
+++ b/drivers/gpu/drm/tidss/tidss_crtc.c
@@ -6,8 +6,10 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_gem_dma_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_vblank.h>
 
 #include "tidss_crtc.h"
diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu/drm/tidss/tidss_drv.c
index 2dac8727d2f4..80f52597ef32 100644
--- a/drivers/gpu/drm/tidss/tidss_drv.c
+++ b/drivers/gpu/drm/tidss/tidss_drv.c
@@ -16,6 +16,7 @@
 #include <drm/drm_fbdev_generic.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_managed.h>
+#include <drm/drm_modeset_helper.h>
 #include <drm/drm_module.h>
 #include <drm/drm_probe_helper.h>
 
diff --git a/drivers/gpu/drm/tidss/tidss_kms.c b/drivers/gpu/drm/tidss/tidss_kms.c
index ad2fa3c3d4a7..c0942607eab4 100644
--- a/drivers/gpu/drm/tidss/tidss_kms.c
+++ b/drivers/gpu/drm/tidss/tidss_kms.c
@@ -10,6 +10,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_vblank.h>
diff --git a/drivers/gpu/drm/tidss/tidss_plane.c b/drivers/gpu/drm/tidss/tidss_plane.c
index fe2c41f0cd4f..1c186e4413af 100644
--- a/drivers/gpu/drm/tidss/tidss_plane.c
+++ b/drivers/gpu/drm/tidss/tidss_plane.c
@@ -6,11 +6,13 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "tidss_crtc.h"
 #include "tidss_dispc.h"

-- 
2.34.1

[PATCH 75/86] drm/tilcdc: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/tilcdc/tilcdc_crtc.c  | 1 +
 drivers/gpu/drm/tilcdc/tilcdc_drv.c   | 1 +
 drivers/gpu/drm/tilcdc/tilcdc_plane.c | 2 ++
 3 files changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
index b5f60b2b2d0e..0991002e7b8c 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
@@ -11,6 +11,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_fb_dma_helper.h>
 #include <drm/drm_fourcc.h>
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index 4ca426007dc8..e9918a539e8a 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
@@ -21,6 +21,7 @@
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_mm.h>
+#include <drm/drm_modeset_helper.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
 
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_plane.c b/drivers/gpu/drm/tilcdc/tilcdc_plane.c
index cf77a8ce7398..5ed832fa9ebc 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_plane.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_plane.c
@@ -6,8 +6,10 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "tilcdc_drv.h"
 

-- 
2.34.1

[PATCH 76/86] drm/tiny: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/tiny/arcpgu.c   | 2 ++
 drivers/gpu/drm/tiny/bochs.c    | 3 +++
 drivers/gpu/drm/tiny/gm12u320.c | 1 +
 drivers/gpu/drm/tiny/repaper.c  | 2 ++
 4 files changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/tiny/arcpgu.c b/drivers/gpu/drm/tiny/arcpgu.c
index 611bbee15071..e2b1af1aa974 100644
--- a/drivers/gpu/drm/tiny/arcpgu.c
+++ b/drivers/gpu/drm/tiny/arcpgu.c
@@ -7,6 +7,7 @@
 
 #include <linux/clk.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_debugfs.h>
 #include <drm/drm_device.h>
 #include <drm/drm_drv.h>
@@ -17,6 +18,7 @@
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_module.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c
index 024346054c70..764d5c8b6ce0 100644
--- a/drivers/gpu/drm/tiny/bochs.c
+++ b/drivers/gpu/drm/tiny/bochs.c
@@ -5,6 +5,7 @@
 
 #include <drm/drm_aperture.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_fbdev_generic.h>
@@ -13,6 +14,8 @@
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_gem_vram_helper.h>
 #include <drm/drm_managed.h>
+#include <drm/drm_modeset_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_module.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>
diff --git a/drivers/gpu/drm/tiny/gm12u320.c b/drivers/gpu/drm/tiny/gm12u320.c
index c5bb683e440c..68ae29cff259 100644
--- a/drivers/gpu/drm/tiny/gm12u320.c
+++ b/drivers/gpu/drm/tiny/gm12u320.c
@@ -23,6 +23,7 @@
 #include <drm/drm_gem_shmem_helper.h>
 #include <drm/drm_ioctl.h>
 #include <drm/drm_managed.h>
+#include <drm/drm_modeset_helper.h>
 #include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>
diff --git a/drivers/gpu/drm/tiny/repaper.c b/drivers/gpu/drm/tiny/repaper.c
index c2677d081a7b..af339798b8ea 100644
--- a/drivers/gpu/drm/tiny/repaper.c
+++ b/drivers/gpu/drm/tiny/repaper.c
@@ -22,6 +22,7 @@
 #include <linux/thermal.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_connector.h>
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_drv.h>
@@ -33,6 +34,7 @@
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_managed.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_modes.h>
 #include <drm/drm_rect.h>
 #include <drm/drm_probe_helper.h>

-- 
2.34.1

[PATCH 77/86] drm/udl: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/udl/udl_drv.c     | 1 +
 drivers/gpu/drm/udl/udl_modeset.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/udl/udl_drv.c b/drivers/gpu/drm/udl/udl_drv.c
index 1506094a8009..e0e5dcbd18e0 100644
--- a/drivers/gpu/drm/udl/udl_drv.c
+++ b/drivers/gpu/drm/udl/udl_drv.c
@@ -12,6 +12,7 @@
 #include <drm/drm_managed.h>
 #include <drm/drm_modeset_helper.h>
 #include <drm/drm_ioctl.h>
+#include <drm/drm_modeset_helper.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_print.h>
 
diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_modeset.c
index aa02fd2789c3..b613c4f461e2 100644
--- a/drivers/gpu/drm/udl/udl_modeset.c
+++ b/drivers/gpu/drm/udl/udl_modeset.c
@@ -12,6 +12,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_edid.h>

-- 
2.34.1

[PATCH 78/86] drm/vboxvideo: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/vboxvideo/vbox_mode.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/vboxvideo/vbox_mode.c b/drivers/gpu/drm/vboxvideo/vbox_mode.c
index 341edd982cb3..4dfe8f1d19fa 100644
--- a/drivers/gpu/drm/vboxvideo/vbox_mode.c
+++ b/drivers/gpu/drm/vboxvideo/vbox_mode.c
@@ -15,12 +15,14 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_fb_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_plane_helper.h>
 #include <drm/drm_probe_helper.h>
 

-- 
2.34.1

[PATCH 79/86] drm/vc4: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/vc4/vc4_crtc.c  | 2 ++
 drivers/gpu/drm/vc4/vc4_dpi.c   | 1 +
 drivers/gpu/drm/vc4/vc4_dsi.c   | 1 +
 drivers/gpu/drm/vc4/vc4_hdmi.c  | 2 ++
 drivers/gpu/drm/vc4/vc4_kms.c   | 2 ++
 drivers/gpu/drm/vc4/vc4_plane.c | 2 ++
 drivers/gpu/drm/vc4/vc4_txp.c   | 2 ++
 drivers/gpu/drm/vc4/vc4_vec.c   | 2 ++
 8 files changed, 14 insertions(+)

diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c
index cdc0559221f0..251c6f76e19e 100644
--- a/drivers/gpu/drm/vc4/vc4_crtc.c
+++ b/drivers/gpu/drm/vc4/vc4_crtc.c
@@ -36,10 +36,12 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_atomic_uapi.h>
 #include <drm/drm_fb_dma_helper.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_drv.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c
index f518d6e59ed6..938a22723c53 100644
--- a/drivers/gpu/drm/vc4/vc4_dpi.c
+++ b/drivers/gpu/drm/vc4/vc4_dpi.c
@@ -15,6 +15,7 @@
 #include <drm/drm_bridge.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
index a5c075f802e4..71a7b6c7f94e 100644
--- a/drivers/gpu/drm/vc4/vc4_dsi.c
+++ b/drivers/gpu/drm/vc4/vc4_dsi.c
@@ -30,6 +30,7 @@
 #include <linux/pm_runtime.h>
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_mipi_dsi.h>
diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index 14628864487a..8de4cd05af62 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -34,7 +34,9 @@
 #include <drm/display/drm_hdmi_helper.h>
 #include <drm/display/drm_scdc_helper.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_drv.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>
 #include <linux/clk.h>
diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c
index a7e3d47c50f4..bb60563219df 100644
--- a/drivers/gpu/drm/vc4/vc4_kms.c
+++ b/drivers/gpu/drm/vc4/vc4_kms.c
@@ -16,9 +16,11 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
 
diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c
index dee525bacd4b..bad505206f55 100644
--- a/drivers/gpu/drm/vc4/vc4_plane.c
+++ b/drivers/gpu/drm/vc4/vc4_plane.c
@@ -17,6 +17,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_atomic_uapi.h>
 #include <drm/drm_blend.h>
 #include <drm/drm_drv.h>
@@ -24,6 +25,7 @@
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "uapi/drm/vc4_drm.h"
 
diff --git a/drivers/gpu/drm/vc4/vc4_txp.c b/drivers/gpu/drm/vc4/vc4_txp.c
index ef5cab2a3aa9..872dc0cd2e4b 100644
--- a/drivers/gpu/drm/vc4/vc4_txp.c
+++ b/drivers/gpu/drm/vc4/vc4_txp.c
@@ -15,11 +15,13 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_fb_dma_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
diff --git a/drivers/gpu/drm/vc4/vc4_vec.c b/drivers/gpu/drm/vc4/vc4_vec.c
index a3782d05cd66..0ad9f4fdc1e8 100644
--- a/drivers/gpu/drm/vc4/vc4_vec.c
+++ b/drivers/gpu/drm/vc4/vc4_vec.c
@@ -14,8 +14,10 @@
  */
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_panel.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>

-- 
2.34.1

[PATCH 80/86] drm/virtio: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/virtio/virtgpu_display.c | 3 +++
 drivers/gpu/drm/virtio/virtgpu_plane.c   | 2 ++
 2 files changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c
index 9ea7611a9e0f..712c98535f4d 100644
--- a/drivers/gpu/drm/virtio/virtgpu_display.c
+++ b/drivers/gpu/drm/virtio/virtgpu_display.c
@@ -26,10 +26,13 @@
  */
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_modeset_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>
 
diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c
index 4c09e313bebc..d0fc333f6b3f 100644
--- a/drivers/gpu/drm/virtio/virtgpu_plane.c
+++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
@@ -24,8 +24,10 @@
  */
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_fourcc.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "virtgpu_drv.h"
 

-- 
2.34.1

[PATCH 81/86] drm/vkms: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/vkms/vkms_crtc.c      | 2 ++
 drivers/gpu/drm/vkms/vkms_drv.c       | 1 +
 drivers/gpu/drm/vkms/vkms_output.c    | 2 ++
 drivers/gpu/drm/vkms/vkms_plane.c     | 1 +
 drivers/gpu/drm/vkms/vkms_writeback.c | 2 ++
 5 files changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c
index 57bbd32e9beb..7d540ed0466b 100644
--- a/drivers/gpu/drm/vkms/vkms_crtc.c
+++ b/drivers/gpu/drm/vkms/vkms_crtc.c
@@ -4,6 +4,8 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
 
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index 6d3a2d57d992..eb62b6171f77 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -22,6 +22,7 @@
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_ioctl.h>
 #include <drm/drm_managed.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_gem_shmem_helper.h>
 #include <drm/drm_vblank.h>
diff --git a/drivers/gpu/drm/vkms/vkms_output.c b/drivers/gpu/drm/vkms/vkms_output.c
index 991857125bb4..2a6fbb1f4d71 100644
--- a/drivers/gpu/drm/vkms/vkms_output.c
+++ b/drivers/gpu/drm/vkms/vkms_output.c
@@ -2,7 +2,9 @@
 
 #include "vkms_drv.h"
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_edid.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>
 
diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c
index b3f8a115cc23..45e53110b581 100644
--- a/drivers/gpu/drm/vkms/vkms_plane.c
+++ b/drivers/gpu/drm/vkms/vkms_plane.c
@@ -7,6 +7,7 @@
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "vkms_drv.h"
 #include "vkms_formats.h"
diff --git a/drivers/gpu/drm/vkms/vkms_writeback.c b/drivers/gpu/drm/vkms/vkms_writeback.c
index 84a51cd281b9..33fd8437e320 100644
--- a/drivers/gpu/drm/vkms/vkms_writeback.c
+++ b/drivers/gpu/drm/vkms/vkms_writeback.c
@@ -3,6 +3,7 @@
 #include <linux/iosys-map.h>
 
 #include <drm/drm_atomic.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_writeback.h>
@@ -10,6 +11,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_gem_shmem_helper.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "vkms_drv.h"
 #include "vkms_formats.h"

-- 
2.34.1

[PATCH 82/86] drm/vmwgfx: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c  | 2 ++
 drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c  | 1 +
 drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 1 +
 drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 1 +
 4 files changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index 257f090071f1..ee0cc8cea3e1 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
@@ -30,8 +30,10 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_fourcc.h>
+#include <drm/drm_modeset_helper.h>
 #include <drm/drm_rect.h>
 #include <drm/drm_sysfs.h>
 
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
index a56e5d0ca3c6..862c0cf4c3c8 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
@@ -28,6 +28,7 @@
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_fourcc.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "vmwgfx_kms.h"
 
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
index e1f36a09c59c..644541d18d29 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
@@ -29,6 +29,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_fourcc.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "vmwgfx_kms.h"
 
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c
index 0090abe89254..be301629b09a 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c
@@ -29,6 +29,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_fourcc.h>
+#include <drm/drm_modeset_helper_vtables.h>
 
 #include "vmwgfx_kms.h"
 #include "vmw_surface_cache.h"

-- 
2.34.1

[PATCH 83/86] drm/xen: Direct include headers from drm_atomic_helper

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Direct include the headers that otherwise comes indirect from
drm_atomic_helper, because drm_atomic_helper will be reduced to
include only the minimal set of headers.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/xen/xen_drm_front_conn.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/xen/xen_drm_front_conn.c b/drivers/gpu/drm/xen/xen_drm_front_conn.c
index a1ba6d3d0568..04fa1cdf7205 100644
--- a/drivers/gpu/drm/xen/xen_drm_front_conn.c
+++ b/drivers/gpu/drm/xen/xen_drm_front_conn.c
@@ -9,8 +9,10 @@
  */
 
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_fourcc.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
 
 #include <video/videomode.h>

-- 
2.34.1

[PATCH 84/86] drm/drm_atomic_helper: Minimize include footprint

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

Reduce drm_atomic_helper.h to include or forward the minimal set of
files/symbols - to minimize the impact of the files that includes this
header file.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 include/drm/drm_atomic_helper.h | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/include/drm/drm_atomic_helper.h b/include/drm/drm_atomic_helper.h
index 33f982cd1a27..c7f2bc46bd24 100644
--- a/include/drm/drm_atomic_helper.h
+++ b/include/drm/drm_atomic_helper.h
@@ -28,11 +28,9 @@
 #ifndef DRM_ATOMIC_HELPER_H_
 #define DRM_ATOMIC_HELPER_H_
 
-#include <drm/drm_crtc.h>
-#include <drm/drm_modeset_helper_vtables.h>
-#include <drm/drm_modeset_helper.h>
-#include <drm/drm_atomic_state_helper.h>
-#include <drm/drm_util.h>
+#include <linux/types.h>
+
+#include <drm/drm_plane.h>
 
 /*
  * Drivers that don't allow primary plane scaling may pass this macro in place
@@ -44,8 +42,17 @@
 #define DRM_PLANE_NO_SCALING (1<<16)
 
 struct drm_atomic_state;
-struct drm_private_obj;
-struct drm_private_state;
+struct drm_bridge;
+struct drm_bridge_state;
+struct drm_connector_state;
+struct drm_crtc_state;
+struct drm_device;
+struct drm_encoder;
+struct drm_framebuffer;
+struct drm_mode_set;
+struct drm_modeset_acquire_ctx;
+struct drm_pending_vblank_event;
+
 
 int drm_atomic_helper_check_modeset(struct drm_device *dev,
 				struct drm_atomic_state *state);

-- 
2.34.1

Re: [PATCH 84/86] drm/drm_atomic_helper: Minimize include footprint

[Thomas Zimmermann]

[-- Attachment #1.1: Type: text/plain, Size: 1993 bytes --]

Hi,

in the subject line, I'd use 'dependencies' instead of 'footprint'. Your 
choice.

Am 21.01.23 um 21:09 schrieb Sam Ravnborg via B4 Submission Endpoint:
> From: Sam Ravnborg <sam@ravnborg.org>
> 
> Reduce drm_atomic_helper.h to include or forward the minimal set of
> files/symbols - to minimize the impact of the files that includes this
> header file.
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> ---
>   include/drm/drm_atomic_helper.h | 21 ++++++++++++++-------
>   1 file changed, 14 insertions(+), 7 deletions(-)
> 
> diff --git a/include/drm/drm_atomic_helper.h b/include/drm/drm_atomic_helper.h
> index 33f982cd1a27..c7f2bc46bd24 100644
> --- a/include/drm/drm_atomic_helper.h
> +++ b/include/drm/drm_atomic_helper.h
> @@ -28,11 +28,9 @@
>   #ifndef DRM_ATOMIC_HELPER_H_
>   #define DRM_ATOMIC_HELPER_H_
>   
> -#include <drm/drm_crtc.h>
> -#include <drm/drm_modeset_helper_vtables.h>
> -#include <drm/drm_modeset_helper.h>
> -#include <drm/drm_atomic_state_helper.h>
> -#include <drm/drm_util.h>
> +#include <linux/types.h>
> +
> +#include <drm/drm_plane.h>
>   
>   /*
>    * Drivers that don't allow primary plane scaling may pass this macro in place
> @@ -44,8 +42,17 @@
>   #define DRM_PLANE_NO_SCALING (1<<16)
>   
>   struct drm_atomic_state;
> -struct drm_private_obj;
> -struct drm_private_state;
> +struct drm_bridge;
> +struct drm_bridge_state;
> +struct drm_connector_state;
> +struct drm_crtc_state;
> +struct drm_device;
> +struct drm_encoder;
> +struct drm_framebuffer;
> +struct drm_mode_set;
> +struct drm_modeset_acquire_ctx;
> +struct drm_pending_vblank_event;
> +

No extra newline here.

>   
>   int drm_atomic_helper_check_modeset(struct drm_device *dev,
>   				struct drm_atomic_state *state);
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

[PATCH 85/86] drm: move drm_timeout_abs_to_jiffies to drm_util

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

drm_timeout_abs_to_jiffies() was implmented in drm_syncobj where
it really did not belong. Create a drm_util file and move the
implementation. Likewise move the prototype and update all users.

Suggested-by: Daniel Vetter <daniel@ffwll.ch>
[https://lore.kernel.org/dri-devel/20190527185311.GS21222@phenom.ffwll.local/]
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/accel/ivpu/ivpu_gem.c           |  2 +-
 drivers/gpu/drm/Makefile                |  1 +
 drivers/gpu/drm/drm_syncobj.c           | 34 ----------------------------
 drivers/gpu/drm/drm_util.c              | 40 +++++++++++++++++++++++++++++++++
 drivers/gpu/drm/lima/lima_gem.c         |  2 +-
 drivers/gpu/drm/panfrost/panfrost_drv.c |  2 +-
 drivers/gpu/drm/tegra/uapi.c            |  2 +-
 include/drm/drm_util.h                  |  1 +
 include/drm/drm_utils.h                 |  2 --
 9 files changed, 46 insertions(+), 40 deletions(-)

diff --git a/drivers/accel/ivpu/ivpu_gem.c b/drivers/accel/ivpu/ivpu_gem.c
index d1f923971b4c..55aa94ba6c10 100644
--- a/drivers/accel/ivpu/ivpu_gem.c
+++ b/drivers/accel/ivpu/ivpu_gem.c
@@ -12,7 +12,7 @@
 #include <drm/drm_cache.h>
 #include <drm/drm_debugfs.h>
 #include <drm/drm_file.h>
-#include <drm/drm_utils.h>
+#include <drm/drm_util.h>
 
 #include "ivpu_drv.h"
 #include "ivpu_gem.h"
diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
index ab4460fcd63f..561b93d19685 100644
--- a/drivers/gpu/drm/Makefile
+++ b/drivers/gpu/drm/Makefile
@@ -42,6 +42,7 @@ drm-y := \
 	drm_syncobj.o \
 	drm_sysfs.o \
 	drm_trace_points.o \
+	drm_util.o \
 	drm_vblank.o \
 	drm_vblank_work.o \
 	drm_vma_manager.o \
diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
index 0c2be8360525..35f5416c5cfe 100644
--- a/drivers/gpu/drm/drm_syncobj.c
+++ b/drivers/gpu/drm/drm_syncobj.c
@@ -197,7 +197,6 @@
 #include <drm/drm_gem.h>
 #include <drm/drm_print.h>
 #include <drm/drm_syncobj.h>
-#include <drm/drm_utils.h>
 
 #include "drm_internal.h"
 
@@ -1114,39 +1113,6 @@ static signed long drm_syncobj_array_wait_timeout(struct drm_syncobj **syncobjs,
 	return timeout;
 }
 
-/**
- * drm_timeout_abs_to_jiffies - calculate jiffies timeout from absolute value
- *
- * @timeout_nsec: timeout nsec component in ns, 0 for poll
- *
- * Calculate the timeout in jiffies from an absolute time in sec/nsec.
- */
-signed long drm_timeout_abs_to_jiffies(int64_t timeout_nsec)
-{
-	ktime_t abs_timeout, now;
-	u64 timeout_ns, timeout_jiffies64;
-
-	/* make 0 timeout means poll - absolute 0 doesn't seem valid */
-	if (timeout_nsec == 0)
-		return 0;
-
-	abs_timeout = ns_to_ktime(timeout_nsec);
-	now = ktime_get();
-
-	if (!ktime_after(abs_timeout, now))
-		return 0;
-
-	timeout_ns = ktime_to_ns(ktime_sub(abs_timeout, now));
-
-	timeout_jiffies64 = nsecs_to_jiffies64(timeout_ns);
-	/*  clamp timeout to avoid infinite timeout */
-	if (timeout_jiffies64 >= MAX_SCHEDULE_TIMEOUT - 1)
-		return MAX_SCHEDULE_TIMEOUT - 1;
-
-	return timeout_jiffies64 + 1;
-}
-EXPORT_SYMBOL(drm_timeout_abs_to_jiffies);
-
 static int drm_syncobj_array_wait(struct drm_device *dev,
 				  struct drm_file *file_private,
 				  struct drm_syncobj_wait *wait,
diff --git a/drivers/gpu/drm/drm_util.c b/drivers/gpu/drm/drm_util.c
new file mode 100644
index 000000000000..5494fa6b8193
--- /dev/null
+++ b/drivers/gpu/drm/drm_util.c
@@ -0,0 +1,40 @@
+// SPDX-License-Identifier: MIT
+
+#include <linux/export.h>
+#include <linux/ktime.h>
+#include <linux/timekeeping.h>
+
+#include <drm/drm_util.h>
+
+/**
+ * drm_timeout_abs_to_jiffies - calculate jiffies timeout from absolute value
+ *
+ * @timeout_nsec: timeout nsec component in ns, 0 for poll
+ *
+ * Calculate the timeout in jiffies from an absolute time in sec/nsec.
+ */
+signed long drm_timeout_abs_to_jiffies(int64_t timeout_nsec)
+{
+	ktime_t abs_timeout, now;
+	u64 timeout_ns, timeout_jiffies64;
+
+	/* make 0 timeout means poll - absolute 0 doesn't seem valid */
+	if (timeout_nsec == 0)
+		return 0;
+
+	abs_timeout = ns_to_ktime(timeout_nsec);
+	now = ktime_get();
+
+	if (!ktime_after(abs_timeout, now))
+		return 0;
+
+	timeout_ns = ktime_to_ns(ktime_sub(abs_timeout, now));
+
+	timeout_jiffies64 = nsecs_to_jiffies64(timeout_ns);
+	/*  clamp timeout to avoid infinite timeout */
+	if (timeout_jiffies64 >= MAX_SCHEDULE_TIMEOUT - 1)
+		return MAX_SCHEDULE_TIMEOUT - 1;
+
+	return timeout_jiffies64 + 1;
+}
+EXPORT_SYMBOL(drm_timeout_abs_to_jiffies);
diff --git a/drivers/gpu/drm/lima/lima_gem.c b/drivers/gpu/drm/lima/lima_gem.c
index 0f1ca0b0db49..5cdd06682afe 100644
--- a/drivers/gpu/drm/lima/lima_gem.c
+++ b/drivers/gpu/drm/lima/lima_gem.c
@@ -10,7 +10,7 @@
 
 #include <drm/drm_file.h>
 #include <drm/drm_syncobj.h>
-#include <drm/drm_utils.h>
+#include <drm/drm_util.h>
 
 #include <drm/lima_drm.h>
 
diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
index fa619fe72086..581df5b724e2 100644
--- a/drivers/gpu/drm/panfrost/panfrost_drv.c
+++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
@@ -11,7 +11,7 @@
 #include <drm/drm_drv.h>
 #include <drm/drm_ioctl.h>
 #include <drm/drm_syncobj.h>
-#include <drm/drm_utils.h>
+#include <drm/drm_util.h>
 
 #include "panfrost_device.h"
 #include "panfrost_gem.h"
diff --git a/drivers/gpu/drm/tegra/uapi.c b/drivers/gpu/drm/tegra/uapi.c
index 5adab6b22916..6d5601517a34 100644
--- a/drivers/gpu/drm/tegra/uapi.c
+++ b/drivers/gpu/drm/tegra/uapi.c
@@ -7,7 +7,7 @@
 
 #include <drm/drm_drv.h>
 #include <drm/drm_file.h>
-#include <drm/drm_utils.h>
+#include <drm/drm_util.h>
 
 #include "drm.h"
 #include "uapi.h"
diff --git a/include/drm/drm_util.h b/include/drm/drm_util.h
index 79952d8c4bba..3d719190cfd9 100644
--- a/include/drm/drm_util.h
+++ b/include/drm/drm_util.h
@@ -80,4 +80,5 @@ static inline bool drm_can_sleep(void)
 	return true;
 }
 
+signed long drm_timeout_abs_to_jiffies(int64_t timeout_nsec);
 #endif
diff --git a/include/drm/drm_utils.h b/include/drm/drm_utils.h
index 70775748d243..bae225f0a24b 100644
--- a/include/drm/drm_utils.h
+++ b/include/drm/drm_utils.h
@@ -14,6 +14,4 @@
 
 int drm_get_panel_orientation_quirk(int width, int height);
 
-signed long drm_timeout_abs_to_jiffies(int64_t timeout_nsec);
-
 #endif

-- 
2.34.1

Re: [PATCH 85/86] drm: move drm_timeout_abs_to_jiffies to drm_util

[Thomas Zimmermann]

[-- Attachment #1.1: Type: text/plain, Size: 7778 bytes --]

Hi Sam,

please see my comment below.

Am 21.01.23 um 21:09 schrieb Sam Ravnborg via B4 Submission Endpoint:
> From: Sam Ravnborg <sam@ravnborg.org>
> 
> drm_timeout_abs_to_jiffies() was implmented in drm_syncobj where
> it really did not belong. Create a drm_util file and move the
> implementation. Likewise move the prototype and update all users.
> 
> Suggested-by: Daniel Vetter <daniel@ffwll.ch>
> [https://lore.kernel.org/dri-devel/20190527185311.GS21222@phenom.ffwll.local/]
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> ---
>   drivers/accel/ivpu/ivpu_gem.c           |  2 +-
>   drivers/gpu/drm/Makefile                |  1 +
>   drivers/gpu/drm/drm_syncobj.c           | 34 ----------------------------
>   drivers/gpu/drm/drm_util.c              | 40 +++++++++++++++++++++++++++++++++
>   drivers/gpu/drm/lima/lima_gem.c         |  2 +-
>   drivers/gpu/drm/panfrost/panfrost_drv.c |  2 +-
>   drivers/gpu/drm/tegra/uapi.c            |  2 +-
>   include/drm/drm_util.h                  |  1 +
>   include/drm/drm_utils.h                 |  2 --
>   9 files changed, 46 insertions(+), 40 deletions(-)
> 
> diff --git a/drivers/accel/ivpu/ivpu_gem.c b/drivers/accel/ivpu/ivpu_gem.c
> index d1f923971b4c..55aa94ba6c10 100644
> --- a/drivers/accel/ivpu/ivpu_gem.c
> +++ b/drivers/accel/ivpu/ivpu_gem.c
> @@ -12,7 +12,7 @@
>   #include <drm/drm_cache.h>
>   #include <drm/drm_debugfs.h>
>   #include <drm/drm_file.h>
> -#include <drm/drm_utils.h>
> +#include <drm/drm_util.h>
>   
>   #include "ivpu_drv.h"
>   #include "ivpu_gem.h"
> diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
> index ab4460fcd63f..561b93d19685 100644
> --- a/drivers/gpu/drm/Makefile
> +++ b/drivers/gpu/drm/Makefile
> @@ -42,6 +42,7 @@ drm-y := \
>   	drm_syncobj.o \
>   	drm_sysfs.o \
>   	drm_trace_points.o \
> +	drm_util.o \
>   	drm_vblank.o \
>   	drm_vblank_work.o \
>   	drm_vma_manager.o \
> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
> index 0c2be8360525..35f5416c5cfe 100644
> --- a/drivers/gpu/drm/drm_syncobj.c
> +++ b/drivers/gpu/drm/drm_syncobj.c
> @@ -197,7 +197,6 @@
>   #include <drm/drm_gem.h>
>   #include <drm/drm_print.h>
>   #include <drm/drm_syncobj.h>
> -#include <drm/drm_utils.h>
>   
>   #include "drm_internal.h"
>   
> @@ -1114,39 +1113,6 @@ static signed long drm_syncobj_array_wait_timeout(struct drm_syncobj **syncobjs,
>   	return timeout;
>   }
>   
> -/**
> - * drm_timeout_abs_to_jiffies - calculate jiffies timeout from absolute value
> - *
> - * @timeout_nsec: timeout nsec component in ns, 0 for poll
> - *
> - * Calculate the timeout in jiffies from an absolute time in sec/nsec.
> - */
> -signed long drm_timeout_abs_to_jiffies(int64_t timeout_nsec)

This function converts an absolute timeout in nsec to a relative timeout 
in jiffies. (?)

It appears to me as if this helper should not exist. It uses a mixture 
of different time interfaces; combined with hardcoded policy for 0 and 
MAX_SCHEDULE_TIMEOUT.

There are only 3 callers of this helper. I think we should consider 
inlining it in each.

As part of this, maybe the use of ktime could go away. Convert nsecs to 
jiffies and do the rest of the computation in jiffies.

Best regards
Thomas

> -{
> -	ktime_t abs_timeout, now;
> -	u64 timeout_ns, timeout_jiffies64;
> -
> -	/* make 0 timeout means poll - absolute 0 doesn't seem valid */
> -	if (timeout_nsec == 0)
> -		return 0;
> -
> -	abs_timeout = ns_to_ktime(timeout_nsec);
> -	now = ktime_get();
> -
> -	if (!ktime_after(abs_timeout, now))
> -		return 0;
> -
> -	timeout_ns = ktime_to_ns(ktime_sub(abs_timeout, now));
> -
> -	timeout_jiffies64 = nsecs_to_jiffies64(timeout_ns);
> -	/*  clamp timeout to avoid infinite timeout */
> -	if (timeout_jiffies64 >= MAX_SCHEDULE_TIMEOUT - 1)
> -		return MAX_SCHEDULE_TIMEOUT - 1;
> -
> -	return timeout_jiffies64 + 1;
> -}
> -EXPORT_SYMBOL(drm_timeout_abs_to_jiffies);
> -
>   static int drm_syncobj_array_wait(struct drm_device *dev,
>   				  struct drm_file *file_private,
>   				  struct drm_syncobj_wait *wait,
> diff --git a/drivers/gpu/drm/drm_util.c b/drivers/gpu/drm/drm_util.c
> new file mode 100644
> index 000000000000..5494fa6b8193
> --- /dev/null
> +++ b/drivers/gpu/drm/drm_util.c
> @@ -0,0 +1,40 @@
> +// SPDX-License-Identifier: MIT
> +
> +#include <linux/export.h>
> +#include <linux/ktime.h>
> +#include <linux/timekeeping.h>
> +
> +#include <drm/drm_util.h>
> +
> +/**
> + * drm_timeout_abs_to_jiffies - calculate jiffies timeout from absolute value
> + *
> + * @timeout_nsec: timeout nsec component in ns, 0 for poll
> + *
> + * Calculate the timeout in jiffies from an absolute time in sec/nsec.
> + */
> +signed long drm_timeout_abs_to_jiffies(int64_t timeout_nsec)
> +{
> +	ktime_t abs_timeout, now;
> +	u64 timeout_ns, timeout_jiffies64;
> +
> +	/* make 0 timeout means poll - absolute 0 doesn't seem valid */
> +	if (timeout_nsec == 0)
> +		return 0;
> +
> +	abs_timeout = ns_to_ktime(timeout_nsec);
> +	now = ktime_get();
> +
> +	if (!ktime_after(abs_timeout, now))
> +		return 0;
> +
> +	timeout_ns = ktime_to_ns(ktime_sub(abs_timeout, now));
> +
> +	timeout_jiffies64 = nsecs_to_jiffies64(timeout_ns);
> +	/*  clamp timeout to avoid infinite timeout */
> +	if (timeout_jiffies64 >= MAX_SCHEDULE_TIMEOUT - 1)
> +		return MAX_SCHEDULE_TIMEOUT - 1;
> +
> +	return timeout_jiffies64 + 1;
> +}
> +EXPORT_SYMBOL(drm_timeout_abs_to_jiffies);
> diff --git a/drivers/gpu/drm/lima/lima_gem.c b/drivers/gpu/drm/lima/lima_gem.c
> index 0f1ca0b0db49..5cdd06682afe 100644
> --- a/drivers/gpu/drm/lima/lima_gem.c
> +++ b/drivers/gpu/drm/lima/lima_gem.c
> @@ -10,7 +10,7 @@
>   
>   #include <drm/drm_file.h>
>   #include <drm/drm_syncobj.h>
> -#include <drm/drm_utils.h>
> +#include <drm/drm_util.h>
>   
>   #include <drm/lima_drm.h>
>   
> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index fa619fe72086..581df5b724e2 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -11,7 +11,7 @@
>   #include <drm/drm_drv.h>
>   #include <drm/drm_ioctl.h>
>   #include <drm/drm_syncobj.h>
> -#include <drm/drm_utils.h>
> +#include <drm/drm_util.h>
>   
>   #include "panfrost_device.h"
>   #include "panfrost_gem.h"
> diff --git a/drivers/gpu/drm/tegra/uapi.c b/drivers/gpu/drm/tegra/uapi.c
> index 5adab6b22916..6d5601517a34 100644
> --- a/drivers/gpu/drm/tegra/uapi.c
> +++ b/drivers/gpu/drm/tegra/uapi.c
> @@ -7,7 +7,7 @@
>   
>   #include <drm/drm_drv.h>
>   #include <drm/drm_file.h>
> -#include <drm/drm_utils.h>
> +#include <drm/drm_util.h>
>   
>   #include "drm.h"
>   #include "uapi.h"
> diff --git a/include/drm/drm_util.h b/include/drm/drm_util.h
> index 79952d8c4bba..3d719190cfd9 100644
> --- a/include/drm/drm_util.h
> +++ b/include/drm/drm_util.h
> @@ -80,4 +80,5 @@ static inline bool drm_can_sleep(void)
>   	return true;
>   }
>   
> +signed long drm_timeout_abs_to_jiffies(int64_t timeout_nsec);
>   #endif
> diff --git a/include/drm/drm_utils.h b/include/drm/drm_utils.h
> index 70775748d243..bae225f0a24b 100644
> --- a/include/drm/drm_utils.h
> +++ b/include/drm/drm_utils.h
> @@ -14,6 +14,4 @@
>   
>   int drm_get_panel_orientation_quirk(int width, int height);
>   
> -signed long drm_timeout_abs_to_jiffies(int64_t timeout_nsec);
> -
>   #endif
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

Re: [PATCH 85/86] drm: move drm_timeout_abs_to_jiffies to drm_util

[Sam Ravnborg]

Hi Thomas,

On Mon, Jan 23, 2023 at 09:57:13AM +0100, Thomas Zimmermann wrote:
> Hi Sam,
> 
> please see my comment below.
> 
> Am 21.01.23 um 21:09 schrieb Sam Ravnborg via B4 Submission Endpoint:
> > From: Sam Ravnborg <sam@ravnborg.org>
> > 
> > drm_timeout_abs_to_jiffies() was implmented in drm_syncobj where
> > it really did not belong. Create a drm_util file and move the
> > implementation. Likewise move the prototype and update all users.
> > 
> > Suggested-by: Daniel Vetter <daniel@ffwll.ch>
> > [https://lore.kernel.org/dri-devel/20190527185311.GS21222@phenom.ffwll.local/]
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > ---
> >   drivers/accel/ivpu/ivpu_gem.c           |  2 +-
> >   drivers/gpu/drm/Makefile                |  1 +
> >   drivers/gpu/drm/drm_syncobj.c           | 34 ----------------------------
> >   drivers/gpu/drm/drm_util.c              | 40 +++++++++++++++++++++++++++++++++
> >   drivers/gpu/drm/lima/lima_gem.c         |  2 +-
> >   drivers/gpu/drm/panfrost/panfrost_drv.c |  2 +-
> >   drivers/gpu/drm/tegra/uapi.c            |  2 +-
> >   include/drm/drm_util.h                  |  1 +
> >   include/drm/drm_utils.h                 |  2 --
> >   9 files changed, 46 insertions(+), 40 deletions(-)
> > 
> > diff --git a/drivers/accel/ivpu/ivpu_gem.c b/drivers/accel/ivpu/ivpu_gem.c
> > index d1f923971b4c..55aa94ba6c10 100644
> > --- a/drivers/accel/ivpu/ivpu_gem.c
> > +++ b/drivers/accel/ivpu/ivpu_gem.c
> > @@ -12,7 +12,7 @@
> >   #include <drm/drm_cache.h>
> >   #include <drm/drm_debugfs.h>
> >   #include <drm/drm_file.h>
> > -#include <drm/drm_utils.h>
> > +#include <drm/drm_util.h>
> >   #include "ivpu_drv.h"
> >   #include "ivpu_gem.h"
> > diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
> > index ab4460fcd63f..561b93d19685 100644
> > --- a/drivers/gpu/drm/Makefile
> > +++ b/drivers/gpu/drm/Makefile
> > @@ -42,6 +42,7 @@ drm-y := \
> >   	drm_syncobj.o \
> >   	drm_sysfs.o \
> >   	drm_trace_points.o \
> > +	drm_util.o \
> >   	drm_vblank.o \
> >   	drm_vblank_work.o \
> >   	drm_vma_manager.o \
> > diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
> > index 0c2be8360525..35f5416c5cfe 100644
> > --- a/drivers/gpu/drm/drm_syncobj.c
> > +++ b/drivers/gpu/drm/drm_syncobj.c
> > @@ -197,7 +197,6 @@
> >   #include <drm/drm_gem.h>
> >   #include <drm/drm_print.h>
> >   #include <drm/drm_syncobj.h>
> > -#include <drm/drm_utils.h>
> >   #include "drm_internal.h"
> > @@ -1114,39 +1113,6 @@ static signed long drm_syncobj_array_wait_timeout(struct drm_syncobj **syncobjs,
> >   	return timeout;
> >   }
> > -/**
> > - * drm_timeout_abs_to_jiffies - calculate jiffies timeout from absolute value
> > - *
> > - * @timeout_nsec: timeout nsec component in ns, 0 for poll
> > - *
> > - * Calculate the timeout in jiffies from an absolute time in sec/nsec.
> > - */
> > -signed long drm_timeout_abs_to_jiffies(int64_t timeout_nsec)

Thanks for the critical look at this!

> 
> This function converts an absolute timeout in nsec to a relative timeout in
> jiffies. (?)
> 
> It appears to me as if this helper should not exist. It uses a mixture of
> different time interfaces; combined with hardcoded policy for 0 and
> MAX_SCHEDULE_TIMEOUT.
> 
> There are only 3 callers of this helper. I think we should consider inlining
> it in each.
> 
> As part of this, maybe the use of ktime could go away. Convert nsecs to
> jiffies and do the rest of the computation in jiffies.

I blindly copied the existing function and did not consider the
implementation. Looking for a helper that do what we needs here turned
up empty. I also looked at your suggestion to do:
nsec in absolute => jiffies in absolute => jiffies in relative
But did not find something that is better than what we have.

I will leave it for now, and focus on the other parts of the patchset.
In the vain hope someone else takes a look.

	Sam

Re: [PATCH 85/86] drm: move drm_timeout_abs_to_jiffies to drm_util

[Thomas Zimmermann]

[-- Attachment #1.1: Type: text/plain, Size: 4493 bytes --]

Hi

Am 23.01.23 um 21:46 schrieb Sam Ravnborg:
> Hi Thomas,
> 
> On Mon, Jan 23, 2023 at 09:57:13AM +0100, Thomas Zimmermann wrote:
>> Hi Sam,
>>
>> please see my comment below.
>>
>> Am 21.01.23 um 21:09 schrieb Sam Ravnborg via B4 Submission Endpoint:
>>> From: Sam Ravnborg <sam@ravnborg.org>
>>>
>>> drm_timeout_abs_to_jiffies() was implmented in drm_syncobj where
>>> it really did not belong. Create a drm_util file and move the
>>> implementation. Likewise move the prototype and update all users.
>>>
>>> Suggested-by: Daniel Vetter <daniel@ffwll.ch>
>>> [https://lore.kernel.org/dri-devel/20190527185311.GS21222@phenom.ffwll.local/]
>>> Cc: Daniel Vetter <daniel@ffwll.ch>
>>> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
>>> ---
>>>    drivers/accel/ivpu/ivpu_gem.c           |  2 +-
>>>    drivers/gpu/drm/Makefile                |  1 +
>>>    drivers/gpu/drm/drm_syncobj.c           | 34 ----------------------------
>>>    drivers/gpu/drm/drm_util.c              | 40 +++++++++++++++++++++++++++++++++
>>>    drivers/gpu/drm/lima/lima_gem.c         |  2 +-
>>>    drivers/gpu/drm/panfrost/panfrost_drv.c |  2 +-
>>>    drivers/gpu/drm/tegra/uapi.c            |  2 +-
>>>    include/drm/drm_util.h                  |  1 +
>>>    include/drm/drm_utils.h                 |  2 --
>>>    9 files changed, 46 insertions(+), 40 deletions(-)
>>>
>>> diff --git a/drivers/accel/ivpu/ivpu_gem.c b/drivers/accel/ivpu/ivpu_gem.c
>>> index d1f923971b4c..55aa94ba6c10 100644
>>> --- a/drivers/accel/ivpu/ivpu_gem.c
>>> +++ b/drivers/accel/ivpu/ivpu_gem.c
>>> @@ -12,7 +12,7 @@
>>>    #include <drm/drm_cache.h>
>>>    #include <drm/drm_debugfs.h>
>>>    #include <drm/drm_file.h>
>>> -#include <drm/drm_utils.h>
>>> +#include <drm/drm_util.h>
>>>    #include "ivpu_drv.h"
>>>    #include "ivpu_gem.h"
>>> diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
>>> index ab4460fcd63f..561b93d19685 100644
>>> --- a/drivers/gpu/drm/Makefile
>>> +++ b/drivers/gpu/drm/Makefile
>>> @@ -42,6 +42,7 @@ drm-y := \
>>>    	drm_syncobj.o \
>>>    	drm_sysfs.o \
>>>    	drm_trace_points.o \
>>> +	drm_util.o \
>>>    	drm_vblank.o \
>>>    	drm_vblank_work.o \
>>>    	drm_vma_manager.o \
>>> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
>>> index 0c2be8360525..35f5416c5cfe 100644
>>> --- a/drivers/gpu/drm/drm_syncobj.c
>>> +++ b/drivers/gpu/drm/drm_syncobj.c
>>> @@ -197,7 +197,6 @@
>>>    #include <drm/drm_gem.h>
>>>    #include <drm/drm_print.h>
>>>    #include <drm/drm_syncobj.h>
>>> -#include <drm/drm_utils.h>
>>>    #include "drm_internal.h"
>>> @@ -1114,39 +1113,6 @@ static signed long drm_syncobj_array_wait_timeout(struct drm_syncobj **syncobjs,
>>>    	return timeout;
>>>    }
>>> -/**
>>> - * drm_timeout_abs_to_jiffies - calculate jiffies timeout from absolute value
>>> - *
>>> - * @timeout_nsec: timeout nsec component in ns, 0 for poll
>>> - *
>>> - * Calculate the timeout in jiffies from an absolute time in sec/nsec.
>>> - */
>>> -signed long drm_timeout_abs_to_jiffies(int64_t timeout_nsec)
> 
> Thanks for the critical look at this!
> 
>>
>> This function converts an absolute timeout in nsec to a relative timeout in
>> jiffies. (?)
>>
>> It appears to me as if this helper should not exist. It uses a mixture of
>> different time interfaces; combined with hardcoded policy for 0 and
>> MAX_SCHEDULE_TIMEOUT.
>>
>> There are only 3 callers of this helper. I think we should consider inlining
>> it in each.
>>
>> As part of this, maybe the use of ktime could go away. Convert nsecs to
>> jiffies and do the rest of the computation in jiffies.
> 
> I blindly copied the existing function and did not consider the
> implementation. Looking for a helper that do what we needs here turned
> up empty. I also looked at your suggestion to do:
> nsec in absolute => jiffies in absolute => jiffies in relative
> But did not find something that is better than what we have.
> 
> I will leave it for now, and focus on the other parts of the patchset.
> In the vain hope someone else takes a look.

No problem. You can add

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

to patches 85 and 86 as well.

Best regards
Thomas

> 
> 	Sam

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

[PATCH 86/86] drm: Move drm_get_panel_orientation_quirk prototype to drm_panel

[Sam Ravnborg via B4 Submission Endpoint]

From: Sam Ravnborg <sam@ravnborg.org>

drm_panel already contain some panel orientation stuff,
So this is a good home for the prototype.

Update all users of drm_get_panel_orientation_quirk.
Remove drm_utils.h header as it is no longer used.

Suggested-by: Daniel Vetter <daniel@ffwll.ch>
[https://lore.kernel.org/dri-devel/20190527185311.GS21222@phenom.ffwll.local/]
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/drm_connector.c                |  1 -
 drivers/gpu/drm/drm_panel_orientation_quirks.c |  2 +-
 drivers/video/fbdev/efifb.c                    |  2 +-
 include/drm/drm_panel.h                        |  1 +
 include/drm/drm_utils.h                        | 17 -----------------
 5 files changed, 3 insertions(+), 20 deletions(-)

diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
index 9d0250c28e9b..b39f4e807685 100644
--- a/drivers/gpu/drm/drm_connector.c
+++ b/drivers/gpu/drm/drm_connector.c
@@ -31,7 +31,6 @@
 #include <drm/drm_print.h>
 #include <drm/drm_privacy_screen_consumer.h>
 #include <drm/drm_sysfs.h>
-#include <drm/drm_utils.h>
 
 #include <linux/fb.h>
 #include <linux/uaccess.h>
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index ca531dbb749d..589adb3e26c6 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -11,7 +11,7 @@
 #include <linux/dmi.h>
 #include <linux/module.h>
 #include <drm/drm_connector.h>
-#include <drm/drm_utils.h>
+#include <drm/drm_panel.h>
 
 #ifdef CONFIG_DMI
 
diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
index a5779fb453a2..37487b945007 100644
--- a/drivers/video/fbdev/efifb.c
+++ b/drivers/video/fbdev/efifb.c
@@ -20,8 +20,8 @@
 #include <linux/pm_runtime.h>
 #include <video/vga.h>
 #include <asm/efi.h>
-#include <drm/drm_utils.h> /* For drm_get_panel_orientation_quirk */
 #include <drm/drm_connector.h>  /* For DRM_MODE_PANEL_ORIENTATION_* */
+#include <drm/drm_panel.h> /* For drm_get_panel_orientation_quirk */
 
 struct bmp_file_header {
 	u16 id;
diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h
index 432fab2347eb..95e509feba75 100644
--- a/include/drm/drm_panel.h
+++ b/include/drm/drm_panel.h
@@ -200,6 +200,7 @@ struct drm_panel {
 	bool prepare_prev_first;
 };
 
+int drm_get_panel_orientation_quirk(int width, int height);
 void drm_panel_init(struct drm_panel *panel, struct device *dev,
 		    const struct drm_panel_funcs *funcs,
 		    int connector_type);
diff --git a/include/drm/drm_utils.h b/include/drm/drm_utils.h
deleted file mode 100644
index bae225f0a24b..000000000000
--- a/include/drm/drm_utils.h
+++ /dev/null
@@ -1,17 +0,0 @@
-/* SPDX-License-Identifier: MIT */
-/*
- * Function prototypes for misc. drm utility functions.
- * Specifically this file is for function prototypes for functions which
- * may also be used outside of drm code (e.g. in fbdev drivers).
- *
- * Copyright (C) 2017 Hans de Goede <hdegoede@redhat.com>
- */
-
-#ifndef __DRM_UTILS_H__
-#define __DRM_UTILS_H__
-
-#include <linux/types.h>
-
-int drm_get_panel_orientation_quirk(int width, int height);
-
-#endif

-- 
2.34.1

Re: [PATCH 00/86] drm: Header file maintenance

[Thomas Zimmermann]

[-- Attachment #1.1: Type: text/plain, Size: 27872 bytes --]

Hi Sam,

nice patchset. For patches 1 to 84, you can add

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

Please consider my (few) comments.

For patches 85 and 86, others may want to comment on those. Ping me if 
no reviewers shown up in the next days.

Best regards
Thomas

Am 21.01.23 um 21:07 schrieb Sam Ravnborg via B4 Submission Endpoint:
> This patchset reduces the headers pulled in by other headers a little.
> The end result is more specific dependencies and slightly faster build
> times.
> This ended up as a lot of patches - which makes it easier to do review
> and handle future conflicts.
> 
> drm_print
> - drm_print.h included a number of files that are not required by the
>    header file. Push the nesessary includes to their users and clean up
>    drm_print.h to the minimal set of include files.
> 
> drm_atomic_helper
> - drm_atomic_helper.h included a number of files that are not required by the
>    header file. Push the nesessary includes to their users and clean up
>    drm_atomic_helper.h to the minimal set of include files.
> 
> For both the above changes this was a manual process involving bulding
> and adding missing includes.
> I have carefully maintained the sorting of the include files (but may
> have failed in a few places).
> I did not find any way to automate the process, so it was a tad boring.
> 
> No attempt was done to find redundant includes - I hope we can find some
> tooling to help us one day.
> 
> On top of the above drm_utils was removed in a small series of two
> patches. One function was moved to drm_util (as per suggestion from
> Daniel in an old mail). Another prototype was moved to a more
> appropriate place.
> 
> The diffstat add more lines than we delete, but the positive thing here
> is that the individual files now pull in less files when building.
> 
> Sam
> 
> ---
> Sam Ravnborg (86):
>        drm/komeda: Direct include headers from drm_print
>        drm/bridge: ite-it6505: Direct include headers from drm_print
>        drm/bridge: panel: Direct include headers from drm_print
>        drm/msm: Direct include headers from drm_print
>        drm/nouveau: Direct include headers from drm_print
>        drm/omapdrm: Direct include headers from drm_print
>        drm/radeon: Direct include headers from drm_print
>        drm/ttm: Direct include headers from drm_print
>        drm/scheduler: Direct include headers from drm_print
>        drm/armada: Direct include headers from drm_print
>        drm/sti: Direct include headers from drm_print
>        drm/vc4: Direct include headers from drm_print
>        drm/drm_print: Direct include headers from drm_print
>        drm/vmwgfx: Direct include headers from drm_print
>        drm/i915: Direct include headers from drm_print
>        drm/drm_print: Minimize include footprint
>        drm/xlnx: Direct include headers from drm_atomic_helper
>        drm/amd: Direct include headers from drm_atomic_helper
>        drm/komeda: Direct include headers from drm_atomic_helper
>        drm/arm/hdlcd: Direct include headers from drm_atomic_helper
>        drm/arm/malidp: Direct include headers from drm_atomic_helper
>        drm/armada: Direct include headers from drm_atomic_helper
>        drm/aspeed: Direct include headers from drm_atomic_helper
>        drm/ast: Direct include headers from drm_atomic_helper
>        drm/atmel-hlcdc: Direct include headers from drm_atomic_helper
>        drm/bridge: adv7511: Direct include headers from drm_atomic_helper
>        drm/bridge: analogix: Direct include headers from drm_atomic_helper
>        drm/bridge: chipone: Direct include headers from drm_atomic_helper
>        drm/bridge: chrontel: Direct include headers from drm_atomic_helper
>        drm/bridge: display-connector: Direct include headers from drm_atomic_helper
>        drm/bridge: fsl-ldb: Direct include headers from drm_atomic_helper
>        drm/bridge: ite: Direct include headers from drm_atomic_helper
>        drm/bridge: lontium: Direct include headers from drm_atomic_helper
>        drm/bridge: lvds-codec: Direct include headers from drm_atomic_helper
>        drm/bridge: megachips: Direct include headers from drm_atomic_helper
>        drm/bridge: nxp: Direct include headers from drm_atomic_helper
>        drm/bridge: panel: Direct include headers from drm_atomic_helper
>        drm/bridge: sii902x: Direct include headers from drm_atomic_helper
>        drm/bridge: simple-bridge: Direct include headers from drm_atomic_helper
>        drm/bridge: synopsys: Direct include headers from drm_atomic_helper
>        drm/bridge: tc358767: Direct include headers from drm_atomic_helper
>        drm/bridge: ti: Direct include headers from drm_atomic_helper
>        drm/display: Direct include headers from drm_atomic_helper
>        drm: Direct include headers from drm_atomic_helper
>        drm/exynos: Direct include headers from drm_atomic_helper
>        drm/fsl-dcu: Direct include headers from drm_atomic_helper
>        drm/gud: Direct include headers from drm_atomic_helper
>        drm/hisilicon: Direct include headers from drm_atomic_helper
>        drm/hyperv: Direct include headers from drm_atomic_helper
>        drm/i2c: Direct include headers from drm_atomic_helper
>        drm/i915: Direct include headers from drm_atomic_helper
>        drm/imx: Direct include headers from drm_atomic_helper
>        drm/ingenic: Direct include headers from drm_atomic_helper
>        drm/kmb: Direct include headers from drm_atomic_helper
>        drm/logicvc: Direct include headers from drm_atomic_helper
>        drm/mcde: Direct include headers from drm_atomic_helper
>        drm/mediatek: Direct include headers from drm_atomic_helper
>        drm/meson: Direct include headers from drm_atomic_helper
>        drm/mgag200: Direct include headers from drm_atomic_helper
>        drm/msm: Direct include headers from drm_atomic_helper
>        drm/mxsfb: Direct include headers from drm_atomic_helper
>        drm/nouveau: Direct include headers from drm_atomic_helper
>        drm/omapdrm: Direct include headers from drm_atomic_helper
>        drm/qxl: Direct include headers from drm_atomic_helper
>        drm/rcar-du: Direct include headers from drm_atomic_helper
>        drm/rockchip: Direct include headers from drm_atomic_helper
>        drm/solomon: Direct include headers from drm_atomic_helper
>        drm/sprd: Direct include headers from drm_atomic_helper
>        drm/sti: Direct include headers from drm_atomic_helper
>        drm/stm: Direct include headers from drm_atomic_helper
>        drm/sun4i: Direct include headers from drm_atomic_helper
>        drm/tegra: Direct include headers from drm_atomic_helper
>        drm/tests: Direct include headers from drm_atomic_helper
>        drm/tidss: Direct include headers from drm_atomic_helper
>        drm/tilcdc: Direct include headers from drm_atomic_helper
>        drm/tiny: Direct include headers from drm_atomic_helper
>        drm/udl: Direct include headers from drm_atomic_helper
>        drm/vboxvideo: Direct include headers from drm_atomic_helper
>        drm/vc4: Direct include headers from drm_atomic_helper
>        drm/virtio: Direct include headers from drm_atomic_helper
>        drm/vkms: Direct include headers from drm_atomic_helper
>        drm/vmwgfx: Direct include headers from drm_atomic_helper
>        drm/xen: Direct include headers from drm_atomic_helper
>        drm/drm_atomic_helper: Minimize include footprint
>        drm: move drm_timeout_abs_to_jiffies to drm_util
>        drm: Move drm_get_panel_orientation_quirk prototype to drm_panel
> 
>   drivers/accel/ivpu/ivpu_gem.c                      |  2 +-
>   drivers/gpu/drm/Makefile                           |  1 +
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c           |  3 ++
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c  |  2 ++
>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c |  2 ++
>   .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c    |  2 ++
>   .../drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c    |  2 ++
>   .../gpu/drm/arm/display/komeda/d71/d71_component.c |  2 ++
>   drivers/gpu/drm/arm/display/komeda/komeda_crtc.c   |  2 ++
>   drivers/gpu/drm/arm/display/komeda/komeda_drv.c    |  1 +
>   .../drm/arm/display/komeda/komeda_framebuffer.c    |  1 +
>   drivers/gpu/drm/arm/display/komeda/komeda_kms.c    |  1 +
>   .../gpu/drm/arm/display/komeda/komeda_pipeline.c   |  1 +
>   drivers/gpu/drm/arm/display/komeda/komeda_plane.c  |  2 ++
>   .../drm/arm/display/komeda/komeda_private_obj.c    |  3 ++
>   .../drm/arm/display/komeda/komeda_wb_connector.c   |  2 ++
>   drivers/gpu/drm/arm/hdlcd_crtc.c                   |  2 ++
>   drivers/gpu/drm/arm/malidp_crtc.c                  |  2 ++
>   drivers/gpu/drm/arm/malidp_drv.c                   |  1 +
>   drivers/gpu/drm/arm/malidp_mw.c                    |  2 ++
>   drivers/gpu/drm/arm/malidp_planes.c                |  2 ++
>   drivers/gpu/drm/armada/armada_crtc.c               |  2 ++
>   drivers/gpu/drm/armada/armada_debugfs.c            |  1 +
>   drivers/gpu/drm/armada/armada_overlay.c            |  2 ++
>   drivers/gpu/drm/armada/armada_plane.c              |  2 ++
>   drivers/gpu/drm/aspeed/aspeed_gfx_out.c            |  2 ++
>   drivers/gpu/drm/ast/ast_drv.c                      |  1 +
>   drivers/gpu/drm/ast/ast_mode.c                     |  1 +
>   drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c     |  1 +
>   drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c    |  2 ++
>   drivers/gpu/drm/bridge/adv7511/adv7511_drv.c       |  2 ++
>   drivers/gpu/drm/bridge/analogix/analogix-anx6345.c |  2 ++
>   drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c |  2 ++
>   drivers/gpu/drm/bridge/analogix/analogix_dp_core.c |  2 ++
>   drivers/gpu/drm/bridge/analogix/anx7625.c          |  1 +
>   drivers/gpu/drm/bridge/chipone-icn6211.c           |  1 +
>   drivers/gpu/drm/bridge/chrontel-ch7033.c           |  2 ++
>   drivers/gpu/drm/bridge/display-connector.c         |  1 +
>   drivers/gpu/drm/bridge/fsl-ldb.c                   |  1 +
>   drivers/gpu/drm/bridge/ite-it6505.c                |  3 ++
>   drivers/gpu/drm/bridge/ite-it66121.c               |  1 +
>   drivers/gpu/drm/bridge/lontium-lt8912b.c           |  2 ++
>   drivers/gpu/drm/bridge/lontium-lt9211.c            |  1 +
>   drivers/gpu/drm/bridge/lontium-lt9611.c            |  2 ++
>   drivers/gpu/drm/bridge/lontium-lt9611uxc.c         |  2 ++
>   drivers/gpu/drm/bridge/lvds-codec.c                |  1 +
>   .../drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c   |  2 ++
>   drivers/gpu/drm/bridge/nxp-ptn3460.c               |  2 ++
>   drivers/gpu/drm/bridge/panel.c                     |  3 ++
>   drivers/gpu/drm/bridge/sii902x.c                   |  2 ++
>   drivers/gpu/drm/bridge/simple-bridge.c             |  2 ++
>   drivers/gpu/drm/bridge/synopsys/dw-hdmi.c          |  2 ++
>   drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c      |  1 +
>   drivers/gpu/drm/bridge/tc358767.c                  |  2 ++
>   drivers/gpu/drm/bridge/ti-dlpc3433.c               |  1 +
>   drivers/gpu/drm/bridge/ti-sn65dsi83.c              |  1 +
>   drivers/gpu/drm/bridge/ti-sn65dsi86.c              |  1 +
>   drivers/gpu/drm/bridge/ti-tfp410.c                 |  2 ++
>   drivers/gpu/drm/display/drm_dp_mst_topology.c      |  1 +
>   drivers/gpu/drm/drm_atomic_helper.c                |  1 +
>   drivers/gpu/drm/drm_connector.c                    |  1 -
>   drivers/gpu/drm/drm_crtc_helper.c                  |  1 +
>   drivers/gpu/drm/drm_fb_dma_helper.c                |  1 +
>   drivers/gpu/drm/drm_gem_framebuffer_helper.c       |  1 +
>   drivers/gpu/drm/drm_mipi_dbi.c                     |  2 ++
>   drivers/gpu/drm/drm_panel_orientation_quirks.c     |  2 +-
>   drivers/gpu/drm/drm_print.c                        |  1 +
>   drivers/gpu/drm/drm_simple_kms_helper.c            |  2 ++
>   drivers/gpu/drm/drm_syncobj.c                      | 34 ------------------
>   drivers/gpu/drm/drm_util.c                         | 40 ++++++++++++++++++++++
>   drivers/gpu/drm/exynos/exynos_dp.c                 |  1 +
>   drivers/gpu/drm/exynos/exynos_drm_crtc.c           |  2 ++
>   drivers/gpu/drm/exynos/exynos_drm_dpi.c            |  2 ++
>   drivers/gpu/drm/exynos/exynos_drm_drv.c            |  4 +++
>   drivers/gpu/drm/exynos/exynos_drm_dsi.c            |  1 +
>   drivers/gpu/drm/exynos/exynos_drm_fb.c             |  2 ++
>   drivers/gpu/drm/exynos/exynos_drm_plane.c          |  2 ++
>   drivers/gpu/drm/exynos/exynos_drm_vidi.c           |  2 ++
>   drivers/gpu/drm/exynos/exynos_hdmi.c               |  2 ++
>   drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c         |  2 ++
>   drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c        |  2 ++
>   drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c          |  2 ++
>   drivers/gpu/drm/gud/gud_drv.c                      |  1 +
>   drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c     |  2 ++
>   drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h    |  3 ++
>   drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c   |  2 ++
>   drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c       |  1 +
>   drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c    |  2 ++
>   drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c    |  1 +
>   drivers/gpu/drm/hyperv/hyperv_drm_drv.c            |  1 +
>   drivers/gpu/drm/hyperv/hyperv_drm_modeset.c        |  2 ++
>   drivers/gpu/drm/i2c/tda998x_drv.c                  |  2 ++
>   drivers/gpu/drm/i915/display/icl_dsi.c             |  2 ++
>   drivers/gpu/drm/i915/display/intel_atomic.c        |  1 +
>   drivers/gpu/drm/i915/display/intel_atomic_plane.c  |  2 ++
>   drivers/gpu/drm/i915/display/intel_connector.c     |  1 +
>   drivers/gpu/drm/i915/display/intel_crt.c           |  2 ++
>   drivers/gpu/drm/i915/display/intel_crtc.c          |  1 +
>   drivers/gpu/drm/i915/display/intel_display.c       |  3 ++
>   drivers/gpu/drm/i915/display/intel_dmc.c           |  1 +
>   drivers/gpu/drm/i915/display/intel_dp.c            |  2 ++
>   drivers/gpu/drm/i915/display/intel_dp_mst.c        |  2 ++
>   drivers/gpu/drm/i915/display/intel_dvo.c           |  2 ++
>   drivers/gpu/drm/i915/display/intel_hdmi.c          |  2 ++
>   drivers/gpu/drm/i915/display/intel_lvds.c          |  2 ++
>   drivers/gpu/drm/i915/display/intel_sdvo.c          |  2 ++
>   drivers/gpu/drm/i915/display/intel_tv.c            |  2 ++
>   drivers/gpu/drm/i915/display/vlv_dsi.c             |  2 ++
>   drivers/gpu/drm/i915/i915_debugfs.c                |  1 +
>   drivers/gpu/drm/i915/i915_debugfs_params.c         |  1 +
>   drivers/gpu/drm/i915/i915_params.c                 |  1 +
>   drivers/gpu/drm/imx/dcss/dcss-crtc.c               |  2 ++
>   drivers/gpu/drm/imx/dcss/dcss-kms.c                |  1 +
>   drivers/gpu/drm/imx/dcss/dcss-plane.c              |  2 ++
>   drivers/gpu/drm/imx/ipuv3/dw_hdmi-imx.c            |  1 +
>   drivers/gpu/drm/imx/ipuv3/imx-drm-core.c           |  2 ++
>   drivers/gpu/drm/imx/ipuv3/imx-ldb.c                |  2 ++
>   drivers/gpu/drm/imx/ipuv3/imx-tve.c                |  2 ++
>   drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c             |  3 ++
>   drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c            |  2 ++
>   drivers/gpu/drm/imx/ipuv3/parallel-display.c       |  2 ++
>   drivers/gpu/drm/ingenic/ingenic-drm-drv.c          |  3 ++
>   drivers/gpu/drm/ingenic/ingenic-ipu.c              |  2 ++
>   drivers/gpu/drm/kmb/kmb_crtc.c                     |  1 +
>   drivers/gpu/drm/kmb/kmb_drv.h                      |  1 +
>   drivers/gpu/drm/kmb/kmb_plane.c                    |  2 ++
>   drivers/gpu/drm/lima/lima_gem.c                    |  2 +-
>   drivers/gpu/drm/logicvc/logicvc_crtc.c             |  2 ++
>   drivers/gpu/drm/logicvc/logicvc_crtc.h             |  2 ++
>   drivers/gpu/drm/logicvc/logicvc_interface.c        |  1 +
>   drivers/gpu/drm/logicvc/logicvc_layer.c            |  2 ++
>   drivers/gpu/drm/mcde/mcde_drv.c                    |  1 +
>   drivers/gpu/drm/mediatek/mtk_dp.c                  |  1 +
>   drivers/gpu/drm/mediatek/mtk_dpi.c                 |  1 +
>   drivers/gpu/drm/mediatek/mtk_drm_crtc.c            |  2 ++
>   drivers/gpu/drm/mediatek/mtk_drm_drv.c             |  2 ++
>   drivers/gpu/drm/mediatek/mtk_drm_plane.c           |  3 ++
>   drivers/gpu/drm/mediatek/mtk_dsi.c                 |  1 +
>   drivers/gpu/drm/mediatek/mtk_hdmi.c                |  1 +
>   drivers/gpu/drm/meson/meson_crtc.c                 |  3 ++
>   drivers/gpu/drm/meson/meson_drv.c                  |  1 +
>   drivers/gpu/drm/meson/meson_encoder_cvbs.c         |  1 +
>   drivers/gpu/drm/meson/meson_encoder_hdmi.c         |  1 +
>   drivers/gpu/drm/meson/meson_overlay.c              |  2 ++
>   drivers/gpu/drm/meson/meson_plane.c                |  2 ++
>   drivers/gpu/drm/mgag200/mgag200_g200.c             |  2 ++
>   drivers/gpu/drm/mgag200/mgag200_g200eh.c           |  2 ++
>   drivers/gpu/drm/mgag200/mgag200_g200eh3.c          |  2 ++
>   drivers/gpu/drm/mgag200/mgag200_g200er.c           |  2 ++
>   drivers/gpu/drm/mgag200/mgag200_g200ev.c           |  2 ++
>   drivers/gpu/drm/mgag200/mgag200_g200ew3.c          |  2 ++
>   drivers/gpu/drm/mgag200/mgag200_g200se.c           |  2 ++
>   drivers/gpu/drm/mgag200/mgag200_g200wb.c           |  2 ++
>   drivers/gpu/drm/mgag200/mgag200_mode.c             |  2 ++
>   drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c           |  2 ++
>   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c        |  1 +
>   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c        |  2 ++
>   drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c            |  1 +
>   drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c          |  2 ++
>   drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c      |  2 ++
>   drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c          |  2 ++
>   drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c   |  1 +
>   drivers/gpu/drm/msm/disp/mdp4/mdp4_dtv_encoder.c   |  2 ++
>   drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c           |  1 +
>   drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c  |  2 ++
>   .../gpu/drm/msm/disp/mdp4/mdp4_lvds_connector.c    |  3 ++
>   drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c         |  2 ++
>   drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c          |  2 ++
>   drivers/gpu/drm/msm/disp/mdp5/mdp5_encoder.c       |  1 +
>   drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c           |  1 +
>   drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.h           |  2 ++
>   drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c         |  2 ++
>   drivers/gpu/drm/msm/dp/dp_drm.c                    |  1 +
>   drivers/gpu/drm/msm/msm_drv.c                      |  2 ++
>   drivers/gpu/drm/msm/msm_fb.c                       |  1 +
>   drivers/gpu/drm/mxsfb/lcdif_drv.c                  |  2 ++
>   drivers/gpu/drm/mxsfb/lcdif_kms.c                  |  2 ++
>   drivers/gpu/drm/mxsfb/mxsfb_drv.c                  |  2 ++
>   drivers/gpu/drm/mxsfb/mxsfb_kms.c                  |  2 ++
>   drivers/gpu/drm/nouveau/dispnv50/crc.c             |  2 ++
>   drivers/gpu/drm/nouveau/dispnv50/disp.c            |  1 +
>   drivers/gpu/drm/nouveau/dispnv50/head.c            |  2 ++
>   drivers/gpu/drm/nouveau/dispnv50/wndw.c            |  2 ++
>   drivers/gpu/drm/nouveau/nouveau_connector.c        |  2 ++
>   drivers/gpu/drm/nouveau/nouveau_display.c          |  1 +
>   drivers/gpu/drm/omapdrm/omap_crtc.c                |  2 ++
>   drivers/gpu/drm/omapdrm/omap_drv.c                 |  3 ++
>   drivers/gpu/drm/omapdrm/omap_fb.c                  |  1 +
>   drivers/gpu/drm/omapdrm/omap_plane.c               |  2 ++
>   drivers/gpu/drm/panfrost/panfrost_drv.c            |  2 +-
>   drivers/gpu/drm/qxl/qxl_display.c                  |  2 ++
>   drivers/gpu/drm/radeon/r100.c                      |  1 +
>   drivers/gpu/drm/radeon/r300.c                      |  1 +
>   drivers/gpu/drm/radeon/r420.c                      |  1 +
>   drivers/gpu/drm/radeon/r600.c                      |  1 +
>   drivers/gpu/drm/radeon/radeon_fence.c              |  1 +
>   drivers/gpu/drm/radeon/radeon_gem.c                |  1 +
>   drivers/gpu/drm/radeon/radeon_ib.c                 |  2 ++
>   drivers/gpu/drm/radeon/radeon_pm.c                 |  1 +
>   drivers/gpu/drm/radeon/radeon_ring.c               |  2 ++
>   drivers/gpu/drm/radeon/radeon_ttm.c                |  1 +
>   drivers/gpu/drm/radeon/rs400.c                     |  1 +
>   drivers/gpu/drm/radeon/rv515.c                     |  1 +
>   drivers/gpu/drm/rcar-du/rcar_du_crtc.c             |  2 ++
>   drivers/gpu/drm/rcar-du/rcar_du_drv.c              |  1 +
>   drivers/gpu/drm/rcar-du/rcar_du_kms.c              |  1 +
>   drivers/gpu/drm/rcar-du/rcar_du_plane.c            |  2 ++
>   drivers/gpu/drm/rcar-du/rcar_du_vsp.c              |  2 ++
>   drivers/gpu/drm/rcar-du/rcar_du_writeback.c        |  2 ++
>   drivers/gpu/drm/rcar-du/rcar_lvds.c                |  1 +
>   drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c            |  1 +
>   drivers/gpu/drm/rcar-du/rzg2l_mipi_dsi.c           |  1 +
>   drivers/gpu/drm/rockchip/analogix_dp-rockchip.c    |  2 ++
>   drivers/gpu/drm/rockchip/cdn-dp-core.c             |  2 ++
>   drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c    |  1 +
>   drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c        |  1 +
>   drivers/gpu/drm/rockchip/inno_hdmi.c               |  2 ++
>   drivers/gpu/drm/rockchip/rk3066_hdmi.c             |  2 ++
>   drivers/gpu/drm/rockchip/rockchip_drm_drv.c        |  1 +
>   drivers/gpu/drm/rockchip/rockchip_drm_drv.h        |  1 +
>   drivers/gpu/drm/rockchip/rockchip_drm_fb.c         |  1 +
>   drivers/gpu/drm/rockchip/rockchip_drm_vop.c        |  2 ++
>   drivers/gpu/drm/rockchip/rockchip_drm_vop2.c       |  2 ++
>   drivers/gpu/drm/rockchip/rockchip_lvds.c           |  2 ++
>   drivers/gpu/drm/rockchip/rockchip_rgb.c            |  1 +
>   drivers/gpu/drm/scheduler/sched_main.c             |  1 +
>   drivers/gpu/drm/solomon/ssd130x.c                  |  2 ++
>   drivers/gpu/drm/sprd/sprd_dpu.c                    |  2 ++
>   drivers/gpu/drm/sprd/sprd_drm.c                    |  1 +
>   drivers/gpu/drm/sprd/sprd_dsi.c                    |  1 +
>   drivers/gpu/drm/sti/sti_crtc.c                     |  2 ++
>   drivers/gpu/drm/sti/sti_cursor.c                   |  2 ++
>   drivers/gpu/drm/sti/sti_drv.c                      |  1 +
>   drivers/gpu/drm/sti/sti_dvo.c                      |  2 ++
>   drivers/gpu/drm/sti/sti_gdp.c                      |  2 ++
>   drivers/gpu/drm/sti/sti_hda.c                      |  2 ++
>   drivers/gpu/drm/sti/sti_hdmi.c                     |  2 ++
>   drivers/gpu/drm/sti/sti_hqvdp.c                    |  2 ++
>   drivers/gpu/drm/sti/sti_tvout.c                    |  1 +
>   drivers/gpu/drm/sti/sti_vid.c                      |  1 +
>   drivers/gpu/drm/stm/ltdc.c                         |  2 ++
>   drivers/gpu/drm/sun4i/sun4i_crtc.c                 |  2 ++
>   drivers/gpu/drm/sun4i/sun4i_drv.c                  |  1 +
>   drivers/gpu/drm/sun4i/sun4i_framebuffer.c          |  1 +
>   drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c             |  2 ++
>   drivers/gpu/drm/sun4i/sun4i_layer.c                |  2 ++
>   drivers/gpu/drm/sun4i/sun4i_lvds.c                 |  2 ++
>   drivers/gpu/drm/sun4i/sun4i_rgb.c                  |  2 ++
>   drivers/gpu/drm/sun4i/sun4i_tv.c                   |  2 ++
>   drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c             |  2 ++
>   drivers/gpu/drm/sun4i/sun8i_ui_layer.c             |  2 ++
>   drivers/gpu/drm/sun4i/sun8i_vi_layer.c             |  2 ++
>   drivers/gpu/drm/tegra/dc.c                         |  2 ++
>   drivers/gpu/drm/tegra/drm.c                        |  2 ++
>   drivers/gpu/drm/tegra/dsi.c                        |  2 ++
>   drivers/gpu/drm/tegra/hdmi.c                       |  2 ++
>   drivers/gpu/drm/tegra/hub.c                        |  2 ++
>   drivers/gpu/drm/tegra/plane.c                      |  1 +
>   drivers/gpu/drm/tegra/rgb.c                        |  1 +
>   drivers/gpu/drm/tegra/sor.c                        |  2 ++
>   drivers/gpu/drm/tegra/uapi.c                       |  2 +-
>   drivers/gpu/drm/tests/drm_plane_helper_test.c      |  1 +
>   drivers/gpu/drm/tidss/tidss_crtc.c                 |  2 ++
>   drivers/gpu/drm/tidss/tidss_drv.c                  |  1 +
>   drivers/gpu/drm/tidss/tidss_kms.c                  |  1 +
>   drivers/gpu/drm/tidss/tidss_plane.c                |  2 ++
>   drivers/gpu/drm/tilcdc/tilcdc_crtc.c               |  1 +
>   drivers/gpu/drm/tilcdc/tilcdc_drv.c                |  1 +
>   drivers/gpu/drm/tilcdc/tilcdc_plane.c              |  2 ++
>   drivers/gpu/drm/tiny/arcpgu.c                      |  2 ++
>   drivers/gpu/drm/tiny/bochs.c                       |  3 ++
>   drivers/gpu/drm/tiny/gm12u320.c                    |  1 +
>   drivers/gpu/drm/tiny/repaper.c                     |  2 ++
>   drivers/gpu/drm/ttm/ttm_device.c                   |  1 +
>   drivers/gpu/drm/ttm/ttm_resource.c                 |  1 +
>   drivers/gpu/drm/ttm/ttm_tt.c                       |  1 +
>   drivers/gpu/drm/udl/udl_drv.c                      |  1 +
>   drivers/gpu/drm/udl/udl_modeset.c                  |  1 +
>   drivers/gpu/drm/vboxvideo/vbox_mode.c              |  2 ++
>   drivers/gpu/drm/vc4/vc4_crtc.c                     |  2 ++
>   drivers/gpu/drm/vc4/vc4_dpi.c                      |  1 +
>   drivers/gpu/drm/vc4/vc4_drv.h                      |  1 +
>   drivers/gpu/drm/vc4/vc4_dsi.c                      |  1 +
>   drivers/gpu/drm/vc4/vc4_hdmi.c                     |  2 ++
>   drivers/gpu/drm/vc4/vc4_kms.c                      |  2 ++
>   drivers/gpu/drm/vc4/vc4_plane.c                    |  2 ++
>   drivers/gpu/drm/vc4/vc4_txp.c                      |  2 ++
>   drivers/gpu/drm/vc4/vc4_vec.c                      |  2 ++
>   drivers/gpu/drm/virtio/virtgpu_display.c           |  3 ++
>   drivers/gpu/drm/virtio/virtgpu_plane.c             |  2 ++
>   drivers/gpu/drm/vkms/vkms_crtc.c                   |  2 ++
>   drivers/gpu/drm/vkms/vkms_drv.c                    |  1 +
>   drivers/gpu/drm/vkms/vkms_output.c                 |  2 ++
>   drivers/gpu/drm/vkms/vkms_plane.c                  |  1 +
>   drivers/gpu/drm/vkms/vkms_writeback.c              |  2 ++
>   drivers/gpu/drm/vmwgfx/vmwgfx_gem.c                |  2 ++
>   drivers/gpu/drm/vmwgfx/vmwgfx_kms.c                |  2 ++
>   drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c                |  1 +
>   drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c               |  1 +
>   drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c               |  1 +
>   drivers/gpu/drm/xen/xen_drm_front_conn.c           |  2 ++
>   drivers/gpu/drm/xlnx/zynqmp_dp.c                   |  1 +
>   drivers/gpu/drm/xlnx/zynqmp_kms.c                  |  2 ++
>   drivers/video/fbdev/efifb.c                        |  2 +-
>   include/drm/drm_atomic_helper.h                    | 21 ++++++++----
>   include/drm/drm_panel.h                            |  1 +
>   include/drm/drm_print.h                            | 11 +++---
>   include/drm/drm_util.h                             |  1 +
>   include/drm/drm_utils.h                            | 19 ----------
>   309 files changed, 558 insertions(+), 73 deletions(-)
> ---
> base-commit: 2e337a8d14bd4b04913d52ccf076be29d846acd7
> change-id: 20230113-drm-include-v1-17dc8bdd5ada
> 
> Best regards,

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

Re: [PATCH 00/86] drm: Header file maintenance

[Sam Ravnborg]

Hi Thomas,

On Mon, Jan 23, 2023 at 10:00:45AM +0100, Thomas Zimmermann wrote:
> Hi Sam,
> 
> nice patchset. For patches 1 to 84, you can add
> 
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Thanks, I will update the changelogs per your suggestions
but need to sort out the build bug before I do anything else.

	Sam