Re: [PATCH v3 2/2] drm/panel: simple: Add support for EDT ETM0350G0DH6 panel

[Sam Ravnborg <sam@ravnborg.org>]

Hi Yunus,

On Tue, Jul 06, 2021 at 09:59:08AM +0200, Yunus Bas wrote:
> From: Stefan Riedmueller <s.riedmueller@phytec.de>
> 
> This patch adds support for the EDT ETM0350G0DH6 3.5" (320x240) lcd
> panel to DRM simple panel driver.
> 
> Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
> Signed-off-by: Yunus Bas <y.bas@phytec.de>
> ---
> Changes in v3:
> - No changes in general, added additional maintainers and also sending
> to general kernel mailing list
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 07433bff6c2b..8aba473a7592 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1929,6 +1929,32 @@ static const struct panel_desc edt_et035012dm6 = {
>  	.bus_flags = DRM_BUS_FLAG_DE_LOW | DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE,
>  };
>  
> +static const struct drm_display_mode edt_etm0350g0dh6_mode = {
> +	.clock = 6520,
> +	.hdisplay = 320,
> +	.hsync_start = 320 + 20,
> +	.hsync_end = 320 + 20 + 68,
> +	.htotal = 320 + 20 + 68,
> +	.vdisplay = 240,
> +	.vsync_start = 240 + 4,
> +	.vsync_end = 240 + 4 + 18,
> +	.vtotal = 240 + 4 + 18,
> +	.flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
> +};
> +
> +static const struct panel_desc edt_etm0350g0dh6 = {
> +	.modes = &edt_etm0350g0dh6_mode,
> +	.num_modes = 1,
> +	.bpc = 6,
> +	.size = {
> +		.width = 70,
> +		.height = 53,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE,
> +	.connector_type = DRM_MODE_CONNECTOR_DPI,
> +};
> +
>  static const struct drm_display_mode edt_etm043080dh6gp_mode = {
>  	.clock = 10870,
>  	.hdisplay = 480,
> @@ -4355,6 +4381,9 @@ static const struct of_device_id platform_of_match[] = {
>  	}, {
>  		.compatible = "edt,et035012dm6",
>  		.data = &edt_et035012dm6,
> +	}, {
> +		.compatible = "edt,etm0350g0dh6",
> +		.data = &edt_etm0350g0dh6,

The compatible "edt,etm0350g0dh6" is not documented.
You likely need to add it to panel-simple.yaml - and likewise for the
first patch.

dt people like binding patches in separate patches so add them both in
one dedicated patch.

	Sam