dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	devicetree@vger.kernel.org
Subject: Re: Fix build [Was: [PATCH 2/2] drm/panel: Add support for Sharp LS060T1SX01 panel]
Date: Sat, 9 Oct 2021 19:10:14 +0200	[thread overview]
Message-ID: <YWHM9i1wxWN8NkIj@ravnborg.org> (raw)
In-Reply-To: <YWHMYgL2o+uzdTUi@ravnborg.org>

On Sat, Oct 09, 2021 at 07:07:46PM +0200, Sam Ravnborg wrote:
> Applied this but forgot to commit the build fix:
> 
> commit 1ae669fe083fda99e465ae6ab2c533658bdb846e
> Author: Sam Ravnborg <sam@ravnborg.org>
> Date:   Sat Oct 9 19:02:48 2021 +0200
> 
>     drm/panel: sharp-ls060t1sx01: fix build
>     
>     Update MIPI_DSI_MODE_EOT_PACKET to the new MIPI_DSI_MODE_NO_EOT_PACKET
>     variant.
>     This fixes the build - I had not committed the fix (blush).
>     
>     Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
>     Fixes: 223cce88a926 ("drm/panel: Add support for Sharp LS060T1SX01 panel")
>     Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> 
> diff --git a/drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c b/drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c
> index 1049810d1f10..ed5f28c8c90b 100644
> --- a/drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c
> +++ b/drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c
> @@ -275,7 +275,7 @@ static int sharp_ls060_probe(struct mipi_dsi_device *dsi)
>  	dsi->lanes = 4;
>  	dsi->format = MIPI_DSI_FMT_RGB888;
>  	dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
> -			  MIPI_DSI_MODE_EOT_PACKET |
> +			  MIPI_DSI_MODE_NO_EOT_PACKET |
>  			  MIPI_DSI_CLOCK_NON_CONTINUOUS;
>  
>  	drm_panel_init(&ctx->panel, dev, &sharp_ls060_panel_funcs,

Seems I need more coffee, this patch should never have hit
drm-misc-next. I will revert it.

	Sam


  reply	other threads:[~2021-10-09 17:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-08  3:50 [PATCH 1/2] dt-bindings: add bindings for the Sharp LS060T1SX01 panel Dmitry Baryshkov
2021-08-08  3:50 ` [PATCH 2/2] drm/panel: Add support for " Dmitry Baryshkov
2021-10-09 17:07   ` Fix build [Was: [PATCH 2/2] drm/panel: Add support for Sharp LS060T1SX01 panel] Sam Ravnborg
2021-10-09 17:10     ` Sam Ravnborg [this message]
2021-08-09 15:40 ` [PATCH 1/2] dt-bindings: add bindings for the Sharp LS060T1SX01 panel Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YWHM9i1wxWN8NkIj@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox