* Re: [PATCH v5 1/3] drm/loongson: Add DRM Driver for Loongson 7A1000 bridge chip
[not found] <20210911023133.851311-1-lichenyang@loongson.cn>
@ 2021-10-14 20:34 ` Sam Ravnborg
0 siblings, 0 replies; only message in thread
From: Sam Ravnborg @ 2021-10-14 20:34 UTC (permalink / raw)
To: lichenyang
Cc: Maxime Ripard, Maarten Lankhorst, Thomas Zimmermann,
Dan Carpenter, David Airlie, Daniel Vetter, dri-devel, devel,
Huacai Chen
Hi lichenyang,
On Sat, Sep 11, 2021 at 10:31:31AM +0800, lichenyang wrote:
> From: Chenyang Li <lichenyang@loongson.cn>
>
> This patch adds an initial DRM driver for the Loongson LS7A1000
> bridge chip(LS7A). The LS7A bridge chip contains two display
> controllers, support dual display output. The maximum support for
> each channel display is to 1920x1080@60Hz.
> At present, DC device detection and DRM driver registration are
> completed, the crtc/plane/encoder/connector objects has been
> implemented.
> On Loongson 3A4000 CPU and 7A1000 system, we have achieved the use
> of dual screen, and support dual screen clone mode and expansion
> mode.
>
> v11:
> - Remove a lot of useless code.
> - Add help information.
> - Delete unnecessary header files.
Looks much better now, thanks.
Can you provide some kind of overview of the HW?
It is confusing that you talk about a bridge for a display driver - is
this something from the HW?
And please look into usign the drm_bridge_connector - as this is what
any modern DRM display driver needs to use today.
Also the connector type needs to be specified - unknown is not
acceptable here.
The mail you sent did not show up at https://lore.kernel.org/dri-devel/
Please fix what is required to make it visible there.
This is where we point people to see the original mails.
Also a cover letter that explains what has been done - and what has not
been done - would be nice.
I look forward to v12,
Sam
^ permalink raw reply [flat|nested] only message in thread