From: Sam Ravnborg <sam@ravnborg.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Qing Wang <wangqing@vivo.com>,
Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: panel: replace snprintf in show functions with sysfs_emit
Date: Fri, 15 Oct 2021 20:16:23 +0200 [thread overview]
Message-ID: <YWnFd+fqxXoR3fdg@ravnborg.org> (raw)
In-Reply-To: <20211015111139.ozarnvcdxscbaqv4@earth.universe>
Hi Qing and Sebastian.
On Fri, Oct 15, 2021 at 01:11:39PM +0200, Sebastian Reichel wrote:
> Hi,
>
> On Thu, Oct 14, 2021 at 11:48:10PM -0700, Qing Wang wrote:
> > show() must not use snprintf() when formatting the value to be
> > returned to user space.
> >
> > Fix the following coccicheck warning:
> > drivers/gpu/drm/panel/panel-dsi-cm.c:251: WARNING: use scnprintf or sprintf.
> > drivers/gpu/drm/panel/panel-dsi-cm.c:271: WARNING: use scnprintf or sprintf.
> >
> > Use sysfs_emit instead of scnprintf or sprintf makes more sense.
> >
> > Signed-off-by: Qing Wang <wangqing@vivo.com>
> > ---
>
> The patch subject could be more specific (this updates just one panel driver).
> Otherwise:
>
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Updated the patch subject and applied the patch to drm-misc-next.
It will show up in -next in 1-2 weeks.
Sam
prev parent reply other threads:[~2021-10-15 18:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 6:48 [PATCH] drm: panel: replace snprintf in show functions with sysfs_emit Qing Wang
2021-10-15 11:11 ` Sebastian Reichel
2021-10-15 18:16 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWnFd+fqxXoR3fdg@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=thierry.reding@gmail.com \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox