* [PATCH 0/1] drm/i915/rpm: Enable runtime pm autosuspend by default
@ 2021-11-10 5:29 Tilak Tangudu
2021-11-10 5:29 ` [PATCH 1/1] " Tilak Tangudu
0 siblings, 1 reply; 6+ messages in thread
From: Tilak Tangudu @ 2021-11-10 5:29 UTC (permalink / raw)
To: intel-gfx, dri-devel
Cc: jon.ewins, anshuman.gupta, tilak.tangudu, badal.nilawar,
rodrigo.vivi
Enable runtime pm autosuspend by default for all Gen12
and Gen12+ platforms
Tilak Tangudu (1):
drm/i915/rpm: Enable runtime pm autosuspend by default
drivers/gpu/drm/i915/intel_runtime_pm.c | 4 ++++
1 file changed, 4 insertions(+)
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] drm/i915/rpm: Enable runtime pm autosuspend by default
2021-11-10 5:29 [PATCH 0/1] drm/i915/rpm: Enable runtime pm autosuspend by default Tilak Tangudu
@ 2021-11-10 5:29 ` Tilak Tangudu
2021-11-10 11:46 ` [Intel-gfx] " Ville Syrjälä
0 siblings, 1 reply; 6+ messages in thread
From: Tilak Tangudu @ 2021-11-10 5:29 UTC (permalink / raw)
To: intel-gfx, dri-devel
Cc: jon.ewins, anshuman.gupta, tilak.tangudu, badal.nilawar,
rodrigo.vivi
Enable runtime pm autosuspend by default for gen12 and
later versions.
Signed-off-by: Tilak Tangudu <tilak.tangudu@intel.com>
---
drivers/gpu/drm/i915/intel_runtime_pm.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index eaf7688f517d..ef75f24288ef 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -600,6 +600,10 @@ void intel_runtime_pm_enable(struct intel_runtime_pm *rpm)
pm_runtime_use_autosuspend(kdev);
}
+ /* XXX: Enable by default only for newer platforms for now */
+ if (GRAPHICS_VER(i915) >= 12)
+ pm_runtime_allow(kdev);
+
/*
* The core calls the driver load handler with an RPM reference held.
* We drop that here and will reacquire it during unloading in
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH 1/1] drm/i915/rpm: Enable runtime pm autosuspend by default
2021-11-10 5:29 ` [PATCH 1/1] " Tilak Tangudu
@ 2021-11-10 11:46 ` Ville Syrjälä
2021-11-10 22:24 ` Rodrigo Vivi
0 siblings, 1 reply; 6+ messages in thread
From: Ville Syrjälä @ 2021-11-10 11:46 UTC (permalink / raw)
To: Tilak Tangudu; +Cc: intel-gfx, dri-devel
On Wed, Nov 10, 2021 at 10:59:26AM +0530, Tilak Tangudu wrote:
> Enable runtime pm autosuspend by default for gen12 and
> later versions.
>
> Signed-off-by: Tilak Tangudu <tilak.tangudu@intel.com>
> ---
> drivers/gpu/drm/i915/intel_runtime_pm.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
> index eaf7688f517d..ef75f24288ef 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> @@ -600,6 +600,10 @@ void intel_runtime_pm_enable(struct intel_runtime_pm *rpm)
> pm_runtime_use_autosuspend(kdev);
> }
>
> + /* XXX: Enable by default only for newer platforms for now */
> + if (GRAPHICS_VER(i915) >= 12)
> + pm_runtime_allow(kdev);
If we change some default then we should just do it across the board.
There is nothing special about tgl+.
> +
> /*
> * The core calls the driver load handler with an RPM reference held.
> * We drop that here and will reacquire it during unloading in
> --
> 2.25.1
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH 1/1] drm/i915/rpm: Enable runtime pm autosuspend by default
2021-11-10 11:46 ` [Intel-gfx] " Ville Syrjälä
@ 2021-11-10 22:24 ` Rodrigo Vivi
2021-11-11 12:42 ` Ville Syrjälä
0 siblings, 1 reply; 6+ messages in thread
From: Rodrigo Vivi @ 2021-11-10 22:24 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx, Tilak Tangudu, dri-devel
On Wed, Nov 10, 2021 at 01:46:46PM +0200, Ville Syrjälä wrote:
> On Wed, Nov 10, 2021 at 10:59:26AM +0530, Tilak Tangudu wrote:
> > Enable runtime pm autosuspend by default for gen12 and
> > later versions.
> >
> > Signed-off-by: Tilak Tangudu <tilak.tangudu@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_runtime_pm.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
> > index eaf7688f517d..ef75f24288ef 100644
> > --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> > @@ -600,6 +600,10 @@ void intel_runtime_pm_enable(struct intel_runtime_pm *rpm)
> > pm_runtime_use_autosuspend(kdev);
> > }
> >
> > + /* XXX: Enable by default only for newer platforms for now */
> > + if (GRAPHICS_VER(i915) >= 12)
> > + pm_runtime_allow(kdev);
>
> If we change some default then we should just do it across the board.
> There is nothing special about tgl+.
Nothing special with tgl and newer platforms indeed. This is why we
have the XXX message here.
The problem in the last attempt was with the gen9 platforms.
Apparently some special there, and I didn't want to block the
progress while we cannot get to the gen9 bugs.
>
> > +
> > /*
> > * The core calls the driver load handler with an RPM reference held.
> > * We drop that here and will reacquire it during unloading in
> > --
> > 2.25.1
>
> --
> Ville Syrjälä
> Intel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH 1/1] drm/i915/rpm: Enable runtime pm autosuspend by default
2021-11-10 22:24 ` Rodrigo Vivi
@ 2021-11-11 12:42 ` Ville Syrjälä
2021-11-11 19:26 ` Vivi, Rodrigo
0 siblings, 1 reply; 6+ messages in thread
From: Ville Syrjälä @ 2021-11-11 12:42 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx, Tilak Tangudu, dri-devel
On Wed, Nov 10, 2021 at 05:24:22PM -0500, Rodrigo Vivi wrote:
> On Wed, Nov 10, 2021 at 01:46:46PM +0200, Ville Syrjälä wrote:
> > On Wed, Nov 10, 2021 at 10:59:26AM +0530, Tilak Tangudu wrote:
> > > Enable runtime pm autosuspend by default for gen12 and
> > > later versions.
> > >
> > > Signed-off-by: Tilak Tangudu <tilak.tangudu@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/intel_runtime_pm.c | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
> > > index eaf7688f517d..ef75f24288ef 100644
> > > --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> > > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> > > @@ -600,6 +600,10 @@ void intel_runtime_pm_enable(struct intel_runtime_pm *rpm)
> > > pm_runtime_use_autosuspend(kdev);
> > > }
> > >
> > > + /* XXX: Enable by default only for newer platforms for now */
> > > + if (GRAPHICS_VER(i915) >= 12)
> > > + pm_runtime_allow(kdev);
> >
> > If we change some default then we should just do it across the board.
> > There is nothing special about tgl+.
>
> Nothing special with tgl and newer platforms indeed. This is why we
> have the XXX message here.
>
> The problem in the last attempt was with the gen9 platforms.
What problem was that?
> Apparently some special there, and I didn't want to block the
> progress while we cannot get to the gen9 bugs.
>
> >
> > > +
> > > /*
> > > * The core calls the driver load handler with an RPM reference held.
> > > * We drop that here and will reacquire it during unloading in
> > > --
> > > 2.25.1
> >
> > --
> > Ville Syrjälä
> > Intel
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH 1/1] drm/i915/rpm: Enable runtime pm autosuspend by default
2021-11-11 12:42 ` Ville Syrjälä
@ 2021-11-11 19:26 ` Vivi, Rodrigo
0 siblings, 0 replies; 6+ messages in thread
From: Vivi, Rodrigo @ 2021-11-11 19:26 UTC (permalink / raw)
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org, Tangudu, Tilak,
dri-devel@lists.freedesktop.org
On Thu, 2021-11-11 at 14:42 +0200, Ville Syrjälä wrote:
> On Wed, Nov 10, 2021 at 05:24:22PM -0500, Rodrigo Vivi wrote:
> > On Wed, Nov 10, 2021 at 01:46:46PM +0200, Ville Syrjälä wrote:
> > > On Wed, Nov 10, 2021 at 10:59:26AM +0530, Tilak Tangudu wrote:
> > > > Enable runtime pm autosuspend by default for gen12 and
> > > > later versions.
> > > >
> > > > Signed-off-by: Tilak Tangudu <tilak.tangudu@intel.com>
> > > > ---
> > > > drivers/gpu/drm/i915/intel_runtime_pm.c | 4 ++++
> > > > 1 file changed, 4 insertions(+)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c
> > > > b/drivers/gpu/drm/i915/intel_runtime_pm.c
> > > > index eaf7688f517d..ef75f24288ef 100644
> > > > --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> > > > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> > > > @@ -600,6 +600,10 @@ void intel_runtime_pm_enable(struct
> > > > intel_runtime_pm *rpm)
> > > > pm_runtime_use_autosuspend(kdev);
> > > > }
> > > >
> > > > + /* XXX: Enable by default only for newer platforms for
> > > > now */
> > > > + if (GRAPHICS_VER(i915) >= 12)
> > > > + pm_runtime_allow(kdev);
> > >
> > > If we change some default then we should just do it across the
> > > board.
> > > There is nothing special about tgl+.
> >
> > Nothing special with tgl and newer platforms indeed. This is why we
> > have the XXX message here.
> >
> > The problem in the last attempt was with the gen9 platforms.
>
> What problem was that?
unfortunately it looks like the logs are not available anymore. :(
Tilak, could you please send this patch without the if?
so we can at
least make sure we spot the differences and see if there's something
quick that we can do about the gen9 or if we should take this path of
gen12, then fix gen9 , then enable eveywhere....
>
> > Apparently some special there, and I didn't want to block the
> > progress while we cannot get to the gen9 bugs.
> >
> > >
> > > > +
> > > > /*
> > > > * The core calls the driver load handler with an RPM
> > > > reference held.
> > > > * We drop that here and will reacquire it during
> > > > unloading in
> > > > --
> > > > 2.25.1
> > >
> > > --
> > > Ville Syrjälä
> > > Intel
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-11-11 19:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-10 5:29 [PATCH 0/1] drm/i915/rpm: Enable runtime pm autosuspend by default Tilak Tangudu
2021-11-10 5:29 ` [PATCH 1/1] " Tilak Tangudu
2021-11-10 11:46 ` [Intel-gfx] " Ville Syrjälä
2021-11-10 22:24 ` Rodrigo Vivi
2021-11-11 12:42 ` Ville Syrjälä
2021-11-11 19:26 ` Vivi, Rodrigo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox