* [PATCH] drm/i915/guc: fix NULL vs IS_ERR() checking
@ 2021-11-16 11:49 Dan Carpenter
2021-11-16 14:53 ` [Intel-gfx] " Rodrigo Vivi
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-11-16 11:49 UTC (permalink / raw)
To: Jani Nikula, Matthew Brost
Cc: David Airlie, intel-gfx, kernel-janitors, dri-devel, Chris Wilson,
Daniele Ceraolo Spurio, Rodrigo Vivi, John Harrison
The intel_engine_create_virtual() function does not return NULL. It
returns error pointers.
Fixes: e5e32171a2cf ("drm/i915/guc: Connect UAPI to GuC multi-lrc interface")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
index 38b47e73e35d..c48557dfa04c 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
@@ -3080,8 +3080,8 @@ guc_create_parallel(struct intel_engine_cs **engines,
ce = intel_engine_create_virtual(siblings, num_siblings,
FORCE_VIRTUAL);
- if (!ce) {
- err = ERR_PTR(-ENOMEM);
+ if (IS_ERR(ce)) {
+ err = ERR_CAST(ce);
goto unwind;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: fix NULL vs IS_ERR() checking
2021-11-16 11:49 [PATCH] drm/i915/guc: fix NULL vs IS_ERR() checking Dan Carpenter
@ 2021-11-16 14:53 ` Rodrigo Vivi
0 siblings, 0 replies; 2+ messages in thread
From: Rodrigo Vivi @ 2021-11-16 14:53 UTC (permalink / raw)
To: Dan Carpenter
Cc: Matthew Brost, David Airlie, intel-gfx, kernel-janitors,
dri-devel, Chris Wilson
On Tue, Nov 16, 2021 at 02:49:16PM +0300, Dan Carpenter wrote:
> The intel_engine_create_virtual() function does not return NULL. It
> returns error pointers.
>
> Fixes: e5e32171a2cf ("drm/i915/guc: Connect UAPI to GuC multi-lrc interface")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> index 38b47e73e35d..c48557dfa04c 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> @@ -3080,8 +3080,8 @@ guc_create_parallel(struct intel_engine_cs **engines,
>
> ce = intel_engine_create_virtual(siblings, num_siblings,
> FORCE_VIRTUAL);
> - if (!ce) {
> - err = ERR_PTR(-ENOMEM);
> + if (IS_ERR(ce)) {
> + err = ERR_CAST(ce);
> goto unwind;
> }
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-16 14:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-16 11:49 [PATCH] drm/i915/guc: fix NULL vs IS_ERR() checking Dan Carpenter
2021-11-16 14:53 ` [Intel-gfx] " Rodrigo Vivi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox