* [PATCH] drm/sun4i: tv: Include drm_atomic.h
@ 2022-09-09 9:31 Maxime Ripard
2022-09-09 9:39 ` Ville Syrjälä
2022-09-09 9:43 ` (subset) " Maxime Ripard
0 siblings, 2 replies; 3+ messages in thread
From: Maxime Ripard @ 2022-09-09 9:31 UTC (permalink / raw)
To: dri-devel; +Cc: David Airlie, Maxime Ripard, Thomas Zimmermann, Daniel Vetter
Commit ec491291dc94 ("drm/sun4i: tv: Merge mode_set into atomic_enable")
has introduced a call to drm_atomic_get_new_crtc_state(), but didn't
include drm_atomic.h.
On CONFIG_OF systems, this is fine because drm_atomic.h is included by
drm_of.h through drm_bridge.h. However, whenever CONFIG_OF isn't set, we
end up with a compilation error.
Fixes: ec491291dc94 ("drm/sun4i: tv: Merge mode_set into atomic_enable")
Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
drivers/gpu/drm/sun4i/sun4i_tv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c
index 74ff5ad6a8b9..c65f0a89b6b0 100644
--- a/drivers/gpu/drm/sun4i/sun4i_tv.c
+++ b/drivers/gpu/drm/sun4i/sun4i_tv.c
@@ -14,6 +14,7 @@
#include <linux/regmap.h>
#include <linux/reset.h>
+#include <drm/drm_atomic.h>
#include <drm/drm_atomic_helper.h>
#include <drm/drm_of.h>
#include <drm/drm_panel.h>
--
2.37.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/sun4i: tv: Include drm_atomic.h
2022-09-09 9:31 [PATCH] drm/sun4i: tv: Include drm_atomic.h Maxime Ripard
@ 2022-09-09 9:39 ` Ville Syrjälä
2022-09-09 9:43 ` (subset) " Maxime Ripard
1 sibling, 0 replies; 3+ messages in thread
From: Ville Syrjälä @ 2022-09-09 9:39 UTC (permalink / raw)
To: Maxime Ripard; +Cc: David Airlie, Daniel Vetter, Thomas Zimmermann, dri-devel
On Fri, Sep 09, 2022 at 11:31:16AM +0200, Maxime Ripard wrote:
> Commit ec491291dc94 ("drm/sun4i: tv: Merge mode_set into atomic_enable")
> has introduced a call to drm_atomic_get_new_crtc_state(), but didn't
> include drm_atomic.h.
>
> On CONFIG_OF systems, this is fine because drm_atomic.h is included by
> drm_of.h through drm_bridge.h. However, whenever CONFIG_OF isn't set, we
> end up with a compilation error.
>
> Fixes: ec491291dc94 ("drm/sun4i: tv: Merge mode_set into atomic_enable")
> Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Also caught by the robot since then:
https://lists.freedesktop.org/archives/dri-devel/2022-September/371257.html
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/sun4i/sun4i_tv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c
> index 74ff5ad6a8b9..c65f0a89b6b0 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_tv.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_tv.c
> @@ -14,6 +14,7 @@
> #include <linux/regmap.h>
> #include <linux/reset.h>
>
> +#include <drm/drm_atomic.h>
> #include <drm/drm_atomic_helper.h>
> #include <drm/drm_of.h>
> #include <drm/drm_panel.h>
> --
> 2.37.1
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: (subset) [PATCH] drm/sun4i: tv: Include drm_atomic.h
2022-09-09 9:31 [PATCH] drm/sun4i: tv: Include drm_atomic.h Maxime Ripard
2022-09-09 9:39 ` Ville Syrjälä
@ 2022-09-09 9:43 ` Maxime Ripard
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2022-09-09 9:43 UTC (permalink / raw)
To: dri-devel, Maxime Ripard; +Cc: David Airlie, Daniel Vetter, Thomas Zimmermann
On Fri, 9 Sep 2022 11:31:16 +0200, Maxime Ripard wrote:
> Commit ec491291dc94 ("drm/sun4i: tv: Merge mode_set into atomic_enable")
> has introduced a call to drm_atomic_get_new_crtc_state(), but didn't
> include drm_atomic.h.
>
> On CONFIG_OF systems, this is fine because drm_atomic.h is included by
> drm_of.h through drm_bridge.h. However, whenever CONFIG_OF isn't set, we
> end up with a compilation error.
>
> [...]
Applied to drm/drm-misc (drm-misc-next).
Thanks!
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-09 9:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-09 9:31 [PATCH] drm/sun4i: tv: Include drm_atomic.h Maxime Ripard
2022-09-09 9:39 ` Ville Syrjälä
2022-09-09 9:43 ` (subset) " Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox