Re: [PATCH] media: Fix building pdfdocs

[Akira Yokosawa <akiyks@gmail.com>]

Hi Mauro,

On Sun, 26 Feb 2023 11:47:44 +0100, Mauro Carvalho Chehab wrote:
> Em Sun, 26 Feb 2023 08:39:32 +0900
> Akira Yokosawa <akiyks@gmail.com> escreveu:
> 
>> [+CC: Jon, linux-doc]
>>
>> On Wed,  8 Feb 2023 10:29:16 +0200, Tomi Valkeinen wrote:
>>> Commit 8d0e3fc61abd ("media: Add 2-10-10-10 RGB formats") added
>>> documatation for a few new RGB formats. For some reason these break the
>>> pdfdocs build, even if the same style seems to work elsewhere in the
>>> file.
>>>
>>> Remove the trailing empty dash lines, which seems to fix the issue.
>>>
>>> Fixes: 8d0e3fc61abd ("media: Add 2-10-10-10 RGB formats")
>>> Reported-by: Akira Yokosawa <akiyks@gmail.com>  
>> Link: https://lore.kernel.org/r/12250823-8445-5854-dfb8-b92c0ff0851e@gmail.com/
>>
>>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
>>> ---
>>>
>>> Note: the offending patch was merged via drm tree, so we may want to
>>> apply the fix to the drm tree also.  
>>
>> So, the offending commit is now in mainline without this fix...
>> I believe this build regression -- a real build error of "make pdfdocs"
>> -- should be fixed ASAP.
>>
>> Tomi, Laurent has suggested a typo fix in the Changelog.
>> Can you respin ?
>>
>> Or, Laurent, can you do the fix on your own?
>>
>> Hopefully, the fix can make v6.3-rc1.
> 
> Better to wait for media PR to be handled. There were some changes at
> the documentation that affected the patch. I guess the bug is gone.

You mean the PR at https://lore.kernel.org/lkml/20230226114551.68480d44@coco.lan/ ?
Unfortunately, it has had no effect on this issue.

> If not, we'll need to rebase the patch.

There was no change in Documentation/userspace-api/media/v4l/pixfmt-rgb.rst,
so rebase is not needed.

Should this bug survive v6.3-rc1, I guess this fix could go through
media or doc tree.

Thoughts?

        Thanks, Akira

> 
> Regards,
> Mauro
>