From: Akira Yokosawa <akiyks@gmail.com>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Daniel Vetter <daniel@ffwll.ch>, Dave Airlie <airlied@redhat.com>
Cc: Akira Yokosawa <akiyks@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org
Subject: Re: [PATCH] media: Fix building pdfdocs
Date: Tue, 21 Feb 2023 10:16:41 +0900 [thread overview]
Message-ID: <e2ca05a5-4d49-a1ce-6129-25c2f57d23c7@gmail.com> (raw)
In-Reply-To: <a8a89876-8868-04c6-104b-6be1b6c628c4@ideasonboard.com>
On Thu, 9 Feb 2023 12:11:19 +0200, Tomi Valkeinen wrote:
> Hi Daniel, Dave,
>
> Could you pick this fix to drm-next? The offending commit is there, it was merged via Laurent's "[GIT PULL FOR v6.3] R-Car DU fixes and improvements".
>
> I can also push this to drm-misc-fixes, but the offending commit is not there yet.
Hi,
I don't see this fix in next-20230220.
I'd really appreciate it if it could be upstreamed during the current
merge window.
Does anybody care to pick this up?
Thanks, Akira
>
> Tomi
>
> On 08/02/2023 13:17, Mauro Carvalho Chehab wrote:
>> Em Wed, 8 Feb 2023 11:11:34 +0200
>> Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu:
>>
>>> Hi Tomi,
>>>
>>> Thank you for the patch.
>>>
>>> On Wed, Feb 08, 2023 at 10:29:16AM +0200, Tomi Valkeinen wrote:
>>>> Commit 8d0e3fc61abd ("media: Add 2-10-10-10 RGB formats") added
>>>> documatation for a few new RGB formats. For some reason these break the
>>>
>>> s/documatation/documentation/
>>>
>>>> pdfdocs build, even if the same style seems to work elsewhere in the
>>>> file.
>>>>
>>>> Remove the trailing empty dash lines, which seems to fix the issue.
>>>>
>>>> Fixes: 8d0e3fc61abd ("media: Add 2-10-10-10 RGB formats")
>>>> Reported-by: Akira Yokosawa <akiyks@gmail.com>
>>>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
>>>
>>> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>>>
>>>> ---
>>>>
>>>> Note: the offending patch was merged via drm tree, so we may want to
>>>> apply the fix to the drm tree also.
>>>
>>> Sounds good to me. Mauro, could you ack this patch ?
>>
>> Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org>
>>
>>>
>>>> Documentation/userspace-api/media/v4l/pixfmt-rgb.rst | 3 ---
>>>> 1 file changed, 3 deletions(-)
>>>>
>>>> diff --git a/Documentation/userspace-api/media/v4l/pixfmt-rgb.rst b/Documentation/userspace-api/media/v4l/pixfmt-rgb.rst
>>>> index d330aeb4d3eb..ea545ed1aeaa 100644
>>>> --- a/Documentation/userspace-api/media/v4l/pixfmt-rgb.rst
>>>> +++ b/Documentation/userspace-api/media/v4l/pixfmt-rgb.rst
>>>> @@ -868,7 +868,6 @@ number of bits for each component.
>>>> - r\ :sub:`4`
>>>> - r\ :sub:`3`
>>>> - r\ :sub:`2`
>>>> - -
>>>> * .. _V4L2-PIX-FMT-RGBA1010102:
>>>> - ``V4L2_PIX_FMT_RGBA1010102``
>>>> @@ -909,7 +908,6 @@ number of bits for each component.
>>>> - r\ :sub:`4`
>>>> - r\ :sub:`3`
>>>> - r\ :sub:`2`
>>>> - -
>>>> * .. _V4L2-PIX-FMT-ARGB2101010:
>>>> - ``V4L2_PIX_FMT_ARGB2101010``
>>>> @@ -950,7 +948,6 @@ number of bits for each component.
>>>> - r\ :sub:`6`
>>>> - r\ :sub:`5`
>>>> - r\ :sub:`4`
>>>> - -
>>>> .. raw:: latex
>>>>
>>>
>>
>>
>>
>> Thanks,
>> Mauro
>
next prev parent reply other threads:[~2023-02-22 17:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 8:29 [PATCH] media: Fix building pdfdocs Tomi Valkeinen
2023-02-08 8:43 ` Akira Yokosawa
2023-02-08 9:11 ` Laurent Pinchart
2023-02-08 11:17 ` Mauro Carvalho Chehab
2023-02-09 10:11 ` Tomi Valkeinen
2023-02-21 1:16 ` Akira Yokosawa [this message]
2023-02-25 23:39 ` Akira Yokosawa
2023-02-26 10:47 ` Mauro Carvalho Chehab
2023-02-27 12:06 ` Akira Yokosawa
2023-02-27 13:42 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2ca05a5-4d49-a1ce-6129-25c2f57d23c7@gmail.com \
--to=akiyks@gmail.com \
--cc=airlied@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox