dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Louis Chauvet <louis.chauvet@bootlin.com>
To: Sean Paul <sean@poorly.run>, dri-devel@lists.freedesktop.org
Cc: Sean Paul <seanpaul@google.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Jim Cromie <jim.cromie@gmail.com>
Subject: Re: [PATCH] drm: Fix DYNAMIC_DEBUG_MODULE propagation to subdirectories
Date: Wed, 29 Apr 2026 15:39:30 +0200	[thread overview]
Message-ID: <a30256a6-e451-4258-89e8-c92a83db6162@bootlin.com> (raw)
In-Reply-To: <20260420160425.3919114-1-sean@poorly.run>



On 4/20/26 18:04, Sean Paul wrote:
> From: Sean Paul <seanpaul@google.com>
> 
> Switch incompatible CFLAGS-y to ccflags-* and propagate the flag
> to subdirectories to avoid implicit declaration errors for
> _dynamic_func_call_cls when DRM_USE_DYNAMIC_DEBUG is enabled.
> 
> Note that this flag is still disabled due to depends on BROKEN.
> 
> Fixes: 84ec67288c10 ("drm_print: wrap drm_*_dbg in dyndbg descriptor factory macro")
> Signed-off-by: Sean Paul <seanpaul@google.com>

Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>

> ---
> 
> a wild seanpaul appears...
> 
>   drivers/gpu/drm/Makefile | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
> index e97faabcd783..7082ff6449fb 100644
> --- a/drivers/gpu/drm/Makefile
> +++ b/drivers/gpu/drm/Makefile
> @@ -3,7 +3,8 @@
>   # Makefile for the drm device driver.  This driver provides support for the
>   # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher.
>   
> -CFLAGS-$(CONFIG_DRM_USE_DYNAMIC_DEBUG)	+= -DDYNAMIC_DEBUG_MODULE
> +ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG)	+= -DDYNAMIC_DEBUG_MODULE
> +subdir-ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG)	+= -DDYNAMIC_DEBUG_MODULE
>   
>   # Unconditionally enable W=1 warnings locally
>   # --- begin copy-paste W=1 warnings from scripts/Makefile.warn


  reply	other threads:[~2026-04-29 13:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 16:04 [PATCH] drm: Fix DYNAMIC_DEBUG_MODULE propagation to subdirectories Sean Paul
2026-04-29 13:39 ` Louis Chauvet [this message]
2026-05-02 16:31   ` jim.cromie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a30256a6-e451-4258-89e8-c92a83db6162@bootlin.com \
    --to=louis.chauvet@bootlin.com \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jim.cromie@gmail.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=sean@poorly.run \
    --cc=seanpaul@google.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox