* [PATCH] drm: Fix DYNAMIC_DEBUG_MODULE propagation to subdirectories
@ 2026-04-20 16:04 Sean Paul
2026-04-29 13:39 ` Louis Chauvet
0 siblings, 1 reply; 3+ messages in thread
From: Sean Paul @ 2026-04-20 16:04 UTC (permalink / raw)
To: dri-devel
Cc: Sean Paul, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Jim Cromie
From: Sean Paul <seanpaul@google.com>
Switch incompatible CFLAGS-y to ccflags-* and propagate the flag
to subdirectories to avoid implicit declaration errors for
_dynamic_func_call_cls when DRM_USE_DYNAMIC_DEBUG is enabled.
Note that this flag is still disabled due to depends on BROKEN.
Fixes: 84ec67288c10 ("drm_print: wrap drm_*_dbg in dyndbg descriptor factory macro")
Signed-off-by: Sean Paul <seanpaul@google.com>
---
a wild seanpaul appears...
drivers/gpu/drm/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
index e97faabcd783..7082ff6449fb 100644
--- a/drivers/gpu/drm/Makefile
+++ b/drivers/gpu/drm/Makefile
@@ -3,7 +3,8 @@
# Makefile for the drm device driver. This driver provides support for the
# Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher.
-CFLAGS-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) += -DDYNAMIC_DEBUG_MODULE
+ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) += -DDYNAMIC_DEBUG_MODULE
+subdir-ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) += -DDYNAMIC_DEBUG_MODULE
# Unconditionally enable W=1 warnings locally
# --- begin copy-paste W=1 warnings from scripts/Makefile.warn
--
Sean Paul, Software Engineer, Google / Chromium OS
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm: Fix DYNAMIC_DEBUG_MODULE propagation to subdirectories
2026-04-20 16:04 [PATCH] drm: Fix DYNAMIC_DEBUG_MODULE propagation to subdirectories Sean Paul
@ 2026-04-29 13:39 ` Louis Chauvet
2026-05-02 16:31 ` jim.cromie
0 siblings, 1 reply; 3+ messages in thread
From: Louis Chauvet @ 2026-04-29 13:39 UTC (permalink / raw)
To: Sean Paul, dri-devel
Cc: Sean Paul, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Jim Cromie
On 4/20/26 18:04, Sean Paul wrote:
> From: Sean Paul <seanpaul@google.com>
>
> Switch incompatible CFLAGS-y to ccflags-* and propagate the flag
> to subdirectories to avoid implicit declaration errors for
> _dynamic_func_call_cls when DRM_USE_DYNAMIC_DEBUG is enabled.
>
> Note that this flag is still disabled due to depends on BROKEN.
>
> Fixes: 84ec67288c10 ("drm_print: wrap drm_*_dbg in dyndbg descriptor factory macro")
> Signed-off-by: Sean Paul <seanpaul@google.com>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
> ---
>
> a wild seanpaul appears...
>
> drivers/gpu/drm/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
> index e97faabcd783..7082ff6449fb 100644
> --- a/drivers/gpu/drm/Makefile
> +++ b/drivers/gpu/drm/Makefile
> @@ -3,7 +3,8 @@
> # Makefile for the drm device driver. This driver provides support for the
> # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher.
>
> -CFLAGS-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) += -DDYNAMIC_DEBUG_MODULE
> +ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) += -DDYNAMIC_DEBUG_MODULE
> +subdir-ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) += -DDYNAMIC_DEBUG_MODULE
>
> # Unconditionally enable W=1 warnings locally
> # --- begin copy-paste W=1 warnings from scripts/Makefile.warn
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm: Fix DYNAMIC_DEBUG_MODULE propagation to subdirectories
2026-04-29 13:39 ` Louis Chauvet
@ 2026-05-02 16:31 ` jim.cromie
0 siblings, 0 replies; 3+ messages in thread
From: jim.cromie @ 2026-05-02 16:31 UTC (permalink / raw)
To: Louis Chauvet
Cc: Sean Paul, dri-devel, Sean Paul, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter
On Wed, Apr 29, 2026 at 7:40 AM Louis Chauvet <louis.chauvet@bootlin.com> wrote:
>
>
>
> On 4/20/26 18:04, Sean Paul wrote:
> > From: Sean Paul <seanpaul@google.com>
> >
> > Switch incompatible CFLAGS-y to ccflags-* and propagate the flag
> > to subdirectories to avoid implicit declaration errors for
> > _dynamic_func_call_cls when DRM_USE_DYNAMIC_DEBUG is enabled.
> >
> > Note that this flag is still disabled due to depends on BROKEN.
> >
> > Fixes: 84ec67288c10 ("drm_print: wrap drm_*_dbg in dyndbg descriptor factory macro")
> > Signed-off-by: Sean Paul <seanpaul@google.com>
>
> Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
>
Acked-by: Jim Cromie <jim.cromie@gmail.com>
Link: https://lore.kernel.org/lkml/20260326185413.1205870-39-jim.cromie@gmail.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-02 16:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-20 16:04 [PATCH] drm: Fix DYNAMIC_DEBUG_MODULE propagation to subdirectories Sean Paul
2026-04-29 13:39 ` Louis Chauvet
2026-05-02 16:31 ` jim.cromie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox