Re: [PATCH] accel/ivpu: Fix wrong register read in LNL failure diagnostics

[Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>]

On 10-Jul-26 12:13 PM, Karol Wachowski wrote:
> diagnose_failure_lnl() read VPU_HW_BTRS_MTL_INTERRUPT_STAT instead of
> VPU_HW_BTRS_LNL_INTERRUPT_STAT, which on LNL and newer parts is a
> different register with a different bit layout, so failure diagnostics
> decoded the wrong register and reported a bogus error cause.
> Read the LNL interrupt status register instead.
> 
> Fixes: 8a27ad81f7d3 ("accel/ivpu: Split IP and buttress code")
> Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
> ---
>   drivers/accel/ivpu/ivpu_hw_btrs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/accel/ivpu/ivpu_hw_btrs.c b/drivers/accel/ivpu/ivpu_hw_btrs.c
> index dac935164e11..a17c829adb89 100644
> --- a/drivers/accel/ivpu/ivpu_hw_btrs.c
> +++ b/drivers/accel/ivpu/ivpu_hw_btrs.c
> @@ -927,7 +927,7 @@ static void diagnose_failure_mtl(struct ivpu_device *vdev)
>   
>   static void diagnose_failure_lnl(struct ivpu_device *vdev)
>   {
> -	u32 reg = REGB_RD32(VPU_HW_BTRS_MTL_INTERRUPT_STAT) & BTRS_LNL_IRQ_MASK;
> +	u32 reg = REGB_RD32(VPU_HW_BTRS_LNL_INTERRUPT_STAT) & BTRS_LNL_IRQ_MASK;
>   
>   	if (REG_TEST_FLD(VPU_HW_BTRS_LNL_INTERRUPT_STAT, ATS_ERR, reg)) {
>   		ivpu_err(vdev, "ATS_ERR_LOG1 0x%08x ATS_ERR_LOG2 0x%08x\n",

Reviewed-by: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>