From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Hans de Goede" <j.w.r.degoede@gmail.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
Hans de Goede <hdegoede@redhat.com>,
dri-devel@lists.freedesktop.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm/i915/intel_dsi: Add acpi_gpio_mapping for the panel-enable GPIO
Date: Fri, 29 Jun 2018 19:12:24 +0300 [thread overview]
Message-ID: <a909c0acd4599fa618431dd17c9605feacdcddcd.camel@linux.intel.com> (raw)
In-Reply-To: <20180629115138.GA5565@intel.com>
On Fri, 2018-06-29 at 14:51 +0300, Ville Syrjälä wrote:
> On Fri, Jun 29, 2018 at 01:32:58PM +0200, Hans de Goede wrote:
I saw that the change was discarded but I would comment about the GPIO
ACPI mapping tables.
> > + devm_acpi_dev_add_driver_gpios(dev->dev,
> > panel_gpios);
>
> Some explanation on what this actually does would be nice. There is no
> documentation that I can see so it's totally unclear why this is
> needed.
Documentation is here Documentation/acpi/gpio-properties.txt.
The key phrase is
"...the driver is supposed to know what to use the GpioIo()/GpioInt()
resources for once it has identified the device. Having done that, it
can simply assign names to the GPIO lines it is going to use and provide
the GPIO subsystem with a mapping between those names and the ACPI GPIO
resources corresponding to them.
To do that, the driver needs to define a mapping table..."
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2018-06-29 16:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 11:32 [PATCH] drm/i915/intel_dsi: Add acpi_gpio_mapping for the panel-enable GPIO Hans de Goede
2018-06-29 11:51 ` Ville Syrjälä
2018-06-29 12:05 ` Hans de Goede
2018-06-29 12:10 ` Ville Syrjälä
2018-06-29 12:28 ` Hans de Goede
2018-06-29 16:12 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a909c0acd4599fa618431dd17c9605feacdcddcd.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=j.w.r.degoede@gmail.com \
--cc=rodrigo.vivi@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox