[PATCH next] drm/i915/dmc: Fix extra bracket and wrong variable in PIPEDMC error logs

[PATCH next] drm/i915/dmc: Fix extra bracket and wrong variable in PIPEDMC error logs

[Alok Tiwari]

Fixes two issues in intel_pipedmc_irq_handler():
- Removed an extra ']' in the PIPEDMC error and interrupt vector log.
- Corrected the interrupt vector log to print int_vector instead of tmp,
  as tmp will be zero in this case.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
 drivers/gpu/drm/i915/display/intel_dmc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
index 0bddb20a7c86..f47b57568a75 100644
--- a/drivers/gpu/drm/i915/display/intel_dmc.c
+++ b/drivers/gpu/drm/i915/display/intel_dmc.c
@@ -1712,14 +1712,14 @@ void intel_pipedmc_irq_handler(struct intel_display *display, enum pipe pipe)
 			drm_err_ratelimited(display->drm, "[CRTC:%d:%s] PIPEDMC GTT fault\n",
 					    crtc->base.base.id, crtc->base.name);
 		if (tmp & PIPEDMC_ERROR)
-			drm_err(display->drm, "[CRTC:%d:%s]] PIPEDMC error\n",
+			drm_err(display->drm, "[CRTC:%d:%s] PIPEDMC error\n",
 				crtc->base.base.id, crtc->base.name);
 	}
 
 	int_vector = intel_de_read(display, PIPEDMC_STATUS(pipe)) & PIPEDMC_INT_VECTOR_MASK;
 	if (tmp == 0 && int_vector != 0)
-		drm_err(display->drm, "[CRTC:%d:%s]] PIPEDMC interrupt vector 0x%x\n",
-			crtc->base.base.id, crtc->base.name, tmp);
+		drm_err(display->drm, "[CRTC:%d:%s] PIPEDMC interrupt vector 0x%x\n",
+			crtc->base.base.id, crtc->base.name, int_vector);
 }
 
 void intel_pipedmc_enable_event(struct intel_crtc *crtc,
-- 
2.50.1

Re: [PATCH next] drm/i915/dmc: Fix extra bracket and wrong variable in PIPEDMC error logs

[Rodrigo Vivi]

On Mon, Nov 03, 2025 at 05:23:31AM -0800, Alok Tiwari wrote:
> Fixes two issues in intel_pipedmc_irq_handler():
> - Removed an extra ']' in the PIPEDMC error and interrupt vector log.
> - Corrected the interrupt vector log to print int_vector instead of tmp,
>   as tmp will be zero in this case.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

and pushed to drm-intel-next

thanks for the patch

 ---
>  drivers/gpu/drm/i915/display/intel_dmc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
> index 0bddb20a7c86..f47b57568a75 100644
> --- a/drivers/gpu/drm/i915/display/intel_dmc.c
> +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
> @@ -1712,14 +1712,14 @@ void intel_pipedmc_irq_handler(struct intel_display *display, enum pipe pipe)
>  			drm_err_ratelimited(display->drm, "[CRTC:%d:%s] PIPEDMC GTT fault\n",
>  					    crtc->base.base.id, crtc->base.name);
>  		if (tmp & PIPEDMC_ERROR)
> -			drm_err(display->drm, "[CRTC:%d:%s]] PIPEDMC error\n",
> +			drm_err(display->drm, "[CRTC:%d:%s] PIPEDMC error\n",
>  				crtc->base.base.id, crtc->base.name);
>  	}
>  
>  	int_vector = intel_de_read(display, PIPEDMC_STATUS(pipe)) & PIPEDMC_INT_VECTOR_MASK;
>  	if (tmp == 0 && int_vector != 0)
> -		drm_err(display->drm, "[CRTC:%d:%s]] PIPEDMC interrupt vector 0x%x\n",
> -			crtc->base.base.id, crtc->base.name, tmp);
> +		drm_err(display->drm, "[CRTC:%d:%s] PIPEDMC interrupt vector 0x%x\n",
> +			crtc->base.base.id, crtc->base.name, int_vector);
>  }
>  
>  void intel_pipedmc_enable_event(struct intel_crtc *crtc,
> -- 
> 2.50.1
>