* [PATCH] drm/xe/xe_vm: Convert comma to semicolon
@ 2026-03-27 3:29 Chen Ni
2026-03-27 13:32 ` Rodrigo Vivi
2026-03-30 21:16 ` Lin, Shuicheng
0 siblings, 2 replies; 3+ messages in thread
From: Chen Ni @ 2026-03-27 3:29 UTC (permalink / raw)
To: matthew.brost
Cc: thomas.hellstrom, rodrigo.vivi, airlied, simona, intel-xe,
dri-devel, Chen Ni
Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it seems best to use ';'
unless ',' is intended.
Found by inspection.
No functional change intended.
Compile tested only.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/gpu/drm/xe/xe_vm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index d96e0a0c5605..21844217dccd 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -626,9 +626,9 @@ void xe_vm_add_fault_entry_pf(struct xe_vm *vm, struct xe_pagefault *pf)
e->address_precision = SZ_4K;
e->access_type = pf->consumer.access_type;
e->fault_type = FIELD_GET(XE_PAGEFAULT_TYPE_MASK,
- pf->consumer.fault_type_level),
+ pf->consumer.fault_type_level);
e->fault_level = FIELD_GET(XE_PAGEFAULT_LEVEL_MASK,
- pf->consumer.fault_type_level),
+ pf->consumer.fault_type_level);
list_add_tail(&e->list, &vm->faults.list);
vm->faults.len++;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/xe/xe_vm: Convert comma to semicolon
2026-03-27 3:29 [PATCH] drm/xe/xe_vm: Convert comma to semicolon Chen Ni
@ 2026-03-27 13:32 ` Rodrigo Vivi
2026-03-30 21:16 ` Lin, Shuicheng
1 sibling, 0 replies; 3+ messages in thread
From: Rodrigo Vivi @ 2026-03-27 13:32 UTC (permalink / raw)
To: Chen Ni
Cc: matthew.brost, thomas.hellstrom, airlied, simona, intel-xe,
dri-devel
On Fri, Mar 27, 2026 at 11:29:23AM +0800, Chen Ni wrote:
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it seems best to use ';'
> unless ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> drivers/gpu/drm/xe/xe_vm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index d96e0a0c5605..21844217dccd 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -626,9 +626,9 @@ void xe_vm_add_fault_entry_pf(struct xe_vm *vm, struct xe_pagefault *pf)
> e->address_precision = SZ_4K;
> e->access_type = pf->consumer.access_type;
> e->fault_type = FIELD_GET(XE_PAGEFAULT_TYPE_MASK,
> - pf->consumer.fault_type_level),
> + pf->consumer.fault_type_level);
> e->fault_level = FIELD_GET(XE_PAGEFAULT_LEVEL_MASK,
> - pf->consumer.fault_type_level),
> + pf->consumer.fault_type_level);
This code is not present in our tree.
In the xe_pagefault.c where this FIELD_GET commands are actually implemented,
the comma is the right way.
>
> list_add_tail(&e->list, &vm->faults.list);
> vm->faults.len++;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] drm/xe/xe_vm: Convert comma to semicolon
2026-03-27 3:29 [PATCH] drm/xe/xe_vm: Convert comma to semicolon Chen Ni
2026-03-27 13:32 ` Rodrigo Vivi
@ 2026-03-30 21:16 ` Lin, Shuicheng
1 sibling, 0 replies; 3+ messages in thread
From: Lin, Shuicheng @ 2026-03-30 21:16 UTC (permalink / raw)
To: Chen Ni, Brost, Matthew
Cc: thomas.hellstrom@linux.intel.com, Vivi, Rodrigo,
airlied@gmail.com, simona@ffwll.ch,
intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org
On Thu, Mar 26, 2026 8:29 PM Chen Ni wrote:
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it seems best to use ';'
> unless ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
LGTM.
Reviewed-by: Shuicheng Lin <shuicheng.lin@intel.com>
BTW, it is blocked by the CI due to the mail address restriction. Let me re-send it for CI validation.
Thanks.
> ---
> drivers/gpu/drm/xe/xe_vm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c index
> d96e0a0c5605..21844217dccd 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -626,9 +626,9 @@ void xe_vm_add_fault_entry_pf(struct xe_vm *vm,
> struct xe_pagefault *pf)
> e->address_precision = SZ_4K;
> e->access_type = pf->consumer.access_type;
> e->fault_type = FIELD_GET(XE_PAGEFAULT_TYPE_MASK,
> - pf->consumer.fault_type_level),
> + pf->consumer.fault_type_level);
> e->fault_level = FIELD_GET(XE_PAGEFAULT_LEVEL_MASK,
> - pf->consumer.fault_type_level),
> + pf->consumer.fault_type_level);
>
> list_add_tail(&e->list, &vm->faults.list);
> vm->faults.len++;
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-30 21:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-27 3:29 [PATCH] drm/xe/xe_vm: Convert comma to semicolon Chen Ni
2026-03-27 13:32 ` Rodrigo Vivi
2026-03-30 21:16 ` Lin, Shuicheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox